Convert bridge span & int. list to SLIST()

2018-12-23 Thread Martin Pieuchot
Using SLIST() instead of TAILQ() is a step towards using lock-less lists. As found in my previous attempts the interface list cannot be protected by a mutex as long a if_enqueue() might grab the KERNEL_LOCK(). So I'm heading towards using SRPL_*(). Ok? Index: net/if_bridge.c

Re: MPLSv6 1/2: kernel diff

2018-12-23 Thread Martin Pieuchot
On 18/12/18(Tue) 12:13, Denis Fondras wrote: > Here is a serie of diffs to enable MPLSv6, MPLS transport over IPv6. Nice! > First diff : allow mpe(4) to handle IPv6 trafic. Comments below > Index: net/if_ethersubr.c > === > RCS

Re: Another attempt to bypass ifqs on interfaces

2018-12-23 Thread Martin Pieuchot
On 20/12/18(Thu) 11:35, David Gwynne wrote: > My last attempt in "let etherip(4) output directly to the ip stack" > didn't go so well. This one at least doesn't break bridge(4) on > Ethernet. It breaks it on mpw(4). > This diff effectively turns if_enqueue into a per interface function >

Re: mg: Delete region

2018-12-23 Thread Ingo Schwarze
Hi Hiltjo, Hiltjo Posthuma wrote on Sun, Dec 23, 2018 at 03:34:12PM +0100: > Shouldn't these kind of diffs be OK'd by other developers before > committing though? Not necessarily. When a developer focusses on work in a particular area and takes responsibility to fix anything that breaks there,

Re: mandoc -T html default style

2018-12-23 Thread Todd C. Miller
On Fri, 21 Dec 2018 00:10:10 +0100, Ingo Schwarze wrote: > I see the point, and it makes sense to me. > > So in case people want a sensible default for "-O style=" as suggested, > where should the file go? > > Maybe /usr/share/misc/mandoc.css ? That would be fine with me. I definitely think it

Re: mg: Delete region

2018-12-23 Thread Hiltjo Posthuma
On Sun, Dec 23, 2018 at 01:58:16PM +, Mark Lumsden wrote: > On Sun, 23 Dec 2018, Hiltjo Posthuma wrote: > > > Date: Sun, 23 Dec 2018 13:43:32 +0100 > > From: Hiltjo Posthuma > > To: Mark Lumsden > > Cc: Leonid Bobrov , tech@openbsd.org > > Subject: Re: mg: Delete region > > > > On Thu, Dec

Re: mg: Delete region

2018-12-23 Thread Mark Lumsden
On Sun, 23 Dec 2018, Hiltjo Posthuma wrote: Date: Sun, 23 Dec 2018 13:43:32 +0100 From: Hiltjo Posthuma To: Mark Lumsden Cc: Leonid Bobrov , tech@openbsd.org Subject: Re: mg: Delete region On Thu, Dec 20, 2018 at 06:44:15AM +, Mark Lumsden wrote: hmm, you are correct. I'm trying to

Re: mg: Delete region

2018-12-23 Thread Hiltjo Posthuma
On Thu, Dec 20, 2018 at 06:44:15AM +, Mark Lumsden wrote: > hmm, you are correct. I'm trying to remember which machine I tested > on that made me come to that conclusion. > > On Thu, 20 Dec 2018, Leonid Bobrov wrote: > > > Date: Thu, 20 Dec 2018 06:43:02 +0200 > > From: Leonid Bobrov > >

Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Denis Fondras
On Sun, Dec 23, 2018 at 10:05:01AM +, Jason McIntyre wrote: > unless you're trying somehow to emphasise that both types of address are > supported, you could simplify the text to just: > > The > .Ar dest-address > is used to find ... > Thank you for your input. Index:

Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Jason McIntyre
On Sun, Dec 23, 2018 at 10:28:30AM +0100, Denis Fondras wrote: > On Sat, Dec 22, 2018 at 11:42:36PM +0100, Klemens Nanni wrote: > > I have no clue about MPLS, so this feedback is code-wise only: > > > > Did you consider using more AF agnostic code for parsing the IP address? > > > > You are

Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Denis Fondras
On Sat, Dec 22, 2018 at 11:42:36PM +0100, Klemens Nanni wrote: > I have no clue about MPLS, so this feedback is code-wise only: > > Did you consider using more AF agnostic code for parsing the IP address? > You are right, it is simpler. Thank you for the clue :) Updated diff : Index: