Re: off by one ksh

2019-01-13 Thread Ted Unangst
Ingo Schwarze wrote: > Feel free to either commit the complete patch below or commit > only your part and optionally OK one, two, or three of my additional > changes. These look ok with one comment. > @@ -141,8 +141,11 @@ mpset(char *mptoparse) > mmsg = strchr(mpath, '?'); >

net80211: don't drop unencrypted data frames with no data

2019-01-13 Thread Lauri Tirkkonen
Hi, (disclaimer: I know basically nothing about 802.11) I noticed on my AP a high counter on netstat -W "input unencrypted packets with wep/wpa config discarded", aka is_rx_unencrypted. After investigation it looked like all of these were frames with type Data, but with the "No data" bit set in FC

Re: microtime.9: update CODE REFERENCES

2019-01-13 Thread Klemens Nanni
On Sun, Jan 13, 2019 at 01:30:09PM -0600, Scott Cheloha wrote: > The microtime(9) functions are in kern_tc.c, not kern_clock.c. OK. The rest looks fine as is: $ man -k pa=kern_tc tc_init(9) - machine-independent binary timescale $ man -k pa=kern_clock hardclock(9)

microtime.9: update CODE REFERENCES

2019-01-13 Thread Scott Cheloha
The microtime(9) functions are in kern_tc.c, not kern_clock.c. ok? Index: share/man/man9/microtime.9 === RCS file: /cvs/src/share/man/man9/microtime.9,v retrieving revision 1.16 diff -u -p -r1.16 microtime.9 --- share/man/man9/microt

Re: LC_NUMERIC in wprintf(3)

2019-01-13 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Sun, Jan 13, 2019 at 08:06:22AM -0700: > On Sun, 13 Jan 2019 05:20:47 +0100, Ingo Schwarze wrote: >> So adding a subsection to the setlocale(3) manual, containing lists >> of functions that are likely to break when you call setlocale(3) >> with bad arguments on n

Re: minor ttyflags(8) diff

2019-01-13 Thread Theo de Raadt
Miod Vallat wrote: > > > Opening a pseudo-tty (/dev/tty[p-zP-T][0-9a-zA-Z]) causes the kernel to > > > allocate a struct tty for it, as well as ring buffers for tty data. This > > > memory will not get released if the pseudo-tty is closed, for it may be > > > opened again in the future. > > > >

Re: minor ttyflags(8) diff

2019-01-13 Thread Miod Vallat
> > Opening a pseudo-tty (/dev/tty[p-zP-T][0-9a-zA-Z]) causes the kernel to > > allocate a struct tty for it, as well as ring buffers for tty data. This > > memory will not get released if the pseudo-tty is closed, for it may be > > opened again in the future. > > The change seems reasonable to me

Re: minor ttyflags(8) diff

2019-01-13 Thread Theo de Raadt
Miod Vallat wrote: > Opening a pseudo-tty (/dev/tty[p-zP-T][0-9a-zA-Z]) causes the kernel to > allocate a struct tty for it, as well as ring buffers for tty data. This > memory will not get released if the pseudo-tty is closed, for it may be > opened again in the future. The change seems reasona

minor ttyflags(8) diff

2019-01-13 Thread Miod Vallat
Opening a pseudo-tty (/dev/tty[p-zP-T][0-9a-zA-Z]) causes the kernel to allocate a struct tty for it, as well as ring buffers for tty data. This memory will not get released if the pseudo-tty is closed, for it may be opened again in the future. On pseudo-ttys, the largest possible ring buffer size

Re: typos in src/distrib/miniroot/install.sub

2019-01-13 Thread Theo de Raadt
Thanks.

Re: LC_NUMERIC in wprintf(3)

2019-01-13 Thread Todd C . Miller
On Sun, 13 Jan 2019 05:20:47 +0100, Ingo Schwarze wrote: > So adding a subsection to the setlocale(3) manual, containing lists > of functions that are likely to break when you call setlocale(3) > with bad arguments on non-OpenBSD systems, might make sense. > Even if we can't guarantee completeness

Re: locale in locate(1)

2019-01-13 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 03:22:41AM -0500: > Ingo Schwarze wrote: >> So, here is some cleanup: >> * garbage collect useless hand-rolled lookup tables >> * merge one-line helper functions into callers >> * garbage collect obfuscating macros >> * fix one format string e

Re: off by one ksh

2019-01-13 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 03:48:05AM -0500: > By inspection, it appears possible this access will underrun if the > first character is a %. OK schwarze@ That said, i see three more buglets here. 1. If the mailbox filename ends in a percent sign (not saying that is

typos in src/distrib/miniroot/install.sub

2019-01-13 Thread Claus Assmann
This might not be worth mailing here, but maybe someone will look at it anyway. Notes: - I did not reformat the first paragraph after adding the missing 'u' (the diff just shows the typo) -- the line is too long now. - Maybe it should be # Functions used in install.sh/upgrade.sh and their associat

Re: Use MACHINE_ARCH in clang/Makefile.inc

2019-01-13 Thread Mark Kettenis
> Date: Sat, 12 Jan 2019 23:41:33 +0100 > From: Christian Weisgerber > Content-Type: text/plain; charset="utf-8" > Content-Disposition: inline > > When tweaking the protection flags for each architecture, we want > to check for the CPU architecture (think "powerpc") and not the > system architect

off by one ksh

2019-01-13 Thread Ted Unangst
By inspection, it appears possible this access will underrun if the first character is a %. Index: mail.c === RCS file: /cvs/src/bin/ksh/mail.c,v retrieving revision 1.25 diff -u -p -r1.25 mail.c --- mail.c 7 Jan 2019 20:50:43 -

Re: locale in locate(1)

2019-01-13 Thread Ted Unangst
Ingo Schwarze wrote: > So, here is some cleanup: > * garbage collect useless hand-rolled lookup tables > * merge one-line helper functions into callers > * garbage collect obfuscating macros > * fix one format string error (%d used for u_int) > * garbage collect setlocale(3) and > * garbage