[PATCH] Huawei E8372 USB Mobile Broadband in HiLink Mode, Generic HiLink Mode Logic

2019-01-20 Thread James Hebden
Hello tech@, Given this is my first email to the list, and the first patch I have submitted to the OpenBSD project, I am very open to feedback on the attached patch and context provided! Below I have included a patch I have been working on to modify some of the logic when handling E-series Huawei

Re: replacing timeout_add() with timeout_add_msec()

2019-01-20 Thread Claudio Jeker
On Sat, Jan 12, 2019 at 10:40:35PM -0600, Amit Kulkarni wrote: > > You started to convert the wrong timeout_add() calls. Doing a blind > > timeout_add() to timeout_add_msec() conversion especially on calls with 0 > > or 1 tick sleep time is the wrong approach. > > The right approach is to identify

Re: teach fstat about pfkey

2019-01-20 Thread Claudio Jeker
On Mon, Jan 21, 2019 at 01:13:23PM +1000, David Gwynne wrote: > i was trying to figure out which bit of ldpd had the pfkey socket (cos > reading code is hard sometimes), but had to work a little bit too hard > to figure it out from what fstat currently prints. this has fstat printf > "pfkey" when i

teach fstat about pfkey

2019-01-20 Thread David Gwynne
i was trying to figure out which bit of ldpd had the pfkey socket (cos reading code is hard sometimes), but had to work a little bit too hard to figure it out from what fstat currently prints. this has fstat printf "pfkey" when it hits an AF_KEY socket, rather than hit the default handler which pri

Adapt to Allwinner device tree changes in linux >= 5.0-rc1

2019-01-20 Thread Jonathan Gray
Adapt to allwinner device tree changes in linux >= 5.0-rc1 "allwinner,sun6i-a31-rtc" has been removed from h3/h5/r40/a64 507c6e89d6c4b2cd68a8e7ff69d1a00cf74b15dd ARM: dts: sunxi: h3/h5: Fix up RTC device node and clock references 44ff3cafcd7f413e7710a58ac40cfdc3a9380097 arm64: dts: allwinner: a64

ndp: zap unused ntop_buf

2019-01-20 Thread Klemens Nanni
Last usage got removed in revision 1.9 date: 2001/02/08 08:35:17; author: itojun; state: Exp; lines: +109 -27; pull latest kame tree. ndp -n -a printing is now prettier with long IPv6 addresses. -l is deprecated (ignored). OK? Index: ndp.c ==

Re: arp timeouts and refresh arp entries before they expire

2019-01-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.01.18 00:11:27 +0100: > On Thu, Jan 17, 2019 at 03:21:58PM -0700, Theo de Raadt wrote: > > - if (la_hold_total < LA_HOLD_TOTAL && la_hold_total < nmbclust / 64) > > { > > + if (la_hold_total < nmbclust / 64) { > > > > I have disagreed wi

Re: bgpctl neighbor group support

2019-01-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.01.20 12:33:29 +0100: > In many cases it is nice to be able to use a command against a group of > neighbors (e.g. all exchange peers). This diff implements this for > bgpctl neighbor group foo [clear|destroy|down|refresh|up] > bgpctl show

Re: what.1: remove BUGS section

2019-01-20 Thread Fabio Scotoni
On 1/20/19 3:11 PM, Ingo Schwarze wrote: > Hi Fabio, > > Fabio Scotoni wrote on Sun, Jan 20, 2019 at 12:52:18PM +0100: > >> The what(1) man page has a BUGS section, >> which mdoc(7) says is discouraged in OpenBSD. > > What? Using BUGS sections is perfectly fine. > > The mdoc(7) manual page doe

Re: what.1: remove BUGS section

2019-01-20 Thread Paul de Weerd
Hi Ingo, On Sun, Jan 20, 2019 at 03:11:55PM +0100, Ingo Schwarze wrote: | > Talking about BSD not being able to distribute SCCS doesn't help | > anyone; | > not behaving like the original SCCS is obvious considering the | > STANDARDS section specifically notes OpenBSD extensions and | > compliance

Re: what.1: remove BUGS section

2019-01-20 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Sun, Jan 20, 2019 at 12:52:18PM +0100: > The what(1) man page has a BUGS section, > which mdoc(7) says is discouraged in OpenBSD. What? Using BUGS sections is perfectly fine. The mdoc(7) manual page does not intend to say that using BUGS sections is discouraged

Re: if_pppoe.c patch

2019-01-20 Thread Peter J. Philipp
On Sun, Jan 20, 2019 at 12:56:22PM +, Stuart Henderson wrote: > On 2019/01/18 10:59, Peter J. Philipp wrote: > > I have "covered" up PPPoE Session ID's from users because it is a value that > > is only gotten on the Data Link layer and historically non-root users did > > not > > have access to

what.1: remove BUGS section

2019-01-20 Thread Fabio Scotoni
The what(1) man page has a BUGS section, which mdoc(7) says is discouraged in OpenBSD. The contents of the BUGS section is mostly unhelpful anyway. Talking about BSD not being able to distribute SCCS doesn't help anyone; not behaving like the original SCCS is obvious considering the STANDARDS sect

Re: if_pppoe.c patch

2019-01-20 Thread Stuart Henderson
On 2019/01/18 10:59, Peter J. Philipp wrote: > I have "covered" up PPPoE Session ID's from users because it is a value that > is only gotten on the Data Link layer and historically non-root users did not > have access to that. It really is a value that doesn't concern them. I have > wrapped the d

Re: bgpctl neighbor group support

2019-01-20 Thread Stuart Henderson
On 2019/01/20 12:33, Claudio Jeker wrote: > In many cases it is nice to be able to use a command against a group of > neighbors (e.g. all exchange peers). This diff implements this for > bgpctl neighbor group foo [clear|destroy|down|refresh|up] > bgpctl show neighbor group foo [messages

bgpctl neighbor group support

2019-01-20 Thread Claudio Jeker
In many cases it is nice to be able to use a command against a group of neighbors (e.g. all exchange peers). This diff implements this for bgpctl neighbor group foo [clear|destroy|down|refresh|up] bgpctl show neighbor group foo [messages|terse|timers] bgpctl show rib neighbo