open correct render node in libdrm

2019-05-11 Thread Jonathan Gray
drm render nodes have the same major as drm primary devices but have a minor offset. render nodes have a name that reflects the minor node not offset by the base. I expected it to be the other way around when these non-linux codepaths were added (before we had render nodes). Index: xf86drm.c

acpi_loadtables(): do not assume rsdt exists

2019-05-11 Thread Lawrence Teo
This makes acpi_loadtables() ensure that rsdp->rsdp_rsdt exists before attempting to to use it. ok? Index: acpi.c === RCS file: /cvs/src/sys/dev/acpi/acpi.c,v retrieving revision 1.365 diff -u -p -r1.365 acpi.c --- acpi.c 11

Re: sys_pledgepid() clean patch; comments?

2019-05-11 Thread Theo de Raadt
I disagree strongly with the direction. Processes should follow the promises previous code made. Developers should be "mindful" of their program's rules & model, if they can't design properly and keep the situation in their head in a 'static fashion', they don't stand a chance in hell of doing

sys_pledgepid() clean patch; comments?

2019-05-11 Thread Andy Seniuk
Hello once again, I have CC'd the original developers of tame/pledge; hope that is not in violation of etiquette? This is my last post on this subject (or to any devs emails) if interest remains cool, but it deserves a fair shot, and after all, 500 hours is nothing to sneeze at! These

Better acpi(4) support

2019-05-11 Thread Mark Kettenis
We encountered a machine that used the "extended" gasio description of the ACPI PM registers, which is something we currently don't support. This diff adds such support and with this diff ACPI support gets enabled and the machine powers off fine if you run "halt -p". ok? Index: dev/acpi/acpi.c

Re: SCHED_LOCK vs 'struct proc'

2019-05-11 Thread Ian Sutton
On Sat, May 11, 2019 at 07:23:42PM -0400, Martin Pieuchot wrote: > Document which fields are protected by the SCHED_LOCK(), ok? > > Index: sys/proc.h > === > RCS file: /cvs/src/sys/sys/proc.h,v > retrieving revision 1.263 > diff -u

Re: SCHED_LOCK vs 'struct proc'

2019-05-11 Thread Amit Kulkarni
On Sat, May 11, 2019 at 6:29 PM Martin Pieuchot wrote: > > Document which fields are protected by the SCHED_LOCK(), ok? > > Index: sys/proc.h > === > RCS file: /cvs/src/sys/sys/proc.h,v > retrieving revision 1.263 > diff -u -p

SCHED_LOCK vs 'struct proc'

2019-05-11 Thread Martin Pieuchot
Document which fields are protected by the SCHED_LOCK(), ok? Index: sys/proc.h === RCS file: /cvs/src/sys/sys/proc.h,v retrieving revision 1.263 diff -u -p -r1.263 proc.h --- sys/proc.h 6 Jan 2019 12:59:45 - 1.263 +++

show driver name on scan debug lines

2019-05-11 Thread Stefan Sperling
Watching scan debug output from multiple drivers at once is highly confusing without this... diff 017348fd9e151db65e509e6fb577f24587e25b0f /usr/src blob - 6aeb14832608d36c839e855b4193418ffb6f7ce0 file + sys/net80211/ieee80211_node.c --- sys/net80211/ieee80211_node.c +++

Re: fix tcpdump localtime caching

2019-05-11 Thread Holger Mikolon
> The variables could have more meaningful names, also the reuse of > variable "gt" looks hackish, but the current code looks correct to me. > > Does the diff below make things clearer? It does. After reading the current code again a few times, it is as well clear. Incredible how I couldn't see

Re: ld.so speedup (part 2)

2019-05-11 Thread Philip Guenther
On Tue, 7 May 2019, Jeremie Courreges-Anglas wrote: > On Sat, Apr 27 2019, Nathanael Rensen > wrote: > > The diff below speeds up ld.so library intialisation where the > > dependency tree is broad and deep, such as samba's smbd which links > > over 100 libraries. ... > As I told mpi@ earlier

Re: cmdfile for config -ef

2019-05-11 Thread Benjamin Baier
On Sat, 11 May 2019 13:26:14 -0600 "Theo de Raadt" wrote: > Ted Unangst wrote: > > > Benjamin Baier wrote: > > > On Sat, 11 May 2019 11:18:02 -0400 > > > "Ted Unangst" wrote: > > > > > > > This adds a new option to config, -c cmdfile, that allows reading > > > > commands > > > > from a file

Re: cmdfile for config -ef

2019-05-11 Thread Theo de Raadt
Ted Unangst wrote: > Benjamin Baier wrote: > > On Sat, 11 May 2019 11:18:02 -0400 > > "Ted Unangst" wrote: > > > > > This adds a new option to config, -c cmdfile, that allows reading commands > > > from a file instead of stdin. This makes it easier to script. > > > > Interesting. Can the

Re: cmdfile for config -ef

2019-05-11 Thread Ted Unangst
Benjamin Baier wrote: > On Sat, 11 May 2019 11:18:02 -0400 > "Ted Unangst" wrote: > > > This adds a new option to config, -c cmdfile, that allows reading commands > > from a file instead of stdin. This makes it easier to script. > > Interesting. Can the cmdfile be /bsd ? > So something like

Re: fix tcpdump localtime caching

2019-05-11 Thread Otto Moerbeek
On Fri, May 10, 2019 at 03:25:17PM +0200, Holger Mikolon wrote: > The comment above priv_localtime() says, the obtained localtime (from the > privileged process) is cached for about one minute. However, since the > according if statement compares the wrong variable, the caching doesn't >

Re: fix tcpdump localtime caching

2019-05-11 Thread Jeremie Courreges-Anglas
On Fri, May 10 2019, Holger Mikolon wrote: > The comment above priv_localtime() says, the obtained localtime (from the > privileged process) is cached for about one minute. However, since the > according if statement compares the wrong variable, the caching doesn't > happen. This bug is there

Re: cmdfile for config -ef

2019-05-11 Thread Benjamin Baier
On Sat, 11 May 2019 11:18:02 -0400 "Ted Unangst" wrote: > This adds a new option to config, -c cmdfile, that allows reading commands > from a file instead of stdin. This makes it easier to script. Interesting. Can the cmdfile be /bsd ? So something like config -u but without the need of

Re: route(8): -n means numeric for default too

2019-05-11 Thread Denis Fondras
On Sat, May 11, 2019 at 01:15:16PM -0400, Alexander Bluhm wrote: > What is wrong with "default"? Why is "0.0.0.0/0" and "::/0" better? > Nothing wrong per-se. I was comparing the output of "bgpctl sh fib" and "route show" when I noticed this.

Re: route(8): -n means numeric for default too

2019-05-11 Thread Alexander Bluhm
On Sat, May 11, 2019 at 07:03:34PM +0200, Denis Fondras wrote: > When using "route -n", also print numeric value for default route. I use -n to avoid DNS lookups. "default" does not do that. So I do not see the benefit of this change. It has been that way for ever without harm. New behavior

route(8): -n means numeric for default too

2019-05-11 Thread Denis Fondras
When using "route -n", also print numeric value for default route. Before : [denis@jig-ai] route -n show -inet6 Routing tables Internet6: DestinationGatewayFlags Refs Use Mtu Prio Iface default2a00:6060:1::1

Re: pthread signal delivery

2019-05-11 Thread Alexander Bluhm
On Thu, May 09, 2019 at 11:01:13PM -0400, Alexander Bluhm wrote: > When killing a process, the signal is handled by any thread that > does not block the signal. If all threads block the signal, we > currently deliver it to the main thread. This does not conform to > POSIX. If any thread

net80211: fix userflags + stayauth

2019-05-11 Thread Stefan Sperling
This fixes ifconfig 'nwflags' hiddennwid and nobridge; these flags currently overlap with other flags, such as the AUTO_JOIN flag and hence can't be used. While here, add another flag which makes the interface ignore deauth frames. diff 63562686d340902505feb02c68d09c5d34652880 /usr/src blob -

Re: iked(8): add support for IKEv2 Message Fragmentation

2019-05-11 Thread Tobias Heider
Hey, I updated the diff to work with the recent fixes. Currently next_pl is checked to be the encrypted payload after the IKE_SA_INIT exchange, this also whitelists the new encrypted fragment payload. Also ikev2_send_encrypted_fragments() now uses the new sa_msgid_current instead of sa_msgid just

cmdfile for config -ef

2019-05-11 Thread Ted Unangst
This adds a new option to config, -c cmdfile, that allows reading commands from a file instead of stdin. This makes it easier to script. Index: config.8 === RCS file: /home/cvs/src/usr.sbin/config/config.8,v retrieving revision 1.66

Re: tcpdump support extended bgp shutdown communication

2019-05-11 Thread Job Snijders
OK job@ On Sat, May 11, 2019 at 14:37 Claudio Jeker wrote: > bgpd already got support for extended shutdown communication messages. > This adds the same support to tcpdump. > > OK? > -- > :wq Claudio > > Index: print-bgp.c > === >

tcpdump support extended bgp shutdown communication

2019-05-11 Thread Claudio Jeker
bgpd already got support for extended shutdown communication messages. This adds the same support to tcpdump. OK? -- :wq Claudio Index: print-bgp.c === RCS file: /cvs/src/usr.sbin/tcpdump/print-bgp.c,v retrieving revision 1.27 diff

Re: Removing old video drivers

2019-05-11 Thread Matthieu Herrb
On Mon, Apr 22, 2019 at 06:47:23PM +0200, Matthieu Herrb wrote: > Hi, > > In xenocara, we still build a number of video drivers for very old > hardware, that is mostly useless. For AGP, I don't have a working > motherboard to test the cards I still have. > I also still have a few PCI cards for