Re: smtpd: Allow labels containing "@"

2019-07-23 Thread Klemens Nanni
On Tue, Jul 23, 2019 at 09:06:33AM +0200, Gilles Chehade wrote: > On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote: > > it seems to me this url is wrong. the '@' in username should be urlencoded. > > > > smtps://klemens%40posteo...@posteo.de:465. OK, according to this it is

zero tmpkeyiv in openssl enc

2019-07-23 Thread Steven Roberts
Hi, This patch for openssl enc will zero out tmpkeyiv which contains key information. Thanks. Index: enc.c === RCS file: /cvs/src/usr.bin/openssl/enc.c,v retrieving revision 1.21 diff -u -p -u -r1.21 enc.c --- enc.c 14 Jul

Re: smtpd: Allow labels containing "@"

2019-07-23 Thread Sebastian Benoit
Gilles Chehade(gil...@poolp.org) on 2019.07.23 09:06:33 +0200: > On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote: > > On Mon, Jul 22, 2019 at 11:26:28PM +0200, Klemens Nanni wrote: > > > My mail is klem...@posteo.de and the provider expects this full address > > > as username, so

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-23 Thread Ingo Schwarze
Hi Gilles, Gilles Chehade wrote on Tue, Jul 23, 2019 at 08:27:06AM +0200: > On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote: >> This is a diff for that changes the example smtpd.conf and smtpd.conf.5 >> so that it no longer uses words that are parts of the configuration >> syntax

Re: net80211 hostap: fix turning HT protection off

2019-07-23 Thread Mark Kettenis
> Date: Tue, 23 Jul 2019 12:33:18 +0200 > From: Stefan Sperling > > HT protection is demanded by the 802.11n standard but really hurts > performance while active. In hostap mode we toggle HT prot on and off > based on non-11n/ac nodes in the node cache. Once the non-11n/ac > nodes are gone, HT

Re: ssh needs sendfd in pledge call?

2019-07-23 Thread Theo de Raadt
Looks good to me. Ricardo Mestre wrote: > Hi, > > As Timothy reported, and with the options he selected for ssh then the > codepath > taken will call mux_client_request_session -> mm_send_fd -> sendmsg(2). Since > sendmsg(2) is not allowed in that codepath then pledge(2) kills the process. >

Re: ssh needs sendfd in pledge call?

2019-07-23 Thread Ricardo Mestre
Hi, As Timothy reported, and with the options he selected for ssh then the codepath taken will call mux_client_request_session -> mm_send_fd -> sendmsg(2). Since sendmsg(2) is not allowed in that codepath then pledge(2) kills the process. Please see below the trace he provided privately, and

Re: [PATCH] Provide static_ASN1_*(). From OpenSSL 1.1.0 API.

2019-07-23 Thread Kinichiro Inoguchi
Hi, +#define static_ASN1_SEQUENCE_END_ref(stname, tname) \ + ;\ + ASN1_ITEM_start(tname) \ I think this should be "static_ASN1_ITEM_start" instead "ASN1_ITEM_start".

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-23 Thread Theo de Raadt
Gilles Chehade wrote: > On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote: > > This is a diff for that changes the example smtpd.conf and smtpd.conf.5 > > so that it no longer uses words that are parts of the configuration > > syntax as labels for actions. A large chunk of my

bgpd parse.y cleanup of rde rib

2019-07-23 Thread Claudio Jeker
Make this part of the parser a bit nicer so that more options can be added in a later step. There should be no functional change caused by this. -- :wq Claudio Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v

Re: fix: NULL dereference in bios(4)

2019-07-23 Thread Jan Klemkow
On Tue, Jul 23, 2019 at 10:05:58PM +1000, Jonathan Gray wrote: > On Mon, Jul 22, 2019 at 10:03:38AM +0200, Jan Klemkow wrote: > > On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > > > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > > > On Fri, Jul 19, 2019 at

Re: fix: NULL dereference in bios(4)

2019-07-23 Thread Jonathan Gray
On Mon, Jul 22, 2019 at 10:03:38AM +0200, Jan Klemkow wrote: > On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > > On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > > > > On Fri, Jul 19, 2019 at

net80211 hostap: fix turning HT protection off

2019-07-23 Thread Stefan Sperling
HT protection is demanded by the 802.11n standard but really hurts performance while active. In hostap mode we toggle HT prot on and off based on non-11n/ac nodes in the node cache. Once the non-11n/ac nodes are gone, HT protection should be switched off again. Due to a coding error we never

Re: smtpd: default to standard ports in relay-host

2019-07-23 Thread Klemens Nanni
On Tue, Jul 23, 2019 at 11:00:04AM +0200, Gilles Chehade wrote: > there is no schema today that should default to 587, unless > submission:// is introduced as an alias to smtp+tls AND port 587. Alright; this way we guarantee not to break any setup as the default of 25 for everything is kept,

Re: extend 802.11 Rx aggregation "gap timeout"

2019-07-23 Thread Stefan Sperling
On Mon, Jul 22, 2019 at 08:40:58PM +0200, Stefan Sperling wrote: > Also, I just realized I can no longer trigger the gap timeout problem > I observed without my patch. The timeout might have triggered due to > some underlying problem where frames were not received correctly by > athn, either

Re: smtpd: default to standard ports in relay-host

2019-07-23 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 10:54:57AM +0200, Klemens Nanni wrote: > On Tue, Jul 23, 2019 at 08:18:18AM +0200, Gilles Chehade wrote: > > it should definitely default to 25 in my opinion, disregarding if people > > use "relay host" for submission or not. > Fine with me; I just tried to be consistent

Re: smtpd: default to standard ports in relay-host

2019-07-23 Thread Klemens Nanni
On Tue, Jul 23, 2019 at 08:18:18AM +0200, Gilles Chehade wrote: > it should definitely default to 25 in my opinion, disregarding if people > use "relay host" for submission or not. Fine with me; I just tried to be consistent with the rest of smtpd's default values. > relay host may be used for

bgpd don't overflow buffer with MPLS VPN prefixes

2019-07-23 Thread Claudio Jeker
Hit this with the mrt dump code reliably since the realloc triggers a chunk canary corrupted error. Fix is obvious, the size if plen is modified to include the label stack and rd of the prefix and so the memcpy writes too much. Store correct size before changing plen to fix this. OK? -- :wq

Re: smtpd: Allow labels containing "@"

2019-07-23 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote: > On Mon, Jul 22, 2019 at 11:26:28PM +0200, Klemens Nanni wrote: > > My mail is klem...@posteo.de and the provider expects this full address > > as username, so that makes for the following perfectly > > valid SMTP URL

Re: smtpd: Allow labels containing "@"

2019-07-23 Thread Sebastien Marie
On Mon, Jul 22, 2019 at 11:26:28PM +0200, Klemens Nanni wrote: > My mail is klem...@posteo.de and the provider expects this full address > as username, so that makes for the following perfectly > valid SMTP URL smtps://klem...@posteo.de@posteo.de:465. it seems to me this url is wrong. the '@' in

Re: Diff to stop using reserved words for smtpd.conf(5) examples

2019-07-23 Thread Gilles Chehade
On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote: > This is a diff for that changes the example smtpd.conf and smtpd.conf.5 > so that it no longer uses words that are parts of the configuration > syntax as labels for actions. A large chunk of my delay to a release > with the new

Re: smtpd: default to standard ports in relay-host

2019-07-23 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 01:34:11AM +0200, Klemens Nanni wrote: > Using the following configuration, I wrongly assumed smtpd(8) to pick > the appropiate ports by default depending on the protocol as it already > does for `listen' statements: > > action "relay" relay host

Re: smtpd: Use IPPORT_HILASTAUTO not 0xffff

2019-07-23 Thread Gilles Chehade
On Tue, Jul 23, 2019 at 12:20:04AM +0200, Klemens Nanni wrote: > More mnemonic and readable. > indeed, I didn't know about IPPORT_HILASTAUTO :-) > OK? yes, ok > Index: to.c > === > RCS file: /cvs/src/usr.sbin/smtpd/to.c,v >