smtpd: parse.y copy/paste error

2019-09-21 Thread Sebastien Marie
Hi, A copy/paste error is present in parse.y, due to late addition of "srs key backup secrets". - grammar needs a | to make the following part of 'srs' section - the backup secret is $4 (and not $3) Comments or OK ? -- Sebastien Marie diff 3a973d3129d0b88d07e9b2c5cb9e9cfcaf7997d7 /home/semari

Re: thermal-zones - A64 support

2019-09-21 Thread Mark Kettenis
> Date: Fri, 6 Sep 2019 21:55:43 +0200 > From: Krystian Lewandowski > > Good evening Mark (and tech@), > thank you for thermal zones support. > > I thought it would be nice to use it in A64 as well. > I tested it by running 'ubench -c' in a loop and checking clocks > and CPU temp. Clock went dow

Re: assert() triggered in flex

2019-09-21 Thread Todd C . Miller
On Sat, 21 Sep 2019 20:21:12 +0800, Michael Mikonos wrote: > When I remembered to check if upstream flex had fixed the sf_pop() > issue I found their fix was a little different: > https://github.com/westes/flex/commit/9ba6e5283efd2fe454d3bc92eca960b3ebd9129 > 4 > > Notably, FLEX_EXIT() is not call

Re: assert() triggered in flex

2019-09-21 Thread Michael Mikonos
On Tue, Sep 17, 2019 at 11:56:26PM +0800, Michael Mikonos wrote: > Hello, > > I was wondering why fuzz input was sometimes crashing flex(1). > Now that assert() is enabled in the build I am able to > trigger it with the following input. > > $ cat test.l > %{ > hello > %} > > %% > > ))) > world

New dwge(4) driver

2019-09-21 Thread Mark Kettenis
Here is a "rewrite" of the dwge(4) driver. It is heavily based on the dwxe(4) driver that patrick@ wrote some time ago for the newer Allwinner SoCs. That isn't an accident. The DMA engines and descriptor ring structures are very, very similar. However, the control bits are scattered around comp

Re: smtpd: smtpc: ssl_check_name() dead assignment

2019-09-21 Thread gilles
September 21, 2019 10:03 AM, "Sebastien Marie" wrote: > Hi, > > The current code in smtp_verify_server_cert() has a dead assignment for return > code of ssl_check_name(). > > At first stance, I was a bit unsure if return code should be checked or not to > detect certificate error. but as soon s

smtpd: smtpc: ssl_check_name() dead assignment

2019-09-21 Thread Sebastien Marie
Hi, The current code in smtp_verify_server_cert() has a dead assignment for return code of ssl_check_name(). At first stance, I was a bit unsure if return code should be checked or not to detect certificate error. but as soon ssl_check_name() is entered, `match' is set to 0, and only set to 1 whe

smtpd: smtp_session.c: remove simple dead assignment

2019-09-21 Thread Sebastien Marie
Hi, The following diff removes a simple i=0 dead assignment. There is no need to set it before entering the for() loop which will set it anyway. Comments or OK ? -- Sebastien Marie diff ea5e035f4d57ede9f18c82c5c9decc5f46c1925a /home/semarie/repos/openbsd/src blob - 4e4978e48478815eb789b777ff4d

smtpd: report_smtp_broadcast: error out on unexpected direction

2019-09-21 Thread Sebastien Marie
Hi, in report_smtp_broadcast(), the direction is expected to be "smtp-in" or "smtp-out", but if something else happen, the `struct dict *d' will be uninitialized when used in `dict_xget(d, event)'. so enforce the direction is right by make an unexpected direction fatal. Please note that it makes

Re: apmd battery emergency message

2019-09-21 Thread Christopher Zimmermann
On Fri, 20 Sep 2019 17:00:39 +0200 Alexander Bluhm wrote: > Hi, > > sometimes my laptop was running out of battery while I was working. > To avoid that, I patched apmd(8) to write a emergency message to > syslog(3). Then with this line in syslog.conf I receive a warning > in every xterm. > > #

smtpd: ecdsa_engine_init: properly initialize errstr on error

2019-09-21 Thread Sebastien Marie
Hi, in ecdsa_engine_init(), if ECDSA_METHOD_new_temporary() failed and return NULL, the goto fail will use errstr which is uninitialized. 749 fail: 750 ssl_error(errstr); 751 fatalx("%s", errstr); Set `errstr' to static string as all others error condition in the function. Comm