Re: use tasks and a task_list to manage if_addrhooks

2019-11-12 Thread Alexander Bluhm
syzkaller managed to trigger one of the assertions added by this diff. https://syzkaller.appspot.com/bug?id=2f4de8101553f64fcf847f8ed15cd1862b355122 On Thu, Nov 07, 2019 at 09:22:17PM +1000, David Gwynne wrote: > this applies the use of tasks and a task_list to interface address > hooks. it's

iked(8): log reason when SA is freed

2019-11-12 Thread Tobias Heider
Currently we print a log message whenever an SA state is changed. When the SA is deleted we print something like "sa_state: ... -> CLOSED", without giving any context why it was dropped. This diff adds a mechanism to specify the reason why the SA was freed. The old output looks like something is

Re: fix xhci 'actlen' calculation

2019-11-12 Thread Patrick Wildt
On Tue, Nov 12, 2019 at 07:00:00PM +0100, Patrick Wildt wrote: > On Tue, Nov 12, 2019 at 01:43:28PM +0100, Patrick Wildt wrote: > > On Tue, Nov 12, 2019 at 10:45:39AM +0100, Gerhard Roth wrote: > > > Hi, > > > > > > xhci's calculation of 'xfer->actlen' is wrong if the xfer was split into > > >

Re: sysupgrade: Allow to use another directory for the sets

2019-11-12 Thread Renaud Allard
On 12/11/2019 08:29, Theo de Raadt wrote: Renaud, please test it for me like this: sysupgrade -d / This interface is dangerously incorrect. What about this one? Index: sysupgrade.8 === RCS file:

Re: fix xhci 'actlen' calculation

2019-11-12 Thread Patrick Wildt
On Tue, Nov 12, 2019 at 01:43:28PM +0100, Patrick Wildt wrote: > On Tue, Nov 12, 2019 at 10:45:39AM +0100, Gerhard Roth wrote: > > Hi, > > > > xhci's calculation of 'xfer->actlen' is wrong if the xfer was split into > > multiple TRBs. That's because the code just looks at the remainder > >

unwind(8): refactor & simplify refcounting

2019-11-12 Thread Florian Obser
Did I get this right? I'd appreciate it if someone could give this a once over. Since resolve() switched to a callback mechanism all uw_resolver objects pass through resolve() and either asr_resolve_done() or ub_resolve_done(). With that we can pull resolver_ref() and

Re: iked(8): add configuration option for esn

2019-11-12 Thread Alexander Bluhm
On Tue, Nov 12, 2019 at 04:07:51PM +0100, Tobias Heider wrote: > Makes sense. Here is the updated diff including a fix for bluhms > comment. OK bluhm@ > Index: iked.conf.5 > === > RCS file:

Re: iked(8): add configuration option for esn

2019-11-12 Thread Mike Belopuhov
On Tue, 12 Nov 2019 at 16:08, Tobias Heider wrote: > On Tue, Nov 12, 2019 at 09:57:31AM +0100, Mike Belopuhov wrote: > > Hi Tobias, > > > > I see, however, I don't think iked would negotiate an SA > > without ESN support if the other side supports ESN, so I'm > > not sure how "enforcing" changes

Re: iked(8): add configuration option for esn

2019-11-12 Thread Tobias Heider
On Tue, Nov 12, 2019 at 09:57:31AM +0100, Mike Belopuhov wrote: > Hi Tobias, > > I see, however, I don't think iked would negotiate an SA > without ESN support if the other side supports ESN, so I'm > not sure how "enforcing" changes that. It doesn't, but if I have an iked on both sides one will

smtpd: add support for cidr in hostname resolution for spf walk

2019-11-12 Thread Quentin Rameau
Hello, Here's a patch for smtpctl spf resolution, adding support for target specified as a hostname + cidr. Yes, SPF lets you specify targets like a:example.com/24. Due to the async and recursive nature of DNS resolution in spfwalk.c, it's kind of hard to pass data around without too much

Re: fix xhci 'actlen' calculation

2019-11-12 Thread Patrick Wildt
On Tue, Nov 12, 2019 at 10:45:39AM +0100, Gerhard Roth wrote: > Hi, > > xhci's calculation of 'xfer->actlen' is wrong if the xfer was split into > multiple TRBs. That's because the code just looks at the remainder > reported by the status TRB. However, this remainder only refers to the > total

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, Nov 12, 2019 at 08:52:58PM +1100, Darren Tucker wrote: > On Tue, 12 Nov 2019 at 20:47, Darren Tucker wrote: > > I got this on the second try although the log is not very helpful. > > I'd suggest checking your MaxStartups setting in sshd_config and > > comparing the settings to the numbers

Re: sysupgrade: Allow to use another directory for the sets

2019-11-12 Thread Renaud Allard
On 11/12/19 8:29 AM, Theo de Raadt wrote: Renaud Allard wrote: +.It Fl d Ar directory +Choose the +.Ar directory +in which the sets will be downloaded. +Default is +.Pa /home/_sysupgrade . ... + d) SETSDIR=${OPTARG};; ... -rm -f /home/_sysupgrade/{${CLEAN}} +rm -f

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, 12 Nov 2019 at 20:47, Darren Tucker wrote: > I got this on the second try although the log is not very helpful. > I'd suggest checking your MaxStartups setting in sshd_config and > comparing the settings to the numbers of connections you have. Confirmed that exceeding MaxStartups matches

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, 12 Nov 2019 at 20:31, Darren Tucker wrote: [..] > I'd start by cranking up the client side log level (LogLevel debug3 in > ~/.ssh/config) and use CVS_RSH="ssh -E logfile" or ssh -y to send the > logs to syslog. > > Is this a public mirror, and if so which one? bleh, it doesn't support

fix xhci 'actlen' calculation

2019-11-12 Thread Gerhard Roth
Hi, xhci's calculation of 'xfer->actlen' is wrong if the xfer was split into multiple TRBs. That's because the code just looks at the remainder reported by the status TRB. However, this remainder only refers to the total size of this single TRB; not to the total size of the xfer. Example: assume

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, 12 Nov 2019 at 20:06, Stuart Henderson wrote: > Occasionally I see this when connecting to anoncvs on my mirror, > > $ cvs -d $CVSROOT di > kex_exchange_identification: Connection closed by remote host > cvs [diff aborted]: end of file from server (consult above messages if any) > > On

Re: iked(8): add configuration option for esn

2019-11-12 Thread Mike Belopuhov
Hi Tobias, I see, however, I don't think iked would negotiate an SA without ESN support if the other side supports ESN, so I'm not sure how "enforcing" changes that. In any case, I'm not opposed to adding a toggle if you guys need it, but could you please adjust the grammar so that "esn" and "no

ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Stuart Henderson
Occasionally I see this when connecting to anoncvs on my mirror, $ cvs -d $CVSROOT di kex_exchange_identification: Connection closed by remote host cvs [diff aborted]: end of file from server (consult above messages if any) On the server side, this is logged: sshd[13009]: error: