cwm: modifier for AltGr

2020-01-31 Thread Artturi Alm
Hi, the diff below adds support for using AltGr(the right Alt on some keyboards) as 'm' modifier with bind-key and bind-mouse. so ie. "bind-key Cm-Return terminal" is available for us w/AltGr to match default binding. the lack of being able to bind w/AltGr did hurt my cwm usage with other bindings

acme-client: prevent duplicate definitions of global variables

2020-01-31 Thread Michael Forney
Every source file that includes extern.h will have its own definition of these variables. Since many compilers allocate the variables with .comm, they end up getting merged by the linker without error. However, ISO C requires exactly one definition of objects with external linkage. gcc 10 will ena

rdomain.4: Use -rdomain to delete rdomain

2020-01-31 Thread Klemens Nanni
Small nit but this properly reflects the "delete" semantic, much better than the implicit "reassign". ifconfig(8) also nicely mentions IPv4 and IPv6 addresses being purged in the `-rdomain' part, should the reader consult this manual afterwards. OK? Index: rdomain.4

Re: em(4) diff to test

2020-01-31 Thread Mike Larkin
On Thu, Jan 30, 2020 at 09:15:35AM +0100, Martin Pieuchot wrote: > On 21/01/20(Tue) 12:31, Martin Pieuchot wrote: > > On 20/01/20(Mon) 16:42, Martin Pieuchot wrote: > > > Diff below is a refactoring of the actual em(4) code and defines that > > > will allows me to present a shorter diff to interrup

Re: refer to pointers as non-null

2020-01-31 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Fri, Jan 31, 2020 at 05:33:05AM -0500: > Noticed this in wait.2, though I imagine other occurences abound. > > I believe non-null is clearer when refering to a pointer than non-zero, which > is a bit 80s, and less likely to be mistaken for the value pointed to. This

Re: [patch] /bin/cp: reduce scope variable

2020-01-31 Thread Ingo Schwarze
Hi, ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: > Reduce scope of a few variables. No, this contradicts OpenBSD coding style. We want local variables declared up front in functions such that you can see at one glance which variables exist. > While here, remove an extraneous

[patch] /bin/cp: reduce scope variable

2020-01-31 Thread ngc891
Hi, Reduce scope of a few variables. While here, remove an extraneous space. Regards, diff --git a/bin/cp/utils.c b/bin/cp/utils.c index a2f480c3393..3e2f94e4fa4 100644 --- a/bin/cp/utils.c +++ b/bin/cp/utils.c @@ -55,10 +55,7 @@ copy_file(FTSENT *entp, int exists) static char *buf;

Re: refer to pointers as non-null

2020-01-31 Thread Klemens Nanni
On Fri, Jan 31, 2020 at 05:33:05AM -0500, Ted Unangst wrote: > Noticed this in wait.2, though I imagine other occurences abound. > > I believe non-null is clearer when refering to a pointer than non-zero, which > is a bit 80s, and less likely to be mistaken for the value pointed to. This > same pa

Re: refer to pointers as non-null

2020-01-31 Thread Gleydson Soares
On Fri, Jan 31, 2020 at 05:33:05AM -0500, Ted Unangst wrote: > Noticed this in wait.2, though I imagine other occurences abound. > > I believe non-null is clearer when refering to a pointer than non-zero, which > is a bit 80s, and less likely to be mistaken for the value pointed to. This > same pa

refer to pointers as non-null

2020-01-31 Thread Ted Unangst
Noticed this in wait.2, though I imagine other occurences abound. I believe non-null is clearer when refering to a pointer than non-zero, which is a bit 80s, and less likely to be mistaken for the value pointed to. This same page also refers to non-zero values, fwiw. Index: wait.2 ==