Re: fix ifconfig joinlist width bug

2020-02-23 Thread Kevin Lo
On Sat, Feb 22, 2020 at 06:38:36PM +0100, Stefan Sperling wrote: > > This fixes display of hex SSIDs in 'ifconfig joinlist' and prevents a > negative number being passed to printf on the following line when 'maxlen' > ends up being capped below the maximum value returned from len_string(): > >

Re: ifconfig man page fix

2020-02-23 Thread Kevin Lo
On Sat, Feb 22, 2020 at 06:40:39PM +0100, Stefan Sperling wrote: > > SSIDs are required to contain printable ASCII only. > Otherwise, they must be specified in hex. > > Let's document this explicitly. ok kevlo@ > diff c20bd74017ceeadb2db0f78a352ed1f1e2b77c2b /usr/src > blob -

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Andrew Hewus Fresh
On Sat, Feb 22, 2020 at 10:21:56PM +, Stuart Henderson wrote: > On 2020/02/22 17:24, Stefan Sperling wrote: > > On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > > > IMHO it is a bad idea to make the output of ifconfig locale-dependent. > > > > Fine. I'll drop this diff. > > > >

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stuart Henderson
On 2020/02/23 05:01, Theo de Raadt wrote: > Stefan Sperling wrote: > > > I don't understand why the installer would matter. Nothing would actually > > change for the installer. We're sure as hell not going to add UTF-8 there. > > The installer's ifconfig would just deal in hex all the way as it

tcpdump: decode some Setup fields for Control transfers

2020-02-23 Thread Jasper Lievisse Adriaanse
Hi, Currently the usbpcap is fairly terse in that it prints the endpoints, type of transfer and data size. Below is a diff to start decoding more data from the packets, currently focusing on control transfers: - print the control stage - for the Setup control transfer stage, print additional

Re: iked.conf.5: Provide GRE tunnel in transport mode example

2020-02-23 Thread Klemens Nanni
On Sat, Feb 22, 2020 at 10:06:49PM +0100, Tobias Heider wrote: > Try this This makes iked use the reverse record of the FQDN's IP (which IP?). I have peers with both IPv4 and IPv6 addreses, one of those peers has an incorrect reverse record, thus iked will not end up using the FQDN I used as

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-23 Thread Lauri Tirkkonen
On Sun, Feb 23 2020 14:48:36 +0200, Lauri Tirkkonen wrote: > So, diff below makes struct __sem non-opaque and removes the indirect > allocations, so that the application is required to provide storage and > can therefore control where it's stored (which could be eg. shm). followup diff that makes

librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-23 Thread Lauri Tirkkonen
I was working on a make jobserver implementation that uses POSIX semaphores as job tokens instead of a complicated socket-based approach. Initially I used named semaphores, which work fine, except if child processes with less privileges need to also open the named semaphore (eg. 'make build' as

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stefan Sperling
On Sun, Feb 23, 2020 at 05:01:03AM -0700, Theo de Raadt wrote: > Stefan Sperling wrote: > > > I don't understand why the installer would matter. Nothing would actually > > change for the installer. We're sure as hell not going to add UTF-8 there. > > The installer's ifconfig would just deal in

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Theo de Raadt
Stefan Sperling wrote: > I don't understand why the installer would matter. Nothing would actually > change for the installer. We're sure as hell not going to add UTF-8 there. > The installer's ifconfig would just deal in hex all the way as it does today. > During install finding the right

Re: diff: init efifb even if VGA is probed.

2020-02-23 Thread Mark Kettenis
> Date: Sun, 23 Feb 2020 18:50:54 +0900 (JST) > From: YASUOKA Masahiko > > On Sat, 22 Feb 2020 13:02:48 +1100 > Jonathan Gray wrote: > > On Fri, Feb 21, 2020 at 02:09:07PM +0900, YASUOKA Masahiko wrote: > >> When efiboot starts the kernel, the video display becomes distorted > >> and never

Re: efiboot, serial port order

2020-02-23 Thread Mark Kettenis
> Date: Sat, 22 Feb 2020 10:40:13 +0900 (JST) > From: YASUOKA Masahiko > > Hi, > > efiboot is using ACPI UID to determine the minor number of comX. > > In sys/arch/amd64/stand/efiboot/efiboot.c: > 646 for (i = 0; i < sz / sizeof(EFI_HANDLE); i++) { > 647 /* > 648

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stefan Sperling
On Sat, Feb 22, 2020 at 10:21:56PM +, Stuart Henderson wrote: > On 2020/02/22 17:24, Stefan Sperling wrote: > > On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > > > IMHO it is a bad idea to make the output of ifconfig locale-dependent. > > > > Fine. I'll drop this diff. > > >

Re: usbdevs: small addition

2020-02-23 Thread Jonathan Gray
On Sun, Feb 23, 2020 at 11:14:37AM +0100, Jasper Lievisse Adriaanse wrote: > On Sun, Feb 23, 2020 at 11:52:10AM +1100, Jonathan Gray wrote: > > On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote: > > > Hi, > > > > > > - add an AMD product found on the APU2 > > > > I would

Re: diff: init efifb even if VGA is probed.

2020-02-23 Thread Jonathan Gray
On Sun, Feb 23, 2020 at 07:06:50PM +0900, YASUOKA Masahiko wrote: > On Sun, 23 Feb 2020 18:50:54 +0900 (JST) > YASUOKA Masahiko wrote: > > On Sat, 22 Feb 2020 13:02:48 +1100 > > Jonathan Gray wrote: > >> On Fri, Feb 21, 2020 at 02:09:07PM +0900, YASUOKA Masahiko wrote: > >>> When efiboot starts

Re: usbdevs: small addition

2020-02-23 Thread Jasper Lievisse Adriaanse
On Sun, Feb 23, 2020 at 11:52:10AM +1100, Jonathan Gray wrote: > On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote: > > Hi, > > > > - add an AMD product found on the APU2 > > I would not consider 0x7900 a root hub as it attaches to another hub > > uhub2 at uhub1 port 1

Re: diff: init efifb even if VGA is probed.

2020-02-23 Thread YASUOKA Masahiko
On Sun, 23 Feb 2020 18:50:54 +0900 (JST) YASUOKA Masahiko wrote: > On Sat, 22 Feb 2020 13:02:48 +1100 > Jonathan Gray wrote: >> On Fri, Feb 21, 2020 at 02:09:07PM +0900, YASUOKA Masahiko wrote: >>> When efiboot starts the kernel, the video display becomes distorted >>> and never recovered until

Re: diff: init efifb even if VGA is probed.

2020-02-23 Thread YASUOKA Masahiko
On Sat, 22 Feb 2020 13:02:48 +1100 Jonathan Gray wrote: > On Fri, Feb 21, 2020 at 02:09:07PM +0900, YASUOKA Masahiko wrote: >> When efiboot starts the kernel, the video display becomes distorted >> and never recovered until CPU reset. >> >> Our kernel tries to initialized console twice, first