code style questions

2020-06-09 Thread johnc
Looking for some guidance to avoid proposing any unpopular diffs. Style(9) says not to use static on file-local functions in the kernel, because it interferes with the debugger. They still show up on some functions today; is this still an issue? I usually advocate for directly inlining small

Shrink efifb.c code

2020-06-09 Thread johnc
Most of the display drivers wrap the rasops functions, but you can get rid of a lot of code by swapping the cookies and just using the rasops functions directly in wsdisplay_accessops. It is unfortunate that an extra parameter was added to the alloc_screen function, aparently for an obscure

Re: Diff for www:openssh/security.html

2020-06-09 Thread Theo de Raadt
I think this is entirely pointless churn, increasing the value and discovery at a single endpoint, and stands against what the web stood for. If the URL isn't served anymore, delete it. Don't let someone harvest visits. No matter who they are. Or simpler, leave it alone. Not all problems

Diff for www:openssh/users.html

2020-06-09 Thread bsd
Hi, Here a diff for www page: openssh/users.html Change URLs to those on archive.org (and others sites) Right? Index: openssh/users.html === RCS file: /cvs/www/openssh/users.html,v retrieving revision 1.66 diff -u -r1.66

Diff for www:openssh/security.html

2020-06-09 Thread bsd
Hi, Here a diff for www page: openssh/security.html Change some URLs to those on archive.org (and other site) Right? Index: openssh/security.html === RCS file: /cvs/www/openssh/security.html,v retrieving revision 1.64 diff -u

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-09 Thread Theo de Raadt
Mark Kettenis wrote: > > Date: Tue, 9 Jun 2020 23:43:50 +0200 > > From: Christian Weisgerber > > > > Mark Kettenis: > > > > > Unfortunately that doesn't quite work. At least in my build it > > > doesn't pick up .c files in the linker/arch directories. > > > > > > > Index:

Re: TCP congestion window pinned by integer arithmetic

2020-06-09 Thread Richard Procter
Hi, > On 2/06/2020, at 9:41 AM, Brian Brombacher wrote: > > Hi, > > RFC 5681 Section 3.1 has an Implementation Note that covers the bug fixed by > the following patch. I ran into this bug testing on a high latency link. My > congestion window was pinned to a specific value and could not

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-09 Thread Mark Kettenis
> Date: Tue, 9 Jun 2020 23:43:50 +0200 > From: Christian Weisgerber > > Mark Kettenis: > > > Unfortunately that doesn't quite work. At least in my build it > > doesn't pick up .c files in the linker/arch directories. > > > > > Index: lib/libkern/arch/arm64/ffs.c > > I was certain I had

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-09 Thread Christian Weisgerber
Mark Kettenis: > Unfortunately that doesn't quite work. At least in my build it > doesn't pick up .c files in the linker/arch directories. > > > Index: lib/libkern/arch/arm64/ffs.c I was certain I had checked this, but indeed it doesn't work. The Makefile rules are generated from

Re: PCI interrupt routing on UEFI machine?

2020-06-09 Thread Mark Kettenis
> From: Jaromír Doleček > Date: Wed, 3 Jun 2020 14:16:47 +0200 > > Hello, > > I'm working on porting xmm7360 device driver from Linux to OpenBSD, > the Linux code: > https://github.com/xmm7360/xmm7360-pci/ > > Most of device driver communication with the device is already > working, but

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-09 Thread Mark Kettenis
> From: Christian Weisgerber > Date: Tue, 9 Jun 2020 18:39:45 - (UTC) > > Here are optimized ffs(3) implementations for > * arm64 (superseding the earlier ffs.S) > * powerpc > * powerpc64 > > arm64 tested by myself, powerpc tested by cwen@. > > OK? > > (Some other archs fell through.

Re: libkern: ffs() for arm64, powerpc, powerpc64

2020-06-09 Thread Christian Weisgerber
On 2020-06-09, Christian Weisgerber wrote: > Here are optimized ffs(3) implementations for > * arm64 (superseding the earlier ffs.S) > * powerpc > * powerpc64 > +int ffs(int x) Oops, I'm going to change that to int ffs(int x) before commit. -- Christian "naddy" Weisgerber

ffs(3): libc arch versions, regress

2020-06-09 Thread Christian Weisgerber
This adds the optimized ffs(3) versions on aarch64 and powerpc to libc, for completeness' sake. Also add a brief regression test. OK? Index: lib/libc/arch/aarch64/string/ffs.c === RCS file: lib/libc/arch/aarch64/string/ffs.c diff

Re: Block device poll(2) vs kqueue(2)

2020-06-09 Thread Mark Kettenis
> Date: Tue, 9 Jun 2020 11:04:02 +0200 > From: Martin Pieuchot > > On 20/05/20(Wed) 14:22, Martin Pieuchot wrote: > > On 20/05/20(Wed) 12:28, Mark Kettenis wrote: > > > > Date: Wed, 20 May 2020 11:42:32 +0200 > > > > From: Martin Pieuchot > > > > > > > > Diff below fixes an incoherency between

Re: Block device poll(2) vs kqueue(2)

2020-06-09 Thread Martin Pieuchot
On 20/05/20(Wed) 14:22, Martin Pieuchot wrote: > On 20/05/20(Wed) 12:28, Mark Kettenis wrote: > > > Date: Wed, 20 May 2020 11:42:32 +0200 > > > From: Martin Pieuchot > > > > > > Diff below fixes an incoherency between poll(2) and kqueue(2) when it > > > comes to non-character devices. It makes

Re: pppx(4): rework to be clese to pseudo-interfaces

2020-06-09 Thread Martin Pieuchot
On 08/06/20(Mon) 15:09, Vitaliy Makkoveev wrote: > On Mon, Jun 08, 2020 at 12:49:05PM +0300, Vitaliy Makkoveev wrote: > > [...] > > There is another way to rewrite pppx_add_session() and > > pipex_add_session(). We can split pipex_add_session() to two > > functions: pipex_init_session() and

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-09 Thread Remi Locherer
On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > > > Hi, > > > > > > to my knowledge there is no easy way to list all active rdomains or > > >

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-09 Thread Claudio Jeker
On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > > Hi, > > > > to my knowledge there is no easy way to list all active rdomains or > > routing tables. Other platforms have "show vrf" or similar commands > > for an

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-09 Thread Remi Locherer
On Mon, Jun 08, 2020 at 10:10:17PM +0200, Remi Locherer wrote: > Hi, > > to my knowledge there is no easy way to list all active rdomains or > routing tables. Other platforms have "show vrf" or similar commands > for an overview. > > Here is my attempt at such a view for OpenBSD: Updated diff