Re: [PATCH] net: prevent if_clone_destroy from racing with rest of stack

2020-06-24 Thread Jason A. Donenfeld
Hi Martin, On Wed, Jun 24, 2020 at 4:02 AM Martin Pieuchot wrote: > Yes, that might be a better way. If I understood your original mail the > issue is related to ifunit(), right? ifunit() is not used in packet- > processing contexts, that's why we did not protect it by the NET_LOCK(). > > I'm n

Re: RIP, freedb (cddb service)

2020-06-24 Thread Theo de Raadt
Fine with me... Christian Weisgerber wrote: > The freedb.org CD track database is dead. Its shutdown had already > been announced for March, and it finally disappeared. > > gnudb.org, whoever they are, offers the last working alternative > that still supports the CDDB protocol. Actually, the

RIP, freedb (cddb service)

2020-06-24 Thread Christian Weisgerber
The freedb.org CD track database is dead. Its shutdown had already been announced for March, and it finally disappeared. gnudb.org, whoever they are, offers the last working alternative that still supports the CDDB protocol. Actually, the port was dead yesterday, but they fixed it today. I sugg

Re: Adapt usbhidaction.1 example to sndio changes

2020-06-24 Thread Jason McIntyre
On Tue, Jun 23, 2020 at 02:22:09PM +0200, Benjamin Baier wrote: > Hi, > > adapt usbhidaction.1 example to sndio changes. > > Greetings Ben > fixed, thanks. jmc > Index: usbhidaction.1 > === > RCS file: /var/cvs/src/usr.bin/usbhida

pipex(4): use reference counters for `ifnet'

2020-06-24 Thread Vitaliy Makkoveev
While `mbuf' enqueued to `pipexinq' or `pipexoutq' it has the reference to corresponding pipex(4) session as `ph_cookie'. `ph_cookie' is accessed by pipexintr() and it's always defferent context from context where we destroy session. `ph_cookie' is protected only while we destroy session by pipex_t

Re: Typo in ifconfig.8

2020-06-24 Thread Jason McIntyre
On Wed, Jun 24, 2020 at 07:17:23PM +0200, Matthias Schmidt wrote: > > Hi, > > there is a typo in the Wireguard section of the ifconfig man page. > > Cheers > > Matthias > fixed, thanks. jmc > diff --git a/ifconfig.8 b/ifconfig.8 > index 5c4a8ad0792..4a95d644972 100644 > --- a/ifconf

Typo in ifconfig.8

2020-06-24 Thread Matthias Schmidt
Hi, there is a typo in the Wireguard section of the ifconfig man page. Cheers Matthias diff --git a/ifconfig.8 b/ifconfig.8 index 5c4a8ad0792..4a95d644972 100644 --- a/ifconfig.8 +++ b/ifconfig.8 @@ -2148,7 +2148,7 @@ Set the allowed IPs for the peer. The allowed IPs indicate t

Re: pkg_add.1

2020-06-24 Thread Jason McIntyre
On Tue, Jun 23, 2020 at 07:28:09PM -0400, sven falempin wrote: > Dear readers, > > It may not be very obvious that 'dry run' mode of pkg_add > actually downloads packages. > It is a good feature and maybe the pkg_add man could use an EXAMPLES > section. > hi. it might not be obvious, but it is

Re: xhci: zero length multi-TRB inbound xfer does not work

2020-06-24 Thread sc . dying
On 2020/06/24 11:57, Patrick Wildt wrote: > On Tue, Jun 16, 2020 at 06:55:27AM +, sc.dy...@gmail.com wrote: >> hi, >> >> The function xhci_event_xfer_isoc() of sys/dev/usb/xhci.c at line 954 >> does not work with zero length multi-TRB inbound transfer. >> >>949 /* >>950

Re: xhci: zero length multi-TRB inbound xfer does not work

2020-06-24 Thread Patrick Wildt
On Tue, Jun 16, 2020 at 06:55:27AM +, sc.dy...@gmail.com wrote: > hi, > > The function xhci_event_xfer_isoc() of sys/dev/usb/xhci.c at line 954 > does not work with zero length multi-TRB inbound transfer. > >949/* >950 * If we queued two TRBs for a fram

Re: Potential grep bug?

2020-06-24 Thread Martijn van Duren
Moving to tech@ On Tue, 2020-06-23 at 22:17 -0900, Philip Guenther wrote: > Nope. This is a grep of a single file, so procfile() must be overflowing > and this only 'fixes' it by relying on signed overflow, which is undefined > behavior, being handled in a particular way by the compiler. So, luc

Re: [PATCH] net: prevent if_clone_destroy from racing with rest of stack

2020-06-24 Thread Martin Pieuchot
On 23/06/20(Tue) 17:21, Jason A. Donenfeld wrote: > On Tue, Jun 23, 2020 at 8:21 AM Martin Pieuchot wrote: > > I'd argue this is a related problem but a different one. The diff I > > sent serializes cloning/destroying pseudo-interfaces. It has value on > > its own because *all* if_clone_*() oper

Re: userland clock_gettime proof of concept

2020-06-24 Thread Robert Nagy
On 22/06/20 19:12 +0300, Paul Irofti wrote: > New iteration: > > - ps_timekeep should not coredump, pointed by deraadt@ > - set ps_timekeep to 0 before user uvm_map for randomization > - map timekeep before fixup. confirmed by naddy@ that it fixes NULL init > - initialize va. clarified by

Re: xhci(4): acknowledge interrupts before calling usb_schedsoftintr()

2020-06-24 Thread Martin Pieuchot
On 23/06/20(Tue) 23:13, Patrick Wildt wrote: > Hi, > > I had issues with a machine hanging on powerdown. The issue is caused > by sd(4)'s suspend method trying to "power down" my umass(4) USB stick. > > The symptom was that during powerdown, when running in "polling mode", > the first transactio