Re: ksh [emacs.c] -- simplify isu8cont()

2020-07-25 Thread ropers
On 25/07/2020, Martijn van Duren wrote: > This function is used throughout the OpenBSD tree and I think it's > fine as it is. This way it's clearer to me that it's about byte > 7 and 8 You mean bits 7 and 8 when counting from 1 from the right? > and not have to do the math in my head to check

timeout(9): add clock-based timeouts (attempt 2)

2020-07-25 Thread Scott Cheloha
Hi, I want to add clock-based timeouts to the kernel because tick-based timeouts suffer from a few problems: 1. They are not sensitive to NTP adjustment, so they can easily expire too early or too late. This is incorrect, particularly for POSIX interfaces that forbid early return. 2.

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-25 Thread Jesper Wallin
On Sat, Jul 25, 2020 at 02:01:06PM +0200, Jeremie Courreges-Anglas wrote: > > For those two reasons I think the feature should be opt-in. Yeah, I agree with you. My first approach was to have it check what kind of DNS record that was requested, and add the AD-flag only if type was SSHFP, but

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-25 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2020.07.25 14:01:06 +0200: > On Fri, Jul 17 2020, Jesper Wallin wrote: > > Hi all, > > > > I recently decided to add SSHFP records for my servers, since I never > > memorize or write down my key fingerprints. I learned that if I > > want ssh(1) to

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-25 Thread sc . dying
On 2020/07/25 18:10, Marcus Glocker wrote: > On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > >> On 2020/07/19 11:25, Marcus Glocker wrote: >>> On Sun, 19 Jul 2020 02:25:30 + >>> sc.dy...@gmail.com wrote: >>> hi, It works on AMD Bolton xHCI (78141022),

Re: ksh [emacs.c] -- simplify isu8cont()

2020-07-25 Thread Ingo Schwarze
Hi, Martijn van Duren wrote on Sat, Jul 25, 2020 at 09:54:53PM +0200: > This function is used throughout the OpenBSD tree and I think it's > fine as it is. This way it's clearer to me that it's about byte > 7 and 8 and not have to do the math in my head to check if we > might have botched it. >

Re: ksh [emacs.c] -- simplify isu8cont()

2020-07-25 Thread Martijn van Duren
This function is used throughout the OpenBSD tree and I think it's fine as it is. This way it's clearer to me that it's about byte 7 and 8 and not have to do the math in my head to check if we might have botched it. Also compilers should be smart enough to optimize this out at compile-time

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-25 Thread Marcus Glocker
On Sun, Jul 19, 2020 at 02:12:21PM +, sc.dy...@gmail.com wrote: > On 2020/07/19 11:25, Marcus Glocker wrote: > > On Sun, 19 Jul 2020 02:25:30 + > > sc.dy...@gmail.com wrote: > > > >> hi, > >> > >> It works on AMD Bolton xHCI (78141022), Intel PCH (1e318086), > >> and ASM1042 (10421b21).

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-07-25 Thread Scott Cheloha
On Fri, Jul 17, 2020 at 10:47:50AM -0900, Philip Guenther wrote: > On Thu, Jul 16, 2020 at 4:55 PM Scott Cheloha > wrote: > > > > On Jul 16, 2020, at 19:36, Theo de Raadt wrote: > > > > > >> Note the third sentence. > > >> > > >> Given that, I reason that a serializing instruction before *and*

Re: Add ability to set control values with video(1)

2020-07-25 Thread Laurence Tratt
On Sat, Jul 25, 2020 at 10:27:15AM -0600, Theo de Raadt wrote: Hello Theo, > My primary concern is about a user changing settings which then persist > past close. > > Upon re-open, how do they know what mode they are in? > > I understand the default mode for a camera might not be nice. But at

Re: Add ability to set control values with video(1)

2020-07-25 Thread Marcus Glocker
On Sat, Jul 25, 2020 at 10:27:15AM -0600, Theo de Raadt wrote: > Matthieu Herrb wrote: > > > On Sat, Jul 25, 2020 at 09:17:24AM -0600, Theo de Raadt wrote: > > > Marcus Glocker wrote: > > > > > > > Instead of introducing the CLI parameter controls in video(1), we could > > > > introduce

Re: Add ability to set control values with video(1)

2020-07-25 Thread Theo de Raadt
Stuart Henderson wrote: > On 2020/07/25 09:20, Theo de Raadt wrote: > > The normal idiom is when last-close happens in a driver, all modal-state > > is lost and restored to default, and when you use the driver again -- > > the new open gets you a raw configuration which is then changed via > >

Re: Add ability to set control values with video(1)

2020-07-25 Thread Stuart Henderson
On 2020/07/25 09:20, Theo de Raadt wrote: > The normal idiom is when last-close happens in a driver, all modal-state > is lost and restored to default, and when you use the driver again -- > the new open gets you a raw configuration which is then changed via > ioctl, before futher use. Isn't this

ksh [emacs.c] -- simplify isu8cont()

2020-07-25 Thread ropers
Index: emacs.c === RCS file: /cvs/src/bin/ksh/emacs.c,v retrieving revision 1.87 diff -u -r1.87 emacs.c --- emacs.c 8 May 2020 14:30:42 - 1.87 +++ emacs.c 25 Jul 2020 16:31:22 - @@ -269,10 +269,11 @@ { 0,

Re: Add ability to set control values with video(1)

2020-07-25 Thread Theo de Raadt
Matthieu Herrb wrote: > On Sat, Jul 25, 2020 at 09:17:24AM -0600, Theo de Raadt wrote: > > Marcus Glocker wrote: > > > > > Instead of introducing the CLI parameter controls in video(1), we could > > > introduce videoctl(1) in base, same as we have with audioctl(1). This > > > also gives us

Re: Add ability to set control values with video(1)

2020-07-25 Thread Matthieu Herrb
On Sat, Jul 25, 2020 at 09:17:24AM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > Instead of introducing the CLI parameter controls in video(1), we could > > introduce videoctl(1) in base, same as we have with audioctl(1). This > > also gives us the possibility to only display the

Re: Add ability to set control values with video(1)

2020-07-25 Thread Theo de Raadt
$ video -c white_balance_temperature=6500 $ video $ video -c reset $ video BTW, no other subsystem of ours has this "reset" type thing. A few subsystems have persistance, but persistant modes are usually only in the software layer, not in the hardware layer. The normal idiom is when

Re: Add ability to set control values with video(1)

2020-07-25 Thread Theo de Raadt
Marcus Glocker wrote: > Instead of introducing the CLI parameter controls in video(1), we could > introduce videoctl(1) in base, same as we have with audioctl(1). This > also gives us the possibility to only display the current video > parameters. I must have missed something. Why does it

Re: pf_remove_divert_state

2020-07-25 Thread Alexander Bluhm
On Sat, Jul 25, 2020 at 09:37:37PM +0900, YASUOKA Masahiko wrote: > Is this part a reason why we have "divert-reply"? Yes. Divert rules pass packets to the local network stack. With divert-to you specify the socket address. This works for incomming connections. The divert-to address can be

Re: pf_remove_divert_state

2020-07-25 Thread YASUOKA Masahiko
On Sat, 25 Jul 2020 13:29:57 +0200 Alexander Bluhm wrote: > On Sat, Jul 25, 2020 at 08:20:21PM +0900, YASUOKA Masahiko wrote: >> Currently SO_BINDANY is usable without any divert or divert-reply >> rule. > > This is why we have the divert-reply feature. Just mark the states > with that keyword

Re: carp: unicast carppeer and peer down

2020-07-25 Thread Klemens Nanni
On Sat, Jul 25, 2020 at 04:27:44PM +0900, YASUOKA Masahiko wrote: > When an unicast address is specified for carppeer, if the peer is > down, sending out advertisemnent packets will fail, this failure is > treated as an error of the sending host, then the error counter is > incremented and

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-25 Thread Jeremie Courreges-Anglas
On Fri, Jul 17 2020, Jesper Wallin wrote: > Hi all, > > I recently decided to add SSHFP records for my servers, since I never > memorize or write down my key fingerprints. I learned that if I > want ssh(1) to trust these records, DNSSEC needs to be enabled for my > zone. To validate these

Re: pf_remove_divert_state

2020-07-25 Thread Alexander Bluhm
On Sat, Jul 25, 2020 at 08:20:21PM +0900, YASUOKA Masahiko wrote: > Currently SO_BINDANY is usable without any divert or divert-reply > rule. This is why we have the divert-reply feature. Just mark the states with that keyword when you want to use them with SO_BINDANY. See man setsockopt Is

pf_remove_divert_state

2020-07-25 Thread YASUOKA Masahiko
Hi, # let me correct the previous mail, it has some typos. Currently SO_BINDANY is usable without any divert or divert-reply rule. pf reserves its associated PCB to its state when the packet is going out. This time, the pf rule is not required to have "divert" or "divert-reply" option. When

pf_remove_divert_state

2020-07-25 Thread YASUOKA Masahiko
Hi, Currently SO_BINDANY is usable without any divert or divert-reply rule. pf reserves its associated PCB to its state when the packet is going out. This time, the pf rule is not required to have "divert" or "divert-reply" option. When receiving reverse direction packets, those packets are

carp: unicast carppeer and peer down

2020-07-25 Thread YASUOKA Masahiko
Hi, When an unicast address is specified for carppeer, if the peer is down, sending out advertisemnent packets will fail, this failure is treated as an error of the sending host, then the error counter is incremented and carpdemote is incremenated. I think this is not correct because the failure