Re: pipex(4): kill pipexintr()

2020-08-03 Thread YASUOKA Masahiko
On Mon, 3 Aug 2020 23:36:09 +0300 Vitaliy Makkoveev wrote: > On Tue, Aug 04, 2020 at 01:26:14AM +0900, YASUOKA Masahiko wrote: >> Comments? > > You introduce `cookie' as > > cookie = session->protocol << 16 | session->session_id; > > also multicast sessions initialized as > >

Re: pipex(4): kill pipexintr()

2020-08-03 Thread Vitaliy Makkoveev
On Tue, Aug 04, 2020 at 01:26:14AM +0900, YASUOKA Masahiko wrote: > On Sat, 1 Aug 2020 18:52:27 +0300 > Vitaliy Makkoveev wrote: > > On Sat, Aug 01, 2020 at 07:44:17PM +0900, YASUOKA Masahiko wrote: > >> I'm not sure when it is broken, in old versions, it was assumed the > >> pipex queues are

Re: use runtime clock for ktime in drm

2020-08-03 Thread Scott Cheloha
On Mon, Aug 03, 2020 at 07:16:46PM +1000, Jonathan Gray wrote: > Scott mentioned that ktime should be using a runtime clock which stops > during suspend. The exception to this is ktime_get_bootime() which does > not stop when suspended. > > This is described in >

Re: Improve ure(4) performance

2020-08-03 Thread Mikolaj Kucharski
On Mon, Aug 03, 2020 at 09:07:39AM -0700, Jonathon Fletcher wrote: > > Assuming no issues with this, I would like to get it into the tree. This > patch predates Marcus' usbd_abort_pipe patch by a few weeks. Let me know > if you want an updated patch against HEAD after his patch. > > After

Add Gear Head keyboard usbdev

2020-08-03 Thread Tom Murphy
Hi, I noticed the kernel was just printing out the generic hex device id rather than the name of my keyboard so I did some checking and there is a vendor id for "Gear Head" keyboards. These keyboards are sometimes resold under different names like Octogen or Sanoxy, but they are

Re: pipex(4): kill pipexintr()

2020-08-03 Thread YASUOKA Masahiko
On Sat, 1 Aug 2020 18:52:27 +0300 Vitaliy Makkoveev wrote: > On Sat, Aug 01, 2020 at 07:44:17PM +0900, YASUOKA Masahiko wrote: >> I'm not sure when it is broken, in old versions, it was assumed the >> pipex queues are empty when pipex_iface_stop() is called. The problem >> mvs@ found is the

Re: Improve ure(4) performance

2020-08-03 Thread Jonathon Fletcher
On Thu, Jul 30, 2020 at 06:56:48PM +, Mikolaj Kucharski wrote: > On Thu, Jul 30, 2020 at 07:58:23AM -0700, Jonathon Fletcher wrote: > > > > Mikolaj, > > > > I hope the patch has been stable for you. I do have an update - it appears > > that a splx(s) got lost along the way (from the end of

Re: [PATCH]: Add a check for upgrade feature to sysupgrade(8)

2020-08-03 Thread Solene Rapenne
On Mon, 3 Aug 2020 13:28:38 +0200 Emil Engler : > ## Abstract > This patch adds an argument to sysupgrade(8) which makes it possible > to check if an upgrade is available, similar to "syspatch -c". > This works both, for snapshots and releases. > > ## Usage > Add "-c" to sysupgrade. > If the

Re: softraid/bioctl cant find device /dev/bio

2020-08-03 Thread sven falempin
On Mon, Aug 3, 2020 at 11:38 AM Brian Brombacher wrote: > > > > On Aug 3, 2020, at 9:54 AM, sven falempin > wrote: > > > > ´╗┐Hello > > > > I saw a similar issue in the mailing list around decembre 2019, > > following an electrical problem softraid doesn't bring devices ups > > > > > > # ls

Re: softraid/bioctl cant find device /dev/bio

2020-08-03 Thread Brian Brombacher
> On Aug 3, 2020, at 9:54 AM, sven falempin wrote: > > ´╗┐Hello > > I saw a similar issue in the mailing list around decembre 2019, > following an electrical problem softraid doesn't bring devices ups > > > # ls /dev/sd?? > /dev/sd0a /dev/sd0g /dev/sd0m /dev/sd1c /dev/sd1i /dev/sd1o

softraid/bioctl cant find device /dev/bio

2020-08-03 Thread sven falempin
Hello I saw a similar issue in the mailing list around decembre 2019, following an electrical problem softraid doesn't bring devices ups # ls /dev/sd?? /dev/sd0a /dev/sd0g /dev/sd0m /dev/sd1c /dev/sd1i /dev/sd1o /dev/sd2e /dev/sd2k /dev/sd0b /dev/sd0h /dev/sd0n /dev/sd1d /dev/sd1j /dev/sd1p

Re: [PATCH]: Add a check for upgrade feature to sysupgrade(8)

2020-08-03 Thread Emil Engler
Indeed, it will still download and install it. It is unsuitable because after the mail was sent it can already be too late and it can take lots of network bandwidth. This can be problematic for various reasons. On 2020-08-03 15:10, Stuart Henderson wrote: > On 2020/08/03 13:50, Solene Rapenne

Re: [PATCH]: Add a check for upgrade feature to sysupgrade(8)

2020-08-03 Thread Stuart Henderson
On 2020/08/03 13:50, Solene Rapenne wrote: > On Mon, 3 Aug 2020 13:28:38 +0200 > Emil Engler : > > > ## Abstract > > This patch adds an argument to sysupgrade(8) which makes it possible > > to check if an upgrade is available, similar to "syspatch -c". > > This works both, for snapshots and

[PATCH]: Add a check for upgrade feature to sysupgrade(8)

2020-08-03 Thread Emil Engler
## Abstract This patch adds an argument to sysupgrade(8) which makes it possible to check if an upgrade is available, similar to "syspatch -c". This works both, for snapshots and releases. ## Usage Add "-c" to sysupgrade. If the script exits with a zero, an upgrade is available. If it fails you

Re: [Patch] Remove unused functions in httpd's proc(?)

2020-08-03 Thread Sebastian Benoit
Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:25:05 +1000: > cppcheck reports that proc_iev and proc_ispeer are unused. > > Unless they are wanted for consistency with other versions of proc.c, > tbey can be removed. Yes, proc.c should stay the same across ./sbin/iked/proc.c

Re: [Patch] Remove unused functions in httpd[.ch]

2020-08-03 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:37:50 +1000: > cppcheck reports that kv_inherit(), kv_log(), and print_time() are unused. > > The patch below deletes them. > > Ross > -- > > Index: httpd.c > === > RCS

Re: [Patch] Remove redundant condition in httpd's server_http.c

2020-08-03 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:06:31 +1000: > cppcheck reports this [and other less simple things]. > > Ross > > Index: server_http.c > === > RCS file: /cvs/src/usr.sbin/httpd/server_http.c,v > retrieving

use runtime clock for ktime in drm

2020-08-03 Thread Jonathan Gray
Scott mentioned that ktime should be using a runtime clock which stops during suspend. The exception to this is ktime_get_bootime() which does not stop when suspended. This is described in https://www.kernel.org/doc/html/latest/core-api/timekeeping.html There was perhaps some confusion as