filtering routing socket messages by flags

2020-08-05 Thread Jonathan Matthew
Most (all?) of our routing daemons don't care about layer 2 or broadcast routing entries, so they do something like this after reading a message off the socket: /* Skip ARP/ND cache and broadcast routes. */ if (rtm->rtm_flags & (RTF_LLINFO|RTF_BROADCAST)) continue;

exar XR17V35x (again)

2020-08-05 Thread joshua stein
In 2018 I added support for Exar XR17V35x serial ports: The Exar XR17V354 has 4 com ports that have a 256-byte FIFO, use a frequency of 125Mhz, and have a unique sleep register. A custom interrupt handler is setup in puc for these ports so it can check a register which reports whi

Remove unused netisr defines

2020-08-05 Thread Vitaliy Makkoveev
Remove defines for netisr bits which are not used anymore. Index: sys/net/netisr.h === RCS file: /cvs/src/sys/net/netisr.h,v retrieving revision 1.52 diff -u -p -r1.52 netisr.h --- sys/net/netisr.h4 Aug 2020 09:32:05 -

Re: Don't check pointers against 0

2020-08-05 Thread Vitaliy Makkoveev
ok mvs > On 5 Aug 2020, at 23:49, Marcus Glocker wrote: > > Reported by Peter J. Philipp. > > OK? > > > Index: sys/netinet/udp_usrreq.c > === > RCS file: /cvs/src/sys/netinet/udp_usrreq.c,v > retrieving revision 1.260 > diff -u -

Don't check pointers against 0

2020-08-05 Thread Marcus Glocker
Reported by Peter J. Philipp. OK? Index: sys/netinet/udp_usrreq.c === RCS file: /cvs/src/sys/netinet/udp_usrreq.c,v retrieving revision 1.260 diff -u -p -u -p -r1.260 udp_usrreq.c --- sys/netinet/udp_usrreq.c1 Aug 2020 23:41:56

video -c: showing auto white balance temperature

2020-08-05 Thread Laurence Tratt
Following Marcus's commit of video(1) changes, the attached patch crudely solves the "-c output is misleading for white_balance_temperature" because we conflate auto_white_balance_temperature and white_balance_temperature (which are two separate UVC controls) into one control in video(1). With thi

Re: pppac(4) move ifnet out of KERNEL_LOCK()

2020-08-05 Thread Vitaliy Makkoveev
A little update. I use `ifq' passed to pppac_start() instead of `ifp->if_snd' for consistency reason. Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.98 diff -u -p -r1.98 if_pppx.c --- sys/ne

Re: bugs in bridge ( netlock ? )

2020-08-05 Thread Vitaliy Makkoveev
I guess it’s know issue caused by ifioctl() races. > On 5 Aug 2020, at 19:06, Sven F. wrote: > > On Wed, Aug 5, 2020 at 9:14 AM Sven F. wrote: >> >> Never seen before crash ( 6. 7 stable ) >> >> My devices run a lot of things in, load is easily 4 >> which is good for breaking lock code ? >>

Re: bugs in bridge ( netlock ? )

2020-08-05 Thread Sven F.
On Wed, Aug 5, 2020 at 9:14 AM Sven F. wrote: > > Never seen before crash ( 6. 7 stable ) > > My devices run a lot of things in, load is easily 4 > which is good for breaking lock code ? > > uvm_fault(0xfd820a916cc0, 0x8, 0, 1) -> e > kernel: page fault trap, code=0 > Stopped at bridge_br

Re: tpmr.4, ifconfig.8: document tpmr ioctls and synopsis

2020-08-05 Thread Klemens Nanni
On Wed, Aug 05, 2020 at 03:24:57PM +0100, Jason McIntyre wrote: > this is in line with all our other pages, so ok. while you're poking > around in there, the first example in tpmr.4 EXAMPLES would be a whole > lot nicer with -indent on the display. care to fix that too? Sure, I'll commit with `.Bd

Re: tpmr.4, ifconfig.8: document tpmr ioctls and synopsis

2020-08-05 Thread Jason McIntyre
On Wed, Aug 05, 2020 at 09:03:20AM +0200, Klemens Nanni wrote: > Add missing TPMR section to ifconfig(8) by moving the commands from > the driver's manual to it (copy/paste) and document the ioctl(2) > interface in tpmr(4). > > Feedback? OK? > > this is in line with all our other pages, so ok.

pppac(4) move ifnet out of KERNEL_LOCK()

2020-08-05 Thread Vitaliy Makkoveev
The same as for pppx(4). pipex(4) and pppac(4) are ready to became a little bit more MP capable. Diff below moves pppac(4) related `ifnet' out of KERNEL_LOCK(). The wakeup(9) and selwakeup() are not require KERNEL_LOCK() so this assertion was wrong and can be dropped. Also we detach `ifnet' befor

bugs in bridge ( netlock ? )

2020-08-05 Thread Sven F.
Never seen before crash ( 6. 7 stable ) My devices run a lot of things in, load is easily 4 which is good for breaking lock code ? uvm_fault(0xfd820a916cc0, 0x8, 0, 1) -> e kernel: page fault trap, code=0 Stopped at bridge_brlconf+0x24:movq0x8(%rdi),%rax ddb{1}> bridge_brlconf(0,

Re: macppc G5 pmap fix

2020-08-05 Thread Olivier Cherrier
On Sun, Jul 12, 2020 at 11:33:33AM +0200, mark.kette...@xs4all.nl wrote: > > While working on the OpenBSD/powerpc64 pmap I noticed that the code we > use for the G5 machines has a bug and doesn't remove execute > permission from mappings when it should. > > Since I don't have a G5 machine readily

Re: acpicpu: remove acpicpu_sc array

2020-08-05 Thread Mark Kettenis
> Date: Wed, 5 Aug 2020 17:10:37 +1000 > From: Jonathan Matthew > > This came out of the work on supporting ACPI0007 devices in acpicpu(4), but > it's independent of that and I'd like to get it in the tree separately. > > Since it was first added, acpicpu stores instances of itself in an array,

pppx(4): move ifnet out of KERNEL_LOCK()

2020-08-05 Thread Vitaliy Makkoveev
pipex(4) and pppx(4) are ready to became a little bit more MP capable. Diff below moves pppx(4) related `ifnet' out of KERNEL_LOCK(). Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.98 diff -u

acpicpu: remove acpicpu_sc array

2020-08-05 Thread Jonathan Matthew
This came out of the work on supporting ACPI0007 devices in acpicpu(4), but it's independent of that and I'd like to get it in the tree separately. Since it was first added, acpicpu stores instances of itself in an array, which it uses to find the acpicpu device for a cpu. This runs into problem

tpmr.4, ifconfig.8: document tpmr ioctls and synopsis

2020-08-05 Thread Klemens Nanni
Add missing TPMR section to ifconfig(8) by moving the commands from the driver's manual to it (copy/paste) and document the ioctl(2) interface in tpmr(4). Feedback? OK? Index: sbin/ifconfig/ifconfig.8 === RCS file: /cvs/src/sbin/ifc