Re: Fix kn_data returned by filt_logread()

2020-08-16 Thread Visa Hankala
On Sun, Aug 16, 2020 at 11:39:31AM +, Visa Hankala wrote: > The kernel message buffer is circular. This is not handled properly > by filt_logread(). When the write index wraps, and becomes smaller than > the read index, filt_logread() reports an incorrect number of available > bytes. This has

Re: radeondrm(4) timing issue

2020-08-16 Thread Jonathan Gray
On Fri, Aug 14, 2020 at 03:00:57PM +0200, Marcus Glocker wrote: > Hi, > > Recently I took over the old iMac11,2 of my son, and what else to do > with it other than installing OpenBSD and see what happens. The first > thing which happened after the installation was that the screen > remained dark

Re: Typo fix in comment sys/dev/usb/ugold.c

2020-08-16 Thread Greg Steuck
Committed. Thanks! -- nest.cx is Gmail hosted, use PGP: https://pgp.key-server.io/0x0B1542BD8DF5A1B0 Fingerprint: 5E2B 2D0E 1E03 2046 BEC3 4D50 0B15 42BD 8DF5 A1B0

ospfd: use ROUTE_FLAGFILTER

2020-08-16 Thread Jonathan Matthew
ospfd is our first target for using ROUTE_FLAGFILTER to reduce pressure on the route socket, so here's the diff we've been running for a couple of weeks now (minus the fix for RTM_DELETE flags, notably). ok? Index: kroute.c === RCS

Re: Remove unnecessary field from struct msgbuf

2020-08-16 Thread Vitaliy Makkoveev
The diff looks good for me. I’ll recompile system with your diff tomorrow. > On 16 Aug 2020, at 14:35, Visa Hankala wrote: > > The msg_bufl field of struct msgbuf is written but never read. The value > was used by kernfs which is no longer present, so the code could be > cleaned up a little by

Re: pppoe: start without kernel lock

2020-08-16 Thread Vitaliy Makkoveev
On Sun, Aug 16, 2020 at 08:44:07PM +0200, Klemens Nanni wrote: > On Sun, Aug 16, 2020 at 07:04:46PM +0200, Klemens Nanni wrote: > > Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big > > lock. > > > > As far as I understand, pppoe_output() does not require NET_LOCK() since > >

Re: pppac(4): destroy sessions the same way as pppx(4) does

2020-08-16 Thread Vitaliy Makkoveev
On Sat, Aug 15, 2020 at 02:01:52PM +0900, YASUOKA Masahiko wrote: > On Wed, 12 Aug 2020 12:26:22 +0300 > Vitaliy Makkoveev wrote: > > We destroy pppx(4) related sessions while we performing PIPEXDSESSION > > command. But with pppac(4) we set session's state to > > PIPEX_STATE_CLOSE_WAIT2 and we

Re: Make pipex more common for pppac and pppx

2020-08-16 Thread Vitaliy Makkoveev
On Sat, Aug 15, 2020 at 05:42:06PM +0900, YASUOKA Masahiko wrote: > Let me update the diff. A bug found by the test. > Hello Yasuoka. I like your idea to kill `pipex_iface_context'. I had trying to keep it by myself and this was wrong way. Could you rework your diff to be against the recent

Re: pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
On Sun, Aug 16, 2020 at 07:04:46PM +0200, Klemens Nanni wrote: > Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big > lock. > > As far as I understand, pppoe_output() does not require NET_LOCK() since > if_get(9)/if_put(9) guarantee the validity of the interface pointer and >

sdmmc(4): add UHS-I support

2020-08-16 Thread Mark Kettenis
The diff below adds support for higher speeds as supported by UHS-I SD cards to the generic sdmmc(4) layer. The diff in itself does not enable the use of those modes. That needs separate changes to the SD/MMC controller drivers. I have such a diff for amlmmc(4) that allows me to use SDR50 mode.

pppoe: start without kernel lock

2020-08-16 Thread Klemens Nanni
Make sppp(4)/pppoe(4) use the ifq API to send packets outside the big lock. As far as I understand, pppoe_output() does not require NET_LOCK() since if_get(9)/if_put(9) guarantee the validity of the interface pointer and no `struct ifnet' member is written to; similar to how vlan(4) does it.

Fix kn_data returned by filt_logread()

2020-08-16 Thread Visa Hankala
The kernel message buffer is circular. This is not handled properly by filt_logread(). When the write index wraps, and becomes smaller than the read index, filt_logread() reports an incorrect number of available bytes. This has not affected the activation of the event, though, because the reported

Remove unnecessary field from struct msgbuf

2020-08-16 Thread Visa Hankala
The msg_bufl field of struct msgbuf is written but never read. The value was used by kernfs which is no longer present, so the code could be cleaned up a little by removing the field. On some systems the message buffer data are preserved across a reboot. However, the preservation is best-effort