Re: ldapd warning

2020-11-28 Thread Theo Buehler
On Sun, Nov 29, 2020 at 08:02:45AM +0100, Emil Engler wrote: > It can overflow! Please check for the positivity and width of size_t before! What can overflow? ret is guaranteed to be non-negative before the cast. As for the width (which would be about truncation, not overflow): while the

Re: ldapd warning

2020-11-28 Thread Emil Engler
It can overflow! Please check for the positivity and width of size_t before! Cheers, Emil On 11/28/20 11:20 PM, Theo Buehler wrote: /usr/src/usr.sbin/ldapd/util.c:46:21: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

vmm(4): cpuid leaf 0x15 fixes clock speed problem in Linux guest [PATCH]

2020-11-28 Thread Jozef Hatala
Hello! On a host with Invariant TSC, vmm advertises to the guest support for cpuid leaves up to 0x15 (in the response to leaf 0x00), but when the guest asks for leaves higher than the host's cpuid level, vmm_handle_cpuid serves the response for host's highest cpuid leaf instead. A Linux guest

Re: kvm_getfiles and KERN_FILE_BYFILE

2020-11-28 Thread Philip Guenther
On Thu, Nov 26, 2020 at 1:08 PM Martijn van Duren < openbsd+t...@list.imperialat.at> wrote: > I'm currently playing around a bit with kvm_getfiles and found that I > couldn't use KERN_FILE_BYFILE with DTYPE_SOCKET. > According to kvm_getfiles(3): > For KERN_FILE_BYFILE the recognized file

ldapd warning

2020-11-28 Thread Theo Buehler
/usr/src/usr.sbin/ldapd/util.c:46:21: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] if (ret < 0 || ret >= size) ~~~ ^ This has been around for a while. I forgot that I had this patch in my

Re: stdio: fclose(3), fopen(3): intended locking hierarchy?

2020-11-28 Thread Philip Guenther
On Fri, Nov 27, 2020 at 10:35 PM Philip Guenther wrote: ... > So yeah, maybe it does work to: > 1) make __sfp() FLOCKFILE() the allocated FILE before unlocking sfp_mutex > 2) update f{,d,mem,un}open() and open_*memstream() to match (1), unlocking >in all paths when the FILE is safe to be

Re: Fan Management Framework

2020-11-28 Thread Marcus Glocker
Hello Constantine, Thanks for your feedback. And no, I wasn't aware about your previous patch set. Interesting background you have provided on that topic though. In the meantime I also received internal feedback from other developers, and as you already have mentioned it, there is no interest

Re: Fwd: gre(4): mgre

2020-11-28 Thread Jason McIntyre
On Sat, Nov 28, 2020 at 09:09:19PM +0100, Pierre Emeriaud wrote: > Le sam. 28 nov. 2020 ?? 17:54, Jason McIntyre a ??crit : > > an mgre example seems conspicuous by its absence, so i'd say adding one > > seems helpful. some comments inline: > > Thanks Jason for reviewing this patch. > > > >

Re: Fan Management Framework

2020-11-28 Thread Constantine A. Murenin
Hi Marcus, Sounds interesting! I don't know if you've seen it, but I did a similar patchset back in the day, alas for the common PC desktops with the lm(4) sensors; http://sensors.cnst.su/fanctl/ . However, there hasn't been as much interest in fan control on OpenBSD as I had initially expected

Re: Fwd: gre(4): mgre

2020-11-28 Thread Pierre Emeriaud
Le sam. 28 nov. 2020 à 17:54, Jason McIntyre a écrit : > an mgre example seems conspicuous by its absence, so i'd say adding one > seems helpful. some comments inline: Thanks Jason for reviewing this patch. > > +.Pp > > +In this example the host A has an outer IP of 198.51.100.12, host > > +B

Re: Fwd: gre(4): mgre

2020-11-28 Thread Jason McIntyre
On Sat, Nov 28, 2020 at 12:18:26PM +0100, Pierre Emeriaud wrote: > Hi, > > mgre(4) does not appear to be documented well, I had to find David's > "mgre(4): point-to-multipoint gre tunnels" mail to understand how gre > endpoints are found. > > hi. an mgre example seems conspicuous by its

Re: sio_open.3: clarify what sio_start() does

2020-11-28 Thread Ingo Schwarze
Hi Alexandre, Alexandre Ratchov wrote on Fri, Nov 27, 2020 at 07:05:27PM +0100: > this wording is shorter and more precise and complete. This looks good mdoc(7)-wise, so go ahead, but please consider the two nits below when committing. Yours, Ingo > Index: sio_open.3 >

Fwd: gre(4): mgre

2020-11-28 Thread Pierre Emeriaud
Hi, mgre(4) does not appear to be documented well, I had to find David's "mgre(4): point-to-multipoint gre tunnels" mail to understand how gre endpoints are found. Index: share/man/man4/gre.4 === RCS file: