Re: bgpd refactor timer code

2020-12-10 Thread Richard Procter
Hi Claudio, > On 10/12/2020, at 1:13 AM, Claudio Jeker wrote: > > This diff makes the timer code independent from struct peer. This way > it can be used in different places without too much issues. ok procter@ > OK? > -- > :wq Claudio > > Index: control.c >

Re: [PATCH] umb(4) fix for X20 (DW5821e) in Dell Latitude 7300

2020-12-10 Thread Bryan Vyhmeister
On Mon, Nov 30, 2020 at 07:58:39AM -0800, Bryan Vyhmeister wrote: > On Mon, Oct 19, 2020 at 08:11:04PM -0700, Bryan Vyhmeister wrote: > > On Fri, Oct 02, 2020 at 12:33:15PM -0700, Bryan Vyhmeister wrote: > > > On Wed, Sep 30, 2020 at 04:05:51PM -0700, Bryan Vyhmeister wrote: > > > > Gerhard Roth

Re: cat(1): -n flag: support files with more than INT_MAX lines

2020-12-10 Thread Todd C . Miller
On Thu, 10 Dec 2020 22:12:49 -0600, Scott Cheloha wrote: > If we bump 'line' from an int to an unsigned long long we will > correctly number files with more than INT_MAX lines instead of > wrapping to a negative number. OK millert@ - todd

cat(1): -n flag: support files with more than INT_MAX lines

2020-12-10 Thread Scott Cheloha
Hi, If we bump 'line' from an int to an unsigned long long we will correctly number files with more than INT_MAX lines instead of wrapping to a negative number. ok? Index: cat.c === RCS file: /cvs/src/bin/cat/cat.c,v retrieving

Re: ipmi(4): ipmi_poll_thread(): tsleep(9) -> tsleep_nsec(9)

2020-12-10 Thread Scott Cheloha
On Thu, Dec 10, 2020 at 10:00:46AM +0100, Claudio Jeker wrote: > On Mon, Dec 07, 2020 at 10:54:26PM -0600, Scott Cheloha wrote: > > Index: ipmi.c > > === > > RCS file: /cvs/src/sys/dev/ipmi.c,v > > retrieving revision 1.112 > > diff

pool(9): remove ticks (attempt 2)

2020-12-10 Thread Scott Cheloha
Hi, We looked at removing the ticks from subr_pool.c a while back but it got shelved. That may or may not have been my fault. I don't remember. Anyway, I would normally suggest switching to getuptime(9) here, but getuptime(9) counts in seconds and we're working with a 1 second timeout in this

Re: delays in sensors thread

2020-12-10 Thread Martin Pieuchot
On 10/12/20(Thu) 21:40, Alexandre Ratchov wrote: > On Thu, Dec 10, 2020 at 05:27:16PM +0100, Marcus Glocker wrote: > > Hi All, > > > > I recently started to play around with uvideo(4) and uaudio(4) on my > > amd64 iMacs. There I quickly noticed regular freezes when streaming > > USB video or

Re: delays in sensors thread

2020-12-10 Thread Alexandre Ratchov
On Thu, Dec 10, 2020 at 05:27:16PM +0100, Marcus Glocker wrote: > Hi All, > > I recently started to play around with uvideo(4) and uaudio(4) on my > amd64 iMacs. There I quickly noticed regular freezes when streaming > USB video or audio. On some of those machines it was very frequent, > like

Re: delays in sensors thread

2020-12-10 Thread Martin Pieuchot
On 10/12/20(Thu) 18:47, Mark Kettenis wrote: > [...] > Sensor drivers that are "good citizens" should probably continue to > use the sensor thread. Butfor things like asmc(4) that handle a > largish bundle of sensors, a separate thread would be fine. And I > suspect that thread could run

Re: spamd: make blacklists override learned whitelist

2020-12-10 Thread Boudewijn Dijkstra
Op Tue, 17 Oct 2017 13:49:45 +0200 schreef Todd C. Miller : When running spamd in greylisting mode, it is not uncommon for an IP to get whitelisted that later shows up on a spam blacklist. However, that blacklist entry never takes effect because the IP is already whitelisted and thus appears in

Re: delays in sensors thread

2020-12-10 Thread Theo de Raadt
Mark Kettenis wrote: > Well, we deliberately chose not to do that since that would lead to a > gazillion of kernel threads if you have lots of sensor drivers. > > Sensor drivers that are "good citizens" should probably continue to > use the sensor thread. Butfor things like asmc(4) that handle

Re: delays in sensors thread

2020-12-10 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Thu, 10 Dec 2020 10:13:52 -0700 > > Marcus Glocker wrote: > > > Hi All, > > > > I recently started to play around with uvideo(4) and uaudio(4) on my > > amd64 iMacs. There I quickly noticed regular freezes when streaming > > USB video or audio. On some of

bpf(4): BIOCGRTIMEOUT, BIOCSRTIMEOUT: protect with bd_mtx

2020-12-10 Thread Scott Cheloha
Hi, Before converting bpf(4) from using ticks to using real units of time we need to serialize BIOCGRTIMEOUT and BIOCSRTIMEOUT. Neither operation is atomic so we need to use the per-descriptor mutex when reading or writing the bd_rtout member. While here we can start annotating the locking for

Re: delays in sensors thread

2020-12-10 Thread Theo de Raadt
Marcus Glocker wrote: > Hi All, > > I recently started to play around with uvideo(4) and uaudio(4) on my > amd64 iMacs. There I quickly noticed regular freezes when streaming > USB video or audio. On some of those machines it was very frequent, > like every few seconds the video or audio

Simplify filt_pipedetach()

2020-12-10 Thread Visa Hankala
filt_pipedetach() can be simplified a bit by using kn_hook to point to the pipe. This additionally lets the system fully remove elements from the knote lists. Previously, the write-side list just vanished when the peer was closed. OK? Index: kern/sys_pipe.c

delays in sensors thread

2020-12-10 Thread Marcus Glocker
Hi All, I recently started to play around with uvideo(4) and uaudio(4) on my amd64 iMacs. There I quickly noticed regular freezes when streaming USB video or audio. On some of those machines it was very frequent, like every few seconds the video or audio stream did freeze for ~1s, then resume,

Re: uvm_fault: entering swap code

2020-12-10 Thread Martin Pieuchot
On 08/12/20(Tue) 22:55, Jonathan Matthew wrote: > On Mon, Dec 07, 2020 at 03:15:50PM -0300, Martin Pieuchot wrote: > > Getting a page from the fault handler might require poking at some > > swap-related states. > > > > These are not in the hot-path of the fault handler so for the moment > > just

Re: bgpd show status of set tables

2020-12-10 Thread Claudio Jeker
On Thu, Dec 03, 2020 at 10:59:29PM +0100, Claudio Jeker wrote: > The use of roa-set, prefix-set and as-set is fairly common in bgpd. > Still sometimes it is not exactly clear how old the data in those tables > is. This diff is a first step at inproving inspection by adding > bgpctl show sets

Switch select(2) to kqueue-based implementation

2020-12-10 Thread Martin Pieuchot
All previous kqueue refactoring have been committed, here's a final diff to modify the internal implementation of {p,}select(2) to query kqfilter handlers instead of poll ones. {p,}poll(2) are left untouched to ease the transition. Here's what I said in the original mail back in May [0]: > The

Re: fix ieee80211_amsdu_decap()

2020-12-10 Thread Stefan Sperling
This patch was committed last night but contains a bug: I forgot to adjust error paths to avoid a double-free. Please check the follow-up fix below. Ok? (This double-free wouldn't trigger under normal conditions even in -current, unless we receive crafted packets that would also need to pass

Re: ipmi(4): ipmi_poll_thread(): tsleep(9) -> tsleep_nsec(9)

2020-12-10 Thread Claudio Jeker
On Mon, Dec 07, 2020 at 10:54:26PM -0600, Scott Cheloha wrote: > On Wed, Dec 02, 2020 at 11:43:32PM +0100, Mark Kettenis wrote: > > > From: "Constantine A. Murenin" > > > Date: Wed, 2 Dec 2020 14:04:52 -0800 > > > > > > Not sure if you've seen it, but ipmi(4) has been disabled for over 12 > > >