Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Todd C . Miller
On Sat, 09 Jan 2021 14:39:53 -0800, Greg Steuck wrote: > How's this instead? OK? > > Tested with the usual diff of before/after sysctl outputs and a random > sysctl -w poke. > > Subject: [PATCH] Split hierarchical calls into kern_sysctl_dirs > > Removed a rash of +/-1 and made both functions

Re: hid_is_collection() sync with NetBSD

2021-01-09 Thread Marcus Glocker
On Sat, 9 Jan 2021 21:51:03 +0100 (CET) Mark Kettenis wrote: > > Date: Sat, 9 Jan 2021 10:38:20 +0100 > > From: Marcus Glocker > > > > I have not much clue about HID, but when we did some testing for the > > new ujoy(4) driver it turned out that the PS4 controller doesn't get > > handled

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Greg Steuck
Thanks for the reviews! Marcus Glocker writes: > On Sat, 9 Jan 2021 22:09:06 +0100 > Marcus Glocker wrote: > If you could fix the switch() indentation in a separate commit (as you > already mentioned in one of your previous e-mails), that would be nice. How's this instead? OK? Tested with

Re: all platforms: isolate hardclock(9) from statclock()

2021-01-09 Thread Mark Kettenis
> Date: Fri, 8 Jan 2021 10:18:27 -0600 > From: Scott Cheloha > > On Thu, Jan 07, 2021 at 08:12:10PM -0600, Scott Cheloha wrote: > > On Thu, Jan 07, 2021 at 09:37:58PM +0100, Mark Kettenis wrote: > > > > Date: Thu, 7 Jan 2021 11:15:41 -0600 > > > > From: Scott Cheloha > > > > > > > > Hi, > > >

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Marcus Glocker
On Sat, 9 Jan 2021 22:09:06 +0100 Marcus Glocker wrote: > On Sat, 09 Jan 2021 13:06:36 -0800 > Greg Steuck wrote: > > > Thanks Todd for reviewing these boring patches! > > > > Todd C. Miller writes: > > > > > Updated diff looks good to me. OK millert@ but it would be good > > > to get

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Marcus Glocker
On Sat, 09 Jan 2021 13:06:36 -0800 Greg Steuck wrote: > Thanks Todd for reviewing these boring patches! > > Todd C. Miller writes: > > > Updated diff looks good to me. OK millert@ but it would be good > > to get feedback from Marcus too. > > Sure thing, I'll wait till tomorrow then? > >

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Greg Steuck
Thanks Todd for reviewing these boring patches! Todd C. Miller writes: > Updated diff looks good to me. OK millert@ but it would be good > to get feedback from Marcus too. Sure thing, I'll wait till tomorrow then? Thanks Greg

Re: hid_is_collection() sync with NetBSD

2021-01-09 Thread Mark Kettenis
> Date: Sat, 9 Jan 2021 10:38:20 +0100 > From: Marcus Glocker > > I have not much clue about HID, but when we did some testing for the > new ujoy(4) driver it turned out that the PS4 controller doesn't get > handled correctly by hid.c:hid_is_collection(). This made me peek in > to the NetBSD

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Todd C . Miller
On Mon, 28 Dec 2020 22:00:55 -0800, Greg Steuck wrote: > Here's an updated version to account from an intervening change since I > posted this first. Updated diff looks good to me. OK millert@ but it would be good to get feedback from Marcus too. - todd

Re: [PATCH] Reduce case duplication in kern_sysctl

2021-01-09 Thread Todd C . Miller
On Sun, 20 Dec 2020 15:52:07 -0800, Greg Steuck wrote: > I tested this by diff'ing sysctl output before/after on amd64. Since > there's a bunch of ifdef'ness I verified RAMDISK still builds. > > I deliberately didn't fix the indentation to keep this diff a pure line > motion (would run over 80

Re: [PATCH]es sysctl_int_bounded goodness

2021-01-09 Thread Todd C . Miller
On Fri, 18 Dec 2020 12:31:54 -0800, Greg Steuck wrote: > I'm scraping the bottom of the barrel with these, so dumped them all > together for ease of review. Will submit piecemeal as reviews happen. > > All verified manually with sysctl -w. Even bothered to find an i386 > machine with watchdog and

Re: all platforms: isolate hardclock(9) from statclock()

2021-01-09 Thread Dale Rahn
The 'magic' here was that MD code could choose to implement statclock (and set stathz appropriately), or MD code could not care about the multiple statclock/hardclock interfaces into the scheduler. Also some clock drivers on a platform could enable split hardclock/statclock where others did not.

Re: New ujoy(4) device for USB gamecontrollers

2021-01-09 Thread Thomas Frohwein
On Sat, Jan 09, 2021 at 10:16:16AM +0100, Marcus Glocker wrote: [...] > So the problem doesn't seem to be in your new ujoy(4) code, but how the > dev/hid/hid.c:hid_is_collection() function tries to cope with the PS4 > controller. > > I'm not much in to HID, but when I sync up the

route sourceaddr: simplify code & get out of ART

2021-01-09 Thread Denis Fondras
This diff place the user-set source address outside of struct art_root and make the code more readable (to me). Based on a concept by mpi@ Index: net/art.h === RCS file: /cvs/src/sys/net/art.h,v retrieving revision 1.20 diff -u -p

XBox One gamecontroller support

2021-01-09 Thread Thomas Frohwein
Hi, This diff adds support for the XBox One gamecontroller in a similar way to what we have for the (older) XBox 360 controller [1][2]. This diff is based on the pertinent code in NetBSD's uhidev.c. Similarities include that the device doesn't provide a report descriptor, so this diff adds one

Re: getopt.3 bugs section

2021-01-09 Thread edgar
On Jan 9, 2021 7:07 AM, Christian Weisgerber wrote: Edgar Pettijohn: > In the BUGS section for the getopt(3) manual it mentions not using > single digits for options. I know spamd uses -4 and -6 there are > probably others. Should they be changed? Or is the manual mistaken? You

Re: slimblade support

2021-01-09 Thread Peter Hessler
On 2021 Jan 09 (Sat) at 07:00:29 -0700 (-0700), Thomas Frohwein wrote: :On Sat, Nov 21, 2020 at 08:10:03AM +0200, Timo Myyrä wrote: :> Hi, :> :> The last attempt at adding Kensington Slimblade trackball support seems :> to have stalled: :> https://marc.info/?l=openbsd-tech=147444999319756=2 :>

Re: getopt.3 bugs section

2021-01-09 Thread Joerg Sonnenberger
On Sat, Jan 09, 2021 at 02:07:32PM +0100, Christian Weisgerber wrote: > Edgar Pettijohn: > > > In the BUGS section for the getopt(3) manual it mentions not using > > single digits for options. I know spamd uses -4 and -6 there are > > probably others. Should they be changed? Or is the manual

Re: slimblade support

2021-01-09 Thread Thomas Frohwein
On Sat, Nov 21, 2020 at 08:10:03AM +0200, Timo Myyrä wrote: > Hi, > > The last attempt at adding Kensington Slimblade trackball support seems > to have stalled: > https://marc.info/?l=openbsd-tech=147444999319756=2 > > I tested the diff and it still seems apply with little fuzz and works > with

Re: getopt.3 bugs section

2021-01-09 Thread Jeremie Courreges-Anglas
On Sat, Jan 09 2021, Christian Weisgerber wrote: > Edgar Pettijohn: > >> In the BUGS section for the getopt(3) manual it mentions not using >> single digits for options. I know spamd uses -4 and -6 there are >> probably others. Should they be changed? Or is the manual mistaken? > > You

Re: getopt.3 bugs section

2021-01-09 Thread Christian Weisgerber
Edgar Pettijohn: > In the BUGS section for the getopt(3) manual it mentions not using > single digits for options. I know spamd uses -4 and -6 there are > probably others. Should they be changed? Or is the manual mistaken? You misunderstand. The manual warns against the use of digits to pass

Re: all platforms: isolate hardclock(9) from statclock()

2021-01-09 Thread Visa Hankala
On Fri, Jan 08, 2021 at 10:18:27AM -0600, Scott Cheloha wrote: > On Thu, Jan 07, 2021 at 08:12:10PM -0600, Scott Cheloha wrote: > > On Thu, Jan 07, 2021 at 09:37:58PM +0100, Mark Kettenis wrote: > > > > Date: Thu, 7 Jan 2021 11:15:41 -0600 > > > > From: Scott Cheloha > > > > > > > > Hi, > > > >

Re: all platforms: isolate hardclock(9) from statclock()

2021-01-09 Thread Kenji Aoyama
Hello, On Sat, 09 Jan 2021 01:18:27 +0900, Scott Cheloha wrote: > > > > Anyway, I don't think I have missed any platforms. However, if > > > > platform experts could weigh in here to verify my changes (and test > > > > them!) I'd really appreciate it. > Also, sorry if I've CC'd you and you're

Re: unwind(8): respect DO flag

2021-01-09 Thread Florian Obser
On Fri, Jan 08, 2021 at 06:37:35PM +0100, Florian Obser wrote: > Rewrite query parsing and answer formating using libunbound provided > functions. > With this we can filter out DNSSEC RRsets if the client did not ask > for them. > We will also be able to send truncated answers to indicate to the >

hid_is_collection() sync with NetBSD

2021-01-09 Thread Marcus Glocker
I have not much clue about HID, but when we did some testing for the new ujoy(4) driver it turned out that the PS4 controller doesn't get handled correctly by hid.c:hid_is_collection(). This made me peek in to the NetBSD code where I could find an update in this function. Syncing it up makes the

Re: cmp -s bugfix

2021-01-09 Thread Theo Buehler
On Sat, Jan 09, 2021 at 08:00:42AM +0100, Otto Moerbeek wrote: > As reported on misc@ > > https://marc.info/?l=openbsd-misc=161016188503894=2 ok tb > > -Otto > > Index: regular.c > === > RCS file:

Re: New ujoy(4) device for USB gamecontrollers

2021-01-09 Thread Marcus Glocker
On Thu, Jan 07, 2021 at 08:20:35PM +0100, Marcus Glocker wrote: > > I have heard from others who tried the diff that the PS4 controller is > > causing problems with the way it attaches. I ordered one to trial-and- > > error this myself at home. Could you share output of lsusb -vv? Thanks > > for

Re: rpki-client check IP and ASnum coverage only on ROAs

2021-01-09 Thread Claudio Jeker
On Thu, Jan 07, 2021 at 04:11:47PM +, Job Snijders wrote: > On Fri, Jan 08, 2021 at 03:43:18PM +0100, Claudio Jeker wrote: > > rpki-client is currently very strict about the ip ranges and as ranges in > > certificates. If a child certificate has a uncovered range in its list it > > is

Re: bgpd simplify update path

2021-01-09 Thread Claudio Jeker
On Fri, Jan 08, 2021 at 09:42:57PM +0100, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.07 19:34:23 +0100: > > When bgpd generates an UPDATE to update or withdraw prefixes it does this > > from rde_generate_updates() and then decends into up_generate_update(). > >