bpf(4) doesn't have to keep track of nonblocking state itself

2021-01-18 Thread David Gwynne
vfs does it for us. ok? Index: bpf.c === RCS file: /cvs/src/sys/net/bpf.c,v retrieving revision 1.202 diff -u -p -r1.202 bpf.c --- bpf.c 17 Jan 2021 02:27:29 - 1.202 +++ bpf.c 19 Jan 2021 00:10:22 - @@ -379,7

Re: snmpd(8): Remove traphandler process attempt 2

2021-01-18 Thread Martijn van Duren
ping On Tue, 2021-01-05 at 22:24 +0100, Martijn van Duren wrote: > With the traphandler code beaten into submission I was able to keep the > traphandler process removal diff more manageable. This diff does a > couple things. > - "listen on" now accepts any combination of read, write and notify. >

tcpdump pflog af and rewritten addresses

2021-01-18 Thread Alexander Bluhm
Hi, tcpdump pflog with addresses rewritten by rdr-to, nat-to, or af-to is broken. 1. Fix address family of the packet in af-to rules: before: 19:26:37.620926 169.254.0.14 > 169.254.0.14: icmp: echo request 19:26:37.620946 bad-ip6-version 4 19:26:37.620963 fc00::23 > fc00::24: icmp6: echo request

Re: -fno-common fixes for slaacd, unwind & rad

2021-01-18 Thread Florian Obser
On Mon, Jan 18, 2021 at 06:19:48PM +0100, Claudio Jeker wrote: > On Mon, Jan 18, 2021 at 05:31:21PM +0100, Florian Obser wrote: > > - move ctl_conns to control.c and control_state to frontend.c, > > control_state needs to be extern because it's shared between > > frontend.c and control.c. (I se

rad(8): get rid of inet_net_{ntop,pton}(3)

2021-01-18 Thread Florian Obser
This is not an api that seems to have caught on (especially the AF_INET6 variant), maybe we can get rid of it entirely. (I also suspect that the AF_INET6 version is broken on FreeBSD and NetBSD as well as mac osx.) OK? diff --git parse.y parse.y index 8f32f11250d..36e5af8be76 100644 --- p

Re: -fno-common fixes for slaacd, unwind & rad

2021-01-18 Thread Claudio Jeker
On Mon, Jan 18, 2021 at 05:31:21PM +0100, Florian Obser wrote: > This is my take on -fno-common fixes. > > slaacd, unwind and rad are based on the same template so the fixes > were similar > > - remove global $daemon_process, just use a const string for > setproctitle > - move ctl_conns to cont

-fno-common fixes for slaacd, unwind & rad

2021-01-18 Thread Florian Obser
This is my take on -fno-common fixes. slaacd, unwind and rad are based on the same template so the fixes were similar - remove global $daemon_process, just use a const string for setproctitle - move ctl_conns to control.c and control_state to frontend.c, control_state needs to be extern becau

pflog remove translation

2021-01-18 Thread Alexander Bluhm
Hi, pflog(4) tries to log the translated packet with rdr-to, nat-to, and af-to applied. Therefore it creates a mbuf chain on the stack with a partial copy. This might have been a good idea for plain IPv4 10 years ago. But now the concept fails miserably due to: - IP options - extension header

Re: ugen(4) and uhidev(4) data toggle problem

2021-01-18 Thread Martin Pieuchot
On 16/01/21(Sat) 16:10, Greg Steuck wrote: > Marcus Glocker writes: > > There are a few threads going on related to problems with ugen(4) and > > uhidev(4) devices on xhci(4). This is related to the issue patrick@ > > already explained; while ehci(4) can save the last data toggle state, > > xhci(

Re: IPPROTO_SCTP

2021-01-18 Thread Vitaliy Makkoveev
ok mvs@ On Mon, Jan 18, 2021 at 12:13:32PM +, Stuart Henderson wrote: > can I add IPPROTO_SCTP to in.h? only one port wants it at the > moment, but I think I've seen others in the past. > > Index: netinet/in.h > === > RCS file: /

Re: IPPROTO_SCTP

2021-01-18 Thread Stuart Henderson
On 2021/01/18 13:31, Landry Breuil wrote: > On Mon, Jan 18, 2021 at 12:13:32PM +, Stuart Henderson wrote: > > can I add IPPROTO_SCTP to in.h? only one port wants it at the > > moment, but I think I've seen others in the past. > > https://searchfox.org/mozilla-central/search?q=ipproto_sctp has

Re: IPPROTO_SCTP

2021-01-18 Thread Landry Breuil
On Mon, Jan 18, 2021 at 12:13:32PM +, Stuart Henderson wrote: > can I add IPPROTO_SCTP to in.h? only one port wants it at the > moment, but I think I've seen others in the past. https://searchfox.org/mozilla-central/search?q=ipproto_sctp has some hits, especially in the chromium-bundled libeve

Re: IPPROTO_SCTP

2021-01-18 Thread Claudio Jeker
On Mon, Jan 18, 2021 at 12:13:32PM +, Stuart Henderson wrote: > can I add IPPROTO_SCTP to in.h? only one port wants it at the > moment, but I think I've seen others in the past. OK claudio@ > Index: netinet/in.h > === > RCS file:

IPPROTO_SCTP

2021-01-18 Thread Stuart Henderson
can I add IPPROTO_SCTP to in.h? only one port wants it at the moment, but I think I've seen others in the past. Index: netinet/in.h === RCS file: /cvs/src/sys/netinet/in.h,v retrieving revision 1.139 diff -u -p -r1.139 in.h --- netine

ospfd -fno-common fixes

2021-01-18 Thread Claudio Jeker
This is my try at cleaning up commons in ospfd. I made one big combined diff but will probably split up a few things into own commits. E.g. the lsupdate.c and lsreq.c ones. I had to cleanup the control.c code a bit since this was a bit of a mess. While in bgpd I was able to remove the global bgpd_