Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
> > Another thought --- is it necessary to call realpath at all? > > Yes, vmd(8) will break if you remove it. > > The caveat here is vmd(8) uses realpath and works with realpath, so the > issue is really vmctl(8). I'm guessing in your test run you ran vmd from > the directory with the disk

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread Dave Voutila
James Cook writes: > On Sun, Mar 14, 2021 at 12:50:52AM +, James Cook wrote: >> > >> >> > >> I believe the correct fix here is to unveil the base image in the >> > >> virtio_qcow2_get_base function in vioqcow2.c and not move around all the >> > >> unveil calls like you're doing. There's no

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
> Another thought --- is it necessary to call realpath at all? > > -- > James This patch seems to fix the problem --- just don't call realpath. Maybe I'm missing something? I briefly tested vmd as well (just quickly booted up an instance that uses a qcow2 disk image with a local path to a base

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
On Sun, Mar 14, 2021 at 12:50:52AM +, James Cook wrote: > > >> > > >> I believe the correct fix here is to unveil the base image in the > > >> virtio_qcow2_get_base function in vioqcow2.c and not move around all the > > >> unveil calls like you're doing. There's no reason to postpone them. > >

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jan Klemkow
On Fri, Mar 12, 2021 at 11:56:00AM +0100, Mark Kettenis wrote: > I believe this is what ark.intel.com calls a "Intel SSD DC P4510 > Series" part. Is that correct? Yes, that is correct. On Fri, Mar 12, 2021 at 10:00:54PM +1100, Jonathan Gray wrote: > On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
> >> > >> I believe the correct fix here is to unveil the base image in the > >> virtio_qcow2_get_base function in vioqcow2.c and not move around all the > >> unveil calls like you're doing. There's no reason to postpone them. > >> > >> I think virtio_qcow2_get_base is only used by vmctl (haven't

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jonathan Gray
On Sat, Mar 13, 2021 at 09:51:30PM +0100, Jan Klemkow wrote: > On Fri, Mar 12, 2021 at 11:56:00AM +0100, Mark Kettenis wrote: > > I believe this is what ark.intel.com calls a "Intel SSD DC P4510 > > Series" part. Is that correct? > > Yes, that is correct. > > On Fri, Mar 12, 2021 at 10:00:54PM

Re: no IPv6 with umb0 on -current

2021-03-13 Thread Thomas Windisch
On Sat, Mar 13, 2021 at 11:34:29AM +, Stuart Henderson wrote: > Nothing changed in umb(4) since 6.8-release. The change last year was > between 6.7 and 6.8 ("IPv6 is no longer on by default. It must be > enabled with "inet6 eui64"). It seems that the issue I had was not related to OpenBSD but

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread Dave Voutila
James Cook writes: >> On Sat, Mar 13, 2021 at 08:34:24AM -0500, Dave Voutila wrote: >> >>> James Cook writes: >>> >>> Currently, "vmctl create -i source.qcow2 dest.qcow" fails when >>> source.qcow2 has a base image, because virtio_qcow2_get_base calls >>> realpath which doesn't interact well

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-13 Thread Claudio Jeker
On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to > me while looking at ifconfig.{c,8} in general. > > > 1. bug: ifconfig(8) forgets to document both `-tunneldomain' and > `-mplslabel' in the first place, diff

ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-13 Thread Klemens Nanni
First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to me while looking at ifconfig.{c,8} in general. 1. bug: ifconfig(8) forgets to document both `-tunneldomain' and `-mplslabel' in the first place, diff below fixes that. 2. bug: mpe(4) supports SIOCDELLABEL it but the driver

Re: LibreSSL: handle EXFLAG_INVALID

2021-03-13 Thread Theo Buehler
On Sat, Mar 13, 2021 at 09:20:32PM +0100, Tobias Heider wrote: > On Wed, Mar 03, 2021 at 05:36:12PM +0100, Theo Buehler wrote: > > On Thu, Feb 25, 2021 at 09:34:30PM +0100, Tobias Heider wrote: > > > Hi, > > > > > > while testing different x509 validator corner cases i found that a bunch > > >

ifconfig: SMALL: move last prototypes out of SMALL

2021-03-13 Thread Klemens Nanni
Looks like those were the last one; the overall unsorted order of prototypes -both under and out of SMALL- as well es the commands makes it hard to spot them systematically, but I'm reluctant to touch all the lines just for this. OK? Index: ifconfig.c

Re: www: fix canonical meta links

2021-03-13 Thread Theo Buehler
On Sat, Mar 13, 2021 at 11:11:00PM +0200, Maxim Vuets wrote: > A minor patch that makes canonical links match their actual page URLs. Committed, thanks

www: fix canonical meta links

2021-03-13 Thread Maxim Vuets
A minor patch that makes canonical links match their actual page URLs. Index: ddb.html === RCS file: /cvs/www/ddb.html,v retrieving revision 1.22 diff -u -r1.22 ddb.html --- ddb.html3 Feb 2021 22:52:03 - 1.22 +++

wg(4): add history section

2021-03-13 Thread Maxim Vuets
Documented in which release wg(4) has been added (as per ). Index: share/man/man4/wg.4 === RCS file: /cvs/src/share/man/man4/wg.4,v retrieving revision 1.9 diff -u -r1.9 wg.4 ---

Re: LibreSSL: handle EXFLAG_INVALID

2021-03-13 Thread Tobias Heider
On Wed, Mar 03, 2021 at 05:36:12PM +0100, Theo Buehler wrote: > On Thu, Feb 25, 2021 at 09:34:30PM +0100, Tobias Heider wrote: > > Hi, > > > > while testing different x509 validator corner cases i found that a bunch of > > errors are currently not handled in libcrypto. > > > > In particular

ifconfig: SMALL: move MPLS related prototypes

2021-03-13 Thread Klemens Nanni
Just for clarity and only prototypes but best to keep tings in order, otherwise it just gets messier over time. OK? Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.437 diff -u -p -r1.437

ifconfig: SMALL: disable rdomain completely

2021-03-13 Thread Klemens Nanni
The commands are ignored under SMALL but their prototypes, the global and therefore dead print logic is still on. OK? Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.437 diff -u -p -r1.437

ifconfig: Remove old deletetunnel

2021-03-13 Thread Klemens Nanni
6.4 is getting old. OK? Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.437 diff -u -p -r1.437 ifconfig.c --- ifconfig.c 12 Mar 2021 17:25:02 - 1.437 +++ ifconfig.c 13 Mar 2021

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
On Sat, Mar 13, 2021 at 08:34:24AM -0500, Dave Voutila wrote: > > James Cook writes: > > > Currently, "vmctl create -i source.qcow2 dest.qcow" fails when > > source.qcow2 has a base image, because virtio_qcow2_get_base calls > > realpath which doesn't interact well with unveil. > > > > The below

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread Dave Voutila
James Cook writes: > Currently, "vmctl create -i source.qcow2 dest.qcow" fails when > source.qcow2 has a base image, because virtio_qcow2_get_base calls > realpath which doesn't interact well with unveil. > > The below patch fixes it by delaying the first call to unveil. Caveat: > I have never

Re: no IPv6 with umb0 on -current

2021-03-13 Thread Stuart Henderson
On 2021/03/12 17:41, Greg Steuck wrote: > Thomas Windisch writes: > > > I can get an IPv6 address with my LTE-Modem via umb with 6.8-release but > > not with -current. I am aware that there was some discussion last year > > on IPv6 support in umb but I'm not really sure what has changed. In > >

Re: xenodm : don't add authorizations for tcp connections by default

2021-03-13 Thread Mark Kettenis
> Date: Mon, 8 Mar 2021 21:09:49 +0100 > From: Matthieu Herrb > > Hi, > > If you look at the output of "xauth list" on you favourite OpenBSD > machine you might get a bit scared, especially if you have an IPv6 > enabled network or if you used to travel and connect to various > networks. > >

Re: More arm64 memory

2021-03-13 Thread Mark Kettenis
> Date: Fri, 12 Mar 2021 00:42:27 +0100 > From: Klemens Nanni > > On Thu, Mar 11, 2021 at 11:36:26PM +0100, Mark Kettenis wrote: > > The UEFI standard indicates that the EfiBootServicesCode and > > EfiBootServicesData memory types are available for general use after > > ExitBootServices() has

Re: allow xlock -dpms* values < 30 and > 0

2021-03-13 Thread Matthieu Herrb
On Thu, Mar 11, 2021 at 03:36:03PM +0100, Alex Raschi wrote: > Ping > > There was an extra space after 'noff', below is the updated patch. > > On Tue, Feb 23, 2021 at 11:11:21AM +0100, Alex Raschi wrote: > > Hi, > > > > I noticed that xlock does not allow values between 30 and 0 for options > >

Re: patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
On Sat, Mar 13, 2021 at 08:40:03AM +, James Cook wrote: > Currently, "vmctl create -i source.qcow2 dest.qcow" fails when > source.qcow2 has a base image, because virtio_qcow2_get_base calls > realpath which doesn't interact well with unveil. > > The below patch fixes it by delaying the first

patch: Fix "vmctl create -i" when input has a qcow2 base image

2021-03-13 Thread James Cook
Currently, "vmctl create -i source.qcow2 dest.qcow" fails when source.qcow2 has a base image, because virtio_qcow2_get_base calls realpath which doesn't interact well with unveil. The below patch fixes it by delaying the first call to unveil. Caveat: I have never worked with unveil or any of this

Re: vmm crash on 6.9-beta

2021-03-13 Thread Otto Moerbeek
On Sat, Mar 13, 2021 at 12:08:52AM -0800, Mike Larkin wrote: > On Wed, Mar 10, 2021 at 08:30:32PM +0100, Mischa wrote: > > On 10 Mar at 18:59, Mike Larkin wrote: > > > On Wed, Mar 10, 2021 at 03:08:21PM +0100, Mischa wrote: > > > > Hi All, > > > > > > > > Currently I am running 6.9-beta on one

Re: vmm crash on 6.9-beta

2021-03-13 Thread Mike Larkin
On Wed, Mar 10, 2021 at 08:30:32PM +0100, Mischa wrote: > On 10 Mar at 18:59, Mike Larkin wrote: > > On Wed, Mar 10, 2021 at 03:08:21PM +0100, Mischa wrote: > > > Hi All, > > > > > > Currently I am running 6.9-beta on one of my hosts to test > > > veb(4)/vport(4). > > > > > > root@server14:~ #