Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread David Gwynne
> On 28 Oct 2021, at 15:35, Jason McIntyre wrote: > > On Thu, Oct 28, 2021 at 01:27:17PM +1000, David Gwynne wrote: >> >>> that strategy does rely on individual driver docs saying upfront that >>> they can be created though, even if using create is not common. i wonder if >>> ifconfig already

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread Jason McIntyre
On Thu, Oct 28, 2021 at 01:27:17PM +1000, David Gwynne wrote: > > > that strategy does rely on individual driver docs saying upfront that > > they can be created though, even if using create is not common. i wonder if > > ifconfig already knows what it can create, and could maybe be more > > helpf

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread David Gwynne
On Wed, Oct 27, 2021 at 02:32:31PM +0100, Jason McIntyre wrote: > On Wed, Oct 27, 2021 at 10:12:35AM +0100, Stuart Henderson wrote: > > On 2021/10/27 17:44, David Gwynne wrote: > > > > > > > benno@ suggested I look at vether(4) to adapt the text related to > > > > bridge(4) but I'm not sure how to

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread David Gwynne
On Wed, Oct 27, 2021 at 10:12:35AM +0100, Stuart Henderson wrote: > On 2021/10/27 17:44, David Gwynne wrote: > > > > > benno@ suggested I look at vether(4) to adapt the text related to > > > bridge(4) but I'm not sure how to rewrite it properly for veb(4). > > > > i get that, but for a different

Re: new site.8: document site*.tgz and /{upgrade,install}.site

2021-10-27 Thread Aaron Poffenberger
Looks good. Nice to see this moving forward. Thanks. On 2021-10-27 21:13 +, Klemens Nanni wrote: > On Mon, Sep 06, 2021 at 02:29:50PM -0500, Aaron Poffenberger wrote: > > Ping. > > > > Will someone commit this? Seems like no one knows about /upgrade.site and it > > fits well with sysupgrade(

Re: snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Todd C . Miller
On Wed, 27 Oct 2021 21:56:16 +0100, Martijn van Duren wrote: > Maybe it's not sufficient, but: > > sysDescr OBJECT-TYPE > SYNTAX DisplayString (SIZE (0..255)) > MAX-ACCESS read-only > STATUS current > DESCRIPTION > "A textual description of the entity. This

new site.8: document site*.tgz and /{upgrade,install}.site

2021-10-27 Thread Klemens Nanni
On Mon, Sep 06, 2021 at 02:29:50PM -0500, Aaron Poffenberger wrote: > Ping. > > Will someone commit this? Seems like no one knows about /upgrade.site and it > fits well with sysupgrade(8). sysupgrade(8) is one potential /upgrade.site user but I disagree about documenting the latter through the fo

Re: snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Martijn van Duren
On Wed, 2021-10-27 at 14:14 -0600, Todd C. Miller wrote: > On Wed, 27 Oct 2021 17:14:28 +0100, Martijn van Duren wrote: > > > Trying to search for memory leaks in my new snmpd code I found some > > harmless, but annoying ones in system from SNMPv2-MIB. > > > > We call uname(3) every time (even if

Re: snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Todd C . Miller
On Wed, 27 Oct 2021 17:14:28 +0100, Martijn van Duren wrote: > Trying to search for memory leaks in my new snmpd code I found some > harmless, but annoying ones in system from SNMPv2-MIB. > > We call uname(3) every time (even if we don't even need info from > that call) and ones set we save it unt

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread Solene Rapenne
On Wed, 27 Oct 2021 14:32:31 +0100 Jason McIntyre : > On Wed, Oct 27, 2021 at 10:12:35AM +0100, Stuart Henderson wrote: > > On 2021/10/27 17:44, David Gwynne wrote: > > > > > > > benno@ suggested I look at vether(4) to adapt the text related to > > > > bridge(4) but I'm not sure how to rewrit

Re: snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Martijn van Duren
On Wed, 2021-10-27 at 17:37 +0100, Stuart Henderson wrote: > On 2021/10/27 17:14, Martijn van Duren wrote: > > Trying to search for memory leaks in my new snmpd code I found some > > harmless, but annoying ones in system from SNMPv2-MIB. > > > > We call uname(3) every time (even if we don't even n

Re: snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Stuart Henderson
On 2021/10/27 17:14, Martijn van Duren wrote: > Trying to search for memory leaks in my new snmpd code I found some > harmless, but annoying ones in system from SNMPv2-MIB. > > We call uname(3) every time (even if we don't even need info from > that call) and ones set we save it until forever. >

snmpd(8): don't allocate memory for system mib

2021-10-27 Thread Martijn van Duren
Trying to search for memory leaks in my new snmpd code I found some harmless, but annoying ones in system from SNMPv2-MIB. We call uname(3) every time (even if we don't even need info from that call) and ones set we save it until forever. Diff below calls uname(3) only a single time and if the va

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread Jason McIntyre
On Wed, Oct 27, 2021 at 10:12:35AM +0100, Stuart Henderson wrote: > On 2021/10/27 17:44, David Gwynne wrote: > > > > > benno@ suggested I look at vether(4) to adapt the text related to > > > bridge(4) but I'm not sure how to rewrite it properly for veb(4). > > > > i get that, but for a different

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread Solene Rapenne
On Wed, 27 Oct 2021 07:28:32 +1000 David Gwynne : > On Tue, Oct 26, 2021 at 09:18:30PM +0200, Solene Rapenne wrote: > > I tried to figure out how to use veb interfaces but the man page > > wasn't obvious in regards to the "vport" thing. It turns out it's > > a kind of interface that can be created

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread Stuart Henderson
On 2021/10/27 17:44, David Gwynne wrote: > > > benno@ suggested I look at vether(4) to adapt the text related to > > bridge(4) but I'm not sure how to rewrite it properly for veb(4). > > i get that, but for a different reason. im too close to veb/vport, so i > think it's all very obvious. > > ma

Re: demystify vport(4) in vport(4) and ifconfig(8)

2021-10-27 Thread David Gwynne
On Wed, Oct 27, 2021 at 08:34:48AM +0200, Solene Rapenne wrote: > On Wed, 27 Oct 2021 07:28:32 +1000 > David Gwynne : > > > On Tue, Oct 26, 2021 at 09:18:30PM +0200, Solene Rapenne wrote: > > > I tried to figure out how to use veb interfaces but the man page > > > wasn't obvious in regards to the