Re: IPsec tdb ref counting

2021-11-22 Thread Hrvoje Popovski
On 21.11.2021. 23:36, Alexander Bluhm wrote: > Updated tdb refcounting diff after merging with mvs@'s commit. Hi, after 24 hours hitting sasyncd setup one box panic r620-2# panic: pool_do_get: tdb free list modified: page 0x812e; item addr 0 x812e2a88; offset 0x28=0xdead410f

Re: netstart: create virtual interfaces upfront when passing specific ones

2021-11-22 Thread Klemens Nanni
On Tue, Nov 16, 2021 at 11:09:40PM +, Klemens Nanni wrote: > Run on boot without arguments, netstart(8) creates all virtual > interfaces *for which hostname.if files exist* before configuring them. > > This prevents ordering problems with bridges and its members, as dlg's > commit message from

Re: extern optind etc already declared in unistd.h

2021-11-22 Thread Theo de Raadt
> This is the usr.sbin part; I am not touching nsd > and other third-party stuff. Well, some of our programs do have -portable variations (not just openssh), and some of them will have to cope.

Re: extern optind etc already declared

2021-11-22 Thread Jan Stary
On Nov 23 00:10:08, h...@stare.cz wrote: > extern optind and friends are already declared > once unistd.h is included, to these can be removed. This is the same for usr.bin except ssh. Jan Index: usr.bin//env/env.c === RCS

ipsec pmtu update

2021-11-22 Thread Alexander Bluhm
Hi, When sending icmp packets for IPsec path MTU discovery, the first icmp packet may be wrong. The mtu 32768 is taken from the loopback interface as the tdb mtu is copied to the route too late. 00:09:31.329586 10.8.26.36.5201 > 10.8.31.33.40322: . 11585:13033(1448) ack 38 win 227 ( DF) 00:09:

extern optind etc already declared in unistd.h

2021-11-22 Thread Jan Stary
extern optind and friends are already declared once unistd.h is included, to these can be removed. This is the usr.sbin part; I am not touching nsd and other third-party stuff. Jan Index: usr.sbin//yppoll/yppoll.c === RCS f

Re: asr(3): strip AD flag in responses

2021-11-22 Thread Jeremie Courreges-Anglas
On Mon, Nov 22 2021, Florian Obser wrote: > On 2021-11-21 21:34 +01, Jeremie Courreges-Anglas wrote: >> On Sat, Nov 20 2021, Florian Obser wrote: >>> On 2021-11-20 17:05 +01, Jeremie Courreges-Anglas wrote: > >>> do you remember why you check for !RES_USE_DNSSEC? >>> I'd like to leave it out. >

Re: Typo in ASN1_NULL_new.3

2021-11-22 Thread Job Snijders
On Mon, Nov 22, 2021 at 07:46:23PM +0100, Matthias Schmidt wrote: > a typo snuck in Thanks

Re: pax(1): Don't open files that will be skipped

2021-11-22 Thread Jeremy Evans
On 10/19 09:34, Jeremy Evans wrote: > Currently, when creating an archive file with pax(1), pax will attempt > to open a file even if the file will be skipped due to an -s > replacement with the empty string. With this change, pax will not > attempt to open files that it knows will be skipped. > >

Typo in ASN1_NULL_new.3

2021-11-22 Thread Matthias Schmidt
Hi, a typo snuck in: diff d1fa7a12c84f12c5694097e95b271ca1621a047e /usr/src blob - dc9f00b0a071ea76a3097d0cb6178c567cf20284 file + lib/libcrypto/man/ASN1_NULL_new.3 --- lib/libcrypto/man/ASN1_NULL_new.3 +++ lib/libcrypto/man/ASN1_NULL_new.3 @@ -39,7 +39,7 @@ This function does not allocate memory

Re: urndis0: IOERROR

2021-11-22 Thread Gerhard Roth
On 11/22/21 10:47, Mikhail wrote: On Mon, Nov 22, 2021 at 12:32:30PM +0300, Mikhail wrote: On Mon, Nov 22, 2021 at 09:31:59AM +0100, Gerhard Roth wrote: On 11/20/21 17:12, Mikhail wrote: Comparing Windows and OpenBSD tcpdumps I noticed some differences: 1) In REMOTE_NDIS_INITIALIZE_MSG (I pat

vmm(4) testers wanted: VMX stability fixes

2021-11-22 Thread Dave Voutila
Greetings tech@, I'm looking for testers of the following diff which addresses spurious VMCS corruption on Intel VMX hosts. If since upgrading to 7.0 or following -current you've had guests die and errors about failure to vmresume, please try this diff. I've had it running with no issues on some h

Unlock accept(2) and accept4(2) syscalls

2021-11-22 Thread Vitaliy Makkoveev
Since the rev1.267 of kern/uipc_socket solock() is used as klist lock for sockets to make socket event filters MP-safe. This means KNOTE(9) within doaccept() doesn't require kernel lock to be held and the accept(2) and accept4(2) syscalls could be unlocked. This makes sense because all our sockets

Re: Rework UNIX sockets locking to be fine grained

2021-11-22 Thread Vitaliy Makkoveev
On Sat, Nov 20, 2021 at 03:12:31AM +0300, Vitaliy Makkoveev wrote: > Updated diff. Re-lock dances were simplified in the unix(4) sockets > layer. > > Reference counters added to unix(4) sockets layer too. This makes > pointer dereference of peer's control block always safe after re-lock. > > The

uhidev: stricter claim multiple report ids

2021-11-22 Thread Anton Lindqvist
Hi, This will prevent a driver attaching on top of uhidev from doing the wrong thing in response to a claim multiple report ids match request. Returning non-zero from such request must imply that at least one report id is claimed. This would have caught some of the uhidev problems fixed at this poi

iwm(4): use per-queue Tx timers

2021-11-22 Thread Stefan Sperling
The iwx(4) driver in -current now contains a workaround for Tx queues which get stuck while other Tx queues keep working. This condition now triggers a device timeout on iwx(4) rather than leaving interface in a semi-operational state. Here is a corresponding patch for iwm(4). The Linux driver app

Re: asr(3): strip AD flag in responses

2021-11-22 Thread Florian Obser
On 2021-11-21 22:21 +01, Jeremie Courreges-Anglas wrote: > On Sun, Nov 21 2021, Jeremie Courreges-Anglas wrote: >> On Sat, Nov 20 2021, Florian Obser wrote: > > [...] > Index: lib/libc/asr/res_mkquery.c === RCS file:

Re: asr(3): strip AD flag in responses

2021-11-22 Thread Florian Obser
On 2021-11-21 21:34 +01, Jeremie Courreges-Anglas wrote: > On Sat, Nov 20 2021, Florian Obser wrote: >> On 2021-11-20 17:05 +01, Jeremie Courreges-Anglas wrote: >> do you remember why you check for !RES_USE_DNSSEC? >> I'd like to leave it out. > > First, here's my understanding of RES_USE_DNSSE

Re: urndis0: IOERROR

2021-11-22 Thread Mikhail
On Mon, Nov 22, 2021 at 12:32:30PM +0300, Mikhail wrote: > On Mon, Nov 22, 2021 at 09:31:59AM +0100, Gerhard Roth wrote: > > On 11/20/21 17:12, Mikhail wrote: > > > Comparing Windows and OpenBSD tcpdumps I noticed some differences: > > > > > > 1) In REMOTE_NDIS_INITIALIZE_MSG (I patched the kernel

Re: urndis0: IOERROR

2021-11-22 Thread Gerhard Roth
On 11/20/21 17:12, Mikhail wrote: Comparing Windows and OpenBSD tcpdumps I noticed some differences: 1) In REMOTE_NDIS_INITIALIZE_MSG (I patched the kernel to send it before getting MAC address and with proper minor version) bInterfaceClass on OpenBSD is set to Unknown (0x), on Windows it's

Re: acme-client: another trivial accessor conversion

2021-11-22 Thread Claudio Jeker
On Mon, Nov 22, 2021 at 12:18:37AM +0100, Theo Buehler wrote: > bio->num_write aka BIO_number_written(bio). Straightforward. The main > reason I'm asking is that keeping the two else results in overlong lines > and awkward line wrapping. So I decided to drop them hoping that's > acceptable. Otherwi