Re: Add CT methods to standard_exts, fix timestamp printing

2021-11-23 Thread Bob Beck
ok beck@ > On Nov 23, 2021, at 21:14, Theo Buehler wrote: > > Two small diffs now that beck has linked the certificate transparency > code to the build. > > The diff for ext_dat.h links the CT methods to the standard extensions. > This replaces the gibberish from the CT extensions which are no

Re: dhcpleased - set ciaddr per RFC

2021-11-23 Thread Joel Knight
On Fri, Nov 19, 2021 at 1:01 PM Joel Knight wrote: > > One thing that got missed in the refactor was that the requested-ip > option should not be set in a RENEWING or BINDING state (or in other > words, when ciaddr is set). This chunk on top of your diff also works > as expected (successful unicas

Add CT methods to standard_exts, fix timestamp printing

2021-11-23 Thread Theo Buehler
Two small diffs now that beck has linked the certificate transparency code to the build. The diff for ext_dat.h links the CT methods to the standard extensions. This replaces the gibberish from the CT extensions which are now present in most certs with something readable. Try $ openssl s_client -

Re: vport: set UP on ip assign

2021-11-23 Thread Theo de Raadt
Klemens Nanni wrote: > Then, finally, interfaces only go UP if users do `ifconfig ... up' > or hostname.* contain the word "up". Otherwise they stay DOWN. > > This would be a dead simple thing to reason. Yeah it is so reasonable in fact why don't we add a chunk to the top of netstart to force

Re: vport: set UP on ip assign

2021-11-23 Thread Theo de Raadt
And here is the root of the argument -- where it is all going towards. > If we decide to handle this in netstart alone, shouldn't all interfaces > behave like vport(4) and not mess with their state unless explicitly > requested to do so? the implication here, is let's go change all the drivers an

Re: vport: set UP on ip assign

2021-11-23 Thread Klemens Nanni
On Wed, Nov 24, 2021 at 02:30:08AM +0100, Klemens Nanni wrote: > On Tue, Nov 16, 2021 at 09:22:26AM +1000, David Gwynne wrote: > > On Mon, Nov 15, 2021 at 02:31:42PM +, Klemens Nanni wrote: > > > On Mon, Nov 15, 2021 at 01:37:49PM +, Stuart Henderson wrote: > > > > On 2021/11/15 12:27, Klem

Re: vport: set UP on ip assign

2021-11-23 Thread Klemens Nanni
On Tue, Nov 16, 2021 at 09:22:26AM +1000, David Gwynne wrote: > On Mon, Nov 15, 2021 at 02:31:42PM +, Klemens Nanni wrote: > > On Mon, Nov 15, 2021 at 01:37:49PM +, Stuart Henderson wrote: > > > On 2021/11/15 12:27, Klemens Nanni wrote: > > > > On Sun, Nov 14, 2021 at 07:04:42PM -0700, Theo

Re: IPsec tdb ref counting

2021-11-23 Thread Vitaliy Makkoveev
> On 23 Nov 2021, at 18:16, Tobias Heider wrote: > > On Tue, Nov 23, 2021 at 02:18:26PM +0100, Alexander Bluhm wrote: >> On Tue, Nov 23, 2021 at 06:54:59AM +0100, Hrvoje Popovski wrote: >>> after 24 hours hitting sasyncd setup one box panic >> >> Thanks for testing. >> >> I have reduced my i

Re: asr(3): strip AD flag in responses

2021-11-23 Thread Theo de Raadt
ksh/ksh.1:Note that ksh/ksh.1:Note that any unquoted space before and after a pattern is ksh/ksh.1:Note that redirections specified after a function definition are ksh/ksh.1:Note that changing the ksh/ksh.1:Note that if the ksh/ksh.1:Note that ksh/ksh.1:Note that both the parameter name and the ksh

Re: asr(3): strip AD flag in responses

2021-11-23 Thread Theo de Raadt
You mean to say Note that, you can drop "Note that". I have no idea where this construct came from. Maybe it should be replaced with "PAY ATTENTION NOW". It is just rude. Imagine if the cat manual page went like this: DESCRIPTION Note that the cat utility reads files sequentially, writin

Re: asr(3): strip AD flag in responses

2021-11-23 Thread Florian Obser
You could drop "Note that". Either way, OK florian On 23 November 2021 13:39:51 CET, Jeremie Courreges-Anglas wrote: >On Mon, Nov 22 2021, Florian Obser wrote: >> On 2021-11-21 22:21 +01, Jeremie Courreges-Anglas wrote: >>> On Sun, Nov 21 2021, Jeremie Courreges-Anglas wrote: On Sat, Nov

Re: IPsec tdb ref counting

2021-11-23 Thread Hrvoje Popovski
On 23.11.2021. 14:18, Alexander Bluhm wrote: > On Tue, Nov 23, 2021 at 06:54:59AM +0100, Hrvoje Popovski wrote: >> after 24 hours hitting sasyncd setup one box panic > > Thanks for testing. > > I have reduced my iked lifetime to about 10 seconds and got the > same panic on my new 8 core test mach

Re: IPsec tdb ref counting

2021-11-23 Thread Tobias Heider
On Tue, Nov 23, 2021 at 02:18:26PM +0100, Alexander Bluhm wrote: > On Tue, Nov 23, 2021 at 06:54:59AM +0100, Hrvoje Popovski wrote: > > after 24 hours hitting sasyncd setup one box panic > > Thanks for testing. > > I have reduced my iked lifetime to about 10 seconds and got the > same panic on my

Re: IPsec tdb ref counting

2021-11-23 Thread Alexander Bluhm
On Tue, Nov 23, 2021 at 06:54:59AM +0100, Hrvoje Popovski wrote: > after 24 hours hitting sasyncd setup one box panic Thanks for testing. I have reduced my iked lifetime to about 10 seconds and got the same panic on my new 8 core test machine. ddb{2}> trace db_enter() at db_enter+0x10 panic(

Re: extern optind etc already declared in unistd.h

2021-11-23 Thread Todd C . Miller
On Mon, 22 Nov 2021 17:53:48 -0700, "Theo de Raadt" wrote: > > This is the usr.sbin part; I am not touching nsd > > and other third-party stuff. > > Well, some of our programs do have -portable variations (not just openssh), > and some of them will have to cope. I don't think we really care about

Re: asr(3): strip AD flag in responses

2021-11-23 Thread Jeremie Courreges-Anglas
On Mon, Nov 22 2021, Florian Obser wrote: > On 2021-11-21 22:21 +01, Jeremie Courreges-Anglas wrote: >> On Sun, Nov 21 2021, Jeremie Courreges-Anglas wrote: >>> On Sat, Nov 20 2021, Florian Obser wrote: >> >> [...] >> > Index: lib/libc/asr/res_mkquery.c > ===

Re: IPsec tdb ref counting

2021-11-23 Thread Vitaliy Makkoveev
On Tue, Nov 23, 2021 at 06:54:59AM +0100, Hrvoje Popovski wrote: > On 21.11.2021. 23:36, Alexander Bluhm wrote: > > Updated tdb refcounting diff after merging with mvs@'s commit. > > Hi, > > after 24 hours hitting sasyncd setup one box panic > > r620-2# panic: pool_do_get: tdb free list modified