Re: unlock mmap(2) for anonymous mappings

2022-01-24 Thread Klemens Nanni
On Mon, Jan 24, 2022 at 12:08:33PM -0300, Martin Pieuchot wrote: > On 24/01/22(Mon) 12:06, Klemens Nanni wrote: > > On Sun, Jan 16, 2022 at 09:22:50AM -0300, Martin Pieuchot wrote: > > > IMHO this approach of let's try if it works now and revert if it isn't > > > doesn't help us make progress. I'd

Re: Properly check if ACPI devices are enabled

2022-01-24 Thread Anton Lindqvist
On Mon, Jan 24, 2022 at 08:40:36PM +0100, Mark Kettenis wrote: > > Date: Mon, 24 Jan 2022 20:19:46 +0100 > > From: Anton Lindqvist > > > > On Mon, Jan 24, 2022 at 05:31:49PM +0100, Mark Kettenis wrote: > > > Currently we attach ACPI devices that are present in a machine. > > > However, in some ca

Re: Capture a repeated pattern into sysctl_securelevel_int

2022-01-24 Thread Alexander Bluhm
On Sun, Jan 23, 2022 at 10:29:22PM -0800, Greg Steuck wrote: > As I was staring a bit more at sysctl related code this pattern caught > my attention. Looks like a few lines can disappear and hopefully code > expressivity goes up. > > Anybody like this? OK bluhm@ > >From 3b52f9ad743fe9b5931607747

kubsan em ix ixgbe

2022-01-24 Thread Alexander Bluhm
Hi There are more undefined behaviour reports in our network drivers kubsan: dev/pci/if_em_hw.c:7625:38: shift: left shift of 65535 by 16 places cannot be represented in type 'int' kubsan: dev/pci/if_ix.c:3403:18: shift: left shift of 255 by 24 places cannot be represented in type 'int' kubsan:

Re: Properly check if ACPI devices are enabled

2022-01-24 Thread Philip Guenther
On Mon, Jan 24, 2022 at 11:41 AM Mark Kettenis wrote: > > Date: Mon, 24 Jan 2022 20:19:46 +0100 > > From: Anton Lindqvist > > > > On Mon, Jan 24, 2022 at 05:31:49PM +0100, Mark Kettenis wrote: > > > Currently we attach ACPI devices that are present in a machine. > > > However, in some cases ACPI

Re: Properly check if ACPI devices are enabled

2022-01-24 Thread Mark Kettenis
> Date: Mon, 24 Jan 2022 20:19:46 +0100 > From: Anton Lindqvist > > On Mon, Jan 24, 2022 at 05:31:49PM +0100, Mark Kettenis wrote: > > Currently we attach ACPI devices that are present in a machine. > > However, in some cases ACPI devices can be present, but not enabled. > > Attaching a device dr

Re: Properly check if ACPI devices are enabled

2022-01-24 Thread Anton Lindqvist
On Mon, Jan 24, 2022 at 05:31:49PM +0100, Mark Kettenis wrote: > Currently we attach ACPI devices that are present in a machine. > However, in some cases ACPI devices can be present, but not enabled. > Attaching a device driver to devices that are not enabled is not a > good idea since reading and

Re: IPv6 privacy extensions

2022-01-24 Thread Florian Obser
On 2022-01-24 00:17 +01, Marcel Logen <33327110-0...@ybtra.de> wrote: > Hello, > > since ca. April 2021 I see, that (after boot) no new IPv6 > temporary adresses are created after 900 seconds (15 min). > > The pltime decreases to 900 and then gets a value of 1800. > No new temporary address is

Re: rpki-client MFT file and hash check change

2022-01-24 Thread Job Snijders
On Mon, Jan 24, 2022 at 06:50:51PM +0100, Claudio Jeker wrote: > > Requiring any content to be present (and the file's calculated digest to > > match with the hash listed on the Manifest) might pose a problem with > > our --exclude/--include rsync filter: files of unknown type are not > > downloade

Re: rpki-client MFT file and hash check change

2022-01-24 Thread Claudio Jeker
On Mon, Jan 24, 2022 at 05:20:49PM +, Job Snijders wrote: > On Mon, Jan 24, 2022 at 04:33:10PM +0100, Claudio Jeker wrote: > > This diff does a few things regarding MFT file and hash sequences: > > > > - it validates the filename early on so that if considered valid it can > > be printed by

Re: rpki-client MFT file and hash check change

2022-01-24 Thread Job Snijders
On Mon, Jan 24, 2022 at 04:33:10PM +0100, Claudio Jeker wrote: > This diff does a few things regarding MFT file and hash sequences: > > - it validates the filename early on so that if considered valid it can > be printed by printf(%s) without problems. > - it assigns the file type (based on the

Properly check if ACPI devices are enabled

2022-01-24 Thread Mark Kettenis
Currently we attach ACPI devices that are present in a machine. However, in some cases ACPI devices can be present, but not enabled. Attaching a device driver to devices that are not enabled is not a good idea since reading and writing from/to its registers will fail and the driver will malfunction

Re: rpki-client MFT file and hash check change

2022-01-24 Thread Theo Buehler
On Mon, Jan 24, 2022 at 04:33:10PM +0100, Claudio Jeker wrote: > This diff does a few things regarding MFT file and hash sequences: > > - it validates the filename early on so that if considered valid it can > be printed by printf(%s) without problems. > - it assigns the file type (based on the

Re: syzcaller pf unhandled af

2022-01-24 Thread Alexandr Nedvedicky
Hello, I'm fine with the fix. I have just small comment/nit. leaving it up to you to fix it ore leave it. > - > if (newrule->rt && !newrule->direction) { > pf_rule_free(newrule); > error = EINVAL; > @@ -3216,6 +319

rpki-client MFT file and hash check change

2022-01-24 Thread Claudio Jeker
This diff does a few things regarding MFT file and hash sequences: - it validates the filename early on so that if considered valid it can be printed by printf(%s) without problems. - it assigns the file type (based on the file extension) early on and no longer uses this information when compa

Re: unlock mmap(2) for anonymous mappings

2022-01-24 Thread Martin Pieuchot
On 24/01/22(Mon) 12:06, Klemens Nanni wrote: > On Sun, Jan 16, 2022 at 09:22:50AM -0300, Martin Pieuchot wrote: > > IMHO this approach of let's try if it works now and revert if it isn't > > doesn't help us make progress. I'd be more confident seeing diffs that > > assert for the right lock in the

syzcaller pf unhandled af

2022-01-24 Thread Alexander Bluhm
Hi, https://syzkaller.appspot.com/bug?id=a6475751c2856d5ea5586f7120d14db1e00bf253 I think these crashes are caused by an af-to rule that has no translation address family naf. Preventing such a rule in the kernel might help. ok? bluhm Index: net/pf_ioctl.c

cad(4): Disable extra queues

2022-01-24 Thread Visa Hankala
The GEMs on the PolarFire SoC implement priority queueing. Currently, cad(4) does not initialize the extra queues, which causes a DMA error on the first transmission. When the driver requests transmission, the hardware begins checking the transmit queues from queue 3 down to queue 0. The base addre

Re: unlock mmap(2) for anonymous mappings

2022-01-24 Thread Klemens Nanni
On Sun, Jan 16, 2022 at 09:22:50AM -0300, Martin Pieuchot wrote: > IMHO this approach of let's try if it works now and revert if it isn't > doesn't help us make progress. I'd be more confident seeing diffs that > assert for the right lock in the functions called by uvm_mapanon() and > documentatio

Re: dt: make vmm tracepoints amd64 only

2022-01-24 Thread Klemens Nanni
On Mon, Jan 17, 2022 at 04:51:37PM -0800, Philip Guenther wrote: > On Mon, Jan 17, 2022 at 5:02 AM Klemens Nanni wrote: > > > These don't hurt on !VMM architectures but I was still surprised to see > > them on e.g. sparc64: > > > > # arch -s ; btrace -l | grep vmm > > sparc64 > >