Re: libcrypto: creating certs with nameConstraints

2022-03-02 Thread Theo Buehler
On Thu, Mar 03, 2022 at 11:06:45AM +1000, Alex Wilson wrote: > On 2/3/22 18:21, Theo Buehler wrote: > > > > At this point it would probably make more sense to use two switches, one > > for is_nc and one for !is_nc, and perhaps factor them into two > > helper functions. > > I stared at this code

ARM: Want add support for two STMicroelectronis board in near future

2022-03-02 Thread Johannes (krjdev) Krottmayer
Hi, I want add two ARM-based boards to the supported boards to OpenBSD in the near future, which I own. STMicroelectronis STM32MP157F-DK2 board: SoC: STM32MP157F (Dual Core Cortex-A7 with Cortex-M4) Fully (expect the Vivante GPU) documented. U-Boot support: yes STMicroelectronis

Re: httpd: simplify .gz handling a bit

2022-03-02 Thread Todd C . Miller
On Wed, 02 Mar 2022 19:26:46 +0100, Theo Buehler wrote: > I think it's easier to use a single snprintf call. Also drop a few > unnecessary parentheses. Seems like an improvement. OK millert@ - todd

httpd: simplify .gz handling a bit

2022-03-02 Thread Theo Buehler
I think it's easier to use a single snprintf call. Also drop a few unnecessary parentheses. Index: server_file.c === RCS file: /cvs/src/usr.sbin/httpd/server_file.c,v retrieving revision 1.71 diff -u -p -r1.71 server_file.c ---

in pcb table mutex

2022-03-02 Thread Alexander Bluhm
Hi, pf_socket_lookup() calls in_pcbhashlookup() in the PCB layer. So to run pf in parallel we must make parts of the stack MP safe. Protect the list and hashes in the PCB tables with a mutex. Note that the protocol notify functions may call pf via tcp_output(). As the pf lock is a sleeping

Re: bgpd adjust prefix_adjout_update

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 04:40:09PM +0100, Claudio Jeker wrote: > This moves the count adjustments into prefix_adjout_update() in a similar > way that was just done for prefix_adjout_withdraw(). > Having the counts closer to the actual places where things are > added/removed makes the code a bit

bgpd adjust prefix_adjout_update

2022-03-02 Thread Claudio Jeker
This moves the count adjustments into prefix_adjout_update() in a similar way that was just done for prefix_adjout_withdraw(). Having the counts closer to the actual places where things are added/removed makes the code a bit easier to grasp. The if cascade in the prefix_adjout_get != NULL case can

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 02:46:55PM +0100, Claudio Jeker wrote: > I forgot to mention that. So during reconfigure rde_up_flush_upcall() > walks over the full adj_rib_out tree. This includes pending withdraws and > we need to properly handle them. I decided it is best to revert this back > to the

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
On Wed, Mar 02, 2022 at 01:25:42PM +0100, Theo Buehler wrote: > On Wed, Mar 02, 2022 at 01:07:09PM +0100, Claudio Jeker wrote: > > On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > > > This diff changes prefix_adjout_withdraw() to take a prefix pointer > > > as argument. So instead

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 01:07:09PM +0100, Claudio Jeker wrote: > On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > > This diff changes prefix_adjout_withdraw() to take a prefix pointer > > as argument. So instead of doing the lookup in the withdraw function the > > caller may need

Re: bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
On Wed, Mar 02, 2022 at 01:03:04PM +0100, Claudio Jeker wrote: > This diff changes prefix_adjout_withdraw() to take a prefix pointer > as argument. So instead of doing the lookup in the withdraw function the > caller may need to do it. > > With this one call to up_generate_updates() can be

bgpd refactor prefix_adjout_withdraw

2022-03-02 Thread Claudio Jeker
This diff changes prefix_adjout_withdraw() to take a prefix pointer as argument. So instead of doing the lookup in the withdraw function the caller may need to do it. With this one call to up_generate_updates() can be replaced with a direct call to prefix_adjout_withdraw(). rde_up_flush_upcall()

Re: Fix deadlock in cad_down()

2022-03-02 Thread Visa Hankala
On Wed, Mar 02, 2022 at 12:11:30PM +0100, Mark Kettenis wrote: > > Date: Wed, 2 Mar 2022 10:53:54 + > > From: Visa Hankala > > > > Holding NET_LOCK() while invoking a taskq barrier can result in > > a deadlock because the lock can prevent the taskq from making progress. > > Avoid this

Re: chrome crash on latest snapshot with intel driver

2022-03-02 Thread Stuart Henderson
On 2022/03/02 13:01, Mikhail wrote: > On latest snapshot I see Xorg crash when trying to launch chrome browser > (firefox works fine), I can reproduce it with 'intel' driver, > 'modesetting' crashed for me too, but it took about two weeks of uptime > and wasn't related to chrome launch (no logs

Re: Fix deadlock in cad_down()

2022-03-02 Thread Mark Kettenis
> Date: Wed, 2 Mar 2022 10:53:54 + > From: Visa Hankala > > Holding NET_LOCK() while invoking a taskq barrier can result in > a deadlock because the lock can prevent the taskq from making progress. > Avoid this problem in cad_down() by serializing the driver's ioctl > handler with an rwlock

Fix deadlock in cad_down()

2022-03-02 Thread Visa Hankala
Holding NET_LOCK() while invoking a taskq barrier can result in a deadlock because the lock can prevent the taskq from making progress. Avoid this problem in cad_down() by serializing the driver's ioctl handler with an rwlock so that NET_LOCK() can be released temporarily. The patch additionally

chrome crash on latest snapshot with intel driver

2022-03-02 Thread Mikhail
On latest snapshot I see Xorg crash when trying to launch chrome browser (firefox works fine), I can reproduce it with 'intel' driver, 'modesetting' crashed for me too, but it took about two weeks of uptime and wasn't related to chrome launch (no logs for 'modesetting' crash unfortunately, but it

Re: [PATCH] [src] usr.bin/make/PSD.doc/tutorial.ms - fix order: makefile -> Makefile

2022-03-02 Thread Jason McIntyre
On Wed, Feb 23, 2022 at 01:57:22PM +, Jason McIntyre wrote: > On Wed, Feb 23, 2022 at 11:09:44AM +, Raf Czlonka wrote: > > Hello, > > > > Pretty straightforward, 'makefile' comes before 'Makefile'. > > > > Regards, > > > > Raf > > > > yep, ok. > jmc > sorry for the mix up! committed

Re: [PATCH] httpd initialize kv structs on stack

2022-03-02 Thread Claudio Jeker
On Wed, Mar 02, 2022 at 10:15:07AM +0100, Florian Obser wrote: > On 2022-03-01 10:22 -08, j...@bitminer.ca wrote: > > Looking at the gz option, I noticed some kv structs allocated on > > stack but not fully initialized. > > Nice catch. > > > > > This patches initializes the kv struct to avoid

Re: [PATCH] httpd initialize kv structs on stack

2022-03-02 Thread Florian Obser
On 2022-03-01 10:22 -08, j...@bitminer.ca wrote: > Looking at the gz option, I noticed some kv structs allocated on > stack but not fully initialized. Nice catch. > > This patches initializes the kv struct to avoid randomly getting > KV_GLAG_GLOBBING in kv_find depending on stack contents,

Re: [PATCH] [src] usr.bin/make/PSD.doc/tutorial.ms - fix order: makefile -> Makefile

2022-03-02 Thread Raf Czlonka
Anyone? On Wed, Feb 23, 2022 at 01:57:22PM GMT, Jason McIntyre wrote: > On Wed, Feb 23, 2022 at 11:09:44AM +, Raf Czlonka wrote: > > Hello, > > > > Pretty straightforward, 'makefile' comes before 'Makefile'. > > > > Regards, > > > > Raf > > > > yep, ok. > jmc > > > Index:

Re: [External] : in6_pcbnotify void

2022-03-02 Thread Alexandr Nedvedicky
On Wed, Mar 02, 2022 at 12:47:11AM +0100, Alexander Bluhm wrote: > Hi, > > The return value of in6_pcbnotify() is never used. Make it a void > function. > > ok? > given we always return 0, which is nothing, then it makes sense to return void, (which is also nothing). ok sashan2

mg and trailing whitespaces

2022-03-02 Thread Omar Polo
Hello tech, mg(1) has this tendency to leave a lot of trailing whitespaces around in auto-indent-mode and c-mode which I find annoying. Yes, there's delete-trailing-space but it works only on the current line (and not the whole buffer as in emacs) and one has to manually call it anyway. Emacs,

Re: libcrypto: creating certs with nameConstraints

2022-03-02 Thread Theo Buehler
On Wed, Mar 02, 2022 at 04:38:46PM +1000, Alex Wilson wrote: > I've been trying to create new CA certificates with nameConstraints on them > using the libcrypto in -current, and it doesn't work. > > Example snippet from config: > > [name_constraints] > permitted;DNS.0 = .foo.com > > This blows