Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 9.6.2022. 19:25, Hrvoje Popovski wrote: > On 9.6.2022. 19:11, Jan Klemkow wrote: >> On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: >>> On 8.6.2022. 22:01, Hrvoje Popovski wrote: On 8.6.2022. 15:04, Jan Klemkow wrote: > Could you show me, how your setup and your

Re: unlock pf_purge

2022-06-09 Thread Chris Cappuccio
David Gwynne [da...@gwynne.id.au] wrote: > the main change here is to move pf_purge out from under the kernel lock. > > another part of the change is to limit the amount of work the state > purging does to avoid hogging a cpu too much, and to also avoid holding > NET_LOCK for too long. > I've

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 9.6.2022. 19:11, Jan Klemkow wrote: > On Thu, Jun 09, 2022 at 08:25:22AM +0200, Hrvoje Popovski wrote: >> On 8.6.2022. 22:01, Hrvoje Popovski wrote: >>> On 8.6.2022. 15:04, Jan Klemkow wrote: Could you show me, how your setup and your configuration looks like? >>> Yes, of course .. >>> >>>

Re: bgpd fix for undefined macros

2022-06-09 Thread Theo Buehler
On Thu, Jun 09, 2022 at 07:07:12PM +0200, Claudio Jeker wrote: > Fix a crash because of a NULL pointer dereference in parse.y ok > > Before: > /etc/bgpd.conf:85: macro 'UNDEFINED' not defined > Segmentation fault > > After: > /etc/bgpd.conf:85: macro 'UNDEFINED' not defined >

bgpd fix for undefined macros

2022-06-09 Thread Claudio Jeker
Fix a crash because of a NULL pointer dereference in parse.y Before: /etc/bgpd.conf:85: macro 'UNDEFINED' not defined Segmentation fault After: /etc/bgpd.conf:85: macro 'UNDEFINED' not defined /etc/bgpd.conf:85: syntax error -- :wq Claudio Index: parse.y

Re: more bgpd kroute cleanup

2022-06-09 Thread Theo Buehler
On Thu, Jun 09, 2022 at 04:53:46PM +0200, Claudio Jeker wrote: > Noticed that similar to fib_prio the rdomain id is passed around to some > places where it really makes no sense. > > First of all kr_nexthop_add() and kr_nexthop_delete() can be simplified. > The imsg peerid is always 0. This was

more bgpd kroute cleanup

2022-06-09 Thread Claudio Jeker
Noticed that similar to fib_prio the rdomain id is passed around to some places where it really makes no sense. First of all kr_nexthop_add() and kr_nexthop_delete() can be simplified. The imsg peerid is always 0. This was added in the beginning of L3VPN support without realizing that all bgp

Re: bgpd: refactor kroute code a fair bit

2022-06-09 Thread Theo Buehler
> I did this change for most calloc calls in kroute.c. So now that is > consistent. Much better. > I think the name2id code should not set an error for the empty string. I > think a lot of the code depends on the mapping of "" to 0. > The ERANGE error should be transformed to a fatalx() so that

Re: bgpd: refactor kroute code a fair bit

2022-06-09 Thread Claudio Jeker
On Thu, Jun 09, 2022 at 02:54:28PM +0200, Theo Buehler wrote: > On Wed, Jun 08, 2022 at 10:47:48PM +0200, Claudio Jeker wrote: > > and here is the updated diff I forgot to include > > I think I've now done what I reasonably can do to review this. I buy > that this mostly preserves behavior and

Re: LDIF case sensitivity, login_ldap

2022-06-09 Thread Stuart Henderson
[moved from misc to tech] On 2022/06/09 13:26, Martijn van Duren wrote: > On Thu, 2022-06-09 at 07:48 +, Stuart Henderson wrote: > > On 2022-06-09, David Diggles wrote: > > > I've just got ldap login working on OpenBSD/7.1 with accounts stored > > > locally in ldapd and using ypldap. > > >

Re: bgpd: refactor kroute code a fair bit

2022-06-09 Thread Theo Buehler
On Wed, Jun 08, 2022 at 10:47:48PM +0200, Claudio Jeker wrote: > and here is the updated diff I forgot to include I think I've now done what I reasonably can do to review this. I buy that this mostly preserves behavior and I'm convinced that it is a step in the right direction, especially given

Re: [PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Florian Obser
On 2022-06-09 01:36 -07, Alfred Morgan wrote: > I think this got missed on misc@ when I posted on 5/24. I'm now > reposting here in tech@ with the [PATCH] subject tag. > > Index: usr.sbin/slowcgi/slowcgi.8 > === > RCS file:

Re: [patch] 802.11 printing akm and cipher suite lists in tcpdump

2022-06-09 Thread Mikhail
Friendly weekly ping On Thu, Jun 02, 2022 at 11:43:30PM +0300, Mikhail wrote: > Recently I bought a router with WPA3 support and decided to investigate > wireless dump with WPA3 config, during the process I've found a small > bug in tcpdump - it doesn't print all akms, also the printing logic is

Re: bgpd: refactor kroute code a fair bit

2022-06-09 Thread Claudio Jeker
On Thu, Jun 09, 2022 at 09:47:31AM +0100, Stuart Henderson wrote: > On 2022/06/08 22:47, Claudio Jeker wrote: > > and here is the updated diff I forgot to include > > Not sure if it's expected / not, but I lose interface information > with this: > > > $ diff -wu old new > --- old Thu Jun

Re: [PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Stuart Henderson
On 2022/06/09 01:36, Alfred Morgan wrote: > I think this got missed on misc@ when I posted on 5/24. I'm now Diffs are definitely likely to get missed on misc@ > reposting here in tech@ with the [PATCH] subject tag. This diff is mangled, tabs have been converted to spaces and it doesn't apply

Re: bgpd: refactor kroute code a fair bit

2022-06-09 Thread Stuart Henderson
On 2022/06/08 22:47, Claudio Jeker wrote: > and here is the updated diff I forgot to include Not sure if it's expected / not, but I lose interface information with this: $ diff -wu old new --- old Thu Jun 9 09:44:37 2022 +++ new Thu Jun 9 09:44:44 2022 @@ -2,18 +2,19 @@ Flags: * = nexthop

[PATCH] adds -t timeout to slowcgi

2022-06-09 Thread Alfred Morgan
I think this got missed on misc@ when I posted on 5/24. I'm now reposting here in tech@ with the [PATCH] subject tag. Index: usr.sbin/slowcgi/slowcgi.8 === RCS file: /cvs/src/usr.sbin/slowcgi/slowcgi.8,v retrieving revision 1.16 diff

Re: ix(4): Add support for TCP Large Receive Offloading

2022-06-09 Thread Hrvoje Popovski
On 8.6.2022. 22:01, Hrvoje Popovski wrote: > On 8.6.2022. 15:04, Jan Klemkow wrote: >> Could you show me, how your setup and your configuration looks like? > Yes, of course .. > > All my lab boxes are connected to switch (no flow-control). In this > setup ix0 and ix1 are in aggr and vlans 700 and