Re: ssh-add(1): fix NULL in fprintf

2022-06-17 Thread Darren Tucker
On Fri, 17 Jun 2022 at 04:49, Martin Vahlensieck wrote: > ping, diff attached Applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Edd Barrett
On Fri, Jun 17, 2022 at 12:46:49PM -0700, Mike Larkin wrote: > Sorry, out of ideas. No worries. Thanks for all of the back and forth :) -- Best Regards Edd Barrett https://www.theunixzoo.co.uk

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Mike Larkin
On Fri, Jun 17, 2022 at 08:32:29PM +0100, Edd Barrett wrote: > Hi Mike, > > On Fri, Jun 17, 2022 at 11:55:51AM -0700, Mike Larkin wrote: > > > - disabling xhci in ukc: the system fails to boot multi-user. The first > > >oddness comes where cpus #1-3 fail to "become ready" (as reported by > >

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Edd Barrett
Hi Mike, On Fri, Jun 17, 2022 at 11:55:51AM -0700, Mike Larkin wrote: > > - disabling xhci in ukc: the system fails to boot multi-user. The first > >oddness comes where cpus #1-3 fail to "become ready" (as reported by > > dmesg). > >It spends a while thinking about these cores not

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Mike Larkin
On Fri, Jun 17, 2022 at 06:41:23PM +0100, Edd Barrett wrote: > Hi Mike, > > On Fri, Jun 17, 2022 at 10:20:35AM -0700, Mike Larkin wrote: > > Oh, didn't read this closely enough the first time. If ZZZ doesn't > > instantly wake > > the machine, then it's one of the two S3 devices described in your

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Edd Barrett
Hi Mike, On Fri, Jun 17, 2022 at 10:20:35AM -0700, Mike Larkin wrote: > Oh, didn't read this closely enough the first time. If ZZZ doesn't instantly > wake > the machine, then it's one of the two S3 devices described in your next email. > Since one is XHCI, I'd disable xhci in ukc and see if

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Mike Larkin
On Fri, Jun 17, 2022 at 09:14:45AM +0100, Edd Barrett wrote: > Hi Mike, > > On Thu, Jun 16, 2022 at 09:19:50PM -0700, Mike Larkin wrote: > > From your original dmesg: > > > > > acpi0: wakeup devices PEG0(S4) PEGP(S4) PEG1(S4) PEGP(S4) PEG2(S4) > > > PEGP(S4) SIO1(S3) RP09(S4) PXSX(S4) RP10(S4)

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Mike Larkin
On Fri, Jun 17, 2022 at 09:14:45AM +0100, Edd Barrett wrote: > Hi Mike, > > On Thu, Jun 16, 2022 at 09:19:50PM -0700, Mike Larkin wrote: > > From your original dmesg: > > > > > acpi0: wakeup devices PEG0(S4) PEGP(S4) PEG1(S4) PEGP(S4) PEG2(S4) > > > PEGP(S4) SIO1(S3) RP09(S4) PXSX(S4) RP10(S4)

Re: bgpd switch kroute_find to bgpd_addr argument

2022-06-17 Thread Claudio Jeker
On Fri, Jun 17, 2022 at 12:32:50PM +0200, Theo Buehler wrote: > On Fri, Jun 17, 2022 at 11:37:29AM +0200, Claudio Jeker wrote: > > On Thu, Jun 16, 2022 at 09:01:33PM +0200, Theo Buehler wrote: > > > On Thu, Jun 16, 2022 at 07:15:51PM +0200, Claudio Jeker wrote: > > > > Not much holds us back to

Re: bgpd switch kroute_find to bgpd_addr argument

2022-06-17 Thread Theo Buehler
On Fri, Jun 17, 2022 at 11:37:29AM +0200, Claudio Jeker wrote: > On Thu, Jun 16, 2022 at 09:01:33PM +0200, Theo Buehler wrote: > > On Thu, Jun 16, 2022 at 07:15:51PM +0200, Claudio Jeker wrote: > > > Not much holds us back to switch kroute_find() to use a struct bgpd_addr > > > as prefix argument.

Re: bgpd switch kroute_find to bgpd_addr argument

2022-06-17 Thread Claudio Jeker
On Thu, Jun 16, 2022 at 09:01:33PM +0200, Theo Buehler wrote: > On Thu, Jun 16, 2022 at 07:15:51PM +0200, Claudio Jeker wrote: > > Not much holds us back to switch kroute_find() to use a struct bgpd_addr > > as prefix argument. Only the match code needs some adoption. > > I created applymask() for

Re: Only scan device 0 on pcie downstream ports

2022-06-17 Thread Jonathan Gray
On Fri, Jun 17, 2022 at 10:38:08AM +0200, Mark Kettenis wrote: > > Date: Fri, 17 Jun 2022 17:22:58 +1000 > > From: Jonathan Gray > > > > On Fri, Jun 17, 2022 at 12:33:47AM +0200, Mark Kettenis wrote: > > > On the Ampere Altra machines, some PCIe devices show up 32 times; once > > > for each

Re: Only scan device 0 on pcie downstream ports

2022-06-17 Thread Mark Kettenis
> Date: Fri, 17 Jun 2022 17:22:58 +1000 > From: Jonathan Gray > > On Fri, Jun 17, 2022 at 12:33:47AM +0200, Mark Kettenis wrote: > > On the Ampere Altra machines, some PCIe devices show up 32 times; once > > for each possible PCI device number. This is a hardware bug, since a > > downstream

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Edd Barrett
On Fri, Jun 17, 2022 at 09:14:45AM +0100, Edd Barrett wrote: > > 1. remove the code that truncates this list after 16, and note down all the > > wake devices. Here's the full list: acpi0: wakeup devices PEG0(S4) PEGP(S4) PEG1(S4) PEGP(S4) PEG2(S4) PEGP(S4) SIO1(S3) RP09(S4) PXSX(S4) RP10(S4)

Re: Lenovo ThinkCentre M910q fails to suspend

2022-06-17 Thread Edd Barrett
Hi Mike, On Thu, Jun 16, 2022 at 09:19:50PM -0700, Mike Larkin wrote: > From your original dmesg: > > > acpi0: wakeup devices PEG0(S4) PEGP(S4) PEG1(S4) PEGP(S4) PEG2(S4) PEGP(S4) > > SIO1(S3) RP09(S4) PXSX(S4) RP10(S4) PXSX(S4) RP11(S4) PXSX(S4) RP12(S4) > > PXSX(S4) RP13(S4) [...] > >

Re: Only scan device 0 on pcie downstream ports

2022-06-17 Thread Jonathan Gray
On Fri, Jun 17, 2022 at 12:33:47AM +0200, Mark Kettenis wrote: > On the Ampere Altra machines, some PCIe devices show up 32 times; once > for each possible PCI device number. This is a hardware bug, since a > downstream switch port (or root port) is supposed to terminate > configuration request

Re: kernel: remove global "randompid" toggle

2022-06-17 Thread Theo de Raadt
Miod Vallat wrote: > > Are we keeping this "randompid" global around to make it possible to > > disable random PIDs by toggling it in ddb(4)? > > IIRC this logic was needed because some kthreads were created before > arc4random was operational, but that was before substantial changes to > the