Re: igc: Add missing return in error path

Thanks Christian! OK gnezdo@ is somebody want to commit this. I confirmed that it builds too. Christian Ludwig writes: > There is a return missing in one of the error paths of igc_init(). > --- > sys/dev/pci/if_igc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

powerpc, macppc: retrigger deferred DEC interrupts from splx(9)

Hi, One of the problems obstructing my dynamic clock interrupt patch is that clock interrupts on powerpc don't (can't?) behave the same as clock interrupts on amd64, arm64, and sparc64. In particular, for historical reasons, on powerpc you cannot mask decrementer (DEC) interrupts without *also*

urtwn: Lower IPL again in error case

The packet receive handler runs on IPL_NET in large parts. Fix the error case that misses to lower the IPL again when decoding CCMP packets fails. --- sys/dev/usb/if_urtwn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/usb/if_urtwn.c b/sys/dev/usb/if_urtwn.c index

mcx: Lower IPL again in error case

The mcx ioctl callback runs on IPL_NET. Fix the error cases that return early, without lowering the IPL again. --- sys/dev/pci/if_mcx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/pci/if_mcx.c b/sys/dev/pci/if_mcx.c index 99930d7a2fe..b9baac3989a 100644 ---

igc: Add missing return in error path

There is a return missing in one of the error paths of igc_init(). --- sys/dev/pci/if_igc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/pci/if_igc.c b/sys/dev/pci/if_igc.c index 734bc8b0275..7f5fcb98b99 100644 --- a/sys/dev/pci/if_igc.c +++ b/sys/dev/pci/if_igc.c @@ -910,6 +910,7

uaq: Lower IPL again in error case

The uaq initialization runs on IPL_NET. Fix the one error case that misses to lower the IPL again. --- sys/dev/usb/if_uaq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/usb/if_uaq.c b/sys/dev/usb/if_uaq.c index d7b9d6daa9a..fa47344bc43 100644 --- a/sys/dev/usb/if_uaq.c +++

Re: bgpctl fmt_timeframe cleanup

On Thu, Jun 23, 2022 at 12:53:37PM +0200, Claudio Jeker wrote: > Newer gcc likes to bitch about snprintf buffers being to small for > insane numbers. This made me look at fmt_timeframe() and I decided to > clean it up a bit. It also likes to throw colorful fits about uninitialized variables... >

bgpctl fmt_timeframe cleanup

Newer gcc likes to bitch about snprintf buffers being to small for insane numbers. This made me look at fmt_timeframe() and I decided to clean it up a bit. First of all the ring buffer is not needed. fmt_timeframe() is never used multiple time in a single printf() call. So drop that. Then make

Re: bgpd move struct kif to kroute.c

On Thu, Jun 23, 2022 at 12:10:36PM +0200, Claudio Jeker wrote: > struct kif is internal to the kroute code with the exception of the > 'depend on' tracking message. So create an extra object for this message > and move struct kif to kroute.c. > > I renamed the IMSG just to make it clear what this

bgpd move struct kif to kroute.c

struct kif is internal to the kroute code with the exception of the 'depend on' tracking message. So create an extra object for this message and move struct kif to kroute.c. I renamed the IMSG just to make it clear what this is about and to make sure I did not miss something. After that struct

Re: bgpd walks into IPv6 hell

On Thu, Jun 23, 2022 at 09:56:19AM +0200, Claudio Jeker wrote: > IPv6 is such a lovley protocol. Add the scope_id for link local addresses > in kr6_tofull() because IPv6 just has to be "special". > > Maybe we should add a scope_id to struct kroute6 but heck it is mostly the > interface index

bgpd walks into IPv6 hell

IPv6 is such a lovley protocol. Add the scope_id for link local addresses in kr6_tofull() because IPv6 just has to be "special". Maybe we should add a scope_id to struct kroute6 but heck it is mostly the interface index except for non link local addresses because there it has to be 0. So this