Re: Replace struct selinfo with klist in bpf, kqueue and pipes

On Fri, Jul 08, 2022 at 03:39:59PM +, Visa Hankala wrote: > Replace struct selinfo with direct use of struct klist in bpf, kqueue > and pipes. These subsystems no longer utilize selwakeup(). > > OK? ok jsg@ > > Index: kern/kern_event.c >

tcpdump: Explicitly set the default value for Bflag

We currently do not explicitly set the value for Bflag. Since it's a static variable it is initialized to 0, which just so conveniently happen to match the default constant. So, this is technically a no-op since the value of the initial constant is 0 anyway, but I do not think we should not rely

Re: pppoe(4): reorder interface destruction and initialization

ping... On Tue, Jul 05, 2022 at 09:15:48PM +0300, Vitaliy Makkoveev wrote: > pppoe_timeout() and pppoe_clone_destroy() are both executed with kernel > lock held, but they are not serialized because pppoe_timeout() has the > sleep point provided by netlock. We should use timeout_del_barrier(9) to

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

On Sat, Jul 09, 2022 at 12:08:49AM +0300, Vitaliy Makkoveev wrote: > Thanks for pointing. > > > On 8 Jul 2022, at 23:13, Alexander Bluhm wrote: > > > > On Fri, Jul 08, 2022 at 05:42:23PM +0300, Vitaliy Makkoveev wrote: > >> The update diff below. I also found we need to increment 'pxc_oerrors'

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

Thanks for pointing. > On 8 Jul 2022, at 23:13, Alexander Bluhm wrote: > > On Fri, Jul 08, 2022 at 05:42:23PM +0300, Vitaliy Makkoveev wrote: >> The update diff below. I also found we need to increment 'pxc_oerrors' >> counter on `session_tmp' instead of session. > >> +m =

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

On Fri, Jul 08, 2022 at 05:42:23PM +0300, Vitaliy Makkoveev wrote: > The update diff below. I also found we need to increment 'pxc_oerrors' > counter on `session_tmp' instead of session. > + m = m_copym(m0, 0, M_COPYALL, M_NOWAIT) Does this compile? There is a ; missing.

bgpd: add add-path send support

Add the missing bits for add-path send support. The config options allows for a fair amount of configuration and not all have been tested: announce add-path send best [ plus X ] announce add-path send ecmp [ plus X ] [ max Y ] announce add-path send as-wide-best [ plus X ]

Re: bgpctl adjust AID loops a bit

On Fri, Jul 08, 2022 at 05:15:49PM +0200, Theo Buehler wrote: > On Fri, Jul 08, 2022 at 05:04:05PM +0200, Claudio Jeker wrote: > > I noticed that some of the loops over all AID (address identifiers) start > > at 0 but they should use AID_MIN. This is not a general rule and I > > actually skipped

gzip: fix pledge violation

gzip violates wpath if you tell it to extract stdin and restore the original filename. The original mail didn't go through after 12 hours so I'm resending it, sorry if you get 2. Index: regress/usr.bin/gzip/Makefile === RCS file:

PATCH: better prime testing for libressl

Hello, I'm suggesting you a diff against master of the implementation of the Baillie-PSW algorithm for primality testing. The code in itself is commented and has information about what is being done and why. The reason for this change is that in this paper from 2018

Replace struct selinfo with klist in bpf, kqueue and pipes

Replace struct selinfo with direct use of struct klist in bpf, kqueue and pipes. These subsystems no longer utilize selwakeup(). OK? Index: kern/kern_event.c === RCS file: src/sys/kern/kern_event.c,v retrieving revision 1.191 diff

Re: bgpctl adjust AID loops a bit

On Fri, Jul 08, 2022 at 05:04:05PM +0200, Claudio Jeker wrote: > I noticed that some of the loops over all AID (address identifiers) start > at 0 but they should use AID_MIN. This is not a general rule and I > actually skipped one of the for loops because I think there 0 is actually > better. In

bgpctl adjust AID loops a bit

I noticed that some of the loops over all AID (address identifiers) start at 0 but they should use AID_MIN. This is not a general rule and I actually skipped one of the for loops because I think there 0 is actually better. In the cases I fixed it is known that only known AID and not AID_UNSPEC are

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

On Fri, Jul 08, 2022 at 05:35:38PM +0900, YASUOKA Masahiko wrote: > Hello, > > On Fri, 8 Jul 2022 00:53:16 +0300 > Vitaliy Makkoveev wrote: > > The `pipex_list_mtx' mutex(9) protects global pipex(4) lists so it need > > to be taken while we perform this foreach loop. > > > > The all sessions

Re: bgpd: initial local path_id support for Adj-RIB-Out

On Fri, Jul 08, 2022 at 11:17:16AM +0200, Claudio Jeker wrote: > This diff adds the required plumbing to support local path_ids in the > output path. Mainly it extends prefix_adjout_update() to do the right > thing. Since in normal mode of operation path_id_tx does not matter and > only on prefix

Re: amd64 serial console changes, part 2

On 6.7.2022. 22:45, Mark Kettenis wrote: > Now that the kernel supports the extended BOOTARG_CONSDEV struct and > snaps with that change are out there, here is the diff that changes > the amd64 bootloaders to switch to the extended struct and provide the > parameters necessary for using the

bgpd: initial local path_id support for Adj-RIB-Out

This diff adds the required plumbing to support local path_ids in the output path. Mainly it extends prefix_adjout_update() to do the right thing. Since in normal mode of operation path_id_tx does not matter and only on prefix is in the Adj-RIB-Out the code uses prefix_adjout_lookup() to locate

Re: pipex(4): Add missing lock around all sessions loop within pipex_ip_output()

Hello, On Fri, 8 Jul 2022 00:53:16 +0300 Vitaliy Makkoveev wrote: > The `pipex_list_mtx' mutex(9) protects global pipex(4) lists so it need > to be taken while we perform this foreach loop. > > The all sessions loop was reworked to make possible to drop the lock > within. This is required