[RFC] acpi: add acpitimer_delay(), acpihpet_delay()

2022-08-14 Thread Scott Cheloha
Hi, In the future when the LAPIC timer is run in oneshot mode there will be no lapic_delay(). This is fine if you have a constant TSC, because we have tsc_delay(). This is *very* bad for older amd64 machines, because you are left with i8254_delay(). I would like to offer a less awful delay(9)

httpd: plug fd/memory leaks in error paths

2022-08-14 Thread Omar Polo
I was looking for something different when I stumbled upon this. - in server_file_index `escapedpath' is leaked if evbuffer_add_printf fails, similarly the directory entries in the loop. `escapeduri' is also leaked if escape_html fails. - read_errdoc leaks a file descriptor if fstat

Re: interface media without netlock

2022-08-14 Thread Alexander Bluhm
On Sun, Aug 14, 2022 at 10:35:34PM +0200, Jeremie Courreges-Anglas wrote: > Works fine on GENERIC.MP. OK bluhm@ > Index: dev/fdt/if_cad.c > === > RCS file: /cvs/src/sys/dev/fdt/if_cad.c,v > retrieving revision 1.11 > diff -u -p

Re: interface media without netlock

2022-08-14 Thread Vitaliy Makkoveev
> On 14 Aug 2022, at 23:35, Jeremie Courreges-Anglas wrote: > > On Sun, Aug 14 2022, Vitaliy Makkoveev wrote: >> I propose to avoid netlock relocking for SIOCGIFSFFPAGE too. > > sigh, that seems to be needed indeed. > >> Also, since the relock should be avoided for many commands, I prefer >>

Re: interface media without netlock

2022-08-14 Thread Jeremie Courreges-Anglas
On Sun, Aug 14 2022, Vitaliy Makkoveev wrote: > I propose to avoid netlock relocking for SIOCGIFSFFPAGE too. sigh, that seems to be needed indeed. > Also, since the relock should be avoided for many commands, I prefer > to have something like below: > > switch(cmd){ > case

Re: IPv6 hop-by-hop check in parallel

2022-08-14 Thread gwes
On 8/13/22 15:08, Alexander Bluhm wrote: Hi, While running forwarding in parallel, I have introduced a hard barrier for parallel local protocol processing. The packets are requeued from shared to exclusive netlock. Unless we unlock all protocol input routines at once, we need some

Re: interface media without netlock

2022-08-14 Thread Vitaliy Makkoveev
I propose to avoid netlock relocking for SIOCGIFSFFPAGE too. Also, since the relock should be avoided for many commands, I prefer to have something like below: switch(cmd){ case SIOCGIFMEDIA: case ...: relock = 1; break; }

Re: interface media without netlock

2022-08-14 Thread Jeremie Courreges-Anglas
On Sun, Aug 14 2022, Jeremie Courreges-Anglas wrote: > On Thu, Jul 28 2022, Alexander Bluhm wrote: >> Hi, >> >> The netlock for SIOCSIFMEDIA and SIOCGIFMEDIA ioctl is not necessary. >> Legacy drivers run with kernel lock, interface media is MP safe or >> has kernel lock. >> >> ixl(4) talks about

Re: interface media without netlock

2022-08-14 Thread Jeremie Courreges-Anglas
On Thu, Jul 28 2022, Alexander Bluhm wrote: > Hi, > > The netlock for SIOCSIFMEDIA and SIOCGIFMEDIA ioctl is not necessary. > Legacy drivers run with kernel lock, interface media is MP safe or > has kernel lock. > > ixl(4) talks about net lock but in fact has kernel lock. > > Problem is that

Add Intel Optane 900P/905P NVMe

2022-08-14 Thread Andreas Bartelt
Hi, Intel Optane 905p NVMe devices were not yet recognized in CURRENT (e.g., https://ark.intel.com/content/www/us/en/ark/products/148607/intel-optane-ssd-905p-series-380gb-m-2-110mm-pcie-x4-20nm-3d-xpoint.html ). I've managed to get it working with the following diff: Index: pcidevs

Re: Remove unneeded kern.nselcoll sysctl

2022-08-14 Thread Todd C . Miller
On Sun, 14 Aug 2022 11:13:35 -, Visa Hankala wrote: > Remove unneeded kern.nselcoll sysctl. > > The last use of this sysctl in base was removed over two weeks ago. > Debian Code Search does not show any uses of the KERN_NSELCOLL macro. OK millert@ - todd

Remove kqueue-related trace points from poll(2) and select(2)

2022-08-14 Thread Visa Hankala
kqueue-based poll(2) and select(2) seem to work fairly well. Because of this, the ktrace points that display the internal translated events do not appear very valuable any longer. They clog up and make traces difficult to read. I think it is time to remove the trace points. OK? Index:

Remove unneeded kern.nselcoll sysctl

2022-08-14 Thread Visa Hankala
Remove unneeded kern.nselcoll sysctl. The last use of this sysctl in base was removed over two weeks ago. Debian Code Search does not show any uses of the KERN_NSELCOLL macro. OK? Index: lib/libc/sys/sysctl.2 === RCS file:

Re: Split (*pr_usrreq)() by multiple handlers

2022-08-14 Thread Alexander Bluhm
On Sun, Aug 14, 2022 at 01:35:18AM +0300, Vitaliy Makkoveev wrote: > The pr_usrreqs hunks. I replaced spaces by tab within `routesw' > structure. OK bluhm@ > Index: sys/kern/uipc_proto.c > === > RCS file: