Re: Typo in bsd.port.mk(5)

2022-09-09 Thread Jason McIntyre
On Fri, Sep 09, 2022 at 10:04:04PM -0400, John Verne wrote: > While studying bsd.port.mk I ran across a reference to > PACKAGES_REPOSITORY that seems like a typo. My assumption is that it > is supposed to be PACKAGE_REPOSITORY as in the rest of the document > (and in the FAQ, etc.). > fixed,

Re: installboot: merge duplicate code into sr_open_chunk()

2022-09-09 Thread Klemens Nanni
On Sat, Sep 10, 2022 at 02:10:22AM +, Klemens Nanni wrote: > It does not have the prettiest signature, but nicely folds identical > copies into MI softraid.c, which then allows us to > - avoid further diverging MD code > - implement the keydisk fix on tech@ once instead of thrice > - reuse

installboot: merge duplicate code into sr_open_chunk()

2022-09-09 Thread Klemens Nanni
It does not have the prettiest signature, but nicely folds identical copies into MI softraid.c, which then allows us to - avoid further diverging MD code - implement the keydisk fix on tech@ once instead of thrice - reuse sr_open_chunk() in an upcoming diff to make -p softraid aware The last

Typo in bsd.port.mk(5)

2022-09-09 Thread John Verne
While studying bsd.port.mk I ran across a reference to PACKAGES_REPOSITORY that seems like a typo. My assumption is that it is supposed to be PACKAGE_REPOSITORY as in the rest of the document (and in the FAQ, etc.). Index: bsd.port.mk.5

Re: top(1): remove last vestiges of "last pid"

2022-09-09 Thread Todd C . Miller
On Fri, 09 Sep 2022 20:19:26 -0500, Scott Cheloha wrote: > millert@ removed most of the "last pid" pieces from top(1) in 1997: > > http://cvsweb.openbsd.org/src/usr.bin/top/machine.c?rev=1.7=text > /x-cvsweb-markup > > Some small bits remain, though. Can we remove the rest? Sure. OK millert@

top(1): remove last vestiges of "last pid"

2022-09-09 Thread Scott Cheloha
millert@ removed most of the "last pid" pieces from top(1) in 1997: http://cvsweb.openbsd.org/src/usr.bin/top/machine.c?rev=1.7=text/x-cvsweb-markup Some small bits remain, though. Can we remove the rest? Index: display.c === RCS

Re: init(8): signal handler boolean needs to be "volatile"

2022-09-09 Thread Todd C . Miller
On Fri, 09 Sep 2022 14:05:46 -0500, Scott Cheloha wrote: > The variable "clang" is modified from a signal handler. It should be > of type sig_atomic_t and it needs to be volatile. Right. OK millert@ - todd

init(8): signal handler boolean needs to be "volatile"

2022-09-09 Thread Scott Cheloha
The variable "clang" is modified from a signal handler. It should be of type sig_atomic_t and it needs to be volatile. ok? Index: init.c === RCS file: /cvs/src/sbin/init/init.c,v retrieving revision 1.71 diff -u -p -r1.71 init.c

Gmux Driver for Macbook Retina Display

2022-09-09 Thread Leonardo Moreno Urbieta
Hello, I wrote this driver to control the backlight in my MacBook Pro 2015 with Retina Display. I had to refer to some of the code in the linux apple-gmux.c driver to learn how to communicate with the chip. This could cause an issue with the license? That's why I haven't included any license

Re: bgpd optimize bgpctl show rib 10/8 or-longer

2022-09-09 Thread Theo Buehler
On Fri, Sep 09, 2022 at 05:50:17PM +0200, Claudio Jeker wrote: > This diff optimized subtree walks. In other words it specifies a subtree > (as a prefix/prefixlen combo) and only walks the entries that are under > this covering route. > > Instead of doing a full table walk this will only walk

bgpd optimize bgpctl show rib 10/8 or-longer

2022-09-09 Thread Claudio Jeker
This diff optimized subtree walks. In other words it specifies a subtree (as a prefix/prefixlen combo) and only walks the entries that are under this covering route. Instead of doing a full table walk this will only walk part of the tree and is therefor much faster if the subtree is small. --

Re: [please test] pvclock(4): fix several bugs

2022-09-09 Thread Scott Cheloha
On Thu, Sep 08, 2022 at 10:17:12AM -0500, Scott Cheloha wrote: > > On Sep 8, 2022, at 9:05 AM, Mike Larkin wrote: > > [...] > > > > You could compile this and then objdump -D it and see for yourself... > > I can't make heads or tails of it. Please explain what I am looking > at and why it is,

Re: bgpd, optimize bgpctl show rib 10.0.0.1 or-shorter

2022-09-09 Thread Claudio Jeker
On Fri, Sep 09, 2022 at 03:20:00PM +0200, Theo Buehler wrote: > On Fri, Sep 09, 2022 at 02:49:12PM +0200, Claudio Jeker wrote: > > So bgpctl has the or-shorter flag to indicate that not only the best > > matching prefix should be shown, instead all matching prefixes are shown. > > Currently this

Re: bgpd, optimize bgpctl show rib 10.0.0.1 or-shorter

2022-09-09 Thread Theo Buehler
On Fri, Sep 09, 2022 at 02:49:12PM +0200, Claudio Jeker wrote: > So bgpctl has the or-shorter flag to indicate that not only the best > matching prefix should be shown, instead all matching prefixes are shown. > Currently this is done by a full table walk which is super expensive. > There is no

Re: installboot: reflect script failure in exit code

2022-09-09 Thread Klemens Nanni
On Thu, Sep 08, 2022 at 03:28:29PM -0600, Todd C. Miller wrote: > On Thu, 08 Sep 2022 20:04:58 -, Klemens Nanni wrote: > > > Here's the full diff to fsck and newfs failure on all architectures. > > > > This is a regular programming issue around system(3) that has nothing to > > do with

bgpd, optimize bgpctl show rib 10.0.0.1 or-shorter

2022-09-09 Thread Claudio Jeker
So bgpctl has the or-shorter flag to indicate that not only the best matching prefix should be shown, instead all matching prefixes are shown. Currently this is done by a full table walk which is super expensive. There is no real reason to do that. One can just start the lookup with prefixlen = 0

Re: acpihpet(4): acpihpet_delay: only use lower 32 bits of counter

2022-09-09 Thread Scott Cheloha
On Fri, Sep 09, 2022 at 03:59:01PM +1000, Jonathan Gray wrote: > On Thu, Sep 08, 2022 at 08:31:21PM -0500, Scott Cheloha wrote: > > On Sat, Aug 27, 2022 at 09:28:06PM -0500, Scott Cheloha wrote: > > > Whoops, forgot about the split read problem. My mistake. > > > > > > Because 32-bit platforms