Re: pf.conf / scrub resulting in invalid checksum

2022-10-09 Thread Bjorn Ketelaars
On Sun 09/10/2022 17:10, Björn Ketelaars wrote: > I'm using mcast-proxy from ports as multicast routing proxy for use with > my ISP's iptv platform. After some setting up i noticed from > mcast-proxy's logging that all incoming packets are dropped because of > IP invalid checksums [0]. At first I

Re: install.sub: Get rid of useless/confusing subshell

2022-10-09 Thread Alexander Hall
On October 10, 2022 12:45:09 AM GMT+02:00, Klemens Nanni wrote: >On Wed, Oct 05, 2022 at 04:56:57PM +0200, Alexander Hall wrote: >> While I dislike the ">/dev/null 2>&1" sledgehammer, this is in the right >> direction. > >Agreed. > >We should be fine silencing only the test condition which

install.sub: use newlines for readability inside single quotes

2022-10-09 Thread Klemens Nanni
No functional changes, just breaking the long line. OK? Index: install.sub === RCS file: /cvs/src/distrib/miniroot/install.sub,v retrieving revision 1.1210 diff -u -p -r1.1210 install.sub --- install.sub 5 Oct 2022 19:30:47 -

Re: install.sub: Get rid of another useless/confusing subshell

2022-10-09 Thread Klemens Nanni
On Tue, Oct 04, 2022 at 08:11:46PM +, Klemens Nanni wrote: > This function's style is a bit off: it wraps the body in a subshell to > discard all stdout/err at once, but a still uses return inside it. > > 1. A command list (using {}) would be enough here as it groups like a >subshell but

Re: [v2] timeout.9: rewrite

2022-10-09 Thread Scott Cheloha
On Wed, Jul 27, 2022 at 12:10:00AM +, Klemens Nanni wrote: > On Fri, Jul 22, 2022 at 01:38:16PM -0500, Scott Cheloha wrote: > > Hi, > > > > As promised, here is the timeout.9 manpage rewrite I've been sitting > > on. I am pretty sure jmc@ (and maybe schwarze@) read an earlier > > version of

Re: install.sub: Get rid of useless/confusing subshell

2022-10-09 Thread Klemens Nanni
On Wed, Oct 05, 2022 at 04:56:57PM +0200, Alexander Hall wrote: > While I dislike the ">/dev/null 2>&1" sledgehammer, this is in the right > direction. Agreed. We should be fine silencing only the test condition which produces legit output and warnings. All else produces no output and should

Re: smtpd bug in Received: header with one recipient

2022-10-09 Thread Chris Waddey
On Sun, Oct 09, 2022 at 08:01:01AM +0200, Martijn van Duren wrote: > Bit focused on other things atm and not familiar with this part of the > code, but some comments. > > On Sat, 2022-10-08 at 12:18 -0600, Chris Waddey wrote: >> A message with a single successful recipient but with a failed >>

Re: [acpi] patch for embedded controller detection

2022-10-09 Thread Mikhail
On Sat, Oct 08, 2022 at 05:10:31PM +0200, Mark Kettenis wrote: > > Date: Sat, 8 Oct 2022 16:36:09 +0300 > > From: Mikhail > > > > On Sat, Oct 08, 2022 at 02:56:18PM +0200, Mark Kettenis wrote: > > > The patch isn't quite right, but you're on the right track here. Can > > > you send me the