Re: [PATCH] [src] share/man/man8/rc.subr.8 - normalise markup

2022-10-19 Thread Raf Czlonka
On Fri, May 27, 2022 at 01:28:07PM BST, Antoine Jacoutot wrote: > > rc.subr.8 committed, thanks. Hi Antoine, I only just noticed that the diff hasn't been applied/committed in its entirety - only the "daemon Ns _logger" -> "daemon_logger" part has been but the "Ar" -> "Va" hasn't, but was also

Re: audio(9): remove unused setfd member from struct audio_hw_if

2022-10-19 Thread Alexandre Ratchov
On Wed, Oct 19, 2022 at 07:31:59PM +, Klemens Nanni wrote: > All consumers now use C99 struct init and none of them sets `.setfd'. > > My X230 still plays audio just fine: > azalia0 at pci0 dev 27 function 0 "Intel 7 Series HD Audio" rev 0x04: msi > azalia0: codecs: Realtek ALC269,

audio(9): remove unused setfd member from struct audio_hw_if

2022-10-19 Thread Klemens Nanni
All consumers now use C99 struct init and none of them sets `.setfd'. My X230 still plays audio just fine: azalia0 at pci0 dev 27 function 0 "Intel 7 Series HD Audio" rev 0x04: msi azalia0: codecs: Realtek ALC269, Intel/0x2806, using Realtek ALC269 audio0 at azalia0 Feedback? OK? diff --git

Re: smtpd bug in Received: header with one recipient

2022-10-19 Thread Todd C . Miller
I took another look at this and it seems correct to me. We should not really be using tx->evp.rcpt after the it has been added to the tx->rcpts list. I plan to commit it unless there are objections. - todd

ahc, ahd: constify global identity tables

2022-10-19 Thread Klemens Nanni
Those .data symbols are already treated as const, so move to .rodata: 82290610 g O .data 05d0 ahc_pci_ident_table 82290be0 g O .data 0198 ahd_pci_ident_table 650 const struct ahc_pci_identity * 651 ahc_find_pci_device(pcireg_t id, pcireg_t subid,

Re: ksh in vi-mode and line editing

2022-10-19 Thread Uwe Werler
On 19 Oct 08:49, Klemens Nanni wrote: > On Wed, Aug 31, 2022 at 05:16:27PM +0200, Uwe Werler wrote: > > Hi folks, > > > > I'm just wondering why there's a test for an empty line and args to start > > the > > editor for line editing. In bash one can start vi immediately with an empty > > line by

asmc: constify global product table

2022-10-19 Thread Klemens Nanni
Looking at symbols in /bsd .data again for .rodata candidates: 82281b70 l O .data 1688 asmc_prods amsc(4) never writes, but a const table requires a const softc member: 263 for (i = 0; asmc_prods[i].pr_name && !sc->sc_prod; i++) 264 if

Re: necsb(4/luna88k): remove audio(9) setfd() stub

2022-10-19 Thread Kenji Aoyama
Hello Klemens, On Wed, 19 Oct 2022 17:17:24 +0900, Klemens Nanni wrote: > > This is the only "implementation" of setfd() throughout the tree. > > With this gone and the audio_hw_if C99 struct init for most drivers, > we can safely remove setfd() code from audio(9). > > OK? Thank you for

Re: ksh in vi-mode and line editing

2022-10-19 Thread Uwe Werler
Hi Klemens, On 19 Oct 08:49, Klemens Nanni wrote: > On Wed, Aug 31, 2022 at 05:16:27PM +0200, Uwe Werler wrote: > > Hi folks, > > > > I'm just wondering why there's a test for an empty line and args to start > > the > > editor for line editing. In bash one can start vi immediately with an empty

Re: sparc64: miniroot: add mount_nfs(8) to fetch sets over NFS

2022-10-19 Thread Klemens Nanni
On Tue, Oct 11, 2022 at 05:43:21PM +, Klemens Nanni wrote: > sparc64 RAMDISK already has NFSCLIENT enabled and miniroot's FSSIZE > still fits after linking mount_nfs: > > /dev/vnd0a6312 5592 72089% 3 59 > 5% /mnt > > This boots fine on T4-2

Re: ksh in vi-mode and line editing

2022-10-19 Thread Klemens Nanni
On Wed, Aug 31, 2022 at 05:16:27PM +0200, Uwe Werler wrote: > Hi folks, > > I'm just wondering why there's a test for an empty line and args to start the > editor for line editing. In bash one can start vi immediately with an empty > line by ^v. Might be there's another reason I don't understand

Re: maestro(4), uaudio(4): constify globals

2022-10-19 Thread Alexandre Ratchov
On Wed, Oct 19, 2022 at 08:33:17AM +, Klemens Nanni wrote: > Used only for lookups; builds on i386. > > OK? > sure!

maestro(4), uaudio(4): constify globals

2022-10-19 Thread Klemens Nanni
Used only for lookups; builds on i386. OK? Index: usb/uaudio.c === RCS file: /cvs/src/sys/dev/usb/uaudio.c,v retrieving revision 1.169 diff -u -p -r1.169 uaudio.c --- usb/uaudio.c21 Mar 2022 19:22:42 - 1.169 +++

necsb(4/luna88k): remove audio(9) setfd() stub

2022-10-19 Thread Klemens Nanni
This is the only "implementation" of setfd() throughout the tree. With this gone and the audio_hw_if C99 struct init for most drivers, we can safely remove setfd() code from audio(9). OK? diff --git a/sys/arch/luna88k/cbus/nec86.c b/sys/arch/luna88k/cbus/nec86.c index 2d2d965d1bc..ea1e8b8f6df

Re: Fix description in OPENBSD-PF-MIB

2022-10-19 Thread Denis Fondras
Le Wed, Oct 19, 2022 at 08:36:46AM +0200, Martijn van Duren a écrit : > As pointed out by Alec on misc@, there's a discrepancy between the > name and description of several objects inside the pfIfTable. > > Looks like a simple copy-paste error. > > OK? > OK denis@ > martijn@ > > Index:

Re: ksh in vi-mode and line editing

2022-10-19 Thread Uwe Werler
On 31 Aug 17:16, Uwe Werler wrote: > Hi folks, > > I'm just wondering why there's a test for an empty line and args to start the > editor for line editing. In bash one can start vi immediately with an empty > line by ^v. Might be there's another reason I don't understand for this test? > > >

Re: dev/isa: ess, pas: constify string table

2022-10-19 Thread Alexandre Ratchov
On Tue, Oct 18, 2022 at 02:27:53PM +, Klemens Nanni wrote: > Each only used once for a printf() call in *_attach(). > Seen while tweaking their *_hw_if struct. > > OK? > ok

Fix description in OPENBSD-PF-MIB

2022-10-19 Thread Martijn van Duren
As pointed out by Alec on misc@, there's a discrepancy between the name and description of several objects inside the pfIfTable. Looks like a simple copy-paste error. OK? martijn@ Index: OPENBSD-PF-MIB.txt === RCS file: