Re: em(4) multiqueue

2023-04-13 Thread Kevin Lo
On Thu, Apr 13, 2023 at 01:30:36PM -0500, Brian Conway wrote: > > Reviving this thread, apologies for discontinuity in mail readers: > https://marc.info/?t=16564219358 > > After rebasing on 7.3, my results have mirrored Hrvoje's testing at the end > of that thread. No issues with

Re: em(4) multiqueue

2023-04-13 Thread Stuart Henderson
On 2023/04/13 16:45, Sonic wrote: > Is this multiqueue support in 7.3 or does it require patching? > According to Intel the i211 should have 2 queues but I see no msi-x > support in dmesg: > em0 at pci1 dev 0 function 0 "Intel I211" rev 0x03: msi, address It is not committed, there's a diff.

Re: em(4) multiqueue

2023-04-13 Thread Sonic
Is this multiqueue support in 7.3 or does it require patching? According to Intel the i211 should have 2 queues but I see no msi-x support in dmesg: em0 at pci1 dev 0 function 0 "Intel I211" rev 0x03: msi, address Thanks. Chris

Re: em(4) multiqueue

2023-04-13 Thread Brian Conway
On Thu, Apr 13, 2023, at 2:45 PM, Stuart Henderson wrote: > On 2023/04/13 13:30, Brian Conway wrote: >> Reviving this thread, apologies for discontinuity in mail readers: >> https://marc.info/?t=16564219358 >> >> After rebasing on 7.3, my results have mirrored Hrvoje's testing at the end >>

Re: em(4) multiqueue

2023-04-13 Thread Stuart Henderson
On 2023/04/13 13:30, Brian Conway wrote: > Reviving this thread, apologies for discontinuity in mail readers: > https://marc.info/?t=16564219358 > > After rebasing on 7.3, my results have mirrored Hrvoje's testing at the end > of that thread. No issues with throughput, unusual latency, or

Re: keynote: ansi for b64_{ntop,pton} wrappers

2023-04-13 Thread Alexander Bluhm
On Thu, Apr 13, 2023 at 07:56:35PM +0200, Theo Buehler wrote: > Silences -Wdeprecated-non-prototype warnings emitted by clang 15. OK bluhm@ > Index: base64.c > === > RCS file: /cvs/src/lib/libkeynote/base64.c,v > retrieving revision

Re: em(4) multiqueue

2023-04-13 Thread Brian Conway
Reviving this thread, apologies for discontinuity in mail readers: https://marc.info/?t=16564219358 After rebasing on 7.3, my results have mirrored Hrvoje's testing at the end of that thread. No issues with throughput, unusual latency, or reliability. `vmstat -i` shows some level of

Re: MALLOC_STATS: dump internal state and leak info via utrace(2)

2023-04-13 Thread Otto Moerbeek
On Tue, Apr 11, 2023 at 05:50:43PM +0200, Otto Moerbeek wrote: > On Sun, Apr 09, 2023 at 12:17:35PM +0200, Otto Moerbeek wrote: > > > On Sun, Apr 09, 2023 at 10:08:25AM +0200, Claudio Jeker wrote: > > > > > On Sun, Apr 09, 2023 at 09:15:12AM +0200, Otto Moerbeek wrote: > > > > On Sun, Apr 09,

keynote: ansi for b64_{ntop,pton} wrappers

2023-04-13 Thread Theo Buehler
Silences -Wdeprecated-non-prototype warnings emitted by clang 15. Index: base64.c === RCS file: /cvs/src/lib/libkeynote/base64.c,v retrieving revision 1.11 diff -u -p -r1.11 base64.c --- base64.c29 Jun 2004 11:35:56 -

Re: fix iwm/iwx updatechan callbacks

2023-04-13 Thread Todd C . Miller
On Wed, 12 Apr 2023 23:27:08 +0200, Stefan Sperling wrote: > The iwm_updatechan and iwx_updatechan callbacks are not reachable > because they were never wired up. Only the iwn driver already has > this callback pointer set as intended. > > With the patch below iwm/iwx should get triggered when an

installer: move code into stop_watchdog()

2023-04-13 Thread Klemens Nanni
start_watchdog() and reset_watchdog() exist, but stop logic is inlined. Giving it a name seems better. No functional change. Feedback? Objection? OK? Questions wrt. upgrade.site(5) prompted me to look at whether execution of /upgrade.site execution is subject to this timeout: it is, finish_up()

Re: bgpd cleanup imsg handling for communities

2023-04-13 Thread Theo Buehler
On Thu, Apr 13, 2023 at 03:48:40PM +0200, Claudio Jeker wrote: > Seen while working on similar code. There is no need to make the > composition of IMSG_CTL_SHOW_RIB_COMMUNITIES so complicated. ok > > -- > :wq Claudio > > Index: rde.c >

bgpd cleanup imsg handling for communities

2023-04-13 Thread Claudio Jeker
Seen while working on similar code. There is no need to make the composition of IMSG_CTL_SHOW_RIB_COMMUNITIES so complicated. -- :wq Claudio Index: rde.c === RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v retrieving revision 1.600 diff

Re: bgpd first bunch of flowspec code

2023-04-13 Thread Claudio Jeker
On Thu, Apr 13, 2023 at 02:17:48PM +0200, Theo Buehler wrote: > On Wed, Apr 12, 2023 at 05:33:10PM +0200, Claudio Jeker wrote: > > This is the first big amount of flowspec specific code. > > It adds a new file (flowspec.c) which exposes basic API functions to work > > with flowspec. Right now

Re: fix iwm/iwx updatechan callbacks

2023-04-13 Thread Florian Obser
On 2023-04-12 23:27 +02, Stefan Sperling wrote: > The iwm_updatechan and iwx_updatechan callbacks are not reachable > because they were never wired up. Only the iwn driver already has > this callback pointer set as intended. > > With the patch below iwm/iwx should get triggered when an AP

Re: bgpd first bunch of flowspec code

2023-04-13 Thread Theo Buehler
On Wed, Apr 12, 2023 at 05:33:10PM +0200, Claudio Jeker wrote: > This is the first big amount of flowspec specific code. > It adds a new file (flowspec.c) which exposes basic API functions to work > with flowspec. Right now apart from the regress test nothing uses these > functions (but don't

Re: alphabetically order commands in bgpctl

2023-04-13 Thread Claudio Jeker
On Thu, Apr 13, 2023 at 01:23:23PM +0200, Theo Buehler wrote: > On Thu, Apr 13, 2023 at 12:25:46PM +0200, Claudio Jeker wrote: > > bgpctl help output follows no clear order. I decided to sort all > > keywords and flags alphabetically. Also fixup the manpage a bit since > > some additions where

Re: alphabetically order commands in bgpctl

2023-04-13 Thread Theo Buehler
On Thu, Apr 13, 2023 at 12:25:46PM +0200, Claudio Jeker wrote: > bgpctl help output follows no clear order. I decided to sort all > keywords and flags alphabetically. Also fixup the manpage a bit since > some additions where added in the wrong spot. > > I think the output of 'bgpctl show rib

alphabetically order commands in bgpctl

2023-04-13 Thread Claudio Jeker
bgpctl help output follows no clear order. I decided to sort all keywords and flags alphabetically. Also fixup the manpage a bit since some additions where added in the wrong spot. I think the output of 'bgpctl show rib help' is the worst (both before and after). It is long and some keywords are