Re: converting perl stuff to v5.36

2023-05-07 Thread George Koehler
On Sun, 7 May 2023 19:21:11 -0700 Philip Guenther wrote: > On Sun, May 7, 2023 at 6:13 AM Marc Espie > wrote: > > > I'm actually wondering whether keeping the prototype is worth it. > ... > For plain subs, I would only keep them if they _really_ help the calls look > for more perl-ish, by

Re: converting perl stuff to v5.36

2023-05-07 Thread Philip Guenther
On Sun, May 7, 2023 at 6:13 AM Marc Espie wrote: > It is generally a good thing, I'm mostly talking about > the "signatures" stuff that allows functions with stuff that looks like > usual languages. > Other benefits include somewhat "cheap" check for correct number of > parameters > and

Re: software tcp send offloading

2023-05-07 Thread Alexander Bluhm
On Fri, May 05, 2023 at 05:54:49PM +0200, Alexander Bluhm wrote: > Claudio suggested to implement TCP send offloading in software as > a fallback if hardware cannot do it. Updated diff below: - some cleanup has been commited - pf route-to should work now - disable TSO if IP options are set Not

Re: nd6 RTM_ADD logic

2023-05-07 Thread Klemens Nanni
On Thu, May 04, 2023 at 08:43:19AM +0200, Alexander Bluhm wrote: > To make ND6 mp-safe, I have to guarantee the life time of ln = > rt->rt_llinfo. This call to nd6_llinfo_settimer(ln) looks strange. It reads like two distinct cases folded into one overly clever block. > The complicated logic

Re: installer: amd64 EFI: default to GPT

2023-05-07 Thread Klemens Nanni
On Sun, May 07, 2023 at 06:22:55PM +0200, Mark Kettenis wrote: > > Date: Sat, 6 May 2023 22:47:55 + > > From: Klemens Nanni > > > > On Sat, Apr 29, 2023 at 06:47:48PM +, Klemens Nanni wrote: > > > Installing to a wiped disk on EFI machines suggests MBR not GPT when > > > chosing > > >

Re: installer: amd64 EFI: default to GPT

2023-05-07 Thread Mark Kettenis
> Date: Sat, 6 May 2023 22:47:55 + > From: Klemens Nanni > > On Sat, Apr 29, 2023 at 06:47:48PM +, Klemens Nanni wrote: > > Installing to a wiped disk on EFI machines suggests MBR not GPT when chosing > > (E)dit because MBR vs. GPT in this manual case is picked based on existing > >

converting perl stuff to v5.36

2023-05-07 Thread Marc Espie
It is generally a good thing, I'm mostly talking about the "signatures" stuff that allows functions with stuff that looks like usual languages. Other benefits include somewhat "cheap" check for correct number of parameters and generally making code shorter. Basically this converts very perlish

Re: pfioctl: drop net lock from DIOCOSFP{FLUSH,ADD,GET}

2023-05-07 Thread Alexandr Nedvedicky
Hello, On Sat, May 06, 2023 at 08:56:06PM +, Klemens Nanni wrote: > On Sat, May 06, 2023 at 09:33:05PM +0200, Alexander Bluhm wrote: > > On Sat, May 06, 2023 at 11:11:25AM +, Klemens Nanni wrote: > > > pf_osfp.c contains all the locking for these three ioctls, this removes > > > the net

Re: fragment code cleanup for tso

2023-05-07 Thread Alexandr Nedvedicky
Hello, On Fri, May 05, 2023 at 11:17:50PM +0200, Alexander Bluhm wrote: > Hi, > > I preparation for my TSO in software diff, I would like to cleanup > the fragment code. Both are very simmilar and I like consistency. > > - Use if_output_ml() to send mbuf lists to interfaces. This can > be