Re: smtpd-filters: swap link-auth fields

2023-06-14 Thread Todd C . Miller
On Wed, 14 Jun 2023 16:34:39 +0200, Omar Polo wrote: > the `link-auth' event hash the user first and the result of the > operation after; this breaks when a username has a '|' character in > it. Since this is triggered by the `auth login' command, anyone could > send a user with a '|' and,

Re: smtpd-filters: swap link-auth fields

2023-06-14 Thread Gilles Chehade
Just released a new filter-rspamd with your diff, thanks > On 14 Jun 2023, at 19:23, Omar Polo wrote: > > Hello, > > the `link-auth' event hash the user first and the result of the > operation after; this breaks when a username has a '|' character in > it. Since this is triggered by the

Re: csh(1), ksh(1), time(1): print durations with millisecond precision

2023-06-14 Thread Scott Cheloha
On Wed, Jun 14, 2023 at 10:34:20AM -0400, Josiah Frentsos wrote: > On Tue, Jun 13, 2023 at 10:59:53PM -0500, Scott Cheloha wrote: > > Index: usr.bin/time/time.c > > === > > RCS file: /cvs/src/usr.bin/time/time.c,v > > retrieving

Re: smtpd-filters: swap link-auth fields

2023-06-14 Thread Omar Polo
On 2023/06/14 16:34:39 +0200, Omar Polo wrote: > For opensmtpd-filter-rspamd I have a corresponding diff that I'll send > to Gilles as it is off-topic for tech@, but here it is too if you want > to play with it: > > https://paste.omarpolo.com/9jtli2w apologize, this one has a stupid typo.

lpd(8): document correct control character for DVI

2023-06-14 Thread Lennart Jablonka
r is for FORTRAN output, not for DVI. Index: lpd.8 === RCS file: /cvs/src/usr.sbin/lpr/lpd/lpd.8,v retrieving revision 1.32 diff -u -p -r1.32 lpd.8 --- lpd.8 10 Oct 2022 09:13:43 - 1.32 +++ lpd.8 6 Jun 2023

smtpd-filters: swap link-auth fields

2023-06-14 Thread Omar Polo
Hello, the `link-auth' event hash the user first and the result of the operation after; this breaks when a username has a '|' character in it. Since this is triggered by the `auth login' command, anyone could send a user with a '|' and, depending on the filter used, make smtpd exit. (if the

Re: csh(1), ksh(1), time(1): print durations with millisecond precision

2023-06-14 Thread Josiah Frentsos
On Tue, Jun 13, 2023 at 10:59:53PM -0500, Scott Cheloha wrote: > Index: usr.bin/time/time.c > === > RCS file: /cvs/src/usr.bin/time/time.c,v > retrieving revision 1.25 > diff -u -p -r1.25 time.c > --- usr.bin/time/time.c 21 Aug

Re: iked: replace last print_host users to print_addr

2023-06-14 Thread Theo Buehler
On Wed, Jun 14, 2023 at 02:30:44PM +0200, Claudio Jeker wrote: > On Wed, Jun 14, 2023 at 12:37:35PM +0200, Theo Buehler wrote: > > On Wed, Jun 14, 2023 at 11:38:15AM +0200, Claudio Jeker wrote: > > > On Wed, Jun 14, 2023 at 11:10:52AM +0200, Theo Buehler wrote: > > > > On Wed, Jun 14, 2023 at

Re: iked: replace last print_host users to print_addr

2023-06-14 Thread Claudio Jeker
On Wed, Jun 14, 2023 at 12:37:35PM +0200, Theo Buehler wrote: > On Wed, Jun 14, 2023 at 11:38:15AM +0200, Claudio Jeker wrote: > > On Wed, Jun 14, 2023 at 11:10:52AM +0200, Theo Buehler wrote: > > > On Wed, Jun 14, 2023 at 10:44:23AM +0200, Claudio Jeker wrote: > > > > There is no real need to

Re: iked: replace last print_host users to print_addr

2023-06-14 Thread Theo Buehler
On Wed, Jun 14, 2023 at 11:38:15AM +0200, Claudio Jeker wrote: > On Wed, Jun 14, 2023 at 11:10:52AM +0200, Theo Buehler wrote: > > On Wed, Jun 14, 2023 at 10:44:23AM +0200, Claudio Jeker wrote: > > > There is no real need to have print_host() with the extra arguments. > > > So convert the last

Re: iked: replace last print_host users to print_addr

2023-06-14 Thread Claudio Jeker
On Wed, Jun 14, 2023 at 11:10:52AM +0200, Theo Buehler wrote: > On Wed, Jun 14, 2023 at 10:44:23AM +0200, Claudio Jeker wrote: > > There is no real need to have print_host() with the extra arguments. > > So convert the last remaining print_host() calls to use print_addr(). > > I'm not entierly

Re: iked: replace last print_host users to print_addr

2023-06-14 Thread Theo Buehler
On Wed, Jun 14, 2023 at 10:44:23AM +0200, Claudio Jeker wrote: > There is no real need to have print_host() with the extra arguments. > So convert the last remaining print_host() calls to use print_addr(). > I'm not entierly sure how to really test all these code paths but the > changes are failry

iked: replace last print_host users to print_addr

2023-06-14 Thread Claudio Jeker
There is no real need to have print_host() with the extra arguments. So convert the last remaining print_host() calls to use print_addr(). I'm not entierly sure how to really test all these code paths but the changes are failry simple. -- :wq Claudio Index: ikev2.c

vmd: relax absolute path requirement for configtest

2023-06-14 Thread Omar Polo
Hello, after vmd.c rv 1.142 vmd(8) errors when ran with a non-absolute path; this makes using -n (configtest) slightly more verbose, as the full path is needed and not just `vmd -n'. here's an attempt at relaxing the requirement for the -n case only. since we're not going to run any vm it should