Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Kevin Lo
On Mon, Aug 21, 2023 at 10:34:53PM -0500, Scott Cheloha wrote: > > On Tue, Aug 22, 2023 at 11:28:25AM +0800, Kevin Lo wrote: > > On Mon, Aug 21, 2023 at 09:53:53PM -0500, Scott Cheloha wrote: > > > On Tue, Aug 22, 2023 at 02:36:31AM +, Mike Larkin wrote: > > > > On Mon, Aug 21, 2023 at

Re: link mbufs/inpcbs to pf_states, not pf_state_keys

2023-08-21 Thread Alexandr Nedvedicky
Hello, On Tue, Aug 22, 2023 at 12:21:59AM +0200, Alexander Bluhm wrote: > On Thu, Aug 17, 2023 at 12:02:35PM +1000, David Gwynne wrote: > > there are links between the pcb/socket layer and pf as an optimisation, > > and links on mbufs between both sides of a forwarded connection. > > these links

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Scott Cheloha
On Tue, Aug 22, 2023 at 11:28:25AM +0800, Kevin Lo wrote: > On Mon, Aug 21, 2023 at 09:53:53PM -0500, Scott Cheloha wrote: > > On Tue, Aug 22, 2023 at 02:36:31AM +, Mike Larkin wrote: > > > On Mon, Aug 21, 2023 at 09:26:00PM -0500, Scott Cheloha wrote: > > > > On Mon, Aug 21, 2023 at

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Scott Cheloha
On Tue, Aug 22, 2023 at 02:36:31AM +, Mike Larkin wrote: > On Mon, Aug 21, 2023 at 09:26:00PM -0500, Scott Cheloha wrote: > > On Mon, Aug 21, 2023 at 10:10:58PM +, Mike Larkin wrote: > > > On Sat, Aug 19, 2023 at 01:44:47PM -0500, Scott Cheloha wrote: > > > > On Sun, Aug 13, 2023 at

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Scott Cheloha
On Tue, Aug 22, 2023 at 02:36:31AM +, Mike Larkin wrote: > On Mon, Aug 21, 2023 at 09:26:00PM -0500, Scott Cheloha wrote: > > On Mon, Aug 21, 2023 at 10:10:58PM +, Mike Larkin wrote: > > > On Sat, Aug 19, 2023 at 01:44:47PM -0500, Scott Cheloha wrote: > > > > On Sun, Aug 13, 2023 at

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Mike Larkin
On Mon, Aug 21, 2023 at 09:26:00PM -0500, Scott Cheloha wrote: > On Mon, Aug 21, 2023 at 10:10:58PM +, Mike Larkin wrote: > > On Sat, Aug 19, 2023 at 01:44:47PM -0500, Scott Cheloha wrote: > > > On Sun, Aug 13, 2023 at 01:48:21PM -0500, Scott Cheloha wrote: > > > > This is the next patch in

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Scott Cheloha
On Mon, Aug 21, 2023 at 10:10:58PM +, Mike Larkin wrote: > On Sat, Aug 19, 2023 at 01:44:47PM -0500, Scott Cheloha wrote: > > On Sun, Aug 13, 2023 at 01:48:21PM -0500, Scott Cheloha wrote: > > > This is the next patch in the clock interrupt reorganization series. > > > > > > Before we continue

Re: link mbufs/inpcbs to pf_states, not pf_state_keys

2023-08-21 Thread Alexander Bluhm
On Thu, Aug 17, 2023 at 12:02:35PM +1000, David Gwynne wrote: > there are links between the pcb/socket layer and pf as an optimisation, > and links on mbufs between both sides of a forwarded connection. > these links let pf skip an rb tree lookup for outgoing packets. > > right now these links

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Mike Larkin
On Sat, Aug 19, 2023 at 01:44:47PM -0500, Scott Cheloha wrote: > On Sun, Aug 13, 2023 at 01:48:21PM -0500, Scott Cheloha wrote: > > This is the next patch in the clock interrupt reorganization series. > > > > Before we continue breaking up the hardclock(9) we need to detour into > > the MD code. >

Re: Virtio fix for testing

2023-08-21 Thread Tobias Heider
On Sun, Aug 20, 2023 at 12:23:49PM +0200, Stefan Fritsch wrote: > Am 13.08.23 um 17:38 schrieb Tobias Heider: > > On Sun, Aug 13, 2023 at 08:33:54AM -0400, Andrew Cagney wrote: > > > > Hi Andrew, > > > > > > > > can you share the qemu cmd you are using in your tests? > > > > I'd like to see if I

Re: i386: i8254_initclocks: set IPL_MPSAFE for clock, rtc IRQs

2023-08-21 Thread Mike Larkin
On Sun, Aug 20, 2023 at 10:39:46PM -0500, Scott Cheloha wrote: > pOn amd64 we lie about the interrupts established during > i8254_initclocks(). We claim they are MP-safe in order to mollify a > KASSERT in intr_establish() and continue booting. > > See amd64/isa/clock.c: >279 void >280

Re: Virtio fix for testing

2023-08-21 Thread Andrew Cagney
On Sun, 20 Aug 2023 at 06:23, Stefan Fritsch wrote: > > Am 13.08.23 um 17:38 schrieb Tobias Heider: > > On Sun, Aug 13, 2023 at 08:33:54AM -0400, Andrew Cagney wrote: > >>> Hi Andrew, > >>> > >>> can you share the qemu cmd you are using in your tests? > >>> I'd like to see if I can reproduce

ober_scanf_elements() and empty sequences

2023-08-21 Thread Gerhard Roth
Hi Martijn, last November you fixed ber.c so that sequences won't generate an uninitialized subelement. This revealed another bug in ober_scanf_elements(): it couldn't process sequences with an empty list of subelements. The following code failed in ober_scanf_elements(): struct