[diff] typo in tls_load_file.3

2017-07-29 Thread Carlos Cardenas
Missing 'ocsp' in the function name. +--+ Carlos diff --git lib/libtls/man/tls_load_file.3 lib/libtls/man/tls_load_file.3 index fcaa5eef029..b83f55e0fe4 100644 --- lib/libtls/man/tls_load_file.3 +++ lib/libtls/man/tls_load_file.3 @@ -254,7 +254,7 @@ sets the files from which the public

[PATCH 1/2] VMD: Prevent Disappearing VM from vmctl status

2017-10-10 Thread Carlos Cardenas
Remove terminate_vm/vm_remove logic from vmm_dispatch_parent. This logic is present in vmm_sighdlr when a VM process has signaled SIGCHLD for proper cleanup. diff --git usr.sbin/vmd/vmm.c usr.sbin/vmd/vmm.c index ccd7680b479..8cc1c15157a 100644 --- usr.sbin/vmd/vmm.c +++ usr.sbin/vmd/vmm.c @@

[PATCH 0/2] VMD: handle VM termination error conditions better

2017-10-10 Thread Carlos Cardenas
This patch series handles two error conditions when terminating a VM (via vmctl or from within the VM). Comments? Ok? -- 2.14.2

[PATCH 2/2] VMD: Handle vm-induced powerdown better

2017-10-10 Thread Carlos Cardenas
The VMD parent process didn't handle the case of a VM exiting with a non 0 return properly (i.e. EIO). diff --git usr.sbin/vmd/vmd.c usr.sbin/vmd/vmd.c index f1abc54d9a3..dcff6de0c0e 100644 --- usr.sbin/vmd/vmd.c +++ usr.sbin/vmd/vmd.c @@ -394,11 +394,14 @@ vmd_dispatch_vmm(int fd, struct

[PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-10 Thread Carlos Cardenas
Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed when creating new bridge and attaching interfaces to it. Comments? Ok? diff --git usr.sbin/vmd/priv.c usr.sbin/vmd/priv.c index ef42549d105..0190c049837 100644 --- usr.sbin/vmd/priv.c +++ usr.sbin/vmd/priv.c @@ -88,6 +88,7 @@

Re: [PATCH] VMD: Remove switch on reload prior to re-creating

2017-10-11 Thread Carlos Cardenas
On 10/10/17 23:31, Claudio Jeker wrote: > On Tue, Oct 10, 2017 at 10:52:42PM -0700, Mike Larkin wrote: >> On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote: >>> On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote: >>>> Destroy switch on `vmct

[PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Carlos Cardenas
Add check(s) in vmd/vmctl to ensure a VM's disk are regular files. Tested with the following: vmctl start "test1" -d /dev/sd3c #block device vmctl start "test2" -d /dev/rsd3c #char device vmctl start "test3" -d fifo #named pipe Comments? Ok? diff --git usr.sbin/vmctl/vmctl.c

[PATCH] vm.conf: Clarify VM name constraints

2017-08-30 Thread Carlos Cardenas
Add VM name constraints to match those in vmctl.8 manpage. Comments? Ok? diff --git usr.sbin/vmd/vm.conf.5 usr.sbin/vmd/vm.conf.5 index d1e68dbce5d..77a7a4e8cea 100644 --- usr.sbin/vmd/vm.conf.5 +++ usr.sbin/vmd/vm.conf.5 @@ -108,7 +108,9 @@ section starts with a declaration of the virtual

Re: [PATCH v2 2/2] VMD: Prevent vmd crashing when stopping a stopped vm

2017-09-06 Thread Carlos Cardenas
On 2017-09-05 23:55, Mike Larkin wrote: > On Mon, Sep 04, 2017 at 12:03:31AM -0700, Carlos Cardenas wrote: >> * Fix logic handling stopping a VM. Prevents VMD from crashing. >> * Add additional error code to notify the user that a vm cannot be >> stopped when not running

[PATCH v3 1/2] VMD: Place log_debug statements in key places

2017-09-07 Thread Carlos Cardenas
Add log_debug statements in key places to assist with troubleshooting. diff --git usr.sbin/vmd/config.c usr.sbin/vmd/config.c index 9ea87eb86e8..7c1eed2697a 100644 --- usr.sbin/vmd/config.c +++ usr.sbin/vmd/config.c @@ -81,14 +81,18 @@ config_purge(struct vmd *env, unsigned int reset)

[PATCH v3 0/2] VMD: Prevent from crashing

2017-09-07 Thread Carlos Cardenas
This patch series contains: 1) Place plenty of log_debug statements in key places to assist with troubleshooting and debugging 2) Add new error code when attempting to stop a non-running vm (used by vmctl) Prevent vmd from crashing with updated logic when stopping a vm Difference

[PATCH v3 2/2] VMD: Prevent vmd crashing when stopping a stopped vm

2017-09-07 Thread Carlos Cardenas
* Fix logic handling stopping a VM. Prevents VMD from crashing. * Add additional error code to notify the user that a vm cannot be stopped when not running. * Add additional log_debug statements. diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl.c index 64d82ca847d..d1517d0d26d 100644 ---

[PATCH] add initial set of regress tests for vmd

2017-08-27 Thread Carlos Cardenas
Howdy. Below is patch for some initial parsing tests for vmd: * Memory string parsing (too small, invalid size, and rounding) * Max disk path * Max vm name * Max kernel path * Max NICs More tests to come. One item missing is the proper hook into regress/usr.sbin/Makefile as it was unknown if

Re: [PATCH] add initial set of regress tests for vmd

2017-08-28 Thread Carlos Cardenas
On Sun, Aug 27, 2017 at 11:44 PM, Mike Larkin <mlar...@azathoth.net> wrote: > On Sun, Aug 27, 2017 at 02:24:08PM -0700, Carlos Cardenas wrote: > > Howdy. > > > > Below is patch for some initial parsing tests for vmd: > > * Memory string parsing (too small, inva

[PATCH v2 2/2] VMD: Prevent vmd crashing when stopping a stopped vm

2017-09-04 Thread Carlos Cardenas
* Fix logic handling stopping a VM. Prevents VMD from crashing. * Add additional error code to notify the user that a vm cannot be stopped when not running. * Add additional log_debug statements. diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl.c index 64d82ca847d..5fb7fbfd74c 100644 ---

[PATCH v2 1/2] VMD: Place log_debug statements in key places

2017-09-04 Thread Carlos Cardenas
Add log_debug statements in key places to assist with troubleshooting. diff --git usr.sbin/vmd/config.c usr.sbin/vmd/config.c index 9ea87eb86e8..623a9b9d4f3 100644 --- usr.sbin/vmd/config.c +++ usr.sbin/vmd/config.c @@ -81,14 +81,18 @@ config_purge(struct vmd *env, unsigned int reset)

[PATCH v2 0/2] VMD: Prevent from crashing

2017-09-04 Thread Carlos Cardenas
This patch series contains: 1) Place plenty of log_debug statements in key places to assist with troubleshooting and debugging 2) Add new error code when attempting to stop a non-running vm (used by vmctl) Prevent vmd from crashing with updated logic when stopping a vm Difference

[PATCH 2/3] VMD: Place log_trace statements in key places

2017-09-03 Thread Carlos Cardenas
Add log_trace statements in key places to assist with troubleshooting. diff --git usr.sbin/vmd/config.c usr.sbin/vmd/config.c index 9ea87eb86e8..623a9b9d4f3 100644 --- usr.sbin/vmd/config.c +++ usr.sbin/vmd/config.c @@ -81,14 +81,18 @@ config_purge(struct vmd *env, unsigned int reset)

[PATCH 3/3] VMD: Prevent vmd crashing when stopping a stopped vm

2017-09-03 Thread Carlos Cardenas
* Fix logic handling stopping a VM. Prevents VMD from crashing. * Add additional error code to notify the user that a vm cannot be stopped when not running. * Add additional log_trace statements. diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl.c index 64d82ca847d..5fb7fbfd74c 100644 ---

[PATCH 0/3] VMD: Prevent from crashing

2017-09-03 Thread Carlos Cardenas
This patch series contains: 1) Add log_trace function (enabled when starting vmd with -vvv) 2) Place plenty of log_trace statements in key places to assist with troubleshooting and debugging 3) Add new error code when attempting to stop a non-running vm (used by vmctl) Prevent vmd from

[PATCH 1/3] VMD: Add log_trace log target

2017-09-03 Thread Carlos Cardenas
Add log_trace log target for when verbose > 2 diff --git usr.sbin/vmd/log.c usr.sbin/vmd/log.c index a6b0db9c264..55578f11e40 100644 --- usr.sbin/vmd/log.c +++ usr.sbin/vmd/log.c @@ -40,6 +40,8 @@ void log_info(const char *, ...) __attribute__((__format__ (printf, 1, 2))); void

[PATCH] tests for vmd config parsing

2017-10-10 Thread Carlos Cardenas
This patch adds a set of tests for vmd config parsing. Comments? Ok? diff --git regress/usr.sbin/Makefile regress/usr.sbin/Makefile index 3912e794d4d..f19a656d45e 100644 --- regress/usr.sbin/Makefile +++ regress/usr.sbin/Makefile @@ -12,6 +12,7 @@ SUBDIR += relayd SUBDIR += snmpd SUBDIR +=

[PATCH 1/2] VMD: vioscsi support for cdrom

2017-11-24 Thread Carlos Cardenas
{ "add",ADD }, { "boot", BOOT }, + { "cdrom", CDROM }, { "disable",DISABLE }, { "disk", DISK },

[PATCH 0/2] Add initial support for cdrom using vioscsi

2017-11-24 Thread Carlos Cardenas
This patchset adds the initial support for a vioscsi cdrom. Tests were done using: * large ( > 4GB) and small isos * OpenBSD as the guest (primary testing) * Seabios as the kernel (primary testing) It is expected that there's a possibility of adding more opcodes as the set of testing VMs

[PATCH 2/2] VMD: add regress tests for cdrom keyword

2017-11-24 Thread Carlos Cardenas
Add regress tests for cdrom keyword diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..91e19037b9c 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -2,10 +2,10 @@ VMD ?= /usr/sbin/vmd

[PATCH] scsi style(9) fix for SC_DEBUG{N} macros

2017-11-10 Thread Carlos Cardenas
Patch fixes a broken compilation when using SCSIDEBUG options(4). Resolved with krw@ assistance. Ok? diff --git sys/scsi/scsi_debug.h sys/scsi/scsi_debug.h index bf1519fa36d..56c2d530653 100644 --- sys/scsi/scsi_debug.h +++ sys/scsi/scsi_debug.h @@ -40,15 +40,17 @@ extern int scsidebug_level;

[PATCH] update struct vm_create_params

2017-11-16 Thread Carlos Cardenas
Add cdrom entry to vm_create_params in preparation for cdrom support in vmd. Ok? diff --git sys/arch/amd64/include/vmmvar.h sys/arch/amd64/include/vmmvar.h index 4847fa3defa..0e067f3f49d 100644 --- sys/arch/amd64/include/vmmvar.h +++ sys/arch/amd64/include/vmmvar.h @@ -26,6 +26,7 @@ #define

[PATCH 2/2] VMD: regress tests update for switch configuration

2017-11-02 Thread Carlos Cardenas
Update regression tests to match new switch configuration diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..a337b816acc 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -5,7 +5,8 @@ VMD ?=

[PATCH 1/2] VMD: complete switch configuration overhaul

2017-11-02 Thread Carlos Cardenas
Removed configuration items on switches for: * adding interfaces * setting group * setting rdomain All of these items are now to be set in hostname.if and are queried by vmd for propagation to the vm's vif(s). Update example vm.conf and vm.conf manpage to reflect changes. Comments? Ok? diff

[PATCH 0/2] VMD: complete switch configuration overhaul

2017-11-02 Thread Carlos Cardenas
This patch series finishes up the switch configuration to be handled in hostname.if change. It removes from switch configuration in vm.conf: * adding interfaces (done in /etc/hostname.if) * setting group(s) (done in /etc/hostname.if) * setting rdomain (don in /etc/hostname.if) vmd now queries

[PATCH 1/2 v2] VMD: remove add from switch configuration

2017-11-02 Thread Carlos Cardenas
Remove configuration items on switches for: * adding static interfaces Adding static interfaces are to be set in hostname.if. Changed rule on rdomain: * vm->interface->rdomain takes precedence over sw->rdomain Update examples/vm.conf and vm.conf manpage to reflect changes. Comments? Ok? diff

[PATCH 2/2 v2] VMD: regress tests update for switch configuration

2017-11-02 Thread Carlos Cardenas
Update regression tests to match new switch configuration diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..3bf124aff56 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -5,7 +5,7 @@ VMD ?=

[PATCH 0/2 v2] VMD: switch configuration changes

2017-11-02 Thread Carlos Cardenas
This patch series makes the following changes to switch configuration: * Removes adding static interfaces (done in /etc/hostname.if) * vm->interface->rdomain take precedence over sw->rdomain Updated regression tests to match vm.conf changes. Updated examples/vm.conf to match vm.conf changes.

Re: vmd: add minimal DHCP support

2017-11-02 Thread Carlos Cardenas
On 11/02/17 14:26, Reyk Floeter wrote: Hi, the problem got reported a few times and a similar diff was floating around: vmd's "local interface" implements a simple auto-magic BOOTP server, but udhcpc doesn't support BOOTP, which is the predecessor and a valid subset of DHCP. udhcpc is used by

[PATCH] VMD: remove debug message in proc

2017-11-02 Thread Carlos Cardenas
This debug message has served its duty for finding bugs in shutdown related issues. Ok reyk@ diff --git usr.sbin/vmd/proc.c usr.sbin/vmd/proc.c index afa9b223649..d223d6bcce2 100644 --- usr.sbin/vmd/proc.c +++ usr.sbin/vmd/proc.c @@ -756,8 +756,6 @@ proc_compose_imsg(struct privsep *ps, enum

[PATCH 0/2 v3] VMD: switch configuration changes

2017-11-08 Thread Carlos Cardenas
This patch series makes the following changes to switch configuration: * Removes adding static interfaces (done in /etc/hostname.if) * vm->interface->rdomain take precedence over sw->rdomain Updated regression tests to match vm.conf changes. Updated examples/vm.conf to match vm.conf changes.

[PATCH 1/2 v3] VMD: remove add from switch configuration

2017-11-08 Thread Carlos Cardenas
Remove configuration items on switches for: * adding static interfaces Adding static interfaces are to be set in hostname.if. Changed rule on rdomain: * vm->interface->rdomain takes precedence over sw->rdomain Update examples/vm.conf and vm.conf manpage to reflect changes. Comments? Ok? Ok by

[PATCH 2/2 v3] VMD: regress tests update for switch configuration

2017-11-08 Thread Carlos Cardenas
Update regression tests to match new switch configuration diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..3bf124aff56 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -5,7 +5,7 @@ VMD ?=

Re: monitor mode for iwm(4)

2018-05-23 Thread Carlos Cardenas
Looks good on a 7260. ok ccardenas@ +--+ Carlos On Wed, May 23, 2018 at 12:31:45PM +0200, Stefan Sperling wrote: > This diff implements monitor mode for iwm(4). > > To use it, enable 11n mode, monitor mode, and configure a channel (e.g. 11): > > ifconfig iwm0 mode 11n mediaopt monitor >

[PATCH 2/2] VMD: update regress tests

2017-10-26 Thread Carlos Cardenas
* Update regress tests for new requirement (interface name on switches) * Add new test for interface name on switch diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 16a43066415..68b5c13323a 100644 --- regress/usr.sbin/vmd/config/Makefile +++

[PATCH 1/2] VMD: Require interface to be defined in switches

2017-10-26 Thread Carlos Cardenas
* Require interface name to be defined for switches in vm.conf ** Requires user to create bridge(4) beforehand * Remove code to create bridges on the fly * Add code to ensure bridge really exists * Update manpage switch and example sections diff --git usr.sbin/vmd/parse.y usr.sbin/vmd/parse.y

[PATCH 0/2] VMD: require interface to be defined in switches

2017-10-26 Thread Carlos Cardenas
This patch set changes the behavior of switches in vm.conf by requiring an interface name to be defined (previously, it was optional). This change also removes the responsibility of creating the underlying bridge from vmd to the user (i.e. doas ifconfig bridge0 create). These changes allow vmctl

VMD: add regress tests for cdrom keyword

2018-01-06 Thread Carlos Cardenas
Attached are regress tests for the cdrom keyword. Comments? Ok? +--+ Carlos Index: Makefile === RCS file: /home/los/cvs/src/regress/usr.sbin/vmd/config/Makefile,v retrieving revision 1.3 diff -u -p -r1.3 Makefile --- Makefile11

Re: vmd: allow vm with "cdrom" but no disk

2018-01-10 Thread Carlos Cardenas
On Wed, Jan 10, 2018 at 02:00:57PM +, Stuart Henderson wrote: > Currently we require either "kernel" or "disk", but there may be > some viable use cases where just a CDROM image is given. This adjusts > the check to avoid bailing in that case. > > OK? ok ccardenas > > Index: vmd.c >

Re: VMD: revise check for regular files on disks

2018-01-05 Thread Carlos Cardenas
Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > On Wed, Jan 03 2018, Carlos Cardenas <cardena...@gmail.com> wrote: > > Howdy. > > > > Attached is a patch to address a TOCTOU issue with checking to > > ensure disks are regular files, reported by jca@

VMD: vioscsi - add REPORT_LUNS opcode

2018-01-15 Thread Carlos Cardenas
Howdy. Attached is a patch that includes handling the REPORT_LUNS opcode which is used by SeaBIOS 1.11.x . Comments? Ok? +--+ Carlos Index: vioscsi.c === RCS file: /home/los/cvs/src/usr.sbin/vmd/vioscsi.c,v retrieving revision 1.2

Re: VMD: vioscsi - fix large iso support

2018-01-19 Thread Carlos Cardenas
On Fri, Jan 19, 2018 at 07:35:08PM +1000, David Gwynne wrote: > > > > On 19 Jan 2018, at 4:32 pm, Carlos Cardenas <cardena...@gmail.com> wrote: > > > > Howdy. > > > > Attached is a patch to fix handling images > 4GB support in Linux. I > &

VMD: vioscsi - fix large iso support

2018-01-18 Thread Carlos Cardenas
Howdy. Attached is a patch to fix handling images > 4GB support in Linux. I confused image size vs blocks to determine when to send UINT32_MAX and trigger a READ_CAPACITY_16. Identified by mlarkin@ Comments? Ok? +--+ Carlos Index: vioscsi.c

Re: VMD: vioscsi refactor

2018-01-14 Thread Carlos Cardenas
On Sun, Jan 14, 2018 at 06:08:05PM -0800, Mike Larkin wrote: > On Sun, Jan 14, 2018 at 05:15:54PM -0800, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch that refactors the vioscsi driver (in particular, > > the vioscsi_notifyq function). > > >

VMD: vioscsi refactor

2018-01-14 Thread Carlos Cardenas
Howdy. Attached is a patch that refactors the vioscsi driver (in particular, the vioscsi_notifyq function). Each opcode is now handled in it's respective function (vioscsi_handle_xxx). Which means, it's now easier to add more opcodes and functionality to the driver. (Like supporting the new

VMD: Fix Failure Start

2018-01-24 Thread Carlos Cardenas
Howdy. Attached is a patch to fix the following condition: When attempting to start a VM from vm.conf that fails (can't allocate resources, etc...), do not remove vm from vm list. Reported to bugs@ by mpi@. Comments? Ok? +--+ Carlos Index: config.c

Re: vmd(8) sends global config too late

2018-02-21 Thread Carlos Cardenas
On Wed, Feb 21, 2018 at 11:27:05PM +0100, Martijn van Duren wrote: > Hello tech@, > > When playing around with local prefix in vm.conf(5) I noticed that it > wasn't picked up by my vm. The reason for this was that config_setvm was > called before config_setconfig. Diff below fixes this. > > OK?

update pcidevs for thinkpad e475 devices

2018-02-25 Thread Carlos Cardenas
Howdy. Attached is a patch for pcidevs for thinkpad e475 with an AMD A10-9600P R5 (Carrizo) along with the dmesg output. Items added: * O2 Micro SD/MMC * various AMD 15h/6xh devs * Carrizo video Comments? Ok? +--+ Carlos OpenBSD 6.2-current (GENERIC.MP) #0: Sun Feb 25 15:32:13 PST 2018

vmctl: clarify console error message

2018-02-25 Thread Carlos Cardenas
Attached patch clears up an ambiguous error message when attaching to a console fails. The vm id is not guaranteed to be populated. Comments? Ok? +--+ Carlos Index: vmctl.c === RCS file: /home/los/cvs/src/usr.sbin/vmctl/vmctl.c,v

Re: update pcidevs for thinkpad e475 devices

2018-02-25 Thread Carlos Cardenas
On Mon, Feb 26, 2018 at 03:25:26PM +1100, Jonathan Gray wrote: > On Sun, Feb 25, 2018 at 06:27:11PM -0800, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch for pcidevs for thinkpad e475 with an > > AMD A10-9600P R5 (Carrizo) along with the dmesg output

VMD: revise check for regular files on disks

2018-01-03 Thread Carlos Cardenas
Howdy. Attached is a patch to address a TOCTOU issue with checking to ensure disks are regular files, reported by jca@ . Comments? Ok? +--+ Carlos Index: config.c === RCS file: /home/los/cvs/src/usr.sbin/vmd/config.c,v retrieving

Re: VMD: revise check for regular files on disks

2018-01-04 Thread Carlos Cardenas
Mike Larkin <mlar...@azathoth.net> wrote: > On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch to address a TOCTOU issue with checking to > > ensure disks are regular files, reported by jca@ . > > >

Re: LACP Administrative Knobs

2018-08-10 Thread Carlos Cardenas
On Fri, Aug 10, 2018 at 11:36:01AM +0200, Remi Locherer wrote: > On 2018-08-09 03:53, Carlos Cardenas wrote: > > On Mon, Aug 06, 2018 at 08:18:23PM -0700, Carlos Cardenas wrote: > > > Howdy. > > > > > > Attached is a patch from my work that started at g2k18

Re: LACP Administrative Knobs

2018-08-08 Thread Carlos Cardenas
On Mon, Aug 06, 2018 at 08:18:23PM -0700, Carlos Cardenas wrote: > Howdy. > > Attached is a patch from my work that started at g2k18 on adding > administrative knobs to our LACP driver. > > The driver now has a new ioctl (SIOCxTRUNKOPTS), which for now only > has optio

LACP Administrative Knobs

2018-08-06 Thread Carlos Cardenas
Howdy. Attached is a patch from my work that started at g2k18 on adding administrative knobs to our LACP driver. The driver now has a new ioctl (SIOCxTRUNKOPTS), which for now only has options for LACP: * Mode - Active or Passive (default Active) * Timeout - Fast or Slow (default Slow) * System

Re: vmd send nameserver only once

2018-08-16 Thread Carlos Cardenas
On Wed, Aug 15, 2018 at 03:43:06PM +0200, Martijn van Duren wrote: > When running vmd with a local interface it sends the nameservers twice, > which seems a bit redundant to me and always annoys me when editing > resolv.conf manually inside the vm. > Diff below removes one of the two instances. >

vmctl: add unveil

2018-08-21 Thread Carlos Cardenas
Patch to unveil vmctl. Comments/OK? +--+ Carlos Index: main.c === RCS file: /home/los/cvs/src/usr.sbin/vmctl/main.c,v retrieving revision 1.39 diff -u -p -r1.39 main.c --- main.c 12 Jul 2018 14:53:37 - 1.39 +++ main.c

Re: [PATCH] Pluggable disk formats for vmd (qcow2 preparation)

2018-08-22 Thread Carlos Cardenas
On Sun, Aug 19, 2018 at 11:46:12PM -0700, Ori Bernstein wrote: > One more minor update to this patch: > > - Remove unused enum > - Remove unused function prototype > - Move some qcow2-specific headers into the qcow2 patch. Ori, it's nice seeing good progress on this. I have a

Re: vmd/vmctl: allow to boot cdrom-only VMs

2018-08-22 Thread Carlos Cardenas
On Wed, Aug 22, 2018 at 08:35:23PM +0200, Reyk Floeter wrote: > Hi, > > vmctl doesn't allow to boot VMs with only a CDROM. I see no reason > for it and vmd already allows CDROM-only. > > OK? ok ccardenas

vmd fail fast on unknown disk format

2018-09-10 Thread Carlos Cardenas
Howdy. Attached patch allows vmd to fail fast on unknown disk format along with some minor clean up on logging. Comments? Ok? +--+ Carlos Index: vioqcow2.c === RCS file: /home/los/cvs/src/usr.sbin/vmd/vioqcow2.c,v retrieving

Enabled bnxt on arm64

2018-09-10 Thread Carlos Cardenas
Howdy. Attached is a patch to enable bnxt on arm64. Tested (and running) on mcbin with Broadcom BCM57404 (Dell variant). Comments? Ok? +--+ Carlos Index: GENERIC === RCS file: /home/los/cvs/src/sys/arch/arm64/conf/GENERIC,v

Re: vmd(8) sends global config too late

2018-03-10 Thread Carlos Cardenas
On Fri, Mar 09, 2018 at 07:06:44PM +0100, Martijn van Duren wrote: > Hello Carlos, > > On 02/22/18 03:30, Carlos Cardenas wrote: > > On Wed, Feb 21, 2018 at 11:27:05PM +0100, Martijn van Duren wrote: > >> Hello tech@, > >> > >> When playing around

Re: vmd(4) close vmm parent socket

2018-04-13 Thread Carlos Cardenas
On Fri, Apr 13, 2018 at 11:29:06AM +0200, Martijn van Duren wrote: > Hello tech@, > > Playing with vmd I noticed that a vm process has vmm's socket to the > parent process still open. > > Patch below works for me. > > OK? > > martijn@ Nice find. Ok ccardenas@ +--+ Carlos > > Index: vmm.c

Add AMD 15h/3xh and Kaveri to pcidevs

2018-04-19 Thread Carlos Cardenas
Howdy. This patch adds AMD 15h/3xh (i.e. A8-7670K) and Kaveri devices. dmesg and patch attached. Comments. Ok? +--+ Carlos OpenBSD 6.3-current (GENERIC.MP) #1: Thu Apr 19 11:04:10 PDT 2018 los@rollo.castle:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 16046288896 (15302MB) avail

Re: [vmd] errror -> error

2018-04-25 Thread Carlos Cardenas
On Wed, Apr 25, 2018 at 07:59:52PM +0200, llgx...@gmail.com wrote: > Hi, > > I spotted a couple more typos: Thanks, I'll commit this later this evening. +--+ Carlos > > Index: vioscsi.c > === > RCS file:

Re: Reuse VM ids.

2018-10-24 Thread Carlos Cardenas
On Tue, Oct 23, 2018 at 10:21:08PM -0700, Ori Bernstein wrote: > On Mon, 8 Oct 2018 07:59:15 -0700, Bob Beck wrote: > > > works here and I like it. but probably for after unlock > > > > It's after unlock -- pinging for OKs. > > -- > Ori Bernstein > ok ccardenas@ +--+ Carlos

Re: faq16: remove unneeded vether(4) from bridging example

2018-10-30 Thread Carlos Cardenas
On Tue, Oct 30, 2018 at 08:43:01PM +0100, Klemens Nanni wrote: > Prompted by a question on the internet, the following diff removes the > useless virtual ethernet interface from > "Option 4 - VMs as real hosts on the same network" where guests are > bridged directly into the host network. > >

Re: NMEA: add more gps sensor values (altitude, precision...)

2018-11-03 Thread Carlos Cardenas
On Sat, Nov 03, 2018 at 05:00:47PM +0100, Landry Breuil wrote: > Hi, > > here's a diff to add 5 new sensor values to nmea: altitude, quality, > hdop, vdop & pdop. altitude and quality are provided by GGA messages: > http://aprs.gids.nl/nmea/#gga, quality is either 0 (no fix), 1 (gps fix) > or 2

Re: 6.4 - RX not working on new supported BCM574xx (bnxt)

2018-11-09 Thread Carlos Cardenas
On Fri, Nov 09, 2018 at 04:35:38AM -0700, Luthing wrote: > Hello there, > > I am facing an issue with a Broadcom NIC (specs here > https://www.broadcom.com/products/ethernet-connectivity/controllers/bcm57416/#specifications). > > After some troubleshooting, I am not able to resolve listen ARP

Re: vmd cores

2018-10-03 Thread Carlos Cardenas
On Wed, Oct 03, 2018 at 10:56:28AM -0700, Greg Steuck wrote: > Hi Mike, > > I'm getting core files from vmds. Here's the most recent one. Should I > start collecting more stack traces and sending them to you? > > ci-openbsd$ doas /usr/local/bin/egdb /syzkaller/src/usr.sbin/vmd/obj/vmd >

add vlan and trunk to arm64 RAMDISK

2018-09-27 Thread Carlos Cardenas
Howdy. Attached is a patch to add vlan and trunk to arm64's RAMDISK (parity with amd64). make release'ed and tested, size increase as follows: -rw--- 1 los los12940598 Sep 27 21:01 bsd.rd-patch -rw--- 1 los los12864682 Sep 27 05:41 bsd.rd-snap

update magic file for qcow

2018-10-03 Thread Carlos Cardenas
Attached is patch from netbsd for updated qcow definitions. Comments? Ok? +--+ Carlos Index: msdos === RCS file: /home/los/cvs/src/usr.bin/file/magdir/msdos,v retrieving revision 1.6 diff -u -p -r1.6 msdos --- msdos 29 Jan

Re: add vlan and trunk to arm64 RAMDISK

2018-09-28 Thread Carlos Cardenas
On Fri, Sep 28, 2018 at 10:30:21AM +0200, Mark Kettenis wrote: > > Date: Thu, 27 Sep 2018 21:55:40 -0700 > > From: Carlos Cardenas > > > > Howdy. > > > > Attached is a patch to add vlan and trunk to arm64's RAMDISK (parity > > with amd64). > >

Re: vmd(4) fw_cfg support

2018-12-10 Thread Carlos Cardenas
On Mon, Dec 10, 2018 at 05:52:43PM +0100, Claudio Jeker wrote: > This adds the fw_cfg interface that QEMU is using to pass data to the > BIOS. It implements both IO port access and DMA access. SeaBIOS will use > the latter if available. This should be useful for adding ACPI tables or > SMBIOS

Re: add more bootdevices to vmctl

2018-12-10 Thread Carlos Cardenas
On Mon, Dec 10, 2018 at 11:30:05PM +0100, Claudio Jeker wrote: > On Mon, Dec 10, 2018 at 02:28:48PM -0800, Carlos Cardenas wrote: > > On Mon, Dec 10, 2018 at 10:38:56PM +0100, Reyk Floeter wrote: > > > OK reyk@ > > > > > > Please think about the manpage. &

Re: add more bootdevices to vmctl

2018-12-10 Thread Carlos Cardenas
On Mon, Dec 10, 2018 at 10:38:56PM +0100, Reyk Floeter wrote: > OK reyk@ > > Please think about the manpage. > > > Am 10.12.2018 um 22:35 schrieb Claudio Jeker : > > > > Now that fw_cfg support is in vmd it makes sense to have -B disk > > and -B cdrom. Also error out if the option is not known.

Re: vmd: set dhcp hostname option during netboot

2018-12-10 Thread Carlos Cardenas
On Sat, Dec 08, 2018 at 10:13:47AM +0100, Anton Lindqvist wrote: > Hi, > I've been trying out the new fake netboot feature in vmd. Overall, a > great addition that removed the need for me to run dhcpd/rebound locally > to achieve auto install. It would be convenient if the DHCP lease > included a

Re: change reboot behaviour in vmd

2018-12-07 Thread Carlos Cardenas
On Thu, Dec 06, 2018 at 10:33:24AM +0100, Claudio Jeker wrote: > So doing autoinstall with -B net is great but one thing I was missing is > changing the reboot behaviour of vmd to exit at a guest reboot. > I came up with this minimal diff that does the trick for me. Now maybe it > would be better

Re: vmctl wait

2018-12-03 Thread Carlos Cardenas
On Mon, Dec 03, 2018 at 06:22:14PM +0100, Claudio Jeker wrote: > This adds a feature to vmctl/vmd to wait for a VM to stop. > It is a feature usable in many situation where you wait for a VM to halt > after work is done. This is more or less vmctl stop -w without > sending the termination to the

Re: vmd: add support for local inet6 interfaces

2018-11-20 Thread Carlos Cardenas
On Tue, Nov 20, 2018 at 03:24:18PM +0100, Reyk Floeter wrote: > Hi > > On Fri, Nov 16, 2018 at 05:35:03PM +0100, Reyk Floeter wrote: > > "local interface" (-L) is an amazing feature and I use it every day; > > but it is IPv4-only and now I realized that I need IPv6 too. > > > > The attached diff

Re: vmd: add support for local inet6 interfaces

2018-11-17 Thread Carlos Cardenas
On Fri, Nov 16, 2018 at 05:35:03PM +0100, Reyk Floeter wrote: > Hi, > > "local interface" (-L) is an amazing feature and I use it every day; > but it is IPv4-only and now I realized that I need IPv6 too. > > The attached diff implements IPv6 support for local interfaces. > > A few notes and

Re: vmd: add some NULL checks after {c,m}alloc()

2018-09-14 Thread Carlos Cardenas
On Fri, Sep 14, 2018 at 02:50:18PM +0800, Michael Mikonos wrote: > On Thu, Sep 13, 2018 at 11:10:50PM -0700, Ori Bernstein wrote: > > On Fri, 14 Sep 2018 13:50:40 +0800, Michael Mikonos wrote: > > > > > On Thu, Sep 13, 2018 at 10:08:16PM -0700, Ori Bernstein wrote: > > > > On Thu, 13 Sep 2018

arm64: fix DEBUG_AGINTC

2019-05-08 Thread Carlos Cardenas
Fix kernel compile with DEBUG_AGINTC. OK? +--+ Carlos Index: agintc.c === RCS file: /cvs/src/sys/arch/arm64/dev/agintc.c,v retrieving revision 1.15 diff -u -p -r1.15 agintc.c --- agintc.c7 Dec 2018 21:33:28 - 1.15 +++