Re: ahci.c: intel_3400_4 needs same flags as intel_3400_1 to avoid a 30 sec boot hang

2011-06-23 Thread Holger Mikolon
Hi, this fix (adapted for PCI_PRODUCT_INTEL_82801I_AHCI_3) works on my Dell Studio 1550: ahci0 at pci0 dev 31 function 2 Intel 82801I AHCI rev 0x03: msi, AHCI 1.2 Regards, Holger Hi A similar patch also prevents the hang on my Toshiba NB200 (with PCI_PRODUCT_INTEL_82801GBM_AHCI):

cwm autogroup fix

2010-06-27 Thread Holger Mikolon
Hi tech@, the autogroup code in xenocara/app/cwm/group.c mixes up windowname and windowclass. At least the code doesn't match the man page cwmrc(5). Below is a proposed fix. I hope that alpine doesn't eat the tabs ... Regards, Holger Index: group.c

if_em.c diff

2010-08-07 Thread Holger Mikolon
In if_em.c rev. 1.239 the hw.revision_id assignment was moved to after call to em_set_mac_type(). However, em_set_mac_type() depends on hw.revision_id being set (is used in a switch statement). Possible fix below. Holger ;-se Index: if_em.c

apmd action scripts

2010-12-01 Thread Holger Mikolon
Hi tech@ ! A couple of times now I didn't notice when my laptop battery reached the 0% remaining capacity. I am not aware of any tool in base that could issue a beep or nice sound in case of critical battery. Currently, apmd reports battery and power events to syslog. Below is a patch to let

in6.c: typo in comment

2009-12-21 Thread Holger Mikolon
Index: in6.c === RCS file: /cvs/src/sys/netinet6/in6.c,v retrieving revision 1.82 diff -u in6.c --- in6.c 4 Jun 2009 19:07:21 - 1.82 +++ in6.c 21 Dec 2009 23:22:14 - @@ -273,7 +273,7 @@ *

tiny typo

2009-12-27 Thread Holger Mikolon
Index: frag6.c === RCS file: /cvs/src/sys/netinet6/frag6.c,v retrieving revision 1.27 diff -u frag6.c --- frag6.c 23 Nov 2008 13:30:59 - 1.27 +++ frag6.c 27 Dec 2009 18:30:04 - @@ -640,7 +640,7 @@

Re: initial 11n support for iwn (n, not m)

2015-12-21 Thread Holger Mikolon
Works without issues on my Dell Studio 1555 since a day now. $ ifconfig iwn0 | grep media media: IEEE802.11 autoselect (HT-MCS7 mode 11n) $ dmesg | grep iwn iwn0 at pci2 dev 0 function 0 "Intel WiFi Link 5300" rev 0x00: msi, MIMO 3T3R, MoW, address 00:21:6a:56:2b:36 $ sysctl hw.product

patch for sysctl.8

2016-07-27 Thread Holger Mikolon
See below man page fix - one of the given examples in sysctl.8 doesn't work: # sysctl net.inet.tcp.baddynamic=+748,6000-6999 sysctl: cannot mix +/- with full list Holger Index: sbin/sysctl/sysctl.8 === RCS file:

Re: dhclient/bpf.c

2016-07-22 Thread Holger Mikolon
SETF, ) < 0) error("Can't install packet filter program: %s", > Date: Fri, 22 Jul 2016 00:56:59 > From: Holger Mikolon <hol...@mikolon.com> > To: tech@openbsd.org > Subject: dhclient/bpf.c > > Hi, > > I'm following -current and

dhclient/bpf.c

2016-07-21 Thread Holger Mikolon
Hi, I'm following -current and see a regression in dhclient on my machine: It seems to be related to version 1.41 of sbin/dhclient/bpf.c. Since then dhclient doesn't recognize the recieved lease. tcpdump shows this: 00:21:6a:56:2b:36 ff:ff:ff:ff:ff:ff 342: 192.168.1.7.68 > 255.255.255.255.67:

ocspcheck typos

2017-01-26 Thread Holger Mikolon
Hi, below are two minor typo fixes: s/OSCP/OCSP/ Holger ;-se Index: ocspcheck.8 === RCS file: /cvs/src/usr.sbin/ocspcheck/ocspcheck.8,v retrieving revision 1.5 diff -u -p -u -r1.5 ocspcheck.8 --- ocspcheck.8 24 Jan 2017 12:00:19

diff for ssh/sftp/scp -j

2017-11-25 Thread Holger Mikolon
Hi tech@ at work I can ssh (hence cvs) to public servers only via a ProxyCommand specified in /etc/ssh/ssh_config. However, with the ProxyCommand set I cannot ssh into servers in the internal network. So I end up changing ssh_config depending on my use case over and over. This bothered me enough

Re: diff for ssh/sftp/scp -j

2017-11-26 Thread Holger Mikolon
> Date: Sun, 26 Nov 2017 02:09:13 > From: Sebastian Benoit <be...@openbsd.org> > To: Holger Mikolon <hol...@mikolon.com> > Cc: tech@openbsd.org > Subject: Re: diff for ssh/sftp/scp -j > > Holger Mikolon(hol...@mikolon.com) on 2017.11.25 23:16:54 +0100: > &

/etc/netstart diff

2017-11-08 Thread Holger Mikolon
The veriable $HN_DIR is set in /etc/netstart on line 166 but used only once (line 78). The diff below makes use of $HN_DIR in the other cases where netstart cares of ip address configuration. With below change I can maintain different sets (think "profiles") of hostname.if(5) files in separate

[PATCH] dhclient.c

2018-02-08 Thread Holger Mikolon
Hi tech@, I'm following -current and recently observed that my laptop startup hangs at execution of netstart (when dhclient is called). Apparently, this is because I use the following dhclient.conf (since a couple of OpenBSD releases - so the issue is not in the config): interface "bge0" {

Re: openssl.1 diff

2018-02-28 Thread Holger Mikolon
> > > Index: openssl.1 > > > === > > > RCS file: /cvs/src/usr.bin/openssl/openssl.1,v > > > retrieving revision 1.87 > > > diff -u -r1.87 openssl.1 > > > --- openssl.1 18 Feb 2018 07:43:55 - 1.87 > > > +++ openssl.1

openssl.1 diff

2018-02-27 Thread Holger Mikolon
When playing with "openssl ca" with various validity end dates I could not manage end dates of 2050 or later - until I started reading code and the RFC 5280. As far as I understand it now (and is confirmed by various tests), the openssl parameter "-enddate" expects one of two date/time formats -

Re: openssl.1 diff

2018-02-27 Thread Holger Mikolon
> hi. > > i wonder whether we could more simply just use the date format [YY]YY, > explain the 2050 cutoff, and forget about mentioning asn.1 time > structures. > > or do you think there is a practical reason why the user would need to > know it? i suspect not. Actually the mentioning of the

[DIFF] sys/net/bridgectl.c

2018-12-25 Thread Holger Mikolon
Hi tech@, I tried to understand the output of "ifconfig bridge0 addr", especially the "magic number" after the interface name. Apparently it indicates the aging of the entry (the value is only ever 0 or 1). Eventually I looked at the aging cycle code in bridge_rtage() and wondered why there are 3

libcrypto: typo in comment

2019-03-05 Thread Holger Mikolon
Index: x509_vfy.c === RCS file: /cvs/src/lib/libcrypto/x509/x509_vfy.c,v retrieving revision 1.71 diff -u -p -u -r1.71 x509_vfy.c --- x509_vfy.c 19 Aug 2018 20:19:31 - 1.71 +++ x509_vfy.c 5 Mar 2019 22:19:46 - @@

Re: libcrypto: INTEGER_cmp vs. STRING_cmp

2019-03-06 Thread Holger Mikolon
> Date: Wed, 6 Mar 2019 06:31:17 > From: Theo Buehler (snip) > If you're up for it, it would probably be a good idea to look at the > changes introduced by the commit you mentioned and see what else looks > suspicious and needs fixing. (snip) I went through the files affected by said commit

libcrypto: INTEGER_cmp vs. STRING_cmp

2019-03-05 Thread Holger Mikolon
Hi, while debugging an unusual openssl use case, I tried reading and understanding libcrypto x509 code and came across the comparison of serialNumbers (of type ASN1_INTEGER*) with a string comparison function. Below patch fixes the comparison to use ASN1_INTEGER_cmp. The man page

Re: fix tcpdump localtime caching

2019-05-11 Thread Holger Mikolon
> The variables could have more meaningful names, also the reuse of > variable "gt" looks hackish, but the current code looks correct to me. > > Does the diff below make things clearer? It does. After reading the current code again a few times, it is as well clear. Incredible how I couldn't see

fix tcpdump localtime caching

2019-05-10 Thread Holger Mikolon
The comment above priv_localtime() says, the obtained localtime (from the privileged process) is cached for about one minute. However, since the according if statement compares the wrong variable, the caching doesn't happen. This bug is there since the very first file version (from 15+ years

iwn: fix off-by-one in antenna calibration for iwn5000

2020-07-17 Thread Holger Mikolon
I came across this by reading the code if_iwn.c and DPRINTFs on a kernel with IWN_DEBUG. IWN_LSB() returns an index starting with 1, however the arrays used later on (noise and gain in iwn5000_set_gains()) start with 0. The current code accounts for this difference when setting the antenna gain