Hi,
Jan Stary wrote on Mon, Feb 10, 2020 at 01:13:58PM +0100:
> Why does cron(8) and crontab(1) need to setlocale()?
I looked through the *.c files in /usr/src/usr.sbin/cron/
and found the following locale-dependent functions:
atrun.c: isalpha(3), isupper(3)
cron.c: strtod(3)
Hi Kyle,
Kyle Isom wrote on Mon, Feb 10, 2020 at 07:34:25AM -0800:
> On Sat, Feb 8, 2020, at 14:15, Jason McIntyre wrote:
>> - i'm ok with adding the path to these files to a FILES section
> Done.
I already committed a comprehensive diff doing that in a simpler
way earlier today:
Hi Joerg,
this is absolutely not OK.
How did you test this?
$ doas cat /var/log/weekly.part
/etc/weekly[79]: no closing quote
With that fixed, i agree with the direction of the change.
Yours,
Ingo
Joerg Jung wrote on Sun, Feb 09, 2020 at 12:33:42AM +0100:
> I have a machine with a
Hi Todd,
Todd C. Miller wrote on Sun, Feb 09, 2020 at 07:52:10AM -0700:
> I'm fine with this.
I don't really object, but i'm not sure it is needed either.
It's certainly obvious that command line arguments override defaults.
That's what they always do. It's their whole point, in general.
Hi Jason,
Jason McIntyre wrote on Sun, Feb 09, 2020 at 07:49:10AM +:
> - bgpd.8 refers to /etc/bgpd.conf. that file doesn;t exist by default.
I do not consider that a problem, not even a minor one. ENVIRONMENT
says which variables are inspected if they exist. FILES says which
files are
Hi Marc,
Marc Espie wrote on Sun, Feb 09, 2020 at 02:27:23PM +0100:
> I still think it's a good idea to put it in afterboot(8).
No more objections, with or without jmc@'s tweaks.
It seems clear that enough people want it in that page.
Yours,
Ingo
> Index: afterboot.8
>
Hi,
Theo de Raadt wrote on Sat, Feb 08, 2020 at 04:39:42PM -0700:
> For complicated configurations, the text could explain the reason the
> example is valuable -- for instance
>
> .It Pa /etc/examples/bgpd.conf
> Example configuration file demonstrating IBGP mesh, multiple transits,
> RPKI
Hi,
Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +:
> - i'm ok with adding the path to these files to a FILES section
So, here is a specific patch for bgpf.conf(5) and bgpd(8) such
that we can agree on a general direction for one case where
the example file is particularly
Hi Theo,
Theo de Raadt wrote on Sat, Feb 08, 2020 at 03:33:37PM -0700:
> Jason McIntyre wrote:
>> without getting into a discussion about /etc/examples, in this case i
>> personally see neither the point of the example config file (so trivial
>> as to be questionable) nor the addition to the
Hi Theo,
you have a point, that was a lot of cheap talk and no patch.
I don't aim at changing yacc(1) grammars. I think most parts of
OpenBSD configuration systems already have sane defaults and most
configuration syntaxes are already good with respect to simplicity
and usability. At least
Hi,
i think i said it before: i hate /etc/examples/ and think that the
directory ought to be mostly empty. With the exception of rare
cases like bgpd(8), where you have to provide a lot of information
before you can start it in any meaningful way, i consider a deamon
ill-designed if the
-3,7 +3,7 @@
.\" Copyright (c) 1989, 1990, 1993
.\"The Regents of the University of California. All rights reserved.
.\" Copyright (c) 2003, 2007, 2008, 2014 Jason McIntyre
-.\" Copyright (c) 2010, 2011, 2014-2018 Ingo Schwarze
+.\" Copyright (c) 2010, 20
Hi,
Laurence Tratt wrote on Wed, Feb 05, 2020 at 09:38:28AM +:
> On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote:
>> The parameter
>> .Fa ident
>> -is a string that will be prepended to every message.
>> +points to a string that will be prepende
Hi Andreas,
Andreas Kusalananda wrote on Mon, Feb 03, 2020 at 09:56:22PM +0100:
> Related: https://www.austingroupbugs.net/view.php?id=1244
>
> A proposal seems to have been accepted (if I'm reading it correctly) in
> November of last year to change the wording in POSIX from
>
> The
Hi,
since our manual page doesn't explain the details of how openlog(3)
uses *ident, it seems reasonable for users to conclude that it is
safest to neither free nor modify it.
Then again, given that in our implementation, freeing it may even
pose a security hazard, i might seem friendly to give
Hi Jeremie,
Jeremie Courreges-Anglas wrote on Sat, Feb 01, 2020 at 01:37:32PM +0100:
> On Fri, Jan 31 2020, Ingo Schwarze wrote:
>> ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900:
>>> Reduce scope of a few variables.
>> No, this contradicts OpenBSD
Hi Ted,
Ted Unangst wrote on Fri, Jan 31, 2020 at 05:33:05AM -0500:
> Noticed this in wait.2, though I imagine other occurences abound.
>
> I believe non-null is clearer when refering to a pointer than non-zero, which
> is a bit 80s, and less likely to be mistaken for the value pointed to. This
Hi,
ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900:
> Reduce scope of a few variables.
No, this contradicts OpenBSD coding style.
We want local variables declared up front in functions
such that you can see at one glance which variables exist.
> While here, remove an
Hi Andreas,
Andreas Kusalananda wrote on Wed, Jan 29, 2020 at 06:09:54PM +0100:
> On Wed, Jan 29, 2020 at 05:48:44PM +0100, Ingo Schwarze wrote:
>> +.Dl du -sh * .??* | sort -h
> Why the ".??*"? That would miss single (well, double) letter hidden
> directory nam
Hi Jason,
Jason McIntyre wrote on Wed, Jan 29, 2020 at 04:26:42PM +:
> i don;t think it would be such a bad thing for du to have an example or
> two, so i'm ok with this.
>
> so sth like:
>
> Display a summary of files and folders in the current directory,
> sorted by size:
>
Hi Marc,
Marc Espie wrote on Wed, Jan 15, 2020 at 01:52:37PM +0100:
> So there is some luggage in make that I think we should drop.
>
> Currently, our make "supports" the keywords
> .EXEC, .INVISIBLE, .JOIN, .MADE,
> to the extent that I never touched the code that handles those, but
> frankly
Hi Mark and Klemens,
Mark Kettenis wrote on Thu, Jan 16, 2020 at 02:46:02PM +0100:
> I suppose this is fine since vmctl(8) has the same option.
>
> However the way you change the usage output isn't quite right.
> Maybe "start" should go on a line of its own then.
That sounds reasonable.
> But
Hello Kinichiro-san,
Kinichiro Inoguchi wrote on Sun, Jan 12, 2020 at 05:09:52PM +0900:
> I think both SSL_CTX_get_extra_chain_certs and
> SSL_CTX_get_extra_chain_certs_only should be described here.
I think the text describing what to do with internal pointers
returned from LibreSSL functions
Hi Tim,
Tim Baumgard wrote on Fri, Jan 10, 2020 at 10:16:40AM -0600:
> Thank you for getting these changes in and so quickly. I will no longer
> get as agitated when I'm looking at man pages away from my desk. :)
You are welcome, enjoy. :-)
Also note that the search form often isn't needed: i
Hi Tim,
Tim Baumgard wrote on Fri, Jan 10, 2020 at 08:58:31AM -0600:
> I found out that Apple requires nonstandard [1] attributes to fully
> "fix" this. I don't know if using nonstandard attributes is the right
> way to go, but Apple, Google, and DuckDuckGo are using these attributes
> on their
Hi Tim & Landry,
Landry Breuil wrote on Fri, Jan 10, 2020 at 07:34:47AM +0100:
> On Thu, Jan 09, 2020 at 09:18:25PM -0600, Tim Baumgard wrote:
>> This turns off HTML5 autocomplete for the query input field for
>> man.cgi(8). This essentially makes smartphones and tablets behave
>> the same as
Hi Marc,
Marc Espie wrote on Thu, Jan 02, 2020 at 11:30:35AM +0100:
> And if I use scp enough, I'm also likely to use cp -r by mistake.
>
> Are we likely to actually remove cp -r so the second mistake
> doesn't happen ?
I wouldn't be opposed to that. It has been deprecated since
rev. 1.1 in
Hi Kurt,
Kurt Mosiejczuk wrote on Wed, Jan 01, 2020 at 08:21:04PM -0500:
> cp(1) uses -R for recursive copy. scp(1) uses -r. This diff adds -R
> as an alias for -r to scp(1) for those assuming consistency with cp(1).
even if cp -R and scp -r did the same thing - which, if i understand
tedu@
Hi Theo,
Theo de Raadt wrote on Sat, Dec 21, 2019 at 04:29:24PM -0700:
> Ingo Schwarze wrote:
>> Alexander Nasonov wrote on Fri, Dec 20, 2019 at 08:33:40PM +:
>>> j...@bitminer.ca wrote:
>>>> Clarify that drand48 returns values not including 1.0.
>>>
Hi,
Alexander Nasonov wrote on Fri, Dec 20, 2019 at 08:33:40PM +:
> j...@bitminer.ca wrote:
>> Clarify that drand48 returns values not including 1.0.
> It's not clear from the documentation whether drand48 can generate
> a denormal number. If it can't, you can exclude 0.0 because it's
> a
Hi Jason,
Jason McIntyre wrote on Thu, Dec 05, 2019 at 02:54:20PM +:
> i have reverted it, with a heavy heart.
Do you think i should try and convince the groff folks to always
render .Aq/.Ao/.Ac as ASCII '<' and '>', even in UTF-8, HTML, PDF
output and the like?
Benefits:
+ easier rules
Hi Martin,
Martin Pieuchot wrote on Thu, Dec 05, 2019 at 01:55:00PM +0100:
> Diff below split uvm(9) into the following:
>
> - uvm_init(9)
> - uvm_fault(9)
> - uvm_km_alloc(9)
> - uvm_map(9)
> - uvm_pagealloc(9)
> - uvn_attach(9)
Yes please!
In particular, i like how this reduces usage of .nr
Hi Jason,
Jason McIntyre wrote on Thu, Dec 05, 2019 at 06:54:28AM -0700:
> CVSROOT: /cvs
> Module name: src
> Changes by: j...@cvs.openbsd.org2019/12/05 06:54:28
>
> Modified files:
> usr.sbin/smtpd : smtpd.conf.5
>
> Log message:
> replace "Pf < ... Ns >" with Aq; tidy up
Hi Scott & Jason,
Jason McIntyre wrote on Sat, Nov 02, 2019 at 06:16:49PM +:
> On Sat, Nov 02, 2019 at 12:32:30PM -0500, Scott Cheloha wrote:
>> Cite the paper describing the timing wheel. PDF here:
>>
>> http://www.cs.columbia.edu/~nahum/w6998/papers/ton97-timing-wheels.pdf
>>
>> The
Hi Nick,
Nick Holland wrote on Sun, Oct 27, 2019 at 02:27:46PM -0400:
> In version 1.78 of /etc/daily, the -i flag was added to the df output.
> Apparently, some people run out of inodes.
>
> I only seem to run out of disk space, and too often, my eye skims
> the daily report from a machine,
Hello,
Masanori Ogino wrote on Tue, Sep 17, 2019 at 11:49:17AM +0900:
> Unlike utf8(7), ascii(7) does not contain a reference to its standard.
> This patch just adds the reference.
Thanks for pointing out the omission, i committed the following version.
Yours,
Ingo
CVSROOT:/cvs
Hello Masato-san,
Masato Asou wrote on Tue, Sep 03, 2019 at 02:39:11PM +0900:
> Does not run input command by vi editor with vi mode.
>
> I do the following:
>
> 1. set vi mode.
>$ echo "bind -v" > ~/.editrc
>
> 2. launch /usr/bin/ftp command.
>$ ftp
>
> 3. launch vi editor with ESC
Hi,
The command line handling code in less/cmdbuf.c is very complicated.
>From the top level function cmd_char(), the stack can go down nine levels
before finally reaching the bottom level function cmd_step_common().
One of the functions traversed during that descent is the recursive
function
Hello Mohammadreza,
Mohammadreza Abdollahzadeh wrote on Sun, Sep 01, 2019 at 09:40:16AM +0430:
> Persian is my native language and I think that the major problem that
> all RTL (Right-To-Left) languages like Persian and Arabic currentlly suffer
> from is the lack of BiDi (Bidirectionality)
Hi,
i have to admit that i am neither able to speak nor to write nor
to understand the Arabic language nor the Arabic script, but here
is my current, probably incomplete understanding of what our less(1)
program is trying to do with Arabic ligatures.
If somebody is reading this who is able to
Hi,
the file less/line.c currently contains three copies of code to
step one multibyte character to the left in a char * buffer, and
cleaning up the file less/cmdbuf.c will require similar functionality
in the future. So let's introduce a new function for that purpose.
Keep it as similar as
Hi Florian,
Florian Obser wrote on Fri, Aug 23, 2019 at 02:43:22PM +0200:
> This is not a typo as such, it describes the default. It is a bit
> awkward since it uses the same text for -r and -s. I think we can just
> remove it from -s:
The following seems more straightforward.
I don't feel
Hello Yasuoka-san,
YASUOKA Masahiko wrote on Mon, Aug 05, 2019 at 04:20:41PM +0900:
> This is the diff which fixes the problem by replacing malloc by calloc.
>
> Initialize the line buffer by zero when allocation. This fixes the
> problem a crash happens after the window size change.
Hi Stephen,
Stephen Gregoratto wrote on Fri, Jul 26, 2019 at 01:23:21AM +1000:
> mrsh[1], a cross-platform shell, can use readline in interactive mode.
> It's configure script detects the presence of readline using
> pkg-config(1). Thus, this patch adds a pkg-config file for our readline.
It is
Hi Andras,
please do not cross-post on OpenBSD lists, choose whatever list fits
best. I trimmed bugs@ for this followup.
On Mon, Jun 3, 2019 at 2:12 PM Andras Farkas wrote:
> https://man.openbsd.org/man1/printf.1
> The section on the b format (%b) neglects to mention that for that
> format,
Hello Yasuoka-san,
YASUOKA Masahiko wrote on Thu, Aug 01, 2019 at 08:42:35PM +0900:
> I noticed the upstream NetBSD recently replaced almost all malloc(3)s
> by calloc(3) in libedit.
>
> https://github.com/NetBSD/src/commit/b91b3c48e0edb116bd797586430cb426b575d717
>
> This also fixes the
Hi,
Ricardo Mestre wrote on Wed, Jul 31, 2019 at 07:41:08PM +0100:
> On 11:22 Wed 31 Jul , Theo de Raadt wrote:
>> Ingo Schwarze wrote:
>>> /*
>>> * When porting this program to a platform lacking pledge(2),
>>> * don't forget to at least
Hi,
Theo de Raadt wrote on Wed, Jul 31, 2019 at 09:48:57AM -0600:
> Ricardo Mestre wrote:
>> By now we are already confident that pledge(2) "just works(tm)"
>> and that it can be used to effectively remove filesystem access.
>>
>> That being said, in spamd(8) when I pledge(2)d it the main priv
Hi Philip,
Philip Guenther wrote on Thu, Jul 25, 2019 at 07:21:48PM -0900:
> Hmm: sh(1) and ksh(1) have *nothing* from sections 2 or 3 in their SEE
> ALSO. That doesn't seem like a wrong choice,
Indeed. Jason generally discourages linking from section 1 to
sections 2 and 3, arguing that
Hi Kurt,
Kurt Mosiejczuk wrote on Wed, Jul 24, 2019 at 09:28:26AM -0400:
> On Wed, Jul 24, 2019 at 02:17:47PM +0200, Klemens Nanni wrote:
>> On Wed, Jul 24, 2019 at 01:32:52PM +0200, Gilles Chehade wrote:
>>> Well I think we should remove the reserved keywords as suggested by Kurt
>>> but keep
Hi Gilles,
Gilles Chehade wrote on Tue, Jul 23, 2019 at 08:27:06AM +0200:
> On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote:
>> This is a diff for that changes the example smtpd.conf and smtpd.conf.5
>> so that it no longer uses words that are parts of the configuration
>> syntax
Hi Jesper,
Jesper Wallin wrote on Mon, Jul 22, 2019 at 06:09:03PM +0200:
> On Mon, Jul 22, 2019 at 03:23:16PM +0200, Ingo Schwarze wrote:
>> 3. Jesper, including a patch according to the best of your
>> understanding is always welcome. Even if it turns out to be a
&
Hi,
Bryan Steele wrote on Sun, Jul 21, 2019 at 01:53:49PM -0400:
> On Sat, Jul 20, 2019 at 12:03:03AM +0200, Jesper Wallin wrote:
>> Oh, you're right. A bit ironic that I didn't notice the exec violation
>> due to the fork being permitted now. Thanks for pointing this out!
>> Scrap my old
Hi,
Bryan Steele wrote on Fri, Jul 19, 2019 at 06:14:56PM -0400:
> On Sat, Jul 20, 2019 at 12:03:03AM +0200, Jesper Wallin wrote:
>> On Fri, Jul 19, 2019 at 05:14:03PM -0400, Bryan Steele wrote:
>>> I suspect that in secure/-S mode, the :pre[serve] should either be
>>> disabled, or modified to
Hi George,
George Brown wrote on Sat, Jul 20, 2019 at 01:29:37PM +0100:
> When viewing a file with "less -S" that has lines longer than $COLUMNS
> said lines are simply not wrapped. The contents of said lines is still
> available, one simply needs to scroll horizontally. I would have
> expected
Hi Moritz,
Moritz Buhl wrote on Thu, Jul 18, 2019 at 01:38:49PM +0200:
> bluhm@ wrote:
>> Moritz, can you create a man page ERRORS diff?
> Is the attached diff ok?
Yes, committed with some additional tweaks.
Thank you,
Ingo
CVSROOT:/cvs
Module name:src
Changes by:
Hi Jason,
Jason McIntyre wrote on Mon, Jul 15, 2019 at 09:04:23PM +0100:
> On Mon, Jul 15, 2019 at 09:35:26PM +0200, Ingo Schwarze wrote:
>> Jason McIntyre wrote on Mon, Jul 15, 2019 at 06:43:09PM +0100:
>>> On Mon, Jul 15, 2019 at 04:56:29PM +0200, Klemens Nanni wrote:
>>
Hi,
Jason McIntyre wrote on Mon, Jul 15, 2019 at 06:43:09PM +0100:
> On Mon, Jul 15, 2019 at 04:56:29PM +0200, Klemens Nanni wrote:
>> This tool comes from the textproc/vgrind port so base does not have it,
>> is that the reason we do not reference it?
>>
>> I think it is still useful, so
Hi Jason,
Jason McIntyre wrote on Sun, Jul 07, 2019 at 08:56:43PM +0100:
> this is getting silly - we're mixing talking about how /re/ and ?re?
> work as addresses and as regular expressions in other places. dropping
> the trailing [/?] does not apply to regular expressions everywhere.
Hi Martin,
Martin Pieuchot wrote on Thu, Jul 11, 2019 at 05:18:41PM -0300:
> Index: rtable_walk.9
> ===
> RCS file: rtable_walk.9
> diff -N rtable_walk.9
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ rtable_walk.9 11 Jul 2019
Hi Theo,
Theo de Raadt wrote on Tue, Jul 09, 2019 at 09:23:25AM -0600:
> Klemens Nanni wrote:
>> I think sysupgrade should, if at all, use the same semantics as the
>> installer. That is, something like `sysugprade -S '-* b*'" to upgrade
>> nothing but kernels and base.
>>
>> Such options
Hi Scott,
Scott Cheloha wrote on Sun, Jun 30, 2019 at 06:49:28AM -0500:
> This is cleaner, shorter.
>
> - Remove the intermediate variables and just build the timespec
>directly.
>
> - Use for-loops to consolidate initialization/incrementation of cp
>into one spot in each loop.
>
>
Hi Klemens,
Klemens Nanni wrote on Sun, Jun 30, 2019 at 01:04:17PM +0200:
> On Sat, Jun 22, 2019 at 11:20:10AM -0600, Theo de Raadt wrote:
>> The problem is when I'm on screens that don't have scroll-back, those 9
>> lines have scrolled other information off the top, and then I've had to
>>
Hi Ross,
Ross L Richardson wrote on Sat, Jun 22, 2019 at 02:17:26PM +1000:
> Probably in acceptable form :-)
Committed, thanks.
Ingo
> Index: events.html
> ===
> RCS file: /cvs/www/events.html,v
> retrieving revision 1.1174
>
Hi Ross,
Ross L Richardson wrote on Sat, Jun 22, 2019 at 02:24:46PM +1000:
> The following corresponds with the events.html patch...
Almost...
Committed with the correct YT ID MCVIBwGOwNY instead of gvmGfpMgny4
which is beck@'s unveil(2) talk.
Thanks anyway,
Ingo
> Index: papers.html
>
Hi Ross,
Ross L Richardson wrote on Tue, Jun 18, 2019 at 08:34:41PM +1000:
> The patch below just adds links for the videos currently available.
Committed, thanks.
> Notes:
> - Lines were already > 80 characters, so I haven't folded.
I took the liberty to fold the lines touched. I think that
Hi,
Jason McIntyre wrote on Mon, Jun 17, 2019 at 04:58:26PM +0100:
> On Mon, Jun 17, 2019 at 05:31:16PM +0200, Tim van der Molen wrote:
>> Jason McIntyre (2019-06-17 15:02 +0200):
>>> On Mon, Jun 17, 2019 at 02:47:09PM +0200, Tim van der Molen wrote:
sftp(1) has this:
reput [-Ppr]
Hi Fabio,
Fabio Scotoni wrote on Sat, Jun 08, 2019 at 12:15:57PM +0200:
> This patch fixes a newline in proot.1 preventing LOCKDIR from
> being rendered correctly.
Thanks for reporting. I committed the patch shown below.
> Note that this causes the input line to be very long, which
> seemed
Hi Christian,
Christian Weisgerber wrote on Sun, May 26, 2019 at 01:19:01AM -:
> Not sure what do about "ELF(3)" in elf(3).
Index: elf.3
===
RCS file: /cvs/src/lib/libelf/elf.3,v
retrieving revision 1.2
diff -u -p -r1.2 elf.3
Hi Tracey,
Tracey Emery wrote on Thu, May 23, 2019 at 02:35:10PM -0600:
> Attached is a proposed diff for cp(1). It adds the -l (hard link)
> and -s (symlink) options.
I don't like that. That's exactly what can be done with ln(1) in a
standard way. There is no value in making every tool do
Hi Klemens,
Jason McIntyre wrote on Sun, May 19, 2019 at 08:58:35PM +0100:
> On Sun, May 19, 2019 at 09:52:39PM +0200, Klemens Nanni wrote:
>> On Sun, May 19, 2019 at 07:31:19PM +0100, Jason McIntyre wrote:
>>> no. just use $Mdocdate$ and it gets expanded on commit. just like
>>> when you add
Hi,
Todd C. Miller wrote on Mon, May 20, 2019 at 01:22:21PM -0600:
> On Mon, 20 May 2019 20:01:12 +0200, Juan Francisco Cantero Hurtado wrote:
>> The grep command works with GNU, NetBSD, FreeBSD and BusyBox. It fails
>> on OpenBSD and Solaris 11. I'm suggesting upstream to change the command
>>
Hi,
tleguern wrote on Wed, May 15, 2019 at 03:36:57PM +0100:
> This little patch makes caesar(6) useful at both encrypting and
> decrypting texts by allowing a negative rotation.
Committed, thanks.
> A similar patch was proposed by Dieter Rauschenberger in 2008 with
> little response
Well,
Hi Alexander,
Alexander Bluhm wrote on Wed, May 15, 2019 at 12:01:00AM -0400:
> Regress prints FAILED in the middle of the make output, this is
> hard to watch.
I agree this is a nuisance. I have often wondered whether the
result was "PASS" or "FAIL" after doing longer regression runs
in the
Hi,
after my LC_NUMERIC cleanup for sort(1) went in (thanks to tb@ for
the review), i'd like to adress the rest of locale dependency.
Large amounts of extremely ugly code in sort(1) - many hundreds of
lines - deal with LC_COLLATE, which we don't support now and have
no intention to support in
Hi Stephen,
Stephen Gregoratto wrote on Tue, May 14, 2019 at 01:08:00PM +1000:
> It was mentioned previously that the use of .Sx to refer to a section in
> a different manual page is incorrect. I grepped through the src tree to
> see if there were any cases of this and I found a couple.
Thanks,
Hi Alexander,
Alexander Bluhm wrote on Tue, May 14, 2019 at 02:16:19AM -0400:
> Does anyone use the REGRESS_MAXTIME feature?
Not me.
> I would like to remove it.
>
> - The timeout based on CPU seconds is pretty useless.
> Most hanging tests sleep and do not spin.
> - A timeout cannot be
Hi,
> That one looks correct. OK millert@
Committed, thanks for checking!
While here, i noticed ugly preprocessor macros.
Let's make our future life easier by unifdefing a bit.
When compiling with -g0, there is no object change.
Note that if TM_ZONE is not defined, wcsftime.c doesn't
Hi Todd,
Todd C. Miller wrote on Fri, May 10, 2019 at 02:08:45PM -0600:
> On Fri, 10 May 2019 16:52:35 +0200, Ingo Schwarze wrote:
>> Here is a patch to fix the code.
> OK millert@ for that part.
Thanks, committed.
>> The change to %Z is exactly what Hiltjo sent.
>>
Hi Ted,
Ted Unangst wrote on Thu, May 09, 2019 at 04:16:40PM -0400:
> Ingo Schwarze wrote:
>> I'm not mixing anything else into this diff. The other bugs should
>> be handled separately.
> Works for me. (with additional comment removal)
Thanks for checking, committ
Hi,
Theo de Raadt wrote on Sun, Mar 24, 2019 at 12:48:03PM -0600:
> Hiltjo Posthuma wrote:
>> On Sun, Feb 24, 2019 at 01:11:39PM +0100, Hiltjo Posthuma wrote:
>>> 2. The military/nautical UTC offsets are [...]
broken by design.
>> As discussed previously for point 2 I think it is fine to
Hi,
Theo de Raadt wrote on Mon, Apr 15, 2019 at 12:56:35PM -0600:
> Hiltjo Posthuma wrote:
>> I noticed the man page hostname(7) still references the environment
>> variable HOSTALIASES. This functionality seems to be removed in the
>> commit:
>>
Hi,
let's start tackling the last file which is using stuff from charset.c:
the file cmdbuf.c. The first dirty function is cmd_putstr().
Fortunately, it doesn't actually need to handle non-ASCII characters.
The function cmd_putstr() is called only from command.c.
Almost all callers pass literal
Hi Alexandr,
Alexandr Nedvedicky wrote on Wed, May 08, 2019 at 04:55:57PM +0200:
> below is third iteration of pf.conf.5 manpage.
OK schwarze@
A few final nits inline.
Thank you again for doing this work.
Ingo
> diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5
[...]
> @@
Hi Todd,
Todd C. Miller wrote on Wed, May 08, 2019 at 06:36:30AM -0600:
> On Tue, 07 May 2019 23:32:20 +0200, Ingo Schwarze wrote:
>> Here is basic cleanup of the last major function in line.c, pshift().
> Looks good. OK millert@
Thanks for checking, i will commit the line.c
Hi,
thanks for checking the pappend() and filename.c patches,
those are now committed.
Here is basic cleanup of the last major function in line.c, pshift().
Several minor issues still remain in the file, but those are for later.
This gets rid of two LWCHAR variables, one call to utf_len(),
Hi,
it was noticed years ago that our implementation of sort(1) is very
messy. It contains huge amounts of dead code -- many hundreds of
lines -- and many wrapper functions around standard C library
functions that are in very bad taste and mostly pointless. However,
nobody ever came round to
Hi Andrew,
Andrew Fresh wrote on Sun, May 05, 2019 at 02:44:58PM -0700:
> On Sun, May 05, 2019 at 04:53:05PM +0200, Ingo Schwarze wrote:
>> The first chunk in the patch below seems to be all that is needed.
>> IIRC, we already do a similar thing in pod2man(1).
> This is t
Hi Andrew,
Andrew Fresh wrote on Fri, May 03, 2019 at 06:24:16PM -0700:
> I committed this after moving the waitpid down a few lines, after the
> last read from the filehandle.
Oops. Sorry for missing that, and thanks for committing it,
and for catching that additional issue.
> I will say
Hi Fabio,
Fabio Scotoni wrote on Thu, May 02, 2019 at 03:33:42PM +0200:
> I've taken a stab at improving kqueue.2 formatting.
> Most of the changes are markup fixes.
All your formatting decisions are good.
> I used ".Dv NULL" over plain "null" in accordance with
> lib/libc/stdlib/malloc.3 rev.
Hi Andrew,
Andrew Daugherity wrote on Thu, May 02, 2019 at 10:53:37AM -0500:
> Also, their ToMan patch has a previously-included hunk
> for MANWIDTH=tty,
All that does is suppress a warning message "non-numeric MANWIDTH"
when a user has MANWIDTH=tty in their environment. No idea why any
user
Hi Todd & Andrew,
Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700:
> On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote:
>> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote:
>>> I reported this to FreeBSD ports a couple months ago [2], and they
>>> provided a
Hi Raf,
Raf Czlonka wrote on Tue, Apr 30, 2019 at 12:18:17PM +0100:
> unwind(8) looks like a good candidate for inclusion into
> innovations.html[0].
>
> While there, add "released with ..." to the preceding entry.
>
> [0] https://www.openbsd.org/innovations.html
Thanks, committed.
Ingo
>
Hi Alexandr,
here are a few additional minor remarks...
Alexandr Nedvedicky wrote on Mon, Apr 29, 2019 at 08:59:55PM +0200:
> diff --git a/sbin/pfctl/pfctl.8 b/sbin/pfctl/pfctl.8
> index b7e941991ba..5e2c57f6bc2 100644
> --- a/sbin/pfctl/pfctl.8
> +++ b/sbin/pfctl/pfctl.8
> @@ -198,7 +198,11 @@
Hi,
Jason McIntyre wrote on Mon, Apr 29, 2019 at 09:53:03PM +0100:
> ah, so singular is correct. but it needs an article of some sort. how
> about:
>
> .Xr pfctl 8
> .Fl F Cm Reset
> restores this value to its default.
>
> to be honest, i don;t like it when we Xr like this,
Hi Fabio,
Fabio Scotoni wrote on Wed, Apr 24, 2019 at 06:14:07AM +0200:
> On 4/23/19 9:30 PM, Ingo Schwarze wrote:
>> Fabio Scotoni wrote:
>>> Ingo Schwarze wrote:
>>>> +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>>>> +.\&qu
Hi Fabio,
Fabio Scotoni wrote on Tue, Apr 23, 2019 at 07:46:31PM +0200:
> On 4/23/19 7:15 PM, Ingo Schwarze wrote:
>> Is it correct that you wrote all the text in the file?
>> If so, your name needs to be there.
> It is indeed correct that I wrote all the text i
Hi Fabio,
i applied a very small number of minor tweaks and plan to commit
the patch below tomorrow based on OK jmc@ deraadt@ millert@,
unless i hear objections.
Fabio Scotoni wrote on Tue, Apr 23, 2019 at 05:19:48PM +0200:
> I've adjusted the updated man page (inline) .Dt and .Nm to match
Hi Fabio,
Fabio Scotoni wrote on Tue, Apr 23, 2019 at 01:45:22PM +0200:
> While familiarizing myself with OpenRCS,
> I noticed that there's no rcsfile(5).
> This may be handy for people whose RCS file got corrupted for whatever
> reasons.
> Other *NIXes that ship SCCS tend to have a sccsfile(4),
Hi Alexandr,
Alexandr Nedvedicky wrote on Wed, Apr 17, 2019 at 12:09:10AM +0200:
> my oracle fellow pointed out [1] a PF documentation can be improved
> a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush
> modifier). I've decided to make manpage changes in separate diff as
> I
201 - 300 of 934 matches
Mail list logo