Re: bgpd: pimp imsg pipes

2019-06-17 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.17 22:38:00 +0200: > On Mon, Jun 17, 2019 at 05:00:32PM -0300, Martin Pieuchot wrote: > > On 17/06/19(Mon) 21:43, Claudio Jeker wrote: > > > I noticed that by default the send and recv socket buffers for > > > socketpair(2) is rather low (4k

Re: bgpd async nexthop update loop

2019-06-17 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.17 21:34:30 +0200: > Hi, > > Now that the community rewrite is in here another diff to make bgpd more > awesome. There was one loop left that did not run asynchronous compared to > the main event loop. This loop was in nexthop_update() now a

Re: acme-client(1): allocate EC_KEY only once

2019-06-17 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2019.06.17 17:36:28 +0200: > OK? after reading the manpage, it seems to be ok. > diff --git key.c key.c > index 02c04a03419..b701cf85467 100644 > --- key.c > +++ key.c > @@ -81,11 +81,8 @@ ec_key_create(FILE *f, const char *fname) > EC_KEY

Re: logger(1): add -c option for LOG_CONS

2019-06-16 Thread Sebastian Benoit
Philip Guenther(guent...@gmail.com) on 2019.06.16 12:28:35 -0700: > > Testing something else I needed to call syslog(3) with LOG_CONS. Diff > below adds support to logger(1) for doing that. Option choice is > compatible with NetBSD. > > ok? sounds useful, -c looks like a good choice too.

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-14 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2019.06.14 13:58:58 +0200: > On Fri, Jun 14, 2019 at 09:50:35AM +0200, Renaud Allard wrote: > > > > > > On 6/12/19 2:30 PM, Renaud Allard wrote: > > > > > > > > > On 6/11/19 2:36 PM, Sebastian Benoit w

Re: ospf6d: conf_clear_redist_list

2019-06-09 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.06.08 18:37:39 +0200: > Clear unused redist_list the same way as in ospfd. > > OK? reads good ok benno@ > Remi > > > Index: ospf6d.h > === > RCS file:

Re: acme-client(1): remove A and D flags

2019-06-07 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2019.06.07 19:52:21 +0200: > > > Remove A and D flag, they are superfluous. > One could always use them on the command line and acme-client would do > the right thing. > > IIRC this is a leftover from when we moved to the config file and we > never mopped

Re: [patch] rsync: fix another double close socket descriptor

2019-06-04 Thread Sebastian Benoit
Christian Weisgerber(na...@mips.inka.de) on 2019.06.03 14:39:14 -: > On 2019-06-02, Hiltjo Posthuma wrote: > > > I noticed when using openrsync with a remote and a ssh_prog set (-e option) > > the > > socket is closed twice also. > > Yes, we need to decide whether rsync_socket() should

Re: bgpd fix duplicate network check

2019-05-30 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.05.29 07:25:59 +0200: > The check if a network is already present is slightly wrong since it does > not check the type. I triggered it with: > > network inet static > network 0.0.0.0/0 > > Fix is trivial. > -- > :wq Claudio > > Index: parse.y

Re: ospfd: allow specifying area by number as well as id

2019-05-16 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.05.15 23:15:03 +0200: > On Tue, Apr 30, 2019 at 11:10:37PM +0200, Remi Locherer wrote: > > On Mon, Apr 29, 2019 at 11:10:31AM +0100, Stuart Henderson wrote: > > > On 2019/04/29 11:58, Sebastian Benoit wrote: > > > > D

Re: bgpd refactor UPDATE attribute writer

2019-05-13 Thread Sebastian Benoit
ok with whitespace fixes below Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.05.10 15:34:22 +0200: > This change is from a much larger patch I'm working on. This cleans up > up_generate_attr() from a hardcoded implementation to a loop-switch > construct. This way attributes are always dumped in

Re: switch(4): add support for protected domains

2019-05-09 Thread Sebastian Benoit
Ayaka Koshibe(akosh...@openbsd.org) on 2019.05.09 15:56:49 -0700: > Hi, > > The following adds port protection support to switch(4). The behavior > copies that of bridge(4), where ports can be added to up to 31 protected > domains with a list of IDs using ifconfig(8): > > # ifconfig switch0

Re: relayd: add from/to filter options

2019-05-09 Thread Sebastian Benoit
ok Reyk Floeter(r...@openbsd.org) on 2019.05.09 19:27:31 +0200: > Hi, > > the relayd code already had a few bits for from/to specifiers in > filter rules, but it wasn't finished. I did get occasional requests > if it would be possible to filter based on IPs (much like Allow/Deny > rules

Re: less discriminatory battlestar

2019-05-09 Thread Sebastian Benoit
Ted Unangst(t...@tedunangst.com) on 2019.05.08 23:39:30 -0400: > there are lists of annointed usernames in battlestar. this creates an unfair > playing field! worse, there is a list of "bad" people! and i'm almost one of > them! ok, but i think you need krw@ to ok it too. > -static const char

Re: relayd websocket

2019-05-08 Thread Sebastian Benoit
ok benno@ Reyk Floeter(r...@openbsd.org) on 2019.05.08 20:35:46 +0200: > On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: > > On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > > > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: &

Re: [cje...@diehard.n-r-g.com: Re: bgpd acting up, dropping connected/static network statements]

2019-05-06 Thread Sebastian Benoit
ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.05.04 15:19:47 +0200: > For those people not on misc@. This bgpd diff fixes reload issues with > all non fixed (those not using a prefix but e.g. static or rtlabel). > > On Fri, May 03, 2019 at 09:59:40AM +0200, open...@kene.nu wrote: >

Re: httpd: New log format to log X-Forwarded-{For|Port} headers

2019-05-03 Thread Sebastian Benoit
Theo Buehler(t...@theobuehler.org) on 2019.05.03 04:59:16 +0200: > On Fri, Mar 08, 2019 at 10:52:28AM +0100, Reyk Floeter wrote: > > Hi, > > > > On Mon, Mar 04, 2019 at 02:06:02PM +0100, Bruno Flueckiger wrote: > > > I've completely reworked my patch for httpd(8). The last patch broke the > > >

Re: unveil tcpdrop

2019-05-01 Thread Sebastian Benoit
Ricardo Mestre(ser...@helheim.mooo.com) on 2019.04.30 18:23:57 +0100: > Went through my old sent emails and saw this one still pending on my tree. > > Is this OK? you got an OK bluhm@ on Nov 7th. and since i cant see a problem with it, ok benno@ too ;) > On 13:02 Wed 07 Nov , Ricardo

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread Sebastian Benoit
David Gwynne(da...@gwynne.id.au) on 2019.04.29 19:36:51 +1000: > > > > On 29 Apr 2019, at 4:59 pm, Remi Locherer wrote: > > > > Hi David > > > > On Mon, Apr 29, 2019 at 11:53:27AM +1000, David Gwynne wrote: > >> it's always bothered me that i config areas on a crisco using a number, > >> but

Re: ifconfig: add carriage return when printing transceiver

2019-04-26 Thread Sebastian Benoit
ok Denis Fondras(open...@ledeuns.net) on 2019.04.26 11:46:58 +0200: > When transceiver is unknown (among others), a carriage return is missing. > > Before : > [root@er6p:~] ifconfig cnmac0 sff > cnmac0: flags=8802 mtu 1500 > lladdr 18:e8:29:b6:d4:a9 >

Re: unveil relayd

2019-04-23 Thread Sebastian Benoit
Ricardo Mestre(ser...@helheim.mooo.com) on 2019.04.23 00:42:46 +0100: > Hi, > > I had a patch with pledge(2) for quite a while ago, but my setup is too simple > and cannot test it enough so at least we can have restricted read access to > the > fs in relayd(8)'s main process through unveil(2).

Re: fix link id for p2p interfaces router lsa type 3 link

2019-04-22 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.04.22 11:07:18 +0200: > Hi, > > when ospfd originates LSAs for p2p interfaces it puts the interface > address into the link id field where it should use the network address. > > The issue was reported by Mitchell Krome on tech@ and one part of the >

Re: ifconfig: remove obsolete vlan code

2019-04-14 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2019.04.14 11:35:57 +0100: > I still don't understand why we wouldn't just keep these as aliases to > parent/vnetid.. When parent/vnetid was introduced, the idea was to remove the old ones. Usually we clean things up eventually, otherwise in a year or

Re: sfp module info and diagnostics

2019-04-08 Thread Sebastian Benoit
David Gwynne(da...@gwynne.id.au) on 2019.04.08 19:33:53 +1000: > this updates the ifconfig part of the diff > > it should have the following improvements: > > - actually applying to -current (thanks hrvoje) > - use vis(3) when printing the strings out (thanks deraadt@) > - make the code less

Re: ksh "clear-screen" editing command

2019-04-02 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.04.02 10:52:34 +0200: > On Mon, Apr 01 2019, Jeremie Courreges-Anglas wrote: > > On Mon, Jun 18 2018, "Todd C. Miller" wrote: > >> On Sun, 17 Jun 2018 15:52:34 -0600, "Todd C. Miller" wrote: > >> > >>> On Sun, 17 Jun 2018 17:29:31 +0200, Mark

Re: rsync: add --one-file-system

2019-04-01 Thread Sebastian Benoit
You are missing usage. I think its ok to just add -x to it, not the long option. Otherwise ok benno@ Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2019.04.01 21:36:34 +0200: > Add --one-file-system, which prevents openrsync to cross filesystem > boundaries. Option and behaviour is the same

Re: ksh "clear-screen" editing command

2019-04-01 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.04.01 16:52:34 +0200: > On Mon, Jun 18 2018, "Todd C. Miller" wrote: > > On Sun, 17 Jun 2018 15:52:34 -0600, "Todd C. Miller" wrote: > > > >> On Sun, 17 Jun 2018 17:29:31 +0200, Mark Kettenis wrote: > >> > >> > If folks indeed think that this is a

Re: [PATCH] bgpctl(8): improve user interface for RPKI Origin Validation

2019-04-01 Thread Sebastian Benoit
Job Snijders(j...@openbsd.org) on 2019.04.01 15:42:02 +0200: > Dear all, > > I've consulted with numerous user interface experts, their consistent > advice was to facilitate internalization by provoking simpler, stronger > emotions through the text based interface. > > bgpctl(8) will now provide

bgpd: remove announce ... from the manpage too

2019-03-27 Thread Sebastian Benoit
ok? (benno_announce_doc.diff) diff --git usr.sbin/bgpd/bgpd.conf.5 usr.sbin/bgpd/bgpd.conf.5 index a6f975e935d..86adf872f64 100644 --- usr.sbin/bgpd/bgpd.conf.5 +++ usr.sbin/bgpd/bgpd.conf.5 @@ -737,23 +737,6 @@ There are several neighbor properties: .Bl -tag -width Ds -compact .It Xo .Ic

Re: pfctl should allow administrator to flush _anchors

2019-03-25 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2019.03.24 10:22:25 -0600: > Alexandr Nedvedicky wrote: > > > On Sun, Mar 24, 2019 at 09:51:13AM +0100, Denis Fondras wrote: > > > On Sun, Mar 24, 2019 at 09:24:34AM +0100, Alexandr Nedvedicky wrote: > > > > I think all the above calls for a new standalone

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Sebastian Benoit
ok Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.03.25 14:43:26 +0100: > On Sun, Mar 24 2019, Mitchell Krome wrote: > > On 24/03/2019 7:23 am, Theo de Raadt wrote: > >> Sebastian Benoit wrote: > >> > >>> Mitchell Krome(mitchellkr...@

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Sebastian Benoit
Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was messing around with ospf and got myself into a situation where the > router ID's were the same on two boxes because I only did a reload on > one of them when I changed the loopback IP's. Thats sub optimal i believe... >

Re: bgpd: unbreak route origin validation

2019-03-23 Thread Sebastian Benoit
Denis Fondras(de...@openbsd.org) on 2019.03.22 21:25:32 +0100: > (better when the right diff is sent...) > > ROV has been broken since the configuration reload changes. ok > Index: rde.c > === > RCS file:

Re: ipv6 via ipsec tunnel

2019-03-14 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.03.14 11:53:29 +0100: > On Thu, Mar 14, 2019 at 11:46:10AM +0100, Otto Moerbeek wrote: > > On Thu, Mar 14, 2019 at 10:43:03AM +0100, Claudio Jeker wrote: > > > > > On Thu, Mar 14, 2019 at 10:36:58AM +0100, Otto Moerbeek wrote: > > > > Hi, > > > > >

relayd: virtual not used

2019-03-12 Thread Sebastian Benoit
Am i not seeing something? ok? diff --git usr.sbin/relayd/parse.y usr.sbin/relayd/parse.y index 5be605302ab..6dbed2f282f 100644 --- usr.sbin/relayd/parse.y +++ usr.sbin/relayd/parse.y @@ -173,7 +173,7 @@ typedef struct { %token PREFORK PRIORITY PROTO QUERYSTR REAL REDIRECT RELAY REMOVE

Re: bgpd cleanup configuration handling

2019-03-11 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.03.11 09:11:39 +0100: > This diff is cleaning up a few minor things. It removes the init_conf() > function in session.c and moves it to init_config() where all defaults > should be set. Because of this printconf is a bit changed to only print >

acme-client: remove free() before exits in main()

2019-03-09 Thread Sebastian Benoit
We free a few strings in main(), some others we dont. We should either free() all strings consistently or not free them at all, because it does not hurt to keep them until exit(). The chances of the main() function being repurposed and that leading to memleaks is slim, readability is more

Re: bgpd fix announce inet none

2019-03-09 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.03.09 10:47:46 +0100: > The reshuffle for l3vpn broke announce inet none. > The problem is that it actually clears way too much since the loop is not > correctly skipped. > This should fix configs where people use any kind of 'announce X none' ok

dirname(3) manpage

2019-03-08 Thread Sebastian Benoit
possibly this sentence comes from a time when dirname and basename shared a manpage? basename.3 does not have that sentence. ok? Index: dirname.3 === RCS file: /cvs/src/lib/libc/gen/dirname.3,v retrieving revision 1.22 diff -u -p

Re: relayd websocket

2019-03-06 Thread Sebastian Benoit
Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > Hi! > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > I guess that this would need strcasestr() instead of strcasecmp(), since you > > are looking for the substring "Upgrade" in value. Maybe more is needed if > > we want to be sure

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Sebastian Benoit
joshua stein(j...@openbsd.org) on 2019.03.05 14:03:13 -0600: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with >

Re: ssh man pages: PKCS#11 no longer limited to RSA

2019-03-05 Thread Sebastian Benoit
ok! Christian Weisgerber(na...@mips.inka.de) on 2019.03.05 16:27:22 +0100: > Minor man page tweaks to reflect the fact that PKCS#11 support is > no longer limited to RSA. > > Index: ssh-keygen.1 > === > RCS file:

Re: Patch: relayd support for HTTP 101 Switching Protocols

2019-03-04 Thread Sebastian Benoit
Hi, thanks for bringing this to my attention, i've commited my latest diff. /Benno Daniel Lamando(d...@danopia.net) on 2019.02.28 21:09:35 -0800: > Hi all, > > I noticed that relayd doesn't support Websocket connections. > When a Websocket request is forwarded through relayd, > the handshake

Re: Patch: relayd support for HTTP 101 Switching Protocols

2019-03-04 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.03.04 17:44:08 +0100: > On Sat, Mar 02, 2019 at 12:13:20AM +0100, Sebastian Benoit wrote: > > --- usr.sbin/relayd/parse.y > > +++ usr.sbin/relayd/parse.y > > @@ -176,6 +176,7 @@ typedef struct { > > %token TO ROUT

Re: Patch: relayd support for HTTP 101 Switching Protocols

2019-03-01 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2019.03.02 00:13:20 +0100: > Hi, > > Alexander Bluhm(alexander.bl...@gmx.net) on 2019.03.01 11:40:05 +0100: > > On Fri, Mar 01, 2019 at 09:37:42AM +0100, Sebastian Benoit wrote: > > > i think its ok to add this, and i would like t

Re: Patch: relayd support for HTTP 101 Switching Protocols

2019-03-01 Thread Sebastian Benoit
Hi, Alexander Bluhm(alexander.bl...@gmx.net) on 2019.03.01 11:40:05 +0100: > On Fri, Mar 01, 2019 at 09:37:42AM +0100, Sebastian Benoit wrote: > > i think its ok to add this, and i would like to commit. Maybe we would want > > some filter option to disallow this? > >

Re: Patch: relayd support for HTTP 101 Switching Protocols

2019-03-01 Thread Sebastian Benoit
Hi, i think its ok to add this, and i would like to commit. Maybe we would want some filter option to disallow this? /Benno Daniel Lamando(d...@danopia.net) on 2019.02.28 21:09:35 -0800: > Hi all, > > I noticed that relayd doesn't support Websocket connections. > When a Websocket request is

Re: sysctl sensor error handling

2019-02-21 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.02.21 15:55:42 +0100: > Hi, > > I had an hanging sysctl(8) that was compiled with an obsolete header > file. Struct sensordev was too small, so sysctl(2) failed with > ENOMEM. But the sysctl(8) program continued with unitialized memory. > > #

Re: Patch to www/faq/pf/options.html

2019-02-20 Thread Sebastian Benoit
Jason Tubnor(ja...@tubnor.net) on 2019.02.21 09:13:46 +1100: > Hi, > > In July 2018, henning@ updated src/sys/net/pfvar.h to lift the default > state table limit to 10: > > https://cvsweb.openbsd.org/src/sys/net/pfvar.h?rev=1.480=text/x-cvsweb-markup > > The patch below brings the pf

Re: bgpd, protability and sockaddr sa_len

2019-02-15 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.02.15 15:07:15 +0100: > Another diff to ease portability of bgpd. The sa_len field in struct > sockaddr does not exist on Linux so instead of using it pass a length to > the function (e.g. like bind(2) and connect(2) and do the same when >

Re: bgpd 'depend on' refactor

2019-02-15 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.02.15 12:01:20 +0100: > To make bgpd more portable it is better to move all the link state code > into kroute.c. Especially for something as simple as a single up / down > flag. This is doing that and removes the net/if_types.h include from >

Re: bgpd handle no peers a bit better

2019-02-12 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.02.12 12:09:30 +0100: > For testing I was running bgpd with no neighbors defined. > In that case the peers pointer is NULL and so bgpctl is reporting suddenly > 'no such neighbor' which is confusing for something like 'bgpctl show rib'. > This is

Re: [patch] openrsync blk_flush() fd leak in blk_match()

2019-02-11 Thread Sebastian Benoit
commited, thanks! Hiltjo Posthuma(hil...@codemadness.org) on 2019.02.11 20:55:09 +0100: > Hi, > > I think the fd can leak when blk_flush() fails in blocks.c blk_match(), > because > ERR and ERRX1 does not to terminate. Am I correct? > > I also (hopefully) simplified the logic a bit (set nfd =

Re: spelling correction

2019-02-10 Thread Sebastian Benoit
Peter Hessler(phess...@theapt.org) on 2019.02.10 17:27:09 +0100: > $ grep -c nonexistant /usr/share/dict/words > 0 > $ grep -c nonexistent /usr/share/dict/words > 2 > > OK > > or if someone else wants to give me an OK I can commit this. ok. I have checked that /usr/share/man/nonexistent does

Re: httpd logging X509 cert subject when CA option is used.

2019-02-10 Thread Sebastian Benoit
:48:46 +0100 > Karel Gardas wrote: > > > On Fri, 1 Feb 2019 16:53:14 +0100 > > Sebastian Benoit wrote: > > > > > > + if (clt->clt_remote_user == NULL && > > > > + clt->clt_tls_ctx != NULL && >

Re: httpd logging X509 cert subject when CA option is used.

2019-02-01 Thread Sebastian Benoit
Karel Gardas(gard...@gmail.com) on 2019.02.01 16:28:17 +0100: > > Hello, > > I'd like to have X509 peer's cert subject name logged in some form when > ca option in httpd.conf is used. That is, we do have X509 verified > client accessing web resource. Following patch implements this > behavior

unwind: make dhcp lease parsing more robust

2019-01-30 Thread Sebastian Benoit
I had a box that was installed in 2012 and got a dhcp lease: $ cat /var/db/dhclient.leases.em0 lease { interface "em0"; fixed-address 172.16.1.5; filename "openbsd.0"; option subnet-mask 255.255.255.0; option routers 172.16.1.1; option

unwind: verify forwarder ip addresses

2019-01-30 Thread Sebastian Benoit
check that ips in the forwarder {} sections are indeed ips. ok? diff --git sbin/unwind/uw_parse.y sbin/unwind/uw_parse.y index 6b23fa3972b..82ac1f1b401 100644 --- sbin/unwind/uw_parse.y +++ sbin/unwind/uw_parse.y @@ -24,6 +24,7 @@ %{ #include +#include #include #include @@ -31,6

unwind: cleanup some includes

2019-01-30 Thread Sebastian Benoit
remove not needed includes in uw_parse.y add some to unwind.h clean up some whitespace. ok? (benno_unwind_clean_include_parser.diff) diff --git sbin/unwind/unwind.h sbin/unwind/unwind.h index 887db4b46ab..e2cbdc2d1b0 100644 --- sbin/unwind/unwind.h +++ sbin/unwind/unwind.h @@ -18,6 +18,11 @@

acme-client: add a check in parser

2019-01-29 Thread Sebastian Benoit
add an extra check for existing "api ..." line in the config. move the check of existing "account ..." line from main.c to the parser. The first one actually triggers a null deref later on if you have a broken config. ok? diff --git usr.sbin/acme-client/main.c usr.sbin/acme-client/main.c index

dhclient.conf example for unwind

2019-01-28 Thread Sebastian Benoit
Add the line mentioned in unwind(8) to /etc/examples/dhclient.conf. ok? Index: dhclient.conf === RCS file: /cvs/src/etc/examples/dhclient.conf,v retrieving revision 1.2 diff -u -p -r1.2 dhclient.conf --- dhclient.conf 16 Oct

Re: acme-client: renewal fails

2019-01-22 Thread Sebastian Benoit
Lindner, Thomas 1. (Nokia - DE/Nuremberg)(thomas.1.lind...@nokia.com) on 2019.01.22 18:56:06 +: > Hello, > > I run OpenBSD 6.4 and recently noted that renewals with acme-client fail: > # acme-client -vv lists.dl6tom.de = >

Re: arp timeouts and refresh arp entries before they expire

2019-01-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.01.18 00:11:27 +0100: > On Thu, Jan 17, 2019 at 03:21:58PM -0700, Theo de Raadt wrote: > > - if (la_hold_total < LA_HOLD_TOTAL && la_hold_total < nmbclust / 64) > > { > > + if (la_hold_total < nmbclust / 64) { > > > > I have disagreed

Re: bgpctl neighbor group support

2019-01-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.01.20 12:33:29 +0100: > In many cases it is nice to be able to use a command against a group of > neighbors (e.g. all exchange peers). This diff implements this for > bgpctl neighbor group foo [clear|destroy|down|refresh|up] > bgpctl show

Re: ospf(6)d: fix "redistribute X set type 2 depend on if"

2019-01-14 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.01.10 23:14:15 +0100: > Hi tech, > > in OSPFs external LSAs the type is encoded in the metric field. ospfd and > ospf6d overwrite the type information when "depend on" is used and the > specified interface is down (or in backup state). Below diff fixes

Re: bgpd accouting error

2019-01-05 Thread Sebastian Benoit
ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.01.05 12:37:05 +0100: > Seen on one of my systems: > 92667 as-set elements in 64963 tables using -22.5M of memory > 339029 prefix-set elements using 14.0M of memory > RIB using 401M of memory > Sets using -8.5M of memory > > Now

Re: ospf6d: detect and remove alien routes

2019-01-02 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.01.02 20:00:19 +0100: > Hi tech, > > ospfd detects and removes routes in the kernel routing table with priority > RTP_OSPF (or the configured fib-priority) that have been inserted by another > program. > > Below diff adds the same behaviour to ospf6d.

Re: ospf6d: fib-priority

2018-12-30 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.12.29 17:09:51 +0100: > On Sat, Dec 29, 2018 at 02:06:32PM +0100, Denis Fondras wrote: > > On Fri, Dec 28, 2018 at 09:50:50PM +0100, Remi Locherer wrote: > > > Hi tech, > > > > > > this allows to adjust the priority of the routes that ospf6d inserts >

Re: bgpd mrt bad sizeof

2018-12-30 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.12.29 23:46:18 +0100: > On Sat, Dec 29, 2018 at 08:24:50PM +0100, Sebastian Benoit wrote: > > Hi, > > > > we allocate the wrong size here i think. > > > > ok? > > No, this diff is wrong. Check out the p

bgpd mrt bad sizeof

2018-12-29 Thread Sebastian Benoit
Hi, we allocate the wrong size here i think. ok? (benno_bgpd_mrt.diff) diff --git usr.sbin/bgpd/mrt.c usr.sbin/bgpd/mrt.c index 7c7f2193db3..2502c792c55 100644 --- usr.sbin/bgpd/mrt.c +++ usr.sbin/bgpd/mrt.c @@ -976,43 +976,43 @@ mrt_get(struct mrt_head *c, struct mrt *m) if

Re: pfctl/pf.conf: remove "load anchor" support

2018-12-25 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2018.12.25 18:13:27 +0100: > Klemens Nanni(k...@openbsd.org) on 2018.12.25 17:33:00 +0100: > > From pf.conf(5): > > > > The anchor can also be populated by adding a load anchor rule after the > > anchor rule.

Re: pfctl/pf.conf: remove "load anchor" support

2018-12-25 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2018.12.25 17:33:00 +0100: > From pf.conf(5): > > The anchor can also be populated by adding a load anchor rule after the > anchor rule. When pfctl(8) loads pf.conf, it will also load all the > rules from the file /etc/pf-spam.conf into the

Re: refactor ext-community into filter_community

2018-12-19 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.12.12 14:19:36 +0100: > Time to fold ext-communities into filter_community so that bgpd can match > multiple ext-communities at the same time as well. Additionally this fixes > parsing some of the ext-community types. Rather large diff again so more

Re: relayd and TLS client cert verification

2018-12-14 Thread Sebastian Benoit
Ashe Connor(a...@kivikakk.ee) on 2018.11.26 05:29:45 +: > On Fri, Nov 23, 2018 at 04:41:21PM +0100, Sebastian Benoit wrote: > > > It appears that relayd doesn't support TLS client certificate validation > > > (in the manner that httpd does with "tls cl

Re: pass prefixlen to rtable_mpath_reprio instead of mask

2018-11-23 Thread Sebastian Benoit
ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.11.23 10:48:19 +0100: > This changes rtable_mpath_reprio() to take the prefixlen as argument > instead of the mask. ART is using the prefixlen internally and since we > switched to ART some time ago it no longer makes sense to convert the

Re: relayd and TLS client cert verification

2018-11-23 Thread Sebastian Benoit
Ashe Connor(a...@kivikakk.ee) on 2018.11.23 05:55:55 +: > Hi all, > > It appears that relayd doesn't support TLS client certificate validation > (in the manner that httpd does with "tls client ca [cafile]"). Would > there be interest in a patch that added such support? yes, a patch to

Re: pvclock(4)

2018-11-19 Thread Sebastian Benoit
Reyk Floeter(r...@openbsd.org) on 2018.11.19 13:12:46 +0100: > Feedback? Tests? OKs? test on my incarnation of kvm: OpenBSD 6.4-current (GENERIC.MP) #0: Mon Nov 19 18:32:29 CET 2018 ben...@test.openbsd.fluchtwagenfahrer.de:/sys/arch/amd64/compile/GENERIC.MP real mem = 2097004544 (1999MB)

Re: prevent bgpd from starting when control socket already used

2018-11-12 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2018.11.11 21:55:19 +: > On 2018/11/11 22:45, Job Snijders wrote: > > Shouldnt we already bomb out at the following? > > > > cannot bind to 0.0.0.0:179: Address already in use > > cannot bind to [::]:179: Address already in use > > > > In any regard,

Re: ripd.conf: allow interface without { }

2018-11-11 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.11.11 14:57:05 +0100: > On Sun, Nov 11, 2018 at 09:48:38AM +0100, Claudio Jeker wrote: > > On Sat, Nov 10, 2018 at 09:17:57PM +0100, Remi Locherer wrote: > > > Hi, > > > > > > ripd wants curly braces for interface blocks even if no parameters are > > >

Re: [PATCH] httpd: Write X-Forwarded-For to access.log

2018-11-11 Thread Sebastian Benoit
Bruno Flueckiger(inform...@gmx.net) on 2018.11.11 10:31:34 +0100: > Hi > > When I run httpd(8) behind relayd(8) the access log of httpd contains > the IP address of relayd, but not the IP address of the client. I've > tried to match the logs of relayd(8) and httpd(8) using some scripting > and

Re: bgpd: deny redefinition of default RIBs

2018-11-04 Thread Sebastian Benoit
Denis Fondras(de...@openbsd.org) on 2018.11.04 18:51:39 +0100: > Redefining a default RIB is not desirable. ok benno@ the rde.c bit isnt needed i guess, but it doesnt hurt either. > Index: bgpd.h > === > RCS file:

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.11.01 10:38:41 +0100: > On Wed, Oct 31, 2018 at 11:55:51PM +0100, Sebastian Benoit wrote: > > Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > > > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote:

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.10.31 16:24:49 +0100: > This diff introduces a real Adj-RIB-Out. It is the minimal change to > introduce the new RIB. This removes the update_rib introduced before 6.4 > lock because that is now replaced with a real RIB. > The code used by bgpctl

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 > > lock because

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2018.10.31 22:26:51 +0100: > two full views v4 + v6, the usual testbox: forget this one, the machine is not really doing much with the Adj-RIB-Out.

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 > > lock because

Re: disable fs access on ripd

2018-10-30 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2018.10.30 18:32:15 +0100: > On Tue, Oct 30, 2018 at 10:54:10AM -0600, Theo de Raadt wrote: > > Remi Locherer wrote: > > > > > On Tue, Oct 30, 2018 at 03:20:35PM +, Ricardo Mestre wrote: > > > > Hi, > > > > > > > > After all files are opened ripd(8) can

Re: disable fs access on ripd

2018-10-30 Thread Sebastian Benoit
ok benno@ Ricardo Mestre(ser...@helheim.mooo.com) on 2018.10.30 15:20:35 +: > Hi, > > After all files are opened ripd(8) can have the fs access disabled just before > each process main loop. Its 2 childs already run under chroot, but since they > are still not pledged at least they have no

Re: unveil ospfd's parent proc

2018-10-28 Thread Sebastian Benoit
Ricardo Mestre(ser...@helheim.mooo.com) on 2018.10.28 17:26:24 +: > Correct, and I'd go even further by not unveiling the socket at all. A few > weeks ago I removed the logic of unlinking the socket when the program stops, > for a few daemons, but left untouched the ones that don't have the

Re: fix route-collector mode in bgpd

2018-10-28 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.10.28 15:07:47 +0100: > Since a long while 'route-collector yes' did not work correctly anymore. > The problem is that the RDE is too strict when it comes to handle the > flag. While it is not possible to turn the mode off it has to be possible > to

Re: unveil ospfd's parent proc

2018-10-28 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.10.27 23:25:58 +0200: > On Fri, Oct 26, 2018 at 10:19:01AM -0600, Theo de Raadt wrote: > > Remi Locherer wrote: > > > > > On Fri, Oct 26, 2018 at 06:01:40PM +0200, Florian Obser wrote: > > > > This breaks usage of the "include" keyword. Something that

Re: bgplg: fix show ip bgp out/in

2018-10-24 Thread Sebastian Benoit
ok benno@ Denis Fondras(de...@openbsd.org) on 2018.10.24 08:26:59 +0200: > This may have been broken for quite some time... > > Fix usage message for "show ip bgp in/out" and add missing "neighbor" > argument. > > Index: bgplg.h >

Re: relayd: sync host*() with ntpd

2018-10-21 Thread Sebastian Benoit
Denis Fondras(de...@openbsd.org) on 2018.10.20 18:12:18 +0200: > On Sat, Oct 20, 2018 at 05:30:59PM +0200, Klemens Nanni wrote: > > On Sat, Oct 20, 2018 at 11:57:13AM +0200, Denis Fondras wrote: > > > Sync changes to host_*() from ntpd to relayd. > > This looks good, however I'm not a relayd user.

Re: Remove VFSLCKDEBUG + ASSERT_VP_ISLOCKED (dead code in VFS)

2018-10-21 Thread Sebastian Benoit
Amit Kulkarni(amit.o...@gmail.com) on 2018.10.20 23:54:34 -0500: > Hi, > > After reading VOP_LOOKUP.9 based on recent commit, a try to remove some dead > code in VFS. > https://marc.info/?l=openbsd-cvs=153886730207657=2 > > VFSLCKDEBUG is not defined anywhere. It is misleading to read in >

Re: pkg_add -Dsnap not fetching any updates and packages on -current

2018-10-15 Thread Sebastian Benoit
Neeraj Pal(neerajpa...@gmail.com) on 2018.10.15 10:36:16 +0530: > Hi there, > > Yesterday I installed OpenBSD 6.3-stable then upgraded it to OpenBSD > -current by downloading and copying bsd.rd file into / > Then, after that, I am trying to update the userland but it is > throwing an error but it

Re: ping: fix ID comments

2018-10-14 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2018.10.14 21:23:30 +0200: > These were left behind in > > revision 1.225 > date: 2018/04/11 16:03:58; author: zhuk; state: Exp; lines: +4 -4; > commitid: 3LTLgJehHSWyW63G; > Two fixes in ping: > > 1. Stop telling our PID to

Re: gre(4): handle IPv6 traffic class like IPv4 tos

2018-10-14 Thread Sebastian Benoit
David Gwynne(da...@gwynne.id.au) on 2018.10.14 07:59:21 +1000: > pretty straightforward... > > ok? ok > Index: if_gre.c > === > RCS file: /cvs/src/sys/net/if_gre.c,v > retrieving revision 1.124 > diff -u -p -r1.124 if_gre.c > ---

Re: bgpd fix mrt table dumps

2018-10-12 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.10.12 13:08:15 +0200: > Some time ago I busted mrt dumps. This fixes them again. > > Run the mrt rib_dump_r runner in the poll loop before checking for queued > imsgs. This makes sure that data is produced and pushed out quickly. Only > run the

Re: pf: honor quick on anchor rules

2018-10-08 Thread Sebastian Benoit
Henning Brauer(hb-openbsdt...@ml.bsws.de) on 2018.10.08 13:56:20 +0200: > * Sebastian Benoit [2018-10-08 10:50]: > > The quick in the anchor does not do anything by itself, it should just > > "behave like all the rules inside the anchor had the quick keyword". > >

Re: pf: honor quick on anchor rules

2018-10-08 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2018.10.07 19:41:22 +0200: > On Fri, Oct 05, 2018 at 11:53:08PM +0200, Klemens Nanni wrote: > > On Fri, Oct 05, 2018 at 10:38:48PM +0200, Fabian Mueller-Knapp wrote: > > > If i read man correctly it means "evaluate the rules inside and stop if > > > any rule

<    1   2   3   4   5   6   7   8   >