[patch] gprof(1): fix incompatible pointer types

2015-11-10 Thread Serguey Parkhomovsky
Hi tech@, Some of the comparator functions in gprof(1) have incompatible pointer types and generate compiler warnings. The following diff fixes the problem. Thanks, Serguey Index: arcs.c === RCS file:

Re: [patch] gprof(1): fix incompatible pointer types

2015-11-16 Thread Serguey Parkhomovsky
Hi Philip, Thanks for the detailed explanation on comparison functions for qsort. I have looked through your changes, and have only found one issue: > 2) totalcmp(A,B) and totalcmp(B,A) both return <0 if both A and B have >name==0 and cycleno!=0, and they both return >0 if both A and B have

Upgrading flex?

2015-10-31 Thread Serguey Parkhomovsky
Hi tech@, Is there any interest in having a newer version of flex in base? I recently tried compiling some software with OpenBSD's flex, but had to tweak some code in order to get it to compile with 2.5.4. Of course, I could always install the flex in ports to get a newer version, but I was

[PATCH 2/2] flex 2.5.39

2015-11-07 Thread Serguey Parkhomovsky
This patch includes minor changes to files that wouldn't compile with flex 2.5.39. Index: usr.sbin/config/scan.l === RCS file: /cvs/src/usr.sbin/config/scan.l,v retrieving revision 1.22 diff -u -p -u -r1.22 scan.l ---

Re: [patch] mailwrapper: remove broken fallback code

2015-12-08 Thread Serguey Parkhomovsky
On Tue, Dec 08, 2015 at 10:39:56AM +0100, Sunil Nimmagadda wrote: > > If /etc/mailer.conf doesn't exist, mailwrapper tries to run sendmail, > > giving a confusing error message: > > > > mailwrapper: cannot exec /usr/libexec/sendmail/sendmail: No such > > file or directory > > > > This patch

Re: Index underflow in lex(1)

2015-11-30 Thread Serguey Parkhomovsky
On Thu, Nov 26, 2015 at 01:03:22PM -0500, Michael McConville wrote: > This nondeterministically underflows _sf_top_ix, causing a segfault: > > http://www.sccs.swarthmore.edu/users/16/mmcconv1/dump/crash.l > Looks like _sf_top_ix always underflows whenever there are extra closing

[patch] mailwrapper: remove broken fallback code

2015-12-07 Thread Serguey Parkhomovsky
If /etc/mailer.conf doesn't exist, mailwrapper tries to run sendmail, giving a confusing error message: mailwrapper: cannot exec /usr/libexec/sendmail/sendmail: No such file or directory This patch removes this fallback code. I believe this is cleaner than updating the fallback since we

[patch] mailwrapper(8): remove unneeded argument in addarg

2015-12-14 Thread Serguey Parkhomovsky
This patch removes the copy argument to addarg, which is unneeded. No functional change. Index: mailwrapper.c === RCS file: /cvs/src/usr.sbin/mailwrapper/mailwrapper.c,v retrieving revision 1.21 diff -u -p -r1.21 mailwrapper.c ---

[patch] nlist(3): out of bounds read

2015-12-10 Thread Serguey Parkhomovsky
When dealing with a malformed ELF header, e_shentsize may be 0. This causes an out of bounds read while finding the symbol table on line 141. Found using afl. Index: nlist.c === RCS file: /cvs/src/lib/libc/gen/nlist.c,v retrieving

[patch] smtpctl(8): fix mail queueing

2015-12-22 Thread Serguey Parkhomovsky
Rev 1.141 of smtpctl.c killed mail queueing for me: $ echo "test" | mail -s test sparkhom $ send-mail: unknown option -- i send-mail: unknown option -- t send-mail: no recipients The sendmail option parsing that was added eats the recipient list. I have attached a

[patch] smtpd.conf.5: change examples to use file backend

2015-12-22 Thread Serguey Parkhomovsky
Since the default backend for the aliases table was recently changed from db to file, change the examples in smtpd.conf.5 to use the file backend as well. Index: smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v

Re: [patch] nlist(3): out of bounds read

2015-12-21 Thread Serguey Parkhomovsky
Ping? This is the same sanity check that's done in nm(1)'s ELF handling. On Thu, Dec 10, 2015 at 09:40:11AM -0800, Serguey Parkhomovsky wrote: > When dealing with a malformed ELF header, e_shentsize may be 0. This > causes an out of bounds read while finding the symbol table on li

Re: [patch] mailwrapper(8): remove unneeded argument in addarg

2015-12-21 Thread Serguey Parkhomovsky
Ping? On Mon, Dec 14, 2015 at 09:24:21AM -0800, Serguey Parkhomovsky wrote: > This patch removes the copy argument to addarg, which is unneeded. No > functional change. > > Index: mailwrapper.c > === > RCS file:

Re: [patch] gprof(1): fix incompatible pointer types

2015-11-30 Thread Serguey Parkhomovsky
Ping? On Mon, Nov 16, 2015 at 10:09:29AM -0800, Serguey Parkhomovsky wrote: > Hi Philip, > > Thanks for the detailed explanation on comparison functions for qsort. I > have looked through your changes, and have only found one issue: > > > 2) totalcmp(A,B) and totalcm

Re: [Flex-devel] Index underflow in lex(1)

2015-11-30 Thread Serguey Parkhomovsky
On Mon, Nov 30, 2015 at 06:51:39PM -0500, Will Estes wrote: > Awesome. This applies cleanly albeit with fuzz and makes sense. > > Could you provide Serguey Parkhomovsky's email address so I can use it when > committing the change into git? Happy to help. :-) The address that I'm sending from

Re: [PATCH 1/2] flex 2.5.39

2015-11-20 Thread Serguey Parkhomovsky
On Thu, Nov 19, 2015 at 06:53:45PM -0500, Ted Unangst wrote: > Serguey Parkhomovsky wrote: > > * renamed parse.c, parse.h, scan.c, skel.c with init prefix so compiling > > flex outside of obj by accident wouldn't clobber the bootstrap files > > Do you remember what cau

[patch] fortune(6): fix missing negative in manpage

2015-11-19 Thread Serguey Parkhomovsky
If you are willing to be offended, then quit using -o? It should be the opposite. Index: fortune.6 === RCS file: /cvs/src/games/fortune/fortune/fortune.6,v retrieving revision 1.14 diff -u -p -r1.14 fortune.6 --- fortune.6 25 Sep

59.html: fix typo

2016-03-05 Thread Serguey Parkhomovsky
This fixes a small typo in the release notes for 5.9. Index: 59.html === RCS file: /cvs/www/59.html,v retrieving revision 1.55 diff -u -r1.55 59.html --- 59.html 5 Mar 2016 03:25:49 - 1.55 +++ 59.html 5 Mar 2016