fix a few uvm includes

2011-06-20 Thread Ted Unangst
uvm_extern.h is the header people should be consuming. change a few uvm.h to uvm_extern.h. a couple other sys .h headers included uvm when they don't need to. fix that. fix a few .c files that depended on getting headers from headers. also, simplify and move the bufcache adjustment code

grep -o

2011-06-20 Thread Ted Unangst
this was proposed a while ago, but got sidetracked by some nonstandard option discussion. bringing it back in slightly different form. -o only prints the matching parts of a line, not the entire line. While this is possible using awk, the same could be said of everything grep does. It is

Re: fix a few uvm includes

2011-06-20 Thread Ted Unangst
On Mon, Jun 20, 2011 at 3:43 PM, Miod Vallat m...@online.fr wrote: uvm_extern.h is the header people should be consuming. change a few uvm.h to uvm_extern.h. This is not what, say, kern_fork.c does. If you include uvm.h, you don't need any other uvm_whatever.h, and definitely not

raidframe bzero casts

2011-06-20 Thread Ted Unangst
yeah, i know. no need to cast to char *. also, no need to cast void return of bzero to void. Index: rf_alloclist.c === RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_alloclist.c,v retrieving revision 1.4 diff -u -r1.4

dev/ic bzero casts

2011-06-20 Thread Ted Unangst
there's no need to cast to char *. Index: dc.c === RCS file: /home/tedu/cvs/src/sys/dev/ic/dc.c,v retrieving revision 1.122 diff -u -r1.122 dc.c --- dc.c5 Mar 2011 13:39:26 - 1.122 +++ dc.c20 Jun 2011

more useless casts in dev

2011-06-21 Thread Ted Unangst
more casts, not needed. Index: pci/if_bge.c === RCS file: /home/tedu/cvs/src/sys/dev/pci/if_bge.c,v retrieving revision 1.306 diff -u -r1.306 if_bge.c --- pci/if_bge.c5 Apr 2011 18:01:21 - 1.306 +++ pci/if_bge.c

ansi some files in dev

2011-06-22 Thread Ted Unangst
checked with md5, before line folding caused differences. Index: cninit.c === RCS file: /home/tedu/cvs/src/sys/dev/cninit.c,v retrieving revision 1.10 diff -u -r1.10 cninit.c --- cninit.c26 Jun 2010 23:24:44 - 1.10 +++

Re: fix a few uvm includes

2011-06-22 Thread Ted Unangst
On Mon, 20 Jun 2011, Miod Vallat wrote: uvm_extern.h is the header people should be consuming. change a few uvm.h to uvm_extern.h. This is not what, say, kern_fork.c does. If you include uvm.h, you don't need any other uvm_whatever.h, and definitely not uvm/uvm_extern.h. also,

disable altq functions

2011-06-22 Thread Ted Unangst
Does anybody use altq cdnr or rio? Do they work? Why do we have them, but not enabled? The last function commit to cdnr was over 8 years ago, and says it's still not ready for pf. So that seems really dead. rio may work, but what good are disabled options? RIO is documented in options(4),

clarify mount_ntfs

2011-06-26 Thread Ted Unangst
Remove some words that are not typically found in OpenBSD mount man pages. Write support is simply not going to happen, so we can summarize that situation much more succinctly. (and enforce readonly mounts in the program.) Index: mount_ntfs.8

Re: clarify mount_ntfs

2011-06-27 Thread Ted Unangst
On Mon, 27 Jun 2011, Kenneth R Westerback wrote: On Mon, Jun 27, 2011 at 12:08:15AM -0400, Ted Unangst wrote: Remove some words that are not typically found in OpenBSD mount man pages. Write support is simply not going to happen, so we can summarize that situation much more succinctly

casts in restore

2011-06-27 Thread Ted Unangst
useless and or wrong Index: dirs.c === RCS file: /home/tedu/cvs/src/sbin/restore/dirs.c,v retrieving revision 1.32 diff -u -r1.32 dirs.c --- dirs.c 27 Oct 2009 23:59:34 - 1.32 +++ dirs.c 27 Jun 2011 19:38:06 -

minor mount_ntfs cleanup

2011-06-27 Thread Ted Unangst
The original porting effort left behind some unneeded bits. Index: mount_ntfs.c === RCS file: /cvs/src/sbin/mount_ntfs/mount_ntfs.c,v retrieving revision 1.13 diff -u -r1.13 mount_ntfs.c --- mount_ntfs.c27 Jun 2011 19:47:22

compat 35 can go

2011-06-29 Thread Ted Unangst
not currently built, nothing relies on it. there's some other cleanup in syscalls.master, but that's the next diff. Index: kern/syscalls.master === RCS file: /home/tedu/cvs/src/sys/kern/syscalls.master,v retrieving revision 1.107

hostid 64-bit support

2011-07-01 Thread Ted Unangst
hostid is a long, and that ship has sailed, but still 64-bit archs should not truncate the value. I would like somebody to test this on a 64-bit machine. Even try setting a 64-bit hostid maybe. Index: kern_sysctl.c === RCS file:

Re: pthread_key_delete doesn't reset values

2011-07-02 Thread Ted Unangst
On Mon, Jun 27, 2011, Henry Precheur wrote: According to pthread_key_create(3): Upon key creation, the value NULL is associated with the new key in all active threads. When pthread_key_create reuse an existing key, the old value is still here, which can create problems. The following

fix rthread specific data

2011-07-02 Thread Ted Unangst
Fix is similar to libpthread. Also, use the spinlock and verify that key has a valid value, the implementation is too flexible right now. (I realize now that libpthread should also check for key 0, I'll have to go back and fix that too.) Index: rthread_tls.c

Re: hostid 64-bit support

2011-07-02 Thread Ted Unangst
On Fri, Jul 01, 2011, Ted Unangst wrote: hostid is a long, and that ship has sailed, but still 64-bit archs should not truncate the value. I would like somebody to test this on a 64-bit machine. Even try setting a 64-bit hostid maybe. never mind about this, it's a waste of time.

more pthread_getspecific fixes

2011-07-02 Thread Ted Unangst
1. check that they key is not less than 0. 2. we can simplify several of the if/else chains. Index: uthread/uthread_spec.c === RCS file: /cvs/src/lib/libpthread/uthread/uthread_spec.c,v retrieving revision 1.10 diff -u -r1.10

better bread

2011-07-03 Thread Ted Unangst
bread doesn't need the cred argument, remove it. Index: isofs/cd9660/cd9660_lookup.c === RCS file: /cvs/src/sys/isofs/cd9660/cd9660_lookup.c,v retrieving revision 1.17 diff -u -r1.17 cd9660_lookup.c --- isofs/cd9660/cd9660_lookup.c

Re: kdump: struct stat and struct sockaddr

2011-07-05 Thread Ted Unangst
On Tue, Jul 05, 2011, Otto Moerbeek wrote: Hi, this adds decoding of some interesting structs to kdump. Mostly from FreeBSD, but adapted to our tree. very cool, just a one comment below. error = copyout(mtod(m, caddr_t), SCARG(uap, asa), len); - if (error == 0) + if (error == 0)

fix a pool bug

2011-07-05 Thread Ted Unangst
Remove a broken optimization found by the new pool_chk code. It leaves an empty page in curpage, and this inconsistency slowly spreads until finally one of the other pool checks freaks out. This is only likely to occur if you are running into PR_WANTED frequently. In my case, I was constantly

memcpy len in iked

2011-07-05 Thread Ted Unangst
found by jsg. Index: config.c === RCS file: /home/tedu/cvs/src/sbin/iked/config.c,v retrieving revision 1.12 diff -u -p -r1.12 config.c --- config.c9 May 2011 11:15:18 - 1.12 +++ config.c5 Jul 2011 18:23:17 - @@

Re: memsets in bind

2011-07-05 Thread Ted Unangst
On Tue, Jul 05, 2011, Miod Vallat wrote: found by jsg. Index: lib/isc/hmacsha.c === RCS file: /home/tedu/cvs/src/usr.sbin/bind/lib/isc/hmacsha.c,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 hmacsha.c ---

another pool tweak

2011-07-05 Thread Ted Unangst
move the internal accounting for a page being removed closer to removing it and before freeing it instead of after. also, rmpage updates curpage, so we don't need to do that twice. Index: subr_pool.c === RCS file:

kernel make clean should delete .d

2011-07-05 Thread Ted Unangst
when I run make clean followed by ls, I want to see a fresh canvas, not the scattered leftovers of old builds. Index: Makefile.i386 === RCS file: /home/tedu/cvs/src/sys/arch/i386/conf/Makefile.i386,v retrieving revision 1.80 diff -u

remove predict in pool

2011-07-05 Thread Ted Unangst
We've been less than consistent maintaining usage of __predict in this file. Index: subr_pool.c === RCS file: /home/tedu/cvs/src/sys/kern/subr_pool.c,v retrieving revision 1.107 diff -u -p -r1.107 subr_pool.c --- subr_pool.c 6 Jul

kernel ktracing

2011-07-06 Thread Ted Unangst
Repost of an older diff. This may conflict with otto's diff, we'll sort that out. This isn't useful day to day, but allows a developer to insert tracing points and log data with very low overhead. Suggestions and bug reports welcome. Index: kern/kern_ktrace.c

softraid crypto kdf

2011-07-06 Thread Ted Unangst
It's a bad idea to pass really long user provided lengths to malloc. Index: softraid_crypto.c === RCS file: /home/tedu/cvs/src/sys/dev/softraid_crypto.c,v retrieving revision 1.70 diff -u -p -r1.70 softraid_crypto.c ---

bioctl aoe support

2011-07-06 Thread Ted Unangst
this is what's needed to parse the necessary arguments for AOE. still can't create devices yet, as there have been some kernel changes to metadata handling, but I think this will suffice for userland. Index: bioctl.c === RCS file:

remove a little compat43 leftover

2011-07-07 Thread Ted Unangst
a little while ago, I made some compat43 syscall args non optional. but we don't really need them. removing the compat will allow us to make getpid SMP safe again (web scale!) Index: kern_prot.c === RCS file:

FFS trim support part 1

2011-07-07 Thread Ted Unangst
All the cool kids have new TRIM supporting drives. FFS should support trim too, so that FFS can be cool again. In order to do so, we need to insert a few more operations in the block freeing code path, which this diff does. This diff doesn't actually add trim support, nor is the interface with

Re: move p_emul to process

2011-07-08 Thread Ted Unangst
On Fri, Jul 08, 2011, Paul Irofti wrote: On Fri, Jul 08, 2011 at 01:35:18AM -0400, Ted Unangst wrote: I don't think we're ever going to support different threads of a process running with different emulations, so move p_emul and p_emuldata to struct process. This uses the p__pgid kinfo_proc

another one bites the dust

2011-07-08 Thread Ted Unangst
COMPAT_09 is now extra officially dead. Only one function actually used, moved to linux compat. Index: compat/linux/linux_misc.c === RCS file: /home/tedu/cvs/src/sys/compat/linux/linux_misc.c,v retrieving revision 1.70 diff -u -p

Re: move p_emul to process

2011-07-08 Thread Ted Unangst
On Fri, Jul 08, 2011, Paul Irofti wrote: There is a macro named p_emul, now, so no more variables of that name. See below. Ah, I really don't like this. Its confusing. Don't worry, guenther convinced me we don't need this.

Re: futex implementation in compat

2011-07-08 Thread Ted Unangst
On Sat, Jul 09, 2011, Paul Irofti wrote: Mostly for people asking for my secret diffs. This is the cas diff... +int +tstohz(const struct timespec *ts) +{ +int +itimespecfix(struct timespec *ts) +{ These functions can't go here with these names. That's too generic. Add futex prefixes.

show cache in top

2011-07-08 Thread Ted Unangst
Top said I didn't have much memory free. Where did it all go? Oh, here it is: Memory: Real: 391M/2730M act/tot Free: 178M Cache: 1711M Swap: 0K/4097M Index: machine.c === RCS file: /home/tedu/cvs/src/usr.bin/top/machine.c,v

Re: utrace(2)

2011-07-12 Thread Ted Unangst
On Tue, Jul 12, 2011, Otto Moerbeek wrote: The diff below implements utrace(2), a syscall to introduce data into a ktrace stream from a userland program. Index: sys/kern/kern_ktrace.c === RCS file:

Re: Expose openat(2), etc in libc

2011-07-12 Thread Ted Unangst
On Tue, Jul 12, 2011, Christian Weisgerber wrote: Matthew Dempsky matt...@dempsky.org wrote: Now that all of the new AT_* flags are supported, it's okay to expose openat(2), etc. in libc. ... revealing that the gnulib configure tests think that our fchownat() is broken. fix: Index:

Re: grep \words\

2011-07-17 Thread Ted Unangst
On Sun, Jul 17, 2011, Matthias Kilian wrote: Then those ports should be fixed. There seem to be more GNUisms in (recent?) GNU grep that are picked up by projects, for example the use of \s and \S in pxltoraster (currently a disabled part of ghostscript, for which I've got a diff and waiting

Re: grep \words\

2011-07-18 Thread Ted Unangst
On Mon, Jul 18, 2011, Marc Espie wrote: If we start adding this to some tools, it would start to make sense to support it at the source. Namely, conversion functions are a bit annoying, and it's always possible to fuck it up. Plus, same code twice = same bugs. Is there anything preventing

wrong return type for sys_wait4

2011-07-25 Thread Ted Unangst
harmless, but wrong. Index: kern_exit.c === RCS file: /home/tedu/cvs/src/sys/kern/kern_exit.c,v retrieving revision 1.102 diff -u -p -r1.102 kern_exit.c --- kern_exit.c 6 Jul 2011 21:41:37 - 1.102 +++ kern_exit.c 25 Jul

Re: kdump: resolve sysctl numbers

2011-07-27 Thread Ted Unangst
On Wed, Jul 27, 2011, Otto Moerbeek wrote: +#define SETNAME(name) do { names = (name); limit = nitems(name); } while (0) userland is not supposed to use nitems I think? But it keeps sneaking in because the kernel headers don't protect it.

Re: [Patch] ffclose() in mg

2011-07-31 Thread Ted Unangst
On Sun, Jul 31, 2011, Loganaden Velvindron wrote: This diff uses void for ffclose() when return values are not needed. Additionally, Instead of ignoring the output it also returns error codes when fclose() fails in ffclose(). This seems silly. ffclose should probably be void itself. I

Re: hide kernel threads in ps?

2011-08-31 Thread Ted Unangst
On Wed, Aug 31, 2011, Uwe Stuehler wrote: Help! My Nagios checks failed. :) This fixes them by hiding kernel threads from ps output. I'd also like to show the main process ID in the PID column as otherwise there is no way of knowing which threads belong together. Likely struct kinfo_proc

Re: A few kernel-related questions: UVM, W^X and PAE

2011-10-02 Thread Ted Unangst
On Fri, Sep 30, 2011, Vadim Zhukov wrote: Hello all. After some talks on opennet.ru I dived into the sys/uvm/ and other places, having a few more or less tech-nical questions raised now. Can anybody answer them? Very nice. 1. amap_share_protect() in sys/uvm/uvm_amap.c is totally unused,

Re: [panc...@nopcode.org: License]

2011-10-14 Thread Ted Unangst
On Fri, Oct 14, 2011, Edd Barrett wrote: Hi guys, A port I am maintaining uses our file(1) implementation. A debian dev who was packaging this thinks he has spotted a license bug. Said I would forward his mail onto OpenBSD, so here it is. Discuss. What COPYRIGHT file? There's no such

Re: [panc...@nopcode.org: License]

2011-10-14 Thread Ted Unangst
On Fri, Oct 14, 2011, Christiano F. Haesbaert wrote: On 14 October 2011 17:19, Ted Unangst t...@tedunangst.com wrote: On Fri, Oct 14, 2011, Edd Barrett wrote: Hi guys, A port I am maintaining uses our file(1) implementation. A debian dev who was packaging this thinks he has spotted a license

Re: [panc...@nopcode.org: License]

2011-10-27 Thread Ted Unangst
On Thu, Oct 27, 2011, pancake wrote: The problem I'm facing now is in libr/util/regex which is the imported version of OpenBSD's lib/libc/regex. The issue was reported by the Debian maintainer of r2 and it's a license issue.

Re: mmap diff for patch(1)

2011-11-11 Thread Ted Unangst
I don't see any reason to even open the file if the size is 0. On Fri, Nov 11, 2011, Michael W. Bombardieri wrote: Sorry, let me try that again... Forgot to clean up file descriptor ifd. Index: inp.c === RCS file:

Re: Compile time assertions

2011-11-14 Thread Ted Unangst
On Mon, Nov 14, 2011, Steffen Daode Nurpmeso wrote: Hi, my dhclient.c patch was very wrong. And it (falsely) removed a runtime check of some struct member size. But this very hunk (while wrong) led me to a question. Since saving even some bytes in shell scripts counts so much, i wonder

Re: Expose some scheduler statistics to userland via sysctl

2011-11-17 Thread Ted Unangst
On Fri, Nov 18, 2011, Thordur Bjornsson wrote: On 2011 Nov 17 (Thu) at 21:18:24 -0200 (-0200), Christiano F. Haesbaert wrote: Moving this to tech@ Hi, I was studying the scheduler code after watching tedu's talk, I'd like to expose this statistics to userland so that I can try playing with

Re: Expose some scheduler statistics to userland via sysctl

2011-11-17 Thread Ted Unangst
On Fri, Nov 18, 2011, Christiano F. Haesbaert wrote: What is the line between sysctl vs globals ? Checking again, it makes sense having the sysctl IMHO. We have something very similar in kern.forkstat, kern.nchstats, and the protocol stats. I think those stats are useful for a sysadmin to

Re: du close handle before exiting

2011-12-31 Thread Ted Unangst
why? On Sat, Dec 31, 2011, Loganaden Velvindron wrote: In du.c, fts_close() is missing before exit. fts_close() may also return -1 on hitting an error. Index: usr.bin/du/du.c === RCS file: /cvs/src/usr.bin/du/du.c,v

allow more glob stats

2012-01-18 Thread Ted Unangst
The glob limit to only allow 128 stat calls seems rather low. We allow 16384 readdir calls, by comparison. We also have a limit on the amount of memory used, which effectively caps stats too. Why 2048? I have 1435 files in /usr/local/bin and I think even a limited glob should be able to list

Re: NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Ted Unangst
On Thu, Jan 26, 2012, Jan Klemkow wrote: I miss some std libc functions in OpenBSD. So, I deside to implement a few of them by myself. This is a diff for getdelim(3) and getline(3). it is too late for this release, I'd advise sending again once 5.1 is released. At the moment this patch

Re: -not for find(1)

2012-02-27 Thread Ted Unangst
On Mon, Feb 27, 2012, Steffen Daode Nurpmeso wrote: this patch adds the -not operator to find(1). I personally always found -not easier to use due to shell escaping, but today may laziness has bitten back. And it's just one more non-POSIX-compliant option. This makes a lot of sense to me, but

Re: -not for find(1)

2012-02-27 Thread Ted Unangst
On Mon, Feb 27, 2012, Ingo Schwarze wrote: The argument that -not is easier to type than \! doesn't convince me at all; at best, it's a matter of taste. And even if it were a bit easier, that wouldn't excuse interface bloat. It's only a little easier to type, but it is more consistent. find

Re: Sysctl(3) man page

2012-03-09 Thread Ted Unangst
On Fri, Mar 09, 2012, Donald Allen wrote: OpenBSD's pride in its man pages is justified, for the most part. But having recently decided to come back to OpenBSD after a long hiatus, I found myself completely baffled by how to get battery status information via sysctl(3). I use suckless.org's

Re: posix_spawn(3)

2012-03-09 Thread Ted Unangst
On Fri, Mar 09, 2012, Frank Denis wrote: Hi Matthew, Good catch. I'm going to fix that. On Mar 9, 2012, at 10:54 AM, Matthew Dempsky matt...@dempsky.org wrote: I briefly looked over this code, and the diff looks good to me except for one subtle FreeBSDism: memory writes done in a

fix file sysctl

2012-03-12 Thread Ted Unangst
run fstat -u root. observe non root files. I don't know why you would pass -1 here to get all files when there's better ways to do that, but just the same, I won't change that. Index: kern_sysctl.c === RCS file:

Re: one usb_mem pool per host controller

2012-03-13 Thread Ted Unangst
On Wed, Mar 14, 2012, Tobias Ulmer wrote: I have a couple of machines with an EHCI controller that refuses to work with memory above 2G, causing all kinds of trouble. This diff enables setting a bus_dma boundary and allows me to make off-site backups again. Due to the bus_dma pool being

Re: md5: new -C flag to skip non-existent files in checklist

2012-03-15 Thread Ted Unangst
On Mon, Mar 12, 2012, Stuart Henderson wrote: On 2012/03/12 00:49, Daniel C. Sinclair wrote: What do you think of making cksum output: (SHA256) nonexistant.txt: MISSING instead of FAILED and the extra output to stderr saying No such file or directory? I think this would be useful (in

Re: KERNEL MODIFICATION in config(8)

2012-03-21 Thread Ted Unangst
On Wed, Mar 21, 2012, Alexey E. Suslikov wrote: The kernel is too old (pre OpenBSD 2.6) and cannot support all of the functionality needed by the -e option. Isn't that OpenBSD 2.6-beta pmap arch config example somewhat exotic and outdated? So about too old pre OpenBSD 2.6 kernel comment.

Re: [cwm patch 1/6] Implement shell-like tab-completion for menus

2012-04-08 Thread Ted Unangst
On Fri, Jan 20, 2012, Alexander Polakov wrote: I'm not sure how you got your clock so wrong, but I almost missed all your mails because they did not show up where I expected them.

Re: move systrace to the process struct

2012-04-12 Thread Ted Unangst
On Thu, Apr 12, 2012, Paul Irofti wrote: Requested by guenther, okay? It's harder than that. With this change, the first thread to exit will un-systrace the entire process.

Re: move systrace to the process struct

2012-04-12 Thread Ted Unangst
On Thu, Apr 12, 2012, Paul Irofti wrote: On Thu, Apr 12, 2012 at 12:44:55PM -0400, Ted Unangst wrote: On Thu, Apr 12, 2012, Paul Irofti wrote: Requested by guenther, okay? It's harder than that. With this change, the first thread to exit will un-systrace the entire process. Right... I

Re: path correction

2012-04-14 Thread Ted Unangst
On Fri, Apr 13, 2012, Peter J. Philipp wrote: This probably saw some debate in the past, which I did not see. On my IRC channel it is concensus that the path given out is dangerous. Why? They whole point of putting home first is so you can override system software. If there are dangerous

Re: ramdisk overflow during make release with -stable on amd64

2012-06-06 Thread Ted Unangst
On Wed, Jun 06, 2012 at 12:26, Peter Bisroev wrote: Hi All! I am having an issue making a 5.1 stable release using a patch branch synced on 2012-06-05 using: cvs -q -d$CVSROOT checkout -P -rOPENBSD_5_1 src ports xenocara. amd64/ramdiskA kernel seems to be too big to fit on the default

Re: vmyield diff (2) please test

2012-06-14 Thread Ted Unangst
. If neither is true, we don't preempt (thus not calling mpswitch(), not releasing the kernel lock etc etc). For this reason it doesn't work well on SMP. Unfortunately the above conditions may be false if for ex 2 processes are spread out across 2 cpus: the cpu with the biglock will not

Re: vmyield diff (2) please test

2012-06-15 Thread Ted Unangst
On Fri, Jun 15, 2012 at 18:07, Ariane van der Steldt wrote: I'm wondering if if (curcpu()-ci_schedstate.spc_schedflags SPCF_SHOULDYIELD) preempt(NULL); shouldn't be a special function in kern_sched, I suspect its useful for more parts of the kernel (although I wouldn't know which ones). In

minor opencvs patch

2012-06-21 Thread Ted Unangst
While trying to dig into another problem, I decided that there's entirely too much reallocing taking place when parsing rcsnums. There's also some confusion over just how big an rcsnum we expect to see. In one place we 64 to mean the things between the dots, and in another we use 64 to mean

man page standards

2012-06-21 Thread Ted Unangst
some of our man pages are a little heavy with the posix macros, which expand into a wall of text, especially when repeated multiple times. here's a diff that cleans up a few offenders, by mostly trimming out what i think is excess verbiage. more man pages are likely afflicted as well, this is a

Re: icmp error mcopy diff

2012-06-22 Thread Ted Unangst
On Fri, Jun 22, 2012 at 04:58, Brad Smith wrote: On Thu, Mar 01, 2012 at 03:28:13PM +0100, Mike Belopuhov wrote: This is a well-known from thib and dlg originally with a length fix from yours truly, that marginally doubles througput (from 300kpps to 500-600kpps on selected hardware). The

Re: man page standards

2012-06-22 Thread Ted Unangst
On Fri, Jun 22, 2012 at 07:58, Jason McIntyre wrote: On Thu, Jun 21, 2012 at 11:31:34PM -0400, Ted Unangst wrote: some of our man pages are a little heavy with the posix macros, which expand into a wall of text, especially when repeated multiple times. here's a diff that cleans up a few

nicer iostat

2012-06-23 Thread Ted Unangst
the columns get all raggedy when I run iostat because my overpowered three year old laptop just has too much speed. make the columns a little wider. I can still fit tty, sd{0,1,2}, and cpu on an 80 column display. Index: iostat.c

Re: unsigned = 0 comparisons

2012-06-25 Thread Ted Unangst
On Mon, Jun 25, 2012 at 20:54, Arto Jonsson wrote: Hi, a couple of = 0 comparisons on unsigned integers. These refer to Bitrig commits 171e1f9d and 72337965 respectively. This is a little meta, but if we're going to start pulling changes from bitrig, I don't think commit 171e1f9d is the

Re: setsockopt SO_SNDBUF and limit (No buffer space available)

2012-06-26 Thread Ted Unangst
On Tue, Jun 26, 2012 at 20:13, Philip Guenther wrote: Sorry, in this case, the C code *is* the documentation. If you're reading the kernel code then you should check things in the rough order: 2) does the C standard specify the behavior? Nitpick! This may be misleading in some cases,

Re: tinyscheme + mg

2012-06-28 Thread Ted Unangst
On Thu, Jun 28, 2012 at 15:07, Jérémie Courrèges-Anglas wrote: If the licence seems ok, why not just pull a complete tinyscheme instance, that would then be usable from other applications? (tinyscheme doesn't seem to be in ports). I don't want to be in the business of adding 20 different

Re: tinyscheme + mg

2012-06-28 Thread Ted Unangst
On Thu, Jun 28, 2012 at 15:21, Jasper Lievisse Adriaanse wrote: On Thu, Jun 28, 2012 at 08:35:18AM -0400, Kjell Wooding wrote: 2. I should point out that all of mg (other than theo.c) is currently PUBLIC DOMAIN, not merely BSD, so this change is significant, license-wise. Please be pedantic

Re: tinyscheme + mg

2012-06-28 Thread Ted Unangst
On Thu, Jun 28, 2012 at 08:09, Bob Beck wrote: I'd be a lot happier voicing an opinion in support of something like this if I also saw diffs and interest in *using* them to extend functionality later or replace some things easier to do with scheme to make the code simpler - something kjell

Re: tinyscheme + mg

2012-06-28 Thread Ted Unangst
On Thu, Jun 28, 2012 at 15:07, Jérémie Courrèges-Anglas wrote: Hi, + +typedef void *HMODULE; +typedef void (*FARPROC)(); +#define SUN_DL Hmmm. +#include dlfcn.h + +#if defined(SUN_DL) Huh? 8) old code is old. :) looks like jasper un-ifdeffed some win32 code, leaving a few

Re: Bridge rules

2012-06-29 Thread Ted Unangst
On Fri, Jun 29, 2012 at 15:08, sven falempin wrote: Code Rewriting (nothing new) and asking I seriously wonder if 'that' is good in sys/net/if_bridge.c if (flags == 0) goto return_action; Because if i m not wrong it could be rewritten this way (diff) That does look clearer to me.

Re: bug fix: 'opencvs log' mangles RCS branch number

2012-06-30 Thread Ted Unangst
On Sun, Jul 01, 2012 at 08:28, Michael W. Bombardieri wrote: Hi tech, I noticed this OpenCVS bug a couple of months ago but I've only just written this report. Comparing cvs log output between GNU CVS 1.11.1p1 and OpenCVS... - mwb: 1.1.1 + mwb: 1.1.0.1 OpenCVS mangles the

Re: bug fix: 'opencvs log' mangles RCS branch number

2012-07-01 Thread Ted Unangst
On Sun, Jul 01, 2012 at 11:17, Tobias Stoeckmann wrote: Your patch breaks this compatibility for every branch except the initial one. GNU CVS is not consistent about its behavior in many ways. Ha! This is the same bug I was looking into last week. I wasn't sure in what circumstances adding

Re: Virtio drivers for OpenBSD

2012-07-11 Thread Ted Unangst
On Wed, Jul 11, 2012 at 14:07, Stefan Fritsch wrote: Hi, I have been working on porting NetBSD's virtio drivers to OpenBSD. I am not finished yet, but in order to prevent duplicate work, I thought I'd publish the current state (attached as diff to OpenBSD 5.1). It adds a virtio block

Re: ar9003.c uninitialized variable

2012-07-14 Thread Ted Unangst
On Sat, Jul 14, 2012 at 15:31, David Hill wrote: Hello, in file sys/dev/ic/ar9003.c, function ar9003_compute_predistortion(), there is an uninitialized variable, y4. It is then used: scale = ((y4 / SCALE_LOG) * (L + 1) - (y2 / SCALE_LOG) * sumy2) * SCALE_LOG; Email to damien and reyk

rm -P

2012-07-23 Thread Ted Unangst
I bring more love to everybody's favorite rm option. So I'm wiping a file from a fairly slow USB stick and it's taking forever. I don't really give a shit about some guy with a quantum tachyon microscope taking it apart, I just want the files to be gone enough that a simple undelete tool won't

sqlite secure delete

2012-07-24 Thread Ted Unangst
I think this option should be available. Index: Makefile === RCS file: /cvs/src/lib/libsqlite3/Makefile,v retrieving revision 1.8 diff -u -p -r1.8 Makefile --- Makefile22 Jun 2012 17:52:34 - 1.8 +++ Makefile24 Jul

vmt ref vmwh

2012-07-24 Thread Ted Unangst
The vmwh package is very handy, but somewhat hard to discover. Can we add a little hint to the man page for vmt? Index: vmt.4 === RCS file: /cvs/src/share/man/man4/vmt.4,v retrieving revision 1.5 diff -u -p -r1.5 vmt.4 --- vmt.4

Re: sqlite secure delete

2012-07-25 Thread Ted Unangst
On Wed, Jul 25, 2012 at 09:34, Landry Breuil wrote: On Tue, Jul 24, 2012 at 08:20:55PM -0400, Ted Unangst wrote: I think this option should be available. Note sure it's a good idea, since it's a non-negligible performance loss for all sqlite users if you change it to default to true

dhclient ignore

2012-07-26 Thread Ted Unangst
I have a system with two network interfaces (em0 and em1), running dhcp on both. Both dhcp servers provide me with a nameserver, but only one of them works (I can't fix this). There is a config file for dhclient I can use, but it only supports the supersede keyword. I don't want to statically

Re: dhclient ignore

2012-07-27 Thread Ted Unangst
On Fri, Jul 27, 2012 at 00:42, Brynet wrote: On Thu, Jul 26, 2012 at 10:09:28PM -0400, Ted Unangst wrote: I have a system with two network interfaces (em0 and em1), running dhcp on both. Both dhcp servers provide me with a nameserver, but only one of them works (I can't fix

fmt_scaled for netstat

2012-08-09 Thread Ted Unangst
Add an -h flag to print human numbers. Easier for me to read. Index: Makefile === RCS file: /cvs/src/usr.bin/netstat/Makefile,v retrieving revision 1.20 diff -u -p -r1.20 Makefile --- Makefile9 Jul 2011 00:45:40 - 1.20

Re: CoDel

2012-08-14 Thread Ted Unangst
On Tue, Aug 14, 2012 at 09:42, Simon Perreault wrote: - CoDel needs to timestamp each packet when it gets queued. - I added a new member in struct pkthdr for this. Is this ok? - I end up calling microuptime() for each packet. Is this ok? You want to use getmicrouptime, it's faster. See the

acpihpet quality

2012-08-15 Thread Ted Unangst
The acpihpet timer is, in my testing, lots better than the acpitimer. Faster to read and more precise. They should not have the same quality value. Double acpihpet. Index: acpihpet.c === RCS file: /cvs/src/sys/dev/acpi/acpihpet.c,v

have timecounter, will stay

2012-08-15 Thread Ted Unangst
timecounters are here to stay, at least for those archs where timecounters have arrived. remove some now useless guards. Index: arch/i386/pci/geodesc.c === RCS file: /cvs/src/sys/arch/i386/pci/geodesc.c,v retrieving revision 1.9

Re: acpihpet quality

2012-08-15 Thread Ted Unangst
On Wed, Aug 15, 2012 at 17:21, Mark Kettenis wrote: Date: Wed, 15 Aug 2012 11:02:43 -0400 From: Ted Unangst t...@tedunangst.com The acpihpet timer is, in my testing, lots better than the acpitimer. Faster to read and more precise. They should not have the same quality value. Double

Re: rdtsc timecounter

2012-08-16 Thread Ted Unangst
On Thu, Aug 16, 2012 at 14:00, Mark Kettenis wrote: A whitelist-based approach is probably best. What you could do is attach this timecounter on platforms that are not whitelisted as well, but give it a fairly low tc_quality if it isn't whitelisted. That way people can still select the TSC

Re: Argument list too long while copying

2012-08-23 Thread Ted Unangst
On Thu, Aug 23, 2012 at 21:17, Jan Stary wrote: On current/amd64 I created a MSDOS filesystem on a CF card inserted into a USB card reader # cp * /mnt cp: /mnt/202.the-hounds-of-baskerville.avi: Argument list too long cp: /mnt/201.a-scandal-in-belgravia.avi: Argument list too long cp:

<    1   2   3   4   5   6   7   8   9   10   >