httpd: fix default request body size

2022-09-02 Thread YASUOKA Masahiko
Hello, For HTTP request body, if neither "Content-Encoding: chunked" nor "Content-Length" is specified, it should mean body length is 0. In RFC 9112 Section 6.3, 7.: | 7. If this is a request message and none of the above are true, then | the message body length is zero (no message body

divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, The diff is to fix a problem in a complex setup. Normal setup of divert-reply for TCP connection: client --- relayd --- server - transparently forward TCP connections - divert-reply is configured the outbound connection to the server - so that the PF state is removed when the PCB is

Re: tcp timer mutex

2022-09-03 Thread YASUOKA Masahiko
ok yasuoka On Fri, 2 Sep 2022 14:44:29 +0200 Alexander Bluhm wrote: > + now = READ_ONCE(tcp_now); > + > /* >* Determine length of data that should be transmitted, >* and flags that will be used. > @@ -228,7 +231,7 @@ tcp_output(struct tcpcb *tp) >* to send, then

Re: diff: b64decode(1) for long line

2022-08-30 Thread YASUOKA Masahiko
On Tue, 30 Aug 2022 14:09:40 +0200 Theo Buehler wrote: > On Tue, Aug 30, 2022 at 01:01:47PM +0200, YASUOKA Masahiko wrote: >> On Tue, 30 Aug 2022 11:56:53 +0200 >> Claudio Jeker wrote: >> > On Tue, Aug 30, 2022 at 11:18:01AM +0200, YASUOKA Masahiko wrote: >> >

diff: fix panic in pf_state_export()

2022-09-20 Thread YASUOKA Masahiko
Hello, My colleague hit the following kernel panic when he is doing "psctl -ss" repeatedly by a script during a performance test. uvm_fault(0xfd811b869110, 0x10, 0, 1) -> e kernel: page fault trap, code=0 Stopped at pf_state_export+0x42: movq0x10(%rax),%rcx TIDPID

Re: hostctl: Change from fixed length to variable length

2022-10-11 Thread YASUOKA Masahiko
Hello, On Wed, 05 Oct 2022 13:37:35 +0900 (JST) Masato Asou wrote: > From: "Theo de Raadt" > Date: Tue, 04 Oct 2022 21:58:13 -0600 >> Userland may not ask the kernel to allocate such a huge object. The >> kernel address space is quite small. First off, huge allocations will >> fail. >> >>

Re: divert-reply: keep pf state after pcb is dropped

2022-09-02 Thread YASUOKA Masahiko
Hi, On Fri, 2 Sep 2022 17:40:13 +0200 Alexander Bluhm wrote: > On Fri, Sep 02, 2022 at 03:04:34PM +0200, YASUOKA Masahiko wrote: >> The diff is to fix a problem in a complex setup. >> >> Normal setup of divert-reply for TCP connection: >> >>

Re: hostctl: Change from fixed length to variable length

2022-12-26 Thread YASUOKA Masahiko
Hi, Sorry for separating emails. On Tue, 27 Dec 2022 11:58:34 +0900 (JST) YASUOKA Masahiko wrote: >> @@ -1115,12 +1116,19 @@ xs_kvop(void *xsc, int op, char *key, char *value, >> size_t valuelen) >> } >> /* FALLTHROUGH */ >> case X

Re: hostctl: Change from fixed length to variable length

2022-12-26 Thread YASUOKA Masahiko
Hi, On Mon, 26 Dec 2022 13:37:45 +0900 (JST) Masato Asou wrote: > My new patch is not returned value length from ioctl() system call > when read the KEY's value. > > The hostctl command allocate 4k bytes memory for store the value. Then > read the value by ioctl() system call. If ioctl()

Re: hostctl: Change from fixed length to variable length

2023-01-05 Thread YASUOKA Masahiko
ok yasuoka On Fri, 06 Jan 2023 15:14:05 +0900 (JST) Masato Asou wrote: > I have updated my patch. > > From: YASUOKA Masahiko > Date: Tue, 27 Dec 2022 11:58:34 +0900 (JST) > >> After diff, it doesn't use PAGE_SIZE any more. And VMware software >> limit see

Re: efi(4): Support for EFI variables and tables in the kernel

2023-01-07 Thread YASUOKA Masahiko
Hi, On Wed, 04 Jan 2023 21:52:35 +0100 Mark Kettenis wrote: > Dear Sergii and others, > > I've committed the change that passes the ESRT from the bootloader to > the kernel. So now it is time to add the interfaces to the kernel to > read it. And add the interfaces to manipulate EFI variables.

pvbus: pass M_ZERO properly

2022-12-07 Thread YASUOKA Masahiko
This is obvious. M_ZERO must be for 3rd argument. ok? Index: sys/dev/pv/pvbus.c === RCS file: /cvs/src/sys/dev/pv/pvbus.c,v retrieving revision 1.25 diff -u -p -r1.25 pvbus.c --- sys/dev/pv/pvbus.c 25 Aug 2022 17:38:16 -

Re: vmt is not closed

2022-12-20 Thread YASUOKA Masahiko
Yes, my previous commit was wrong. Calling vm_rpc_close() was missing. Thank you for finding. ok yasuoka On Tue, 13 Dec 2022 19:26:05 +0900 (JST) Masato Asou wrote: > From: Masato Asou > Date: Tue, 13 Dec 2022 18:26:22 +0900 (JST) > > Delete #define VMT_DEBUG > ok? > -- > ASOU Masato > >>

Re: hostctl: Change from fixed length to variable length

2022-11-18 Thread YASUOKA Masahiko
On Sat, 19 Nov 2022 14:41:18 +0900 (JST) YASUOKA Masahiko wrote: > On Wed, 12 Oct 2022 07:58:20 +0900 (JST) > YASUOKA Masahiko wrote: >> On Wed, 05 Oct 2022 13:37:35 +0900 (JST) >> Masato Asou wrote: >>> From: "Theo de Raadt" >>> Date: Tue, 04 Oct

Re: hostctl: Change from fixed length to variable length

2022-11-18 Thread YASUOKA Masahiko
On Wed, 12 Oct 2022 07:58:20 +0900 (JST) YASUOKA Masahiko wrote: > On Wed, 05 Oct 2022 13:37:35 +0900 (JST) > Masato Asou wrote: >> From: "Theo de Raadt" >> Date: Tue, 04 Oct 2022 21:58:13 -0600 >>> Userland may not ask the kernel to allocate such a huge

Re: pppx(4): decrease netlock pressure in pppxioctl()

2022-11-19 Thread YASUOKA Masahiko
It doesn't seem to have a problem. Sorry for my delay. ok yasuoka On Wed, 9 Nov 2022 13:24:21 +0300 Vitaliy Makkoveev wrote: > ping... > > On Tue, Nov 01, 2022 at 03:16:02PM +0300, Vitaliy Makkoveev wrote: >> Push netlock down to pppx_add_session(). The 'pppx_if' structure has >> the

Re: npppd(8): remove "pipex" option

2023-01-30 Thread YASUOKA Masahiko
Hi, On Sun, 29 Jan 2023 14:35:05 +0300 Vitaliy Makkoveev wrote: > While switchind pppx(4) and pppac(4) from selwakeup() to KNOTE(9), I > found npppd(8) doesn't create pppx interface with "pipex no" in > npppd.conf, but successfully connects the client. So packets don't flow. > However, the

Re: npppd(8): remove "pipex" option

2023-02-01 Thread YASUOKA Masahiko
Hi, On Wed, 1 Feb 2023 21:32:29 +0300 Vitaliy Makkoveev wrote: > On Wed, Feb 01, 2023 at 09:00:13PM +0900, YASUOKA Masahiko wrote: >> ... >> >> But I think we should keep the part since it is needed when adding a >> tunneling protocol which is not supported

diff: www/faq/pf/carp.html

2023-04-17 Thread YASUOKA Masahiko
Hi, carpdemote is increased/decreased when the link state of the carpdev is down/up. This behavior is not related to net.inet.carp.preempt since "carpdemote" is introduced. But the faq still says the "net.inet.carp.preempt" variable enables it. I'd like to commit the diff. ok or any comment

Re: atactl(8): 'readattr' subcommand quits silently.

2023-04-26 Thread YASUOKA Masahiko
Hello, On Wed, 26 Apr 2023 16:32:28 +0900 Yuichiro NAITO wrote: > These 2 revisions of 'attr_val' and 'attr_thr' are different on this > disk. > The comment says that it's wrong vendor implementation but I can see > 'smartctl' shows the attributes as follows. NetBSD's atactl doesn't > see these

Re: npppd(8): remove "pipex" option

2023-02-01 Thread YASUOKA Masahiko
I'm sorry for sending 2 mails. First one was a draft. Please read second one.

Re: npppd(8): remove "pipex" option

2023-02-01 Thread YASUOKA Masahiko
Hi On Tue, 31 Jan 2023 11:30:43 +0300 Vitaliy Makkoveev wrote: > On Tue, Jan 31, 2023 at 01:40:19PM +0900, YASUOKA Masahiko wrote: >> Hi, >> >> On Sun, 29 Jan 2023 14:35:05 +0300 >> Vitaliy Makkoveev wrote: >> > While switchind pppx(4) and pppac(4) from s

Re: npppd(8): remove "pipex" option

2023-02-01 Thread YASUOKA Masahiko
On Tue, 31 Jan 2023 11:30:43 +0300 Vitaliy Makkoveev wrote: > On Tue, Jan 31, 2023 at 01:40:19PM +0900, YASUOKA Masahiko wrote: >> Hi, >> >> On Sun, 29 Jan 2023 14:35:05 +0300 >> Vitaliy Makkoveev wrote: >> > While switchind pppx(4) and pppac(4) from selwake

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, Does using 64 bit for timer in tcpcb require this? ok? Index: sys/netinet/tcp.h === RCS file: /cvs/src/sys/netinet/tcp.h,v retrieving revision 1.24 diff -u -p -r1.24 tcp.h --- sys/netinet/tcp.h 19 May 2023 01:04:39 -

Use u_long for struct mstat

2023-07-07 Thread YASUOKA Masahiko
Hi, I'd like to expand the counters in struct mbstat from u_short to u_long. When I was debugging a mbuf leak, I saw the result of "netstat -m" --- 28647 mbufs in use: 28551 mbufs allocated to data 4 mbufs allocated to packet headers 92 mbufs allocated to socket names and

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, This netstat diff is already needed to avoid compiler warnings since it uses struct tcpcb directly. ok? Index: usr.bin/netstat/inet.c === RCS file: /cvs/src/usr.bin/netstat/inet.c,v retrieving revision 1.177 diff -u -p -r1.177

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 10:43:21 +0200 Claudio Jeker wrote: >> @@ -411,7 +412,7 @@ tcp_stats_display(unsigned long long tot >> P(tcpi, rcv_up, "%u") >> P(tcpi, rcv_wscale, "%hhu") >> P(tcpi, rfbuf_cnt, "%u") >> -P(tcpi,

make mstat smaller

2023-07-08 Thread YASUOKA Masahiko
Hi, The diff makes the mbstat be the same size which is actually used. Also revert the previous that the mbstat is located on the stack. ok? Index: sys/kern/kern_sysctl.c === RCS file: /cvs/src/sys/kern/kern_sysctl.c,v retrieving

assign wsdisplay0 to the glass console

2023-07-19 Thread YASUOKA Masahiko
Hi, I noticed that the keyboard doesn't work for RAMDISK kernel on HP DL20 Gen10. The kernel assigns wsdisplay0 for VGA and wsdisplay1 for efifb. But actually the glass console is efieb but it doesn't have any keyboard assigned because the keyboard is assigned to wsdisplay0. GENERIC kernel

make mbstat smaller (was Re: make mstat smaller)

2023-07-09 Thread YASUOKA Masahiko
On Sat, 08 Jul 2023 21:58:30 +0300 (EEST) YASUOKA Masahiko wrote: > The diff makes the mbstat be the same size which is actually used. > Also revert the previous that the mbstat is located on the stack. The userland program also needed to be changed. ok? Index: sys/kern/kern_sy

Re: tcp timer wrap around, use 64 bit

2023-07-06 Thread YASUOKA Masahiko
On Tue, 4 Jul 2023 12:14:47 +0300 Alexander Bluhm wrote: > After changing tcp now tick to milliseconds, it will wrap around > after 49 days of uptime. That may be a problem in some places of > our stack. Better use a 64 bit counter. I agree since we sometimes hit a problem from where we could

Re: acpi: move acpiioctl to x86

2023-07-08 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 11:56:42 +0200 Tobias Heider wrote: > On Wed, Jul 05, 2023 at 04:53:33PM +0200, Tobias Heider wrote: >> I am planning to restructure the APM/sleep APIs to make it easier to suspend >> from more places like as a suspend keyboard shortcut. >> >> The acpiioctl handler is x86

diff asr_run.3

2023-05-31 Thread YASUOKA Masahiko
Hi, asr_run.3 is explaining that ar_rrsetinfo must be freed only for the blocking function, but I think it must be freed regardless of the function blocking type. ok? Index: lib/libc/asr/asr_run.3 === RCS file:

attach azalia(4) for "Intel 700 Series HD Audio"

2023-07-30 Thread YASUOKA Masahiko
Hello, New vaio has an audio device which is not configured. "Intel 700 Series HD Audio" rev 0x01 at pci0 dev 31 function 3 not configured 0:31:3: Intel unknown 0x: Vendor ID: 8086, Product ID: 51ca 0x0004: Command: 0006, Status: 0010 0x0008: Class: 04 Multimedia,

<    1   2   3   4