Re: [PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Mike Larkin
On Thu, Aug 31, 2017 at 06:56:45AM +0100, Raf Czlonka wrote: > Hi Carlos, > > Doesn't this mean that, even though it might not be possible to do > this today (is it?), you're effectively disabling the usage of > physical disks for VMs, i.e. equivalent of a raw disk device used > in other hyperviso

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

2017-08-30 Thread Mike Larkin
On Wed, Aug 30, 2017 at 12:48:20AM -0700, Mike Larkin wrote: > On Tue, Aug 29, 2017 at 04:32:04PM -0700, Mike Larkin wrote: > > On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > > > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted Unangst > > > > CVSROOT:

Re: softraid: export rebuild status to sensor

2017-08-30 Thread Mike Larkin
On Wed, Aug 30, 2017 at 02:20:31PM +0200, Patrick Wildt wrote: > Hi, > > like our other hardware raid controller drivers, softraid should > report the rebuild state properly. Currently the sensor exports > the drive state in that case as "unknown", which is misleading. > > ok? > makes sense to

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

2017-08-30 Thread Mike Larkin
On Tue, Aug 29, 2017 at 04:32:04PM -0700, Mike Larkin wrote: > On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted Unangst > > > CVSROOT: /cvs > > > Module name: src > > > Changes by: t...

i386 zzz broken, Was: CVS: cvs.openbsd.org: src

2017-08-29 Thread Mike Larkin
On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted Unangst > > CVSROOT:/cvs > > Module name:src > > Changes by: t...@cvs.openbsd.org2017/08/28 10:16:58 > > > > Modified files: > > usr.sbin/apmd : apmd.8 apmd.c > > >

Re: [PATCH] add initial set of regress tests for vmd

2017-08-27 Thread Mike Larkin
On Sun, Aug 27, 2017 at 02:24:08PM -0700, Carlos Cardenas wrote: > Howdy. > > Below is patch for some initial parsing tests for vmd: > * Memory string parsing (too small, invalid size, and rounding) > * Max disk path > * Max vm name > * Max kernel path > * Max NICs > > More tests to come. > > On

Re: Improve the accuracy of the TSC frequency calibration - Updated Patch

2017-08-27 Thread Mike Larkin
On Sun, Aug 27, 2017 at 09:45:52PM -0700, Mike Larkin wrote: > On Mon, Aug 28, 2017 at 08:02:35AM +0800, Adam Steen wrote: > > On Fri, Aug 25, 2017 at 12:43:44PM +0200, Mike Belopuhov wrote: > > > On Fri, Aug 25, 2017 at 00:40 -0700, Mike Larkin wrote: > > > > On T

Re: Improve the accuracy of the TSC frequency calibration - Updated Patch

2017-08-27 Thread Mike Larkin
On Mon, Aug 28, 2017 at 08:02:35AM +0800, Adam Steen wrote: > On Fri, Aug 25, 2017 at 12:43:44PM +0200, Mike Belopuhov wrote: > > On Fri, Aug 25, 2017 at 00:40 -0700, Mike Larkin wrote: > > > On Thu, Aug 24, 2017 at 12:39:33PM +0800, Adam Steen wrote: > > > > On Thu,

Re: [PATCH] add initial set of regress tests for vmd

2017-08-27 Thread Mike Larkin
On Sun, Aug 27, 2017 at 02:24:08PM -0700, Carlos Cardenas wrote: > Howdy. > > Below is patch for some initial parsing tests for vmd: > * Memory string parsing (too small, invalid size, and rounding) > * Max disk path > * Max vm name > * Max kernel path > * Max NICs > > More tests to come. > > On

Re: Improve the accuracy of the TSC frequency calibration - Updated Patch

2017-08-25 Thread Mike Belopuhov
On Fri, Aug 25, 2017 at 00:40 -0700, Mike Larkin wrote: > On Thu, Aug 24, 2017 at 12:39:33PM +0800, Adam Steen wrote: > > On Thu, Aug 24, 2017 at 2:35 AM, Mike Larkin wrote: > > > On Wed, Aug 23, 2017 at 09:29:15PM +0800, Adam Steen wrote: > > >> > > >>

Re: Improve the accuracy of the TSC frequency calibration - Updated Patch

2017-08-25 Thread Mike Larkin
On Thu, Aug 24, 2017 at 12:39:33PM +0800, Adam Steen wrote: > On Thu, Aug 24, 2017 at 2:35 AM, Mike Larkin wrote: > > On Wed, Aug 23, 2017 at 09:29:15PM +0800, Adam Steen wrote: > >> On Thu, Aug 17, 2017 at 12:19:28PM +0800, Adam Steen wrote: > >> > On Tue, Aug 8, 20

Re: Improve the accuracy of the TSC frequency calibration - Updated Patch

2017-08-23 Thread Mike Larkin
On Wed, Aug 23, 2017 at 09:29:15PM +0800, Adam Steen wrote: > On Thu, Aug 17, 2017 at 12:19:28PM +0800, Adam Steen wrote: > > On Tue, Aug 8, 2017 at 10:12 PM, Mike Belopuhov wrote: > > > On Tue, Aug 08, 2017 at 08:18 +0800, Adam Steen wrote: > > >> On Mon, Jul 31, 2

Re: Prevent attaching "secondary" acpi devices twice

2017-08-17 Thread Mike Larkin
On Thu, Aug 17, 2017 at 10:16:55PM +0200, Mark Kettenis wrote: > If we attach a device to dwiic(4), we should mark it as attached such > that we don't try to attach it again. Before this diff, I had: > > ihidev0 at iic6 addr 0x5c gpio 77, vendor 0x457 product 0x1133, SIS0457 > ... > "SIS0457" at

Re: hfsc_deferred race

2017-08-17 Thread Mike Belopuhov
On Tue, Aug 15, 2017 at 17:14 +0200, Mike Belopuhov wrote: > Hi, > > I've just triggered an assert in hfsc_deferred (a callout) on an > MP kernel running on an SP virtual machine: > > panic: kernel diagnostic assertion "HFSC_ENABLED(ifq)" failed: file > &q

CID 1453170, 1452971: Uninitialized scalar variable (txp_start)

2017-08-17 Thread Mike Belopuhov
Hi, I've made a mistake when refactoring txp_start recently. firstprod and firstcnt served one purpose only: they cached the value of prod and cnt at the start of the loop and then if they'd get incremented but we'd have to bail and goto the oactive label we'd restore the r_prod and r_cnt to value

Re: hfsc_deferred race

2017-08-16 Thread Mike Belopuhov
On Tue, Aug 15, 2017 at 17:14 +0200, Mike Belopuhov wrote: > Hi, > > I've just triggered an assert in hfsc_deferred (a callout) on an > MP kernel running on an SP virtual machine: > > panic: kernel diagnostic assertion "HFSC_ENABLED(ifq)" failed: file > &q

Re: qemu vmm 6.0 / 6.1

2017-08-16 Thread Mike Larkin
On Wed, Aug 16, 2017 at 11:09:57AM -0400, sven falempin wrote: > 6.1 got a firmware (ewww) for seabios > if you dont like this you are free to delete it and use the -b option in vmctl instead. You just don't get non-openbsd guests. your choice. -ml > i mean this : /usr/ports/sysutils/firmware/v

CID 1453358: Out-of-bounds read (bufq_init)

2017-08-16 Thread Mike Belopuhov
There's only two disk elevator disciplines 0 - fifo and 1 - nscan. BUFQ_HOWMANY is 2, but the 'type' should be checked against (BUFQ_HOWMANY - 1) as it's used as an index. OK? diff --git sys/kern/kern_bufq.c sys/kern/kern_bufq.c index 7ed83470e58..ad9558e0d53 100644 --- sys/kern/kern_bufq.c +++ s

CID 1452946, 1452957: Uninitialized scalar variable (bridge_ipsec)

2017-08-16 Thread Mike Belopuhov
Hi, In may this year, the condition that would make this break do the right thing got removed and now if a short packet is sent to an ipsec-enabled bridge, various things like 'spi' and 'off' are left uninitialized, but thankfully the gettdb call that follows will most likely fail when presented w

Additional media options for ix(4) [again]

2017-08-16 Thread Mike Belopuhov
Hi, I haven't gotten any feedback on the following diff but I think there's still hope. Please test. Original mail: I won't mind some broad testing of the following diff which adds some additional media options to ix(4) from FreeBSD and includes a fix for changing media from Masanobu SAITOH. T

Re: Skipping amd errata on hypervisors?

2017-08-15 Thread Mike Larkin
On Tue, Aug 15, 2017 at 05:54:34PM +0200, Stefan Fritsch wrote: > On Tue, 15 Aug 2017, Mike Larkin wrote: > > > On Tue, Aug 15, 2017 at 08:46:59AM -0700, Mike Larkin wrote: > > > On Tue, Aug 15, 2017 at 05:39:29PM +0200, Stefan Fritsch wrote: > > > > I have go

Re: Skipping amd errata on hypervisors?

2017-08-15 Thread Mike Larkin
On Tue, Aug 15, 2017 at 08:46:59AM -0700, Mike Larkin wrote: > On Tue, Aug 15, 2017 at 05:39:29PM +0200, Stefan Fritsch wrote: > > I have got a report that openbsd panics on boot with qemu -cpu Opteron_G3 > > (but Opteron_G2 works). > > > > kernel: pr

Re: Skipping amd errata on hypervisors?

2017-08-15 Thread Mike Larkin
On Tue, Aug 15, 2017 at 05:39:29PM +0200, Stefan Fritsch wrote: > I have got a report that openbsd panics on boot with qemu -cpu Opteron_G3 > (but Opteron_G2 works). > > kernel: protection fault trap, code=0 > Stopped at amd64_errata_setmsr+0x14: rdmsr > ddb{0}> >> OpenBSD/

hfsc_deferred race

2017-08-15 Thread Mike Belopuhov
Hi, I've just triggered an assert in hfsc_deferred (a callout) on an MP kernel running on an SP virtual machine: panic: kernel diagnostic assertion "HFSC_ENABLED(ifq)" failed: file "/home/mike/src/openbsd/sys/net/hfsc.c", line 950 Stopped at db_enter+0x9:

CID 1452909: Use of untrusted scalar value (pf_table.c)

2017-08-15 Thread Mike Belopuhov
Hi, Coverity has discovered that we're blindly trusting the value of pfra_type that we read from the userland supplied pfr_addr and use it to index an array of pools in pfr_create_kentry. I suggest to do two things: add a check in pfr_validate_addr that is called after every copyin and also perfo

Re: vmd vioblk writer thread

2017-08-10 Thread Mike Larkin
On Thu, Aug 10, 2017 at 12:43:38PM -0400, Ted Unangst wrote: > this moves writes into a thread. we need to do reads too, but the write side > is much easier... could use a little more testing. > Reads ok to me, I'll try in my tree today. -ml > > Index: virtio.c > ==

Re: Improve the accuracy of the TSC frequency calibration (Was: Calculate the frequency of the tsc timecounter)

2017-08-08 Thread Mike Belopuhov
On Tue, Aug 08, 2017 at 08:18 +0800, Adam Steen wrote: > On Mon, Jul 31, 2017 at 3:58 PM, Mike Belopuhov wrote: > > On Mon, Jul 31, 2017 at 09:48 +0800, Adam Steen wrote: > >> Ted Unangst wrote: > >> > we don't currently export this info, but we coul

Re: vmd: reset queue_size if queue_select is invalid

2017-08-04 Thread Mike Larkin
On Wed, Jul 26, 2017 at 09:37:30PM -0700, Nick Owens wrote: > hello tech@, > > here is a diff that will follow the virtio spec a little closer, and > allows 9front's (http://9front.org) virtio-blk driver to correctly find > the number of queues. i know that virtio-blk only has one queue, but > the

Re: vmd: reset queue_size if queue_select is invalid

2017-08-04 Thread Mike Larkin
On Thu, Aug 03, 2017 at 04:18:54PM -0700, Nick Owens wrote: > ping? > Sorry this got buried. Should have time later today (yes, really) :) -ml > On Thu, Jul 27, 2017 at 10:20 AM, Mike Larkin wrote: > > On Wed, Jul 26, 2017 at 09:37:30PM -0700, Nick Owens wrote:

Re: vmd: reset queue_size if queue_select is invalid

2017-07-27 Thread Mike Larkin
On Wed, Jul 26, 2017 at 09:37:30PM -0700, Nick Owens wrote: > hello tech@, > > here is a diff that will follow the virtio spec a little closer, and > allows 9front's (http://9front.org) virtio-blk driver to correctly find > the number of queues. i know that virtio-blk only has one queue, but > the

Re: Document hostctl commands for XenServer

2017-07-21 Thread Mike Belopuhov
On Fri, Jul 21, 2017 at 17:49 +0200, Erik van Westen wrote: > Hi Ingo, > > Op 21-7-2017 om 16:20 schreef Ingo Schwarze: > > Hi Mike, > > > > Mike Belopuhov wrote on Fri, Jul 21, 2017 at 03:14:08PM +0200: > > > >> Together with Maxim Khitrov we have

Re: Document hostctl commands for XenServer

2017-07-21 Thread Mike Belopuhov
On Fri, Jul 21, 2017 at 19:58 +0200, Ingo Schwarze wrote: > Hi Mike, > > Mike Belopuhov wrote on Fri, Jul 21, 2017 at 07:08:06PM +0200: > > > Thanks for the detailed respose, I share your outlook and in > > this case it is better to keep this stuff in the userland since &

Create pvbus1 node in addition to pvbus0

2017-07-21 Thread Mike Belopuhov
As suggested by deraadt@ it's better to have /dev/pvbus1 around then document the need to create it under certain circumstances which are of course availability of multiple virtualization interfaces. The diff has survived a make build. I'm not sure the adjustment is done perfectly, but I've tried

Re: Document hostctl commands for XenServer

2017-07-21 Thread Mike Belopuhov
On Fri, Jul 21, 2017 at 10:28 -0400, Maxim Khitrov wrote: > On Fri, Jul 21, 2017 at 9:14 AM, Mike Belopuhov wrote: > > Hi, > > > > Together with Maxim Khitrov we have figured out what needs to > > be set for XenServer (that's a Citrix product based on Xen) to &g

Re: Document hostctl commands for XenServer

2017-07-21 Thread Mike Belopuhov
On Fri, Jul 21, 2017 at 16:20 +0200, Ingo Schwarze wrote: > Hi Mike, > > Mike Belopuhov wrote on Fri, Jul 21, 2017 at 03:14:08PM +0200: > > > Together with Maxim Khitrov we have figured out what needs to > > be set for XenServer > > If XenServer were free software

Document hostctl commands for XenServer

2017-07-21 Thread Mike Belopuhov
-0400 From: Maxim Khitrov To: Mike Belopuhov Cc: Dinar Talypov , tech@openbsd.org Subject: Re: [patch] fake pv drivers installation on xen On Mon, Jul 17, 2017 at 3:40 PM, Mike Belopuhov wrote: > On Mon, Jul 17, 2017 at 14:32 -0400, Maxim Khitrov wrote: >> On Wed, Jan 18, 2017 at 2:

Re: urndis issues

2017-07-18 Thread Mike Belopuhov
On Thu, Jul 13, 2017 at 14:04 +0200, Mike Belopuhov wrote: > On Wed, Jul 12, 2017 at 21:04 +, Jonathan Armani wrote: > > Hi, > > > > Thanks I was cooking the same diff. > > > > Ok armani@ > > > > Hi, thanks! I want to get rid of printfs though a

Re: [patch] fake pv drivers installation on xen

2017-07-17 Thread Mike Belopuhov
On Mon, Jul 17, 2017 at 14:32 -0400, Maxim Khitrov wrote: > On Wed, Jan 18, 2017 at 2:16 PM, Dinar Talypov wrote: > > I use Xenserver 7.0 with xencenter management console. > > without it doesn't allow shutdown or reboot. > > Anyway I'll try with hostctl. > > > > Thanks. > > Were you able to get

Re: time(1): use monotonic clock for computing elapsed time

2017-07-13 Thread Mike Belopuhov
On Thu, Jul 13, 2017 at 13:44 +1000, David Gwynne wrote: > > > On 13 Jul 2017, at 11:16 am, Scott Cheloha wrote: > > > > Hi, > > > > The "real" elapsed time for time(1) and the ksh/csh time builtins is > > currently computed with gettimeofday(2), so it's subject to changes > > by adjtime(2) and

Re: urndis issues

2017-07-13 Thread Mike Belopuhov
On Wed, Jul 12, 2017 at 21:04 +, Jonathan Armani wrote: > Hi, > > Thanks I was cooking the same diff. > > Ok armani@ > Hi, thanks! I want to get rid of printfs though and return errors (or unhandled status codes) so that we don't paper over them. In theory, all error codes that I've seen in

Re: remove CPU_LIDSUSPEND/machdep.lidsuspend

2017-07-11 Thread Mike Larkin
On Tue, Jul 11, 2017 at 11:19:17PM +0200, Martin Natano wrote: > Go ahead replacing machdep.lidsuspend with cpu.lidaction. OpenBSD 6.1 cpu.lidaction or machdep.lidaction? > contains both MIBs, so there is a clear path for migration. > > ok? > > natano > > > Index: arch/amd64/amd64/machdep.c >

Re: urndis issues

2017-07-11 Thread Mike Belopuhov
On Sun, Jul 09, 2017 at 09:57 +0300, Artturi Alm wrote: > Hi, > > anyone else having issues w/urndis(android)? > victim of circumstances, i have to rely on it at times during the summer. > When i plug phone into usb, and enable usb tethering or w/e it is called, > i never get ip on first try, i ha

Re: backgammon(6): remove compiled out user count checks

2017-07-11 Thread Mike Larkin
On Tue, Jul 11, 2017 at 11:01:32AM +0200, Frederic Cambus wrote: > Hi tech@, > > The user count checks have been compiled out since 1998, let's get rid > of them. > > Comments? OK? > ok mlarkin > Index: games/backgammon/backgammon/main.c > ==

Re: Fix compilation warning/error when using ACPIVIDEO_DEBUG

2017-06-29 Thread Mike Larkin
On Wed, Jun 28, 2017 at 10:13:25PM +0200, Fasse wrote: > When building OpenBSD with the ACPIVIDEO_DEBUG option set the > compilation fails: > > cc1: warnings being treated as errors > /usr/src/sys/dev/acpi/acpivideo.c: In function 'acpivideo_set_policy': > /usr/src/sys/dev/acpi/acpivideo.c:136: wa

Additional media options for ix(4)

2017-06-27 Thread Mike Belopuhov
Hi, I won't mind some broad testing of the following diff which adds some additional media options to ix(4) from FreeBSD and includes a fix for changing media from Masanobu SAITOH. The fix makes sure that when the media operation speed is selected manually, the device doesn't additionally adverti

Re: Trapsleds

2017-06-21 Thread Mike Larkin
On Tue, Jun 20, 2017 at 10:34:00PM -0400, Todd Mortimer wrote: > > 2. This patch also hits NOP sleds > 8 bytes on i386. We could also hit > > the NOP sleds between 3 and 7 bytes if there are no objections. > > The attached diff implements the same trapsled mechanism for i386 and > amd64 for all pa

Re: Towards tcp_input() w/o KERNEL_LOCK()

2017-06-20 Thread Mike Belopuhov
On 19 June 2017 at 15:53, Martin Pieuchot wrote: > > On 09/06/17(Fri) 15:54, Martin Pieuchot wrote: > > On 09/06/17(Fri) 00:32, Alexander Bluhm wrote: > > > On Tue, Jun 06, 2017 at 05:15:40PM +0200, Martin Pieuchot wrote: > > > > TCP/UDP are almost ready to run without KERNEL_LOCK() because access

Re: Trapsleds

2017-06-19 Thread Mike Larkin
On Mon, Jun 19, 2017 at 09:22:57PM -0400, Todd Mortimer wrote: > Hello tech, > > I have attached a patch that converts NOP padding from the assembler > into INT3 padding on amd64. The idea is to remove potentially conveinent > NOP sleds from programs and libraries, which makes it harder for an > a

Re: faster timecounters for kvm/xen

2017-06-18 Thread Mike Belopuhov
On Sun, Jun 18, 2017 at 21:20 +1000, Jonathan Matthew wrote: > On Fri, Jun 16, 2017 at 10:25:29AM +0200, Mike Belopuhov wrote: > > Now regarding the diff. pvbus_init_vcpu. Ah yes, please. > > It was a chicken and the egg problem for me: I didn't have > > Xen, but wanted

Re: faster timecounters for kvm/xen

2017-06-17 Thread Mike Belopuhov
On 17 June 2017 at 14:17, Jonathan Matthew wrote: > > On Fri, Jun 16, 2017 at 01:19:02PM +0200, Mike Belopuhov wrote: > > On Fri, Jun 16, 2017 at 10:25 +0200, Mike Belopuhov wrote: > > > I don't know if it's a good idea to depend on Xen's > > >

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Larkin
On Fri, Jun 16, 2017 at 11:09:01PM +1000, Jonathan Gray wrote: > On Fri, Jun 16, 2017 at 02:23:36PM +0200, Mike Belopuhov wrote: > > On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > > > Index: arch/i386

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 10:25 +0200, Mike Belopuhov wrote: > Last time I've tried uebayashi's pvclock on Xen, it didn't > work for me. I didn't have time to investigate why but > probably because we need per-cpu readings. Which you do > for KVM. I'll tes

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 23:09 +1000, Jonathan Gray wrote: > On Fri, Jun 16, 2017 at 02:23:36PM +0200, Mike Belopuhov wrote: > > On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > > > Index: arch/i386

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > Index: arch/i386/include/cpufunc.h > === > RCS file: /cvs/src/sys/arch/i386/include/cpufunc.h,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 cpufunc.h > --- arch/i3

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 10:25 +0200, Mike Belopuhov wrote: > I don't know if it's a good idea to depend on Xen's > definition of vcpu_time_info. I think I have factored > it out into the pvclock_time_info and put it into the > pvclockvar.h or something like that. An

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > Recently I updated the kernel lock profiling stuff I've been working on, since > it had been rotting a bit since witness was introduced. Running my diff on a > KVM VM, I found there was a pretty huge performance impact (10 minutes to

Re: CPU_LIDSUSPEND in init(8) and reboot(8)

2017-06-14 Thread Mike Larkin
On Wed, Jun 14, 2017 at 07:45:42AM +0200, Martin Natano wrote: > ping? > I think I said ok a long time ago. -ml > > On Sun, May 21, 2017 at 09:46:45AM +0200, Martin Natano wrote: > > While switching init and reboot to CPU_LIDACTION, I forgot about the > > #ifdef's. Ok? > > > > natano > > > >

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 11:43 -0400, Ted Unangst wrote: > Mike Belopuhov wrote: > > still looking forward to replies to the original set of changes. > > i'm a little in between. on the one hand, yes, ok, it's good that we don't > leave corrupted buffers around

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 09:12 -0600, Bob Beck wrote: > > > As you all might have gathered by now Amit has jumped the gun > > but was wrong to do so. His setup is not affected by this change. > > That was expected so please don't get distracted by this as I'm > > still looking forward to replies t

Re: tweak txp to avoid ifq_deq_begin/commit/rollback

2017-06-14 Thread Mike Belopuhov
On Mon, Jun 05, 2017 at 16:13 +0200, Mike Belopuhov wrote: > On Wed, May 31, 2017 at 20:40 +0200, Mike Belopuhov wrote: > > According to the FreeBSD driver, txp(4) is not setting up its TX > > ring correctly. FreeBSD driver uses up to 16 fragments, while we > > use up to 25

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Thu, Jun 08, 2017 at 11:55 +0200, Mike Belopuhov wrote: > On Wed, Jun 07, 2017 at 23:04 -0500, Amit Kulkarni wrote: > > On Wed, 7 Jun 2017 21:27:27 -0500 > > Amit Kulkarni wrote: > > > > > On Thu, 8 Jun 2017 01:57:25 +0200 > > > Mike Belopuhov wrote: &g

Re: pool cpu caches and a systat view of them

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 13:50 +1000, David Gwynne wrote: > i have a few things left to do in the pools per cpu caches, one of > which is make their activity visibile. to that end, here's a diff > provides a way for userland to request stats from the per cpu caches, > and uses that in systat so you

Re: wsfont: remove iso7/pcvt encoding macros and entries

2017-06-13 Thread Mike Larkin
On Tue, Jun 13, 2017 at 11:00:52AM +0200, Frederic Cambus wrote: > Hi tech@, > > We do not support iso7 nor pcvt encoding, so remove macro definitions > and commented entries. > > Comments? OK? > ok mlarkin also see what miod said in a later reply, maybe more "-" for you :) > Index: sys/dev/w

Re: pfctl: make functions return void, merge two ifs

2017-06-12 Thread Mike Belopuhov
On Sun, Jun 11, 2017 at 15:03 +0100, Raymond wrote: > Transform the following functions (which never return anything other than 0, > and whose return value is never used) to void: > > * pfctl_clear_stats, pfctl_clear_interface_flags, pfctl_clear_rules, > pfctl_clear_src_nodes, pfctl_clear_states

Re: Better handling of short reads

2017-06-08 Thread Mike Belopuhov
On Wed, Jun 07, 2017 at 23:04 -0500, Amit Kulkarni wrote: > On Wed, 7 Jun 2017 21:27:27 -0500 > Amit Kulkarni wrote: > > > On Thu, 8 Jun 2017 01:57:25 +0200 > > Mike Belopuhov wrote: > > > > > On Wed, Jun 07, 2017 at 18:35 -0500, Amit Kulkarni wr

Re: Better handling of short reads

2017-06-07 Thread Mike Belopuhov
able. There's a night and > day improvement, before and after. Thanks for debugging and fixing > this. > What kind of broken hardware do you have that this diff helps you? Can you show us your dmesg? > amit > > On Wed, Jun 7, 2017 at 12:29 PM, Mike Belopuhov wrote: > >

Better handling of short reads

2017-06-07 Thread Mike Belopuhov
Hi, I've discovered that short reads (nonzero b_resid) aren't handled very well in our kernel and I've proposed a diff like this to handle short reads of buffercache read-ahead buffers: diff --git sys/kern/vfs_bio.c sys/kern/vfs_bio.c index 95bc80bc0e6..1cc1943d752 100644 --- sys/kern/vfs_bio.c +

Fail adding the queue for an interface that doesn't exist

2017-06-07 Thread Mike Belopuhov
This might not be the fix we want in the long run, but it surely prevents frustration when making a typo in the interface name. As reported by Sebastien Marie and claudio@. OK? diff --git sys/net/pf_ioctl.c sys/net/pf_ioctl.c index 43cccdb2efa..c563a439c45 100644 --- sys/net/pf_ioctl.c +++ sys/n

vic: stop using ifq_deq_rollback

2017-06-07 Thread Mike Belopuhov
Hi, This is a straightforward diff moving invariant chunks before dequeue operation. OK? diff --git sys/dev/pci/if_vic.c sys/dev/pci/if_vic.c index e34a1aa4f27..bc1e600d8bc 100644 --- sys/dev/pci/if_vic.c +++ sys/dev/pci/if_vic.c @@ -1049,43 +1049,35 @@ vic_start(struct ifnet *ifp)

Re: tweak txp to avoid ifq_deq_begin/commit/rollback

2017-06-05 Thread Mike Belopuhov
On Wed, May 31, 2017 at 20:40 +0200, Mike Belopuhov wrote: > According to the FreeBSD driver, txp(4) is not setting up its TX > ring correctly. FreeBSD driver uses up to 16 fragments, while we > use up to 252 which is suspicious. > > This gets us in line with FreeBSD, introdu

Re: i386: sync trampoline code with amd64 for clang

2017-06-04 Thread Mike Larkin
On Sun, Jun 04, 2017 at 11:46:00PM +0200, Christian Weisgerber wrote: > This catches up i386 with the changes to acpi_wakecode.S and mptramp.s > that were made on amd64 for clang. Here's kettenis@'s original > commit message: > > ---> > Generating mixed 16-bit/32-bit/64-bit code w

Re: i386 clang: fix libc build

2017-06-04 Thread Mike Larkin
On Thu, Jun 01, 2017 at 02:01:02PM +0200, Mark Kettenis wrote: > > Date: Thu, 1 Jun 2017 13:33:05 +0200 > > From: Christian Weisgerber > > > > >From kettenis@'s corresponding commit on amd64: > > > > Remove branch prediction hints from conditional branch instructions. > > These hints are not

Re: iked: add a tag macro for EAP identity

2017-06-01 Thread Mike Belopuhov
On 1 June 2017 at 10:57, Stuart Henderson wrote: > > I have an iked VPN box that needs to restrict access to certain > resources by user. For connections using a client cert this can be > done by using PF tags based on the ID from the cert, but this > falls short for EAP. > > This diff adds an $ea

Re: tweak txp to avoid ifq_deq_begin/commit/rollback

2017-05-31 Thread Mike Belopuhov
On Wed, May 31, 2017 at 20:40 +0200, Mike Belopuhov wrote: > According to the FreeBSD driver, txp(4) is not setting up its TX > ring correctly. FreeBSD driver uses up to 16 fragments, while we > use up to 252 which is suspicious. > > This gets us in line with FreeBSD, introdu

tweak txp to avoid ifq_deq_begin/commit/rollback

2017-05-31 Thread Mike Belopuhov
According to the FreeBSD driver, txp(4) is not setting up its TX ring correctly. FreeBSD driver uses up to 16 fragments, while we use up to 252 which is suspicious. This gets us in line with FreeBSD, introduces goodness of m_defrag and removes pesky if_deq_* thingies. Does anyone still have the

Re: tweak msk to avoid ifq_deq_begin/commit/rollback

2017-05-31 Thread Mike Belopuhov
On Wed, May 31, 2017 at 10:28 +1000, David Gwynne wrote: > ie, do the space check before trying to dequeue and mbuf. > > this also moves it to using m_defrag. > Thanks, this looks good. Forgot to mention that you can remove the /* now we are committed to transmit the packet */ comment from both

Re: let's add PF_LOCK()

2017-05-31 Thread Mike Belopuhov
On Wed, May 31, 2017 at 10:50 +0200, Alexandr Nedvedicky wrote: > Hello Mike, > > I'd like to ask you to take a one more look to change I'm going > to commit. Looks much better w/o SPLs. I did't find any issues with the diff and I'm OK with you going forward wi

Re: kqueue EV_RECEIPT and EV_DISPATCH

2017-05-31 Thread Mike Belopuhov
. > Patch is below. > > mike@ looked throug, thanks a lot! > That was me (mikeb@). > Jan > > Index: sys/kern/kern_event.c > === > RCS file: /cvs/src/sys/kern/kern_event.c,v > retrieving revision 1.78 &g

vmm: exception injection plumbing

2017-05-30 Thread Mike Larkin
This diff adds the ability to inject exceptions into the guest. It is needed for a variety of things coming soon (XO kernel .text, #UD on unsupported instructions, routing RDRAND/RDSEED to arc4random, etc). ok? Index: amd64/vmm.c ===

Re: let's add PF_LOCK()

2017-05-30 Thread Mike Belopuhov
On Tue, May 30, 2017 at 14:46 +0200, Alexandr Nedvedicky wrote: > oh, not again... > > I'm sorry for not attaching patch to the first email > > On Tue, May 30, 2017 at 02:34:32PM +0200, Alexandr Nedvedicky wrote: > > Hello, > > > > patch delivers two changes to PF: > > > > it adds PF_LOCK()

Re: vmd vioblk start/finish

2017-05-30 Thread Mike Larkin
On Tue, May 30, 2017 at 07:00:08AM -0400, Ted Unangst wrote: > This splits the read/write functions into top and bottom halves. It doesn't > change much yet, but this is a requirement for async IO. The start funtion > turns the request into an ioinfo (to be completed eventually by a thread) and > t

Re: Randomize link of kernel, and unmap startup code

2017-05-30 Thread Mike Larkin
On Tue, May 30, 2017 at 02:16:45AM -0600, Theo de Raadt wrote: > This change relinks kernel objects randomly, and unmaps the bootcode > component of locore during boot. This makes gadgets harder to find. > > The current linker layout is: > > locore.o [bring-up code + asm runtime] > r

Re: pcdisplay(4): remove unused pcdisplay_mapchar_simple function

2017-05-29 Thread Mike Larkin
On Mon, May 29, 2017 at 11:09:06PM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to remove the unused pcdisplay_mapchar_simple function > in pcdisplay(4). > > It has been unused since this code was imported from NetBSD. > > Comments? OK? > ok mlarkin > Index: sys/dev/ic/pcdispl

Re: wsfont: remove lucida16x29.h and omron12x20?

2017-05-29 Thread Mike Larkin
On Mon, May 29, 2017 at 04:30:26PM +0200, Frederic Cambus wrote: > Hi, > > Those fonts are not compiled in by default, and I see no reason > to keep them: > > lucida16x29 is a bad conversion from a truetype font, it is too bold > which makes it unreadable and unusable. > > omron12x20 is a serif

HFSC and FQ-CoDel integration

2017-05-28 Thread Mike Belopuhov
This is a first stab at HFSC and FQ-CoDel integration via extending PF queueing operations (pfq_ops) interface. With this FQ-CoDel can be attached directly to an interface as well as serve as a replacement for the HFSC queue to improve its characteristics. In essence, in many setups (router behin

Re: vmd read/write pfunctions

2017-05-27 Thread Mike Larkin
On Sat, May 27, 2017 at 07:24:30PM -0400, Ted Unangst wrote: > using pread and pwrite is a little shorter and half the syscalls. > ok mlarkin. thanks! > Index: virtio.c > === > RCS file: /cvs/src/usr.sbin/vmd/virtio.c,v > retrieving

Re: EFI header file for kernel

2017-05-24 Thread Mike Larkin
On Wed, May 24, 2017 at 11:14:43AM +0200, Mark Kettenis wrote: > We're going to need some EFI/UEFI support code in the kernel, i.e. to > parse the EFI memory map and to call runtime services to get/set the > RTC. I don't think we want to use the full set of headers that we use > for the bootloader

Re: memory barriers and atomic instructions

2017-05-23 Thread Mike Belopuhov
On Tue, May 23, 2017 at 17:41 +0200, Mark Kettenis wrote: > So here is a diff that implements what I proposed recently. This > recognizes that atomic instructions on amd64 already include an > implicit memory barrier and allows us to write optimized code that > avoids a redundant memory barrier. >

Re: UDP sendspace for dlna providing

2017-05-23 Thread Mike Belopuhov
On Tue, May 23, 2017 at 11:51 +0100, Stuart Henderson wrote: > (replying to an old mail), > > On 2017/03/16 18:07, Claudio Jeker wrote: > > On Thu, Mar 16, 2017 at 03:46:38PM +0100, Eric JACQUOT wrote: > > > Hi all, > > > > > > I had some problems with dlna server (minidlna) and a lot of cuts and

Re: IPsec ours policy check in IPv6 input

2017-05-22 Thread Mike Belopuhov
On 22 May 2017 at 21:02, Alexander Bluhm wrote: > > Hi, > > In the IPv4 input path the IPsec policy is checked by > ip_input_ipsec_ours_check(). This is missing in the IPv6 case. So > call this function also from ip6_local(). > > ok? > > bluhm > This looks good, but please consider moving these

Re: Displaying flow queue in the systat

2017-05-21 Thread Mike Belopuhov
On Mon, May 15, 2017 at 20:13 +0200, Mike Belopuhov wrote: > Here are some bits to display flow queues alongside H-FSC ones. > It's a bit hackish in a way I switch the "bandwidth" field to > the "bandwidth or flows" and then use node->qstats.data.period

Re: pf queue definition: bandwidth resolution problem

2017-05-16 Thread Mike Belopuhov
On Tue, May 16, 2017 at 18:19 +, Carl Mascott wrote: > At the end is the patch I mentioned against pftop.c v1.37, using a guard > digit. > WARNING: Untested. I couldn't even try to compile it. > > At this point I don't see anything wr

Minor annoyances in the pfctl queue parser

2017-05-16 Thread Mike Belopuhov
jmc@ has pointed out some inconsistencies in how bandwidth parameters are parsed and printed out. I agree that we can fix or improve this: 1) Bit/B/bit/b are parsed incorrectly. Ditching them is another option. 2) Should we make lowercase K, M and G parseable as well? I'd like that. 3) Avoid an

Re: pf queue definition: bandwidth resolution problem

2017-05-15 Thread Mike Belopuhov
On Sun, May 14, 2017 at 21:08 +, Carl Mascott wrote: > OK, I was indeed missing something. Thanks, Theo and Mike. > > I think I see another very minor problem, though. > Let the pf BW be 9,999,999. > Shift right 3 digits (divide by 1000) : yields 9,999K. > (If we were do

Displaying flow queue in the systat

2017-05-15 Thread Mike Belopuhov
Here are some bits to display flow queues alongside H-FSC ones. It's a bit hackish in a way I switch the "bandwidth" field to the "bandwidth or flows" and then use node->qstats.data.period because I'm too lazy to change the pfctl_queue_node to include a union... This will require changes in the who

Re: pf: percpu anchor stacks

2017-05-15 Thread Mike Belopuhov
On Mon, May 15, 2017 at 15:19 +0200, Alexandr Nedvedicky wrote: > Hello, > > > Now *is* the time to commit the first step, the refactoring. Once > > that's done we can discuss the introduction of the context. > > > > Could you come up with such diff? > > first of all: I have not managed to

Re: [patch] ND_COMPUTER_RTIME is not uniformly distributed

2017-05-15 Thread Mike Belopuhov
On Sun, May 07, 2017 at 18:59 -0500, Matthew Martin wrote: > RFC 4861 specifies ReachableTime "should be a uniformly distributed > random value between MIN_RANDOM_FACTOR and MAX_RANDOM_FACTOR times > BaseReachableTime milliseconds." I think the author intended to do the > multiplication by (x>>10)

Re: pf queue definition: bandwidth resolution problem

2017-05-14 Thread Mike Belopuhov
on Tuesday. > > Yes, I understand that systat can display only 4 digits for BW. > That's 5 digits with my guard digit, which is shifted out (and not displayed) > at the end. > So, with the guard digit, 6 digits is too many. > > > --

Re: pf queue definition: bandwidth resolution problem

2017-05-14 Thread Mike Belopuhov
On Sun, May 14, 2017 at 19:48 +, Carl Mascott wrote: > I have a suggestion RE your pftop.c patch. You are rounding > multiple times, after each scale operation. This is known as > rounding the intermediate results of a calculation and degrades > accuracy. If you're not familiar with the issu

Re: pf queue definition: bandwidth resolution problem

2017-05-13 Thread Mike Belopuhov
iodically, > but if that's not the case then the same fix is needed in systat. > > > > > On Sat, 5/13/17, Carl Mascott wrote: > > Subject: Re: pf queue definition: bandwidth resolution problem > To: "Mike Belopu

<    1   2   3   4   5   6   7   8   9   10   >