Re: Change CMakeLists.txt in LibreSSL to use target_include_directores

2018-06-14 Thread Cameron Palmer
compat is intended to ​be private. We will need to make some tweaks here. On Mon, Jun 4, 2018 at 5:36 PM, Cameron Palmer mailto:came...@promon.no>> wrote: Question about the PUBLIC status of the ../include/compat headers in CMakeLists.txt. I wrote the target_include_directories calls to includ

Re: Change CMakeLists.txt in LibreSSL to use target_include_directores

2018-06-04 Thread Cameron Palmer
and if they should be marked PRIVATE. With them marked PUBLIC and including ssl or crypto one must add a compiler define like -D HAVE_CLOCK_GETTIME in the linking project to avoid a conflict. > On 29 May 2018, at 12:48, Brent Cook wrote: > > On Thu, May 24, 2018 at 10:10:58AM +, Camer

Change CMakeLists.txt in LibreSSL to use target_include_directores

2018-05-24 Thread Cameron Palmer
It is beneficial for projects that depend on LibreSSL libraries and are built with CMake to use target_link_libraries and automatically receive the PUBLIC or INTERFACE headers without needing to specify include_directories. This patch changes the project to use target_include_directories and