Re: ssh nits

2023-03-08 Thread Darren Tucker
On Thu, 9 Mar 2023 at 06:50, joshua stein wrote: > On Thu, 09 Mar 2023 at 06:41:50 +1100, Darren Tucker wrote: > > This seems to be one too many parens? ie > > if (negate = (attrib[0] == '!')) > > clang warns if there's not the extra set of parens in ca

Re: ssh nits

2023-03-08 Thread Darren Tucker
(attrib[0] == '!'))) This seems to be one too many parens? ie if (negate = (attrib[0] == '!')) > - if ((r = parse_dest_constraint_hop(frombuf, &dc->from) != 0) || > - (r = parse_dest_constraint_hop(tobuf, &dc->to) != 0)) > + if ((r = parse_dest_

Re: ssh-keygen(1): by default generate ed25519 key (instead of rsa)

2022-11-08 Thread Darren Tucker
On Tue, 8 Nov 2022 at 14:23, Joerg Sonnenberger wrote: > Am Tue, Nov 08, 2022 at 01:23:52PM +1100 schrieb Darren Tucker: [...] > > Not quite: the default value for IdentityFile has RSA before ED25519. [...] > I tried that first and it picked up id_ed25519 from the agent, even if >

Re: ssh-keygen(1): by default generate ed25519 key (instead of rsa)

2022-11-07 Thread Darren Tucker
sh/id_ecdsa, ~/.ssh/id_ecdsa_sk, ~/.ssh/id_ed25519, ~/.ssh/id_ed25519_sk and ~/.ssh/id_dsa. $ SSH_AUTH_SOCK= ssh -F/dev/null localhost Enter passphrase for key '/home/dtucker/.ssh/id_rsa': Enter passphrase for key '/home/dtucker/.ssh/id_ecdsa': Enter passphrase f

Re: SSH_USER_AUTH

2022-09-18 Thread Darren Tucker
process on the system, whereas files have ownership and permission bits that control access. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually com

Re: ssh-add(1): fix NULL in fprintf

2022-06-17 Thread Darren Tucker
On Fri, 17 Jun 2022 at 04:49, Martin Vahlensieck wrote: > ping, diff attached Applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usua

Re: sshd_config(5): Use correct path for system-wide known_hosts

2022-04-11 Thread Darren Tucker
On Mon, 11 Apr 2022 at 16:12, Martin Vahlensieck wrote: > The path to the system-wide known_hosts file is /etc/ssh/ssh_known_hosts > and not /etc/ssh/known_hosts. See auth2-hostbased.c line 221-223. Applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E0

dhcpd: look up ethernet addresses in /etc/ethers

2020-02-18 Thread Darren Tucker
x27;:', 16, 8); + if (!t) + t = parse_numeric_aggregate(cfile, NULL, &hlen, ':', 16, 8); + if (!t) return; if (hlen > sizeof(hardware->haddr)) { -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B

Re: backgrounded ssh, strange terminal behaviour

2019-12-10 Thread Darren Tucker
otto but not otherwise. Can you confirm that you are also using controlmaster or are you seeing this in a single process? -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, Nov 12, 2019 at 08:52:58PM +1100, Darren Tucker wrote: > On Tue, 12 Nov 2019 at 20:47, Darren Tucker wrote: > > I got this on the second try although the log is not very helpful. > > I'd suggest checking your MaxStartups setting in sshd_config and > > comparing t

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, 12 Nov 2019 at 20:47, Darren Tucker wrote: > I got this on the second try although the log is not very helpful. > I'd suggest checking your MaxStartups setting in sshd_config and > comparing the settings to the numbers of connections you have. Confirmed that exceeding MaxSt

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
On Tue, 12 Nov 2019 at 20:31, Darren Tucker wrote: [..] > I'd start by cranking up the client side log level (LogLevel debug3 in > ~/.ssh/config) and use CVS_RSH="ssh -E logfile" or ssh -y to send the > logs to syslog. > > Is this a public mirror, and if so which

Re: ssh "kex_exchange_identification: Connection closed by remote host"

2019-11-12 Thread Darren Tucker
ice about tracking it down? I'd start by cranking up the client side log level (LogLevel debug3 in ~/.ssh/config) and use CVS_RSH="ssh -E logfile" or ssh -y to send the logs to syslog. Is this a public mirror, and if so which one? -- Darren Tucker (dtucker at dtucker.net) GPG

Re: ssh-keygen: tweak error for -b

2019-08-03 Thread Darren Tucker
sed and delete this ifdef. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: www/64.html - OpenSSH version 7.8 or 7.9?

2018-10-18 Thread Darren Tucker
ated shortly. $ ssh -V > OpenSSH_7.9, LibreSSL 2.8.2 > > Theo bumped the version in src/usr.bin/ssh/version.h r1.83, > this version is tagged with OPENBSD_6_4_BASE. > > On the www.openssh.org the latest OpenSSH release mentioned is 7.8, > so no newer release notes there to link to.

Re: ssh: use getservbyname(3) for port numbers

2018-10-04 Thread Darren Tucker
behind it was (reduce NIS lookups back in the day?) -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: Show -o and -a in ssh-keygen(1) synopsis

2018-08-13 Thread Darren Tucker
ogonal flags. [...] > + "usage: ssh-keygen [-oq] [-a rounds] [-b bits] [-t dsa | ecdsa | > ed25519 | rsa]\n" ditto. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

look up interface names for IPv6 "cannot forward" errors

2018-01-02 Thread Darren Tucker
m->m_pkthdr.ph_ifidx, rt->rt_ifidx); + } + if_put(ifp_dst); + ifp_dst = NULL; + if_put(ifp); + ifp = NULL; } if (mcopy) icmp6_

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-17 Thread Darren Tucker
sizeof(remote_id)); + logit("Timeout, client not responding from %s", remote_id); cleanup_exit(255); } -- Darren Tucker (dtucker at zip.com.au) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-10-16 Thread Darren Tucker
On 17 October 2017 at 06:04, Lars Noodén wrote: > > + logit("Timeout, client not responding from %s on port %d.", > + ssh_remote_ipaddr(ssh), ssh_remote_port(ssh) ); > probably better to use fmt_connection_id() instead of hand-rolling the form

Re: NET_LOCK() pflow panic

2016-12-21 Thread Darren Tucker
On Thu, Dec 22, 2016 at 11:41 AM, Alexander Bluhm wrote: > On Thu, Dec 22, 2016 at 11:32:26AM +1100, Darren Tucker wrote: >> > I don't have a solution for the moment and I want to be sure we know all >> > recursions before trying to write a fix. So here's a dif

Re: NET_LOCK() pflow panic

2016-12-21 Thread Darren Tucker
systqmp 85279 0 0 0 3 0x14200 bored systq 33036 0 0 0 3 0x40014200 bored softclock 66216 0 0 0 3 0x40014200idle0 1 0 1 0 30x82 wait init 0 -1 0 0 3 0x

Re: make ssh -qO {stop,exit} less noisy

2016-10-19 Thread Darren Tucker
_level != SYSLOG_LEVEL_QUIET) > + fprintf(stderr, "Stop listening request sent.\r\n"); > exit(0); > case SSHMUX_COMMAND_CANCEL_FWD: > if (mux_client_forwards(sock, 1) != 0) > -- Darren Tucker (dtucker at zip

Re: little simpler ssh code

2016-09-18 Thread Darren Tucker
, SSH_SESSION_KEY_LENGTH); > sizeof(session_key) instead please. with those, ok dtucker@ -- Darren Tucker (dtucker at zip.com.au) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: [calendar] United States holiday migrations

2016-01-28 Thread Darren Tucker
On Thu, Jan 28, 2016 at 11:30 AM, Ian Mcwilliam wrote: > Just for the record > > 01/30 Australia Day in Australia > should be > 01/26 Australia Day in Australia > > If someone so wishes to fix it. Fixed, thanks. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4

Re: ssh-agent: flush stdout before main loop in foreground mode

2015-12-10 Thread Darren Tucker
en to stdout, this output may never be written. Patch applied, thanks! -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re:

2015-05-31 Thread Darren Tucker
at wrote: > > Hey Darren, misc@ is for the trolls, so I moved this to tech@. > > But using a vr(4) device is a troll in itself. > Well I was trying to find problems. Seemed to work pretty well for that :-) -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7E

Re: Snapshot install54.iso does not boot under qemu/kvm

2014-01-02 Thread Darren Tucker
6.S rev 1.3 (confirmed working for me). The next snapshot should be good. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: small ssh refinements

2013-12-24 Thread Darren Tucker
my chances > with ssize_t being the right size. (there are 3 occurrences of > ptrdiff_t in umac.c too). Given that it's already in use and we haven't had any complaints that I'm aware of I have no objection to adding more ptrdiff_t. I'll look through the rest of the diff

Re: bzip2

2013-06-07 Thread Darren Tucker
o deal with this either way so I'll leave it there. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: bzip2

2013-06-06 Thread Darren Tucker
42 bsd.zopfli.gz [1] https://code.google.com/p/zopfli/ -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: vr(4) TX interrupt reduction

2013-01-17 Thread Darren Tucker
On Fri, Jan 18, 2013 at 01:09:50PM +1100, Darren Tucker wrote: > The turd polishing continues unabated. and continues to continue. This adds a quirk to frob the interrupt-disable bit for VT6105M only. After checking all of the spec sheets that I can find, I found the TX interrupt disable

Re: vr(4) TX interrupt reduction

2013-01-17 Thread Darren Tucker
On Fri, Jan 18, 2013 at 09:00:25AM +1100, Darren Tucker wrote: > Thanks to Mark Patruck for noticing that the previous patch didn't > actually help, due to a bug I introduced in a last minute "obviously > correct" clean up. The turd polishing continues unabated. This ad

Re: vr(4) TX interrupt reduction

2013-01-17 Thread Darren Tucker
On Thu, Jan 17, 2013 at 09:34:32PM +1100, Darren Tucker wrote: > OK, here's another diff which does seem to help. It seems that there's > two different bits in the TX descriptor that control interrupts. Quoting > from the VT6105M spec: Thanks to Mark Patruck for noticing that

Re: vr(4) TX interrupt reduction

2013-01-17 Thread Darren Tucker
On Wed, Jan 16, 2013 at 01:38:01PM +1100, Darren Tucker wrote: > On Mon, Jan 14, 2013 at 10:10:55PM +1100, Darren Tucker wrote: > > On my ALIX, it increase the IP routing throughput from 80Mbit/s to > > 85Mbit/s while reducing the interrupt CPU usage from 99% to 80%. > > It

Re: hardware VLAN tagging for vr(4)

2013-01-15 Thread Darren Tucker
On Mon, Jan 14, 2013 at 02:42:54PM +1100, Darren Tucker wrote: > Resurrecting this, I've now fixed the problem I introduced when I merged > in your changes and have tested it. Updated diff now incorporating feedback from brad jsing mikeb and probably others. Having corrected for the

vr(4): avoid unnecessary PCI bus transactions

2013-01-15 Thread Darren Tucker
sc->vr_cdata.vr_tx_prod = cur_tx; bus_dmamap_sync(sc->sc_dmat, sc->sc_listmap.vrm_map, 0, -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: vr(4) TX interrupt reduction

2013-01-15 Thread Darren Tucker
On Mon, Jan 14, 2013 at 10:10:55PM +1100, Darren Tucker wrote: > On my ALIX, it increase the IP routing throughput from 80Mbit/s to > 85Mbit/s while reducing the interrupt CPU usage from 99% to 80%. It turns out that due to an error on my part, most of this improvment was due to one of th

Re: vr(4) TX interrupt reduction

2013-01-14 Thread Darren Tucker
On Mon, Jan 14, 2013 at 10:10:55PM +1100, Darren Tucker wrote: > This patch below reduces the number of interrupts on the transmit side > of vr(4). Currently we set the TX competion interrupt bit on each > outbound packet. This patch changes it to only set the interrupt bit on > the

vr(4) TX interrupt reduction

2013-01-14 Thread Darren Tucker
cur_tx = cur_tx->vr_nextdesc; + prev_tx = head_tx; + } + if (prev_tx != NULL) { + prev_tx->vr_ptr->vr_ctl |= htole32(VR_TXCTL_FINT); + prev_tx->vr_ptr->vr_status |= htole32(VR_TXSTAT_OWN); } + if (sc->vr_cdata.vr_tx_cn

Re: hardware VLAN tagging for vr(4)

2013-01-13 Thread Darren Tucker
000 #define VR_TXSTAT_OWN 0x8000 +#define VR_TXSTAT_PQSHIFT 16 #define VR_TXCTL_BUFLEN0x07FF #define VR_TXCTL_BUFLEN_EXT0x7800 -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.

Re: [PATCH] OpenSSH: auth.c

2012-12-13 Thread Darren Tucker
On Thu, Dec 13, 2012 at 07:31:46PM +0100, Maxime Villard wrote: > Hi, > I was looking at some openssh code when I spotted a mistake applied, thanks. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement come

hardware VLAN tagging for vr(4)

2012-09-26 Thread Darren Tucker
L 0x02 +#define VR_CAMCTRL_WRITE 0x04 +#define VR_CAMCTRL_READ0x08 + +/* * Rhine TX/RX list structure. */ @@ -404,6 +415,7 @@ struct vr_desc { #define VR_TXSTAT_ERRSUM 0x00008000 #define VR_TXSTAT_PQMASK 0x7FFF #define VR_TXSTAT_OWN 0x8000

Re: Fix for sftp(1) tab-complete

2012-09-21 Thread Darren Tucker
On Tue, Sep 11, 2012 at 11:27 AM, Jean-Marc Robert wrote: > This is a diff that should fix a few issues I've encountered with sftp's > tab-complete, and a few others that I found in the process. Thanks, these have been committed (with some mild style adjustment). -- Darren Tu