Re: wcwidth of soft hyphen

2021-04-05 Thread Ingo Schwarze
Hi, Martijn van Duren wrote on Thu, Apr 01, 2021 at 09:30:36AM +0200: > When it comes to these discussions I prefer to go back to the standards I would propose an even more rigorous stance: not only go back to the standards, but use whatever the Unicode data files (indirectly, via the Perl

Re: mandoc: -Tlint: search /usr/local/man as well

2021-04-05 Thread Ingo Schwarze
Hi, Klemens Nanni wrote on Sun, Apr 04, 2021 at 03:54:43PM +0200: > On Sun, Apr 04, 2021 at 03:42:03PM +0200, Tim van der Molen wrote: >> Doesn't mandoc -Tlint -Wstyle do what you want? > I don't think so. Oddly enough, `-Wstyle' does not do what I would > expect: it omits STYLE messages

Re: Patch for crypt(3) man page.

2021-01-27 Thread Ingo Schwarze
Hi, this page is a mess. It is full of unclear wordings, in some cases verging incorrect statements. At the same time, parts of it are wordy. Here is an attempt to start fixing it. I refrained from trying to explain $2a$ (as suggested by sthen@) or to document the missing bcrypt_gensalt(3) in

Re: man: help pagers recognise HTML files as such

2021-01-26 Thread Ingo Schwarze
Hi Klemens, Klemens Nanni wrote on Sat, Jan 16, 2021 at 10:31:49AM +0100: > On rare occasions I'd like to use the following idiom to read manuals in > browsers, mostly to better readability and navigation of long sections: > > MANPAGER=netsurf-gtk3 man -Thtml jq > > (jq(1) has lots of

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hi Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:39:30PM +0100: > On Mon, Dec 07, 2020 at 01:30:55PM +0100, Ingo Schwarze wrote: >> Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:01:27PM +0100: >>> I just tested this change and it seems to work: [...] >>

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hello Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:01:27PM +0100: > I just tested this change and it seems to work: I did not repeat my testing, but here is some quick feedback purely from code inspection: The proposed code change makes sense to me. The proposed manual page text

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hi Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 09:48:36AM +0100: > On Sun, Dec 06, 2020 at 10:52:37PM +0100, Alexander Hall wrote: >> On December 6, 2020 8:13:26 PM GMT+01:00, Antoine Jacoutot wrote: >>> On Sun, Dec 06, 2020 at 05:20:31PM +, Stuart Henderson wrote: On

Re: sio_open.3: clarify what sio_start() does

2020-11-28 Thread Ingo Schwarze
Hi Alexandre, Alexandre Ratchov wrote on Fri, Nov 27, 2020 at 07:05:27PM +0100: > this wording is shorter and more precise and complete. This looks good mdoc(7)-wise, so go ahead, but please consider the two nits below when committing. Yours, Ingo > Index: sio_open.3 >

Re: AUDIORECDEVICE environment variable in sndio lib

2020-11-17 Thread Ingo Schwarze
Hi Solene, sorry if i misunderstand because i did not fully follow the thread... Solene Rapenne wrote on Tue, Nov 17, 2020 at 07:36:38PM +0100: > I added the new variable after MIDIDEVICE in the ENVIRONMENT section > to keep order of appearance in the document. Usually, we order the

Re: Import seq(1) from FreeBSD

2020-11-17 Thread Ingo Schwarze
contain UTF-8 and it just works. No need to call setlocale(3) or inspect LC_*. Yours, Ingo Todd C. Miller wrote on Mon, Nov 16, 2020 at 10:08:08AM -0700: > On Mon, 16 Nov 2020 16:14:31 +0100, Ingo Schwarze wrote: >> are you really sure this is a good idea? The version you sent is

Re: Import seq(1) from FreeBSD

2020-11-16 Thread Ingo Schwarze
Hi Todd, are you really sure this is a good idea? The version you sent is wildly incompatible with GNU sed. So we add a non-standard utility that exhibits different behaviour on different systems even though a standard utility already exists for the purpose? Is this needed for porting work?

Re: accton(8) requires a reboot after being enabled

2020-11-03 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Mon, Nov 02, 2020 at 05:29:37PM +: > - adding EXIT STATUS makes sense. i agree. So i added just the .Sh and .Ex lines. All the rest (both regarding "file" and "install") seems controversial and hardly worth have a long discussion, so i dropped all the

Re: accton(8) requires a reboot after being enabled

2020-11-02 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Fri, Oct 30, 2020 at 12:10:41PM -0600: > Yes, that diff is a whole bunch of TOCTUO. > > If this was going to be changed, it should be in the kernel. > > But I don't know if it should be changed yet, which is why I asked > a bunch of questions. > > Stepping back

Re: accton(8) requires a reboot after being enabled

2020-10-30 Thread Ingo Schwarze
Hi Solene, Solene Rapenne wrote on Fri, Oct 30, 2020 at 06:34:09PM +0100: > Following diff changes accton(8) behavior. > > If the file given as parameter doesn't exists, accton will create it. > Then it will check the ownership and will make it root:wheel if > it's different. > > I added a

Re: accton(8) requires a reboot after being enabled

2020-10-30 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Fri, Oct 30, 2020 at 09:59:09AM -0600: > With a careful reading of the current manual page, everything is there > and it is accurate. > > With an argument naming an existing file > > > Ok so let's create it with touch.

Re: [PATCH] Fix link in Porting Guide

2020-10-29 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Wed, Oct 28, 2020 at 09:02:21PM +0100: > This refers to the libc function. Committed, thanks. > P.S.: I noticed that e.g. sysmerge(8) is mentioned like this but not a > link. Is this intentional? Probably not, i added a few more links while there.

Re: [PATCH] Mention unsupported stacking in softraid(4)

2020-10-25 Thread Ingo Schwarze
Hi Jeremie and Filippo, Jeremie Courreges-Anglas wrote on Sun, Oct 25, 2020 at 03:05:04PM +0100: > On Sun, Oct 25 2020, "Filippo Valsorda" wrote: >> Based on the text in faq14.html, but using the manpage language. > Makes sense. I'm not sure .Em is useful here, though. Indeed. We use .Em

Re: diff: fixing a few broken links on 68.html, and other minor things

2020-10-22 Thread Ingo Schwarze
Hi, Andras Farkas wrote on Wed, Oct 21, 2020 at 09:19:43PM -0400: > While reading 68.html I noticed some of the man page links pointed to > the man pages in the wrong section of the manual. (at least, given the > manual section numbers listed next to them in the 68.html text) > I decided to fix

Re: libexec/security: don't prune mount points

2020-10-11 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Wed, Oct 07, 2020 at 09:36:33AM -0600: > The recent changes to the daily security script will result in it > not traversing file systems where the parent mount point is mounted > with options nodev,nosuid but the child is mounted with setuid > enabled. > > For

Re: Make df output more human friendly in daily(8)

2020-10-03 Thread Ingo Schwarze
Hi Daniel, my OK still stands, except that you went too far in one respect in the manual page, see below. Yours, Ingo Daniel Jakots wrote on Fri, Oct 02, 2020 at 03:41:31PM -0400: > Index: share/man/man8/daily.8 > === > RCS

Re: Make df output more human friendly in daily(8)

2020-10-02 Thread Ingo Schwarze
Hi Daniel, Daniel Jakots wrote on Fri, Oct 02, 2020 at 02:16:57PM -0400: > On Fri, 2 Oct 2020 19:55:53 +0200, Ingo Schwarze wrote: >> Daniel Jakots wrote on Thu, Oct 01, 2020 at 10:32:31PM -0400: >>> Currently daily(8) runs `df -ikl`. >> By default, it does not. It o

Re: Make df output more human friendly in daily(8)

2020-10-02 Thread Ingo Schwarze
Hi, Daniel Jakots wrote on Thu, Oct 01, 2020 at 10:32:31PM -0400: > Currently daily(8) runs `df -ikl`. By default, it does not. It only does that if you set VERBOSESTATUS. I would prefer deleting the VERBOSESTATUS parts completely, strictly enforcing the principle "daily(8) only produces

Re: drop support for afs, nnpfs, and procfs from security(8)

2020-09-17 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Wed, Sep 16, 2020 at 01:36:09PM -0600: > On Wed, 16 Sep 2020 18:17:36 +0200, Ingo Schwarze wrote: >> Does anyone think that explicitely excluding these file system >> types might still be useful, or is the following simplification >> OK?

drop support for afs, nnpfs, and procfs from security(8)

2020-09-16 Thread Ingo Schwarze
Hi, by chance, i noticed that security(8) is careful to avoid scanning filesystems of the types "afs", "nnpfs", and "procfs". According to "ls /sbin/mount*", no such file systems are supported, and the only page "man -ak any=afs any=nnpfs any=procfs" brings up seems to be sshd_config(5) talking

Re: route.8, remove unprinted text

2020-09-10 Thread Ingo Schwarze
Hi Denis, Denis Fondras wrote on Thu, Sep 10, 2020 at 10:09:14PM +0200: > I can't see where these two lines are printed. Not OK, please do not commit that diff. You are correct that these two macros produce no output to the terminal, but they do produce output to the ctags(1) file and they

Re: exFAT support

2020-08-06 Thread Ingo Schwarze
Hi, in addition to what Bryan said... This message is wildly off-topic on tech@. If you reply, please reply to misc@. Quoting from https://www.openbsd.org/mail.html (please read that!): Developer lists: [...] tech@openbsd.org Discussion of technical topics for OpenBSD developers and

Re: ksh [emacs.c] -- simplify isu8cont()

2020-07-25 Thread Ingo Schwarze
Hi, Martijn van Duren wrote on Sat, Jul 25, 2020 at 09:54:53PM +0200: > This function is used throughout the OpenBSD tree and I think it's > fine as it is. This way it's clearer to me that it's about byte > 7 and 8 and not have to do the math in my head to check if we > might have botched it. >

Re: join(1) remove redundant memory copy

2020-07-23 Thread Ingo Schwarze
Hi Martijn, this is a nice simplification, OK schwarze@. A few nits: * The MAXIMUM() macro is now unused, so i prefer that you delete the definition. * The second getline(3) argument should be size_t, not u_long, so change that in the struct declaration (it's not used anywhere else).

Re: switch default MANPAGER from more(1) to less(1)

2020-07-20 Thread Ingo Schwarze
Hi, ropers wrote on Mon, Jul 20, 2020 at 05:54:46AM +0100: > Ah, I see where you're coming from, Ingo. You've dropped the idea of > testing for less(1) in non-portable mandoc because we know less(1) is > in base.[1] Configuration testing is never needed in a base system. It may sometimes

Re: switch default MANPAGER from more(1) to less(1)

2020-07-19 Thread Ingo Schwarze
Hi Jason & Theo, thanks for the feedback! Jason McIntyre wrote on Sun, Jul 19, 2020 at 05:02:02PM +0100: > i guess the argument in favour of more(1) would be that it is part of > posix, even if optional, where less(1) is not. so it makes sense to > choose a command most likely to work on most

switch default MANPAGER from more(1) to less(1)

2020-07-19 Thread Ingo Schwarze
Hi, currently, if neither the MANPAGER nor the PAGER environment variable is set, man(1) uses "more -s" as the manual page pager. I am quite sure that the only reason i did this is that i thought this behaviour was required by POSIX. But it is not:

Re: LC_MESSAGES in xargs(1)

2020-07-19 Thread Ingo Schwarze
; > Minor nits inline, but either way OK martijn@ Thanks to all three of you for checking, i just committed the patch. > On Thu, 2020-07-16 at 21:49 +0200, Ingo Schwarze wrote: [...] >> * There is no need to put a marker "return value ignored on >>purpose" wher

Re: LC_MESSAGES in xargs(1)

2020-07-16 Thread Ingo Schwarze
Hi Jan, Jan Stary wrote on Thu, Jul 16, 2020 at 09:45:44AM +0200: > Does xargs need to set LC_MESSAGES? As it stands, your patch doesn't make much sense. It is true that it doesn't change behaviour, but it leaves more cruft behund than it tidies up. That said, i agree that we will never

Re: disable libc sys wrappers?

2020-07-10 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Fri, Jul 10, 2020 at 10:02:46AM -0600: > I also don't see the point of the leading _ > > Where does that come from? > > This isn't a function namespace. What does it signify, considering > no other environment variable uses _ prefixing. $ man -kO Ev Ev~^_ |

Re: disable libc sys wrappers?

2020-07-09 Thread Ingo Schwarze
Hi Mark, Mark Kettenis wrote on Thu, Jul 09, 2020 at 07:59:25PM +0200: > Ingo Schwrze wrote: >> Now that i look at that, and at what you said previously, is it even >> plausible that some user ever wants "-t c" ktracing but does >> specifically *not* want to see clock_gettime(2) and friends?

Re: disable libc sys wrappers?

2020-07-09 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Thu, Jul 09, 2020 at 11:08:38AM -0600: > Ingo Schwarze wrote: >> So, what about >> LD_KTRACE_GETTIME >> or a similar environment variable name? > That naming seems logical. > > If it is mostly hidden behind a ktrace flag (-T ?

Re: disable libc sys wrappers?

2020-07-09 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Thu, Jul 09, 2020 at 09:47:26AM -0600: > This time, they become invisible. [...] > There are many circumstances where ltrace is not suitable. [...] > We fiddle with programs all the time, to inspect them. Fair enough, then. The following variables already exist

Re: disable libc sys wrappers?

2020-07-09 Thread Ingo Schwarze
Hi, i wonder whether there is a layering violation going on here. >From the user perspective, whether an API call is a syscall or a mere library function doesn't make any difference, it's an implementation detail. API calls have often moved from being library functions to syscall and vice

rewrite printf(3) manual page

2020-07-08 Thread Ingo Schwarze
Hi, the following is the execution of an idea brought up by deraadt@. There are four problems with the printf(3) manual page: 1. While some modifiers (like "argno$" and "width") do the same for all conversion specifiers, the effects of some other modifiers varies wildly. For example,

Re: snmp(1) initial UTF-8 support

2020-07-03 Thread Ingo Schwarze
Hi Martijn, sorry for the delay, now i finally looked at the function smi_displayhint_os() from the line "if (MB_CUR_MAX > 1) {" to the end of the corresponding else clause. IIUC, what that code is trying to do is iterate the input buffer "const char *buf" of length "size_t buflen". Before

Re: Add man parameter for HTML pager

2020-06-15 Thread Ingo Schwarze
Hi Abel, i committed a tweaked version of your patch with these changes: - pass pointers to structs around, don't pass structs by value - no need for an additional automatic variable for the URI - no need for comments similar to: i++; /* increment i */ - only use file:// when -O tag was

Re: Add man parameter for HTML pager

2020-06-14 Thread Ingo Schwarze
Hi Abel, Romero Perez, Abel wrote on Mon, Jun 15, 2020 at 03:06:26AM +0200: > Romero Perez, Abel wrote: >> I tried to view the manuals in HTML format with lynx, but I couldn't I assume what you mean is that you could, but the "-O tag" option had no effect. >> because lynx and links can't

Re: snmp(1) initial UTF-8 support

2020-05-31 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Tue, May 19, 2020 at 10:25:37PM +0200: > So according to RFC2579 an octetstring can contain UTF-8 characters if > so described in the DISPLAY-HINT. One of the main consumers of this is > SnmpAdminString, which is used quite a lot. > > Now that we trimmed

Re: locale thread support

2020-05-29 Thread Ingo Schwarze
to avoid such issues. To make support desirable, it might be sufficient that xlocale.h is one reasonable way and that some amounts of useful software actually use it. Yours, Ingo Marc Espie wrote on Thu, May 28, 2020 at 05:52:12PM +0200: > On Tue, May 26, 2020 at 12:13:02AM +0200, Ingo Schwa

Re: Enable building wsmoused on arm64 and armv7

2020-05-29 Thread Ingo Schwarze
Hi, Frederic Cambus wrote on Thu, May 28, 2020 at 10:44:59PM +0200: > On Thu, May 28, 2020 at 10:52:44AM -0600, Theo de Raadt wrote: >> -MANSUBDIR= i386 amd64 alpha >> +MANSUBDIR= i386 amd64 arm64 armv7 alpha >> >> Actually, I suggest making this a MI man page. Delete that line, >> and

Re: locale thread support

2020-05-25 Thread Ingo Schwarze
Hi, my impression is there are two totally independent topics in this thread. 1. Whether and how to make things safer, ideally terminating the program in a controlled manner, if it uses functions that are not thread-safe in an invalid manner. I'm not addressing that topic in this

Re: Fix manpage links in upgrade67.html

2020-05-24 Thread Ingo Schwarze
Hi Andre, Andre Stoebe wrote on Sat, May 23, 2020 at 06:10:36PM +0200: > following patch fixes two manpage links that point to the wrong section. Committed, thanks. Ingo > Index: faq/upgrade67.html > === > RCS file:

Re: vi.beginner diff and analysis (vi.advanced to follow)

2020-05-24 Thread Ingo Schwarze
Hi Andras, Andras Farkas wrote on Sun, May 24, 2020 at 01:27:18AM -0400: > I went through vi.beginner. Thanks. > It works both with vi's regular settings, > and with the settings applied via EXINIT in vi.tut.csh. Good. > I have a diff attached. I was mostly light and gentle with my >

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-20 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Wed, May 20, 2020 at 06:38:18AM +0100: > i'm fine with the text, but does it really warrant a CAVEATS section? it > sounds like it should just be part of "this is how it works" text. I may not be the best person to judge this, but as far as i understand, this

Re: Add CAVEATS to ldom.conf(5) man page

2020-05-19 Thread Ingo Schwarze
Hi Kurt, Kurt Mosiejczuk wrote on Tue, May 19, 2020 at 07:49:56PM -0400: > On Mon, May 18, 2020 at 08:12:00PM +0200, Klemens Nanni wrote: >> On Mon, May 18, 2020 at 01:20:07PM -0400, Kurt Mosiejczuk wrote: >>> Learning how LDOMs work on this T4-1 and we only create 8 devices >>> (each /dev/ldom*

Re: ddb(4): missing tags

2020-05-17 Thread Ingo Schwarze
Hi Anton, Anton Lindqvist wrote on Sun, May 17, 2020 at 10:56:18AM +0200: > The ddb(4) manual documents a couple of commands which can be > abbreviated. The diff below adds explicit tags for such commands which > in turn makes it possible to jump to for instance `examine' from within > your

Re: WireGuard patchset for OpenBSD

2020-05-12 Thread Ingo Schwarze
Hi Matt, Matt Dunwoodie wrote on Wed, May 13, 2020 at 01:56:51AM +1000: > On Tue, 12 May 2020 17:36:15 +0200 > Ingo Schwarze wrote: >> I feel somewhat concerned that you recommend the openssl(1) command >> for production use. As far as i understand, the LibreSSL developers &

Re: WireGuard patchset for OpenBSD

2020-05-12 Thread Ingo Schwarze
Hi Matt, again, documentation is not critical for the initial commit, but why not provide feedback right away. As we already have an ifconfig(8) manual page, i decided to simply send an updated version of the ifconfig.8 part of the diff because sending around diffs of diffs feels awkward, and

Re: WireGuard patchset for OpenBSD

2020-05-12 Thread Ingo Schwarze
Hi Matt, thanks for doing all this work. Note that i cannot provide feedback on the code or concepts, and also note that when the code is ready, a developer can commit it even if there are still issues to sort out with the documentation. We do value good documentation, but the exact point in

Re: Broken links to the usb.org document library

2020-05-12 Thread Ingo Schwarze
Hi, clematis wrote on Tue, May 12, 2020 at 03:06:40AM +0200: > - Should we update those links? For the manual pages, that seems clear: if some document is worth linking to (which i assume it is unless told otherwise, if a link is currently present in a manual page), then we should provide the

Re: Diff for www:mail

2020-05-05 Thread Ingo Schwarze
Salut Stephane, b...@stephane-huc.net wrote on Mon, May 04, 2020 at 03:51:33PM +0200: > Here a diff for www page: mail > Please, review this diff to add French ML Committed. Merci, Ingo > Index: mail.html > === > RCS file:

Re: Mention /etc/examples/ in those config files manpages + FILES short description

2020-05-01 Thread Ingo Schwarze
Hi, clematis wrote on Fri, May 01, 2020 at 11:37:51AM +0200: > On Fri, May 01, 2020 at 06:52:27AM +0100, Jason McIntyre wrote: >> i don;t understand your reference to 28 out of 41 files. i cannot see >> where we added any expanded FILES entries. can you provide a summary of >> these

Re: [PATCH] printf: Add %B conversion specifier for binary

2020-04-27 Thread Ingo Schwarze
Hi, Alejandro Colomar wrote on Mon, Apr 27, 2020 at 08:26:38PM +0200: > This patch adds a new feature to the ``printf`` family of functions: > ``%B`` conversion specifier for printing unsigned numbers in binary. No. We do not want non-standard extensions to standard functions unless they

Re: Update /etc/examples/doas.conf and doas.conf(5)

2020-04-25 Thread Ingo Schwarze
Hi, clematis wrote on Sat, Apr 25, 2020 at 11:34:14PM +0200: > But then based on your feedback I wonder if there's even any > value of an example file which gives not much more than an already > well documented manpage? We had that discussion among developers at least twice in the past. If i

Re: Update /etc/examples/doas.conf and doas.conf(5)

2020-04-25 Thread Ingo Schwarze
Hi, i strongly dislike what you are doing here. Not just because of one particular line, but in general. clematis wrote on Sat, Apr 25, 2020 at 07:41:40PM +0200: > Looking arround in /etc/examples/ I felt like some of those files > aren't as "verbose" as others. The shorter the better. Yes,

Re: www/advisories unreferenced files - should they go to the attic?

2020-04-24 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Fri, Apr 24, 2020 at 10:57:23AM -0600: > Somewhere along the line, the web pages were changed to no longer > reference those pages, and that is a shame. > > It is a shame that the old errata pages don't point at those files. > > They aren't quite in the same

Re: [PATCH] [src] usr.bin/audioctl/audioctl.8, usr.bin/mixerctl/mixerctl.8 - manpages moved to section 8, mark them as such

2020-04-22 Thread Ingo Schwarze
Hi Raf, Raf Czlonka wrote on Thu, Apr 23, 2020 at 12:58:41AM +0100: > Recently moved manpages bear section 1 number - update accordingly. Committed, thanks. Ingo > Index: usr.bin/audioctl/audioctl.8 > === > RCS file:

Re: Update www/support.html

2020-04-18 Thread Ingo Schwarze
Hi, clematis wrote on Sat, Apr 18, 2020 at 11:26:51AM +0200: > I went through the sites listed on support.html to check if they were > still valid. Caught a few that needs removal or update. Thank you for doing that work! > Please find the details below and the changes in the diff attached. >

Re: implement locale(1) charmap argument

2020-04-17 Thread Ingo Schwarze
Hi Stefan and Todd, Stefan Sperling wrote on Fri, Apr 17, 2020 at 08:55:29AM +0200: > On Thu, Apr 16, 2020 at 09:35:18PM +0200, Ingo Schwarze wrote: >>$ locale -m >> UTF-8 >>$ locale charmap >> UTF-8 >>$ LC_ALL=C locale charmap >> US-AS

implement locale(1) charmap argument

2020-04-16 Thread Ingo Schwarze
dex: locale.1 === RCS file: /cvs/src/usr.bin/locale/locale.1,v retrieving revision 1.7 diff -u -p -r1.7 locale.1 --- locale.126 Oct 2016 01:00:27 - 1.7 +++ locale.116 Apr 2020 19:04:25 - @@ -1,6 +1,6 @@ .\

Re: Update www/groups.html

2020-04-16 Thread Ingo Schwarze
Hi, clematis wrote on Thu, Apr 16, 2020 at 12:53:19PM +0200: > Hello, > Here's a few suggestions to update www/groups.html > I was checking if all those links were still existing/active/valid. Thanks, both for doing the checks and providing details about what exactly you did. > Does anyone has

Re: [patch]: Change kern_unveil to [] array derefs

2020-04-04 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Sat, Apr 04, 2020 at 07:16:46PM +0200: > This makes these array derefs consistent with the others in the file. > Also I believe this is the preferred way to do this. That depends. In mandoc, i certainly prefer "pointer + offset" over "[offest]", arguing

Re: [patch] mandoc: Remove argument names from function prototypes

2020-04-03 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200: > I think these are superfluous. Correct, and it is irritating to have a general style of not using argument names in prototypes in mandoc, but then a few scattered names here and there, so i committed your patch.

Re: bug? in getopt(3) + [PATCH] + testcase

2020-03-30 Thread Ingo Schwarze
Hi, 0xef967...@gmail.com wrote on Wed, Mar 25, 2020 at 05:58:22PM +0200: > To wrap this up and get if off my plate, here is the updated patch, [...] > --- getopt-long.c~2020-03-12 02:23:29.028903616 +0200 > +++ getopt-long.c 2020-03-15 23:46:07.988119523 +0200 > @@ -418,15 +418,7 @@ >

Re: [patch] Tweak libssl manpages

2020-03-30 Thread Ingo Schwarze
Hi Martin, Martin wrote on Sun, Mar 29, 2020 at 10:22:15PM +0200: > It seems these are just a coded form for no return value, > unless this is some libssl slang I am not aware of. I don't think "does not provide diagnostic information" has any special meaning in libssl. Also, the word

Re: [patch] Remove "do not return a value" from libcrypto/libssl manpages

2020-03-29 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Sun, Mar 29, 2020 at 01:51:58AM +0100: > I found some more. Thanks, committed, also including in lh_stats(3). Ingo > Index: libcrypto/man/RC4.3 > === > RCS file:

Re: [patch] ERR_print_errors.3

2020-03-28 Thread Ingo Schwarze
Hi Martin, thanks for reporting the issue in the manual page. Martin Vahlensieck wrote on Sat, Mar 28, 2020 at 09:06:54PM +0100: > Unless I miss something ERR_print_errors_cb returns no value as well. Actually, i committed about the opposite, for the reasons explained in the commit message.

Re: find.1: Markup primaries with Fl not Cm for easier tags

2020-03-20 Thread Ingo Schwarze
Hi Klemens, Klemens Nanni wrote on Sat, Mar 21, 2020 at 12:49:20AM +0100: > On Fri, Mar 20, 2020 at 04:53:19PM +0100, Ingo Schwarze wrote: >> I don't feel very strongly about that, but i think .Cm does make >> slightly more sense for primaries than .Fl (and .Ic is probably >

Re: find.1: Markup primaries with Fl not Cm for easier tags

2020-03-20 Thread Ingo Schwarze
Hi Klemens, Klemens Nanni wrote on Fri, Mar 20, 2020 at 12:12:39AM +0100: > In both command line usage and manual output format, find's options > and primaries behave the same, Not really. In the POSIX sense, options are indeed options while primaries are arguments. That has implications, for

Re: bt.5: Fix time() description

2020-03-18 Thread Ingo Schwarze
Hi Martin, hi Klemens, Martin Pieuchot wrote on Wed, Mar 18, 2020 at 09:06:24PM +0100: > On 18/03/20(Wed) 20:45, Klemens Nanni wrote: >> It takes a format string, e.g. >> >> syscall:sysctl:entry { >> time("%+\n") >> } I can't comment on the content of bt(5). > This is

Re: openssl.1: Tag command names

2020-02-27 Thread Ingo Schwarze
Hi Klemens, Ingo Schwarze wrote on Tue, Feb 18, 2020 at 04:30:53PM +0100: > While i don't strongly object to the patch, it might be worth holding > off a bit on manually tagging of .Sh given that even automatic > tagging isn't done for that macro yet. Which would mean postponing >

Re: openssl.1: Tag command names

2020-02-26 Thread Ingo Schwarze
Hi Klemens, Ingo Schwarze wrote on Tue, Feb 18, 2020 at 04:30:53PM +0100: > Klemens Nanni wrote on Mon, Feb 17, 2020 at 05:19:27PM +0100: >> Patch was done with a VIM macro by adding a new line after each `.Sh' >> line with the respective name but lowercased, so no typos in the a

Re: Update en_US.UTF-8 to Unicode 12.1

2020-02-18 Thread Ingo Schwarze
Hi Andrew, ironically, the patch did not apply for me because you sent it with Content-Type: text/plain; charset=iso-8859-1 so when i saved it to disk, it remained in ISO-Latin-1. In the license comment you are changing, there is a U+00A9 COPYRIGHT SIGN encoded as UTF-8. I suggest you change

Re: openssl.1: Tag command names

2020-02-18 Thread Ingo Schwarze
Hi, Steffen Nurpmeso wrote on Tue, Feb 18, 2020 at 04:52:48PM +0100: > i just want to add that there is still the mdocmx mdoc macro > extension available, and is working fine for more than half > a decade. I have not ported that to groff 1.22.4, but it is > available for groff 1.22.3. It can

Re: openssl.1: Tag command names

2020-02-18 Thread Ingo Schwarze
Hi Klemens, Klemens Nanni wrote on Mon, Feb 17, 2020 at 05:19:27PM +0100: > I'd like to commit this soon, it allows me to jump to the command I'm > looking for, e.g. ":tx509" shows me the synopsis right away. > > FWIW, some Linux distributions ship with separate manuals, e.g. x509(1SSL). Yes,

Re: bgpd.conf.5: Tag groups

2020-02-16 Thread Ingo Schwarze
Hi Klemens, Klemens Nanni wrote on Sun, Feb 16, 2020 at 09:32:52PM +0100: > On Sun, Feb 16, 2020 at 09:25:51PM +0100, Klemens Nanni wrote: >> Going through the example with bgpd.conf(5) side by side, jumping to the >> "group" tag shows >> >> group descr Neighbors in this group will be

Re: dd(1) wording and style

2020-02-15 Thread Ingo Schwarze
Hi Jan, Jan Stary wrote on Sat, Feb 15, 2020 at 10:51:28AM +0100: > On Feb 14 17:37:27, schwa...@usta.de wrote: >> Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: >>> On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: -.It Cm seek= Ns Ar n +.It Cm seek Ns = Ns Ar

Re: dd bs= supercede ibs= and obs=

2020-02-15 Thread Ingo Schwarze
Hi, Jan Stary wrote on Sat, Feb 15, 2020 at 11:07:04AM +0100: > On Feb 14 17:04:51, schwa...@usta.de wrote: >> Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: >>> On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: * Fix a factual error in the description of bs: it

Re: extern already declared

2020-02-14 Thread Ingo Schwarze
Hi, Todd C. Miller wrote on Sun, Feb 09, 2020 at 09:49:35AM -0700: > On Sun, 09 Feb 2020 17:46:51 +0100, Jan Stary wrote: >> Whenever unistd.h declares getopt(3), it also declares >> the extern optind and optarg, so files including unistd.h >> don't need to declare those themselves, right? >

Re: dd(1) wording and style

2020-02-14 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: > On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: >> -.It Cm seek= Ns Ar n >> +.It Cm seek Ns = Ns Ar n >> Seek >> .Ar n >> blocks from the beginning of the output before copying. >> -On non-tape devices, an >> -.Xr

Re: dd(1) wording and style

2020-02-14 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Fri, Feb 14, 2020 at 07:28:59AM +: > On Thu, Feb 13, 2020 at 11:25:07PM +0100, Jan Stary wrote: >> * Fix a factual error in the description of bs: it does not >> supersede ibs/obs, dd will error out when both are specified. > i don;t want to comment on this

Re: [PATCH] [www] books.html - remove superfluous angle bracket

2020-02-14 Thread Ingo Schwarze
Hi Raf, Raf Czlonka wrote on Fri, Feb 14, 2020 at 02:55:20PM +: > On Mon, Nov 25, 2019 at 11:16:09AM GMT, Raf Czlonka wrote: >> Index: books.html >> === >> RCS file: /cvs/www/books.html,v >> retrieving revision 1.117 >> diff -u

Re: [PATCH] [www] faq/current.html - be consistent with naming of the 'id' attribute

2020-02-14 Thread Ingo Schwarze
Hi Raf, Raf Czlonka wrote on Fri, Feb 14, 2020 at 01:53:03PM +: > Small inconsistency. > Personally, I prefer id *without* the 'r' but the below is "the odd > one out" so... Oops, sorry. Fixed, thanks for noticing. Ingo > Index: faq/current.html >

Re: setlocale() in cron

2020-02-11 Thread Ingo Schwarze
Hi, Jan Stary wrote on Mon, Feb 10, 2020 at 01:13:58PM +0100: > Why does cron(8) and crontab(1) need to setlocale()? Committed; thanks to millert@ for cross-checking. Ingo > Index: cron.c > === > RCS file:

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Ingo Schwarze
Hi, Jan Stary wrote on Mon, Feb 10, 2020 at 05:12:53PM +0100: > The -r option of newsyslog(8) removes the requirement > that newsyslog runs as root. Would it also make sense > to not try to send the SIGHUP to syslogd in that case? While i'm not sure that i want to take care of this patch, given

Re: setlocale() in cron

2020-02-10 Thread Ingo Schwarze
Hi, Jan Stary wrote on Mon, Feb 10, 2020 at 01:13:58PM +0100: > Why does cron(8) and crontab(1) need to setlocale()? I looked through the *.c files in /usr/src/usr.sbin/cron/ and found the following locale-dependent functions: atrun.c: isalpha(3), isupper(3) cron.c: strtod(3)

Re: Add note about example dhclient.conf

2020-02-10 Thread Ingo Schwarze
Hi Kyle, Kyle Isom wrote on Mon, Feb 10, 2020 at 07:34:25AM -0800: > On Sat, Feb 8, 2020, at 14:15, Jason McIntyre wrote: >> - i'm ok with adding the path to these files to a FILES section > Done. I already committed a comprehensive diff doing that in a simpler way earlier today:

Re: locate.updatedb TMPDIR

2020-02-09 Thread Ingo Schwarze
Hi Joerg, this is absolutely not OK. How did you test this? $ doas cat /var/log/weekly.part /etc/weekly[79]: no closing quote With that fixed, i agree with the direction of the change. Yours, Ingo Joerg Jung wrote on Sun, Feb 09, 2020 at 12:33:42AM +0100: > I have a machine with a

Re: locate.updatedb TMPDIR

2020-02-09 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Sun, Feb 09, 2020 at 07:52:10AM -0700: > I'm fine with this. I don't really object, but i'm not sure it is needed either. It's certainly obvious that command line arguments override defaults. That's what they always do. It's their whole point, in general.

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sun, Feb 09, 2020 at 07:49:10AM +: > - bgpd.8 refers to /etc/bgpd.conf. that file doesn;t exist by default. I do not consider that a problem, not even a minor one. ENVIRONMENT says which variables are inspected if they exist. FILES says which files are

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Marc, Marc Espie wrote on Sun, Feb 09, 2020 at 02:27:23PM +0100: > I still think it's a good idea to put it in afterboot(8). No more objections, with or without jmc@'s tweaks. It seems clear that enough people want it in that page. Yours, Ingo > Index: afterboot.8 >

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-08 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Sat, Feb 08, 2020 at 04:39:42PM -0700: > For complicated configurations, the text could explain the reason the > example is valuable -- for instance > > .It Pa /etc/examples/bgpd.conf > Example configuration file demonstrating IBGP mesh, multiple transits, > RPKI

mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-08 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +: > - i'm ok with adding the path to these files to a FILES section So, here is a specific patch for bgpf.conf(5) and bgpd(8) such that we can agree on a general direction for one case where the example file is particularly

Re: get rid of almost empty /etc/examples/mixerctl.conf

2020-02-08 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sat, Feb 08, 2020 at 03:33:37PM -0700: > Jason McIntyre wrote: >> without getting into a discussion about /etc/examples, in this case i >> personally see neither the point of the example config file (so trivial >> as to be questionable) nor the addition to the

get rid of almost empty /etc/examples/mixerctl.conf

2020-02-08 Thread Ingo Schwarze
Hi Theo, you have a point, that was a lot of cheap talk and no patch. I don't aim at changing yacc(1) grammars. I think most parts of OpenBSD configuration systems already have sane defaults and most configuration syntaxes are already good with respect to simplicity and usability. At least

  1   2   3   4   5   6   7   8   9   >