Re: crontab(5): document -q flag in command

2016-10-12 Thread Jérémie Courrèges-Anglas
Ingo Schwarze writes: > Hi Jeremie, > > Jeremie Courreges-Anglas wrote on Wed, Oct 12, 2016 at 03:19:13PM +0200: >> Wouter Clarie writes: > >>> The -q flag for the command in a crontab(5) entry was introduced >>> in revision 1.8 of src/usr.sbin/cron/entry.c

Re: IPV6_MINHOPCOUNT on UDP sockets

2016-06-27 Thread Jérémie Courrèges-Anglas
Alexander Bluhm writes: > On Mon, Jun 27, 2016 at 08:46:12PM +0200, Jeremie Courreges-Anglas wrote: >> >> Renato would like to implement GTSM in ldpd(8), the first step would be >> to support IPV6_MINHOPCOUNT on SOCK_DGRAM sockets. The following diff >> seems to work

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-27 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2016/06/15 19:43, Vincent Gross wrote: >> On Mon, 13 Jun 2016 16:49:01 +0200 >> Vincent Gross wrote: >> > >> > While validating source address inside selection functions is the >> > right direction, I don't think it would

tcpdump: print router advertisement preference

2016-05-06 Thread Jérémie Courrèges-Anglas
As defined by https://tools.ietf.org/html/rfc4191, prompted by http://marc.info/?l=openbsd-misc=146239072929264=2 "pref" is inspired by upstream tcpdump format. Thoughts / ok? Index: print-icmp6.c === RCS file:

ndp(8) CPPFLAGS

2016-05-02 Thread Jérémie Courrèges-Anglas
ndp.c doesn't have any #ifdef INET6 preprocessor directive, I can't see how keeping that in CPPFLAGS changes anything. While here, -I${.CURDIR} isn't needed either. Verified with sha256(1). ok? Index: Makefile === RCS file:

Re: rtadvd: remove more dead code

2016-02-25 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > - a few *cnt members of struct rainfo aren't used for anything > - the SIOCGIFPREFIX_IN6 ioctl has been deprecated since June 2002 > - prefix_match() and in6a_site_allrouters are remnants from the > Renumbering code (now in the A

Re: traceroute: pledge "dns" problem

2016-02-11 Thread Jérémie Courrèges-Anglas
Sebastien Marie writes: > Hi, > > I noted that calling traceroute with -nA result to pledge to abort. > > $ traceroute -nA openbsd.org > traceroute to openbsd.org (129.128.5.194), 64 hops max, 40 byte packets > Abort trap (core dumped) > > It is due because with -n we don't

Re: Intel i219 network card support

2016-02-11 Thread Jérémie Courrèges-Anglas
Alexander Bluhm writes: > On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: >> The diff was initially done for 5.7, bluhm@ did the forward port >> to current. The resulting diff is below. > > I am running this diff with my Thinkpad T430s, no problems so

Re: multicast, ETOOMANYREFS and intro(2)

2016-02-08 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > On Fri, 05 Feb 2016 17:17:30 +0100, Martin Pieuchot wrote: > >> > > We could also return ENOBUFS in this case instead. That would >> > > correspond to the errors described in ip(4) (sadly setsockopt(2) is not >> > > really reflecting the

Re: rtadvd unicast

2016-02-08 Thread Jérémie Courrèges-Anglas
> rtadvd contains code to send unicast replies, RFC4861 mentions this > possibility (section 6.2.6) but I'm having a hard time thinking how it > could be useful. > > Since the sending part is commented out since it was introduced, I doubt > that anyone will miss it. This removes pointless memory

rtadvd: remove more dead code

2016-02-08 Thread Jérémie Courrèges-Anglas
- a few *cnt members of struct rainfo aren't used for anything - the SIOCGIFPREFIX_IN6 ioctl has been deprecated since June 2002 - prefix_match() and in6a_site_allrouters are remnants from the Renumbering code (now in the Attic) ok? Index: config.c

Re: rtadvd usage()

2016-02-05 Thread Jérémie Courrèges-Anglas
Alexander Bluhm writes: > On Thu, Feb 04, 2016 at 02:02:46PM +0100, J??r??mie Courr??ges-Anglas wrote: >> +static void usage(void); > > Can you make the usage static __dead void? gsoares made the same comment, there are other functions that could be marked __dead and I

rtadvd unicast

2016-02-05 Thread Jérémie Courrèges-Anglas
rtadvd contains code to send unicast replies, RFC4861 mentions this possibility (section 6.2.6) but I'm having a hard time thinking how it could be useful. Since the sending part is commented out since it was introduced, I doubt that anyone will miss it. This removes pointless memory

Re: multicast, ETOOMANYREFS and intro(2)

2016-02-05 Thread Jérémie Courrèges-Anglas
Martin Pieuchot writes: > On 01/02/16(Mon) 13:15, Todd C. Miller wrote: >> On Mon, 01 Feb 2016 19:56:01 +0100, >> =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- >> Anglas?= wrote: >> >> > intro(2) describes it as such: >> > >> > 59 ETOOMANYREFS Too many references: can't

rtadvd usage()

2016-02-04 Thread Jérémie Courrèges-Anglas
AFAIK none of our daemons ignore unknown options, I can't see why rtadvd(8) should be special. Bonus: - main doesn't need to be declared - rtadvd.c now uses poll(2), not select(2) ok? Index: rtadvd.c === RCS file:

Re: ldapd: add -r option to specify datadir path

2016-02-02 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > Sebastien Marie <sema...@openbsd.org> writes: > >> On Sun, Jan 31, 2016 at 09:39:52AM +0100, Landry Breuil wrote: >>> Hi, >>> >>> i'm tinkering with ldapd and writing regress tests for it, a

Re: ldapd: add -r option to specify datadir path

2016-02-02 Thread Jérémie Courrèges-Anglas
Gleydson Soares writes: >> Thinking about it .. would a call to access(2) with R_OK|W_OK|R_OK|F_OK >> satisfy >> everyone ? Or only F_OK ? > > Sounds better than chdir(2), but it will lack if datadir was passed to > access(2) > without including trailing "/" > > eg with

Re: ldapd: add -r option to specify datadir path

2016-02-01 Thread Jérémie Courrèges-Anglas
Gleydson Soares writes: > Hi Landry, > > On Sun, Jan 31, 2016 at 09:39:52AM +0100, Landry Breuil wrote: >> Hi, >> >> i'm tinkering with ldapd and writing regress tests for it, and to >> allow running independent instances (with separate port/control >> socket/etc) i needed to

unused variable in init(8)

2016-02-01 Thread Jérémie Courrèges-Anglas
Not needed since rev. 1.55 and the introduction of crypt_checkpass(). ok? Index: init.c === RCS file: /cvs/src/sbin/init/init.c,v retrieving revision 1.57 diff -u -p -p -u -r1.57 init.c --- init.c 23 Dec 2015 02:41:12 -

multicast, ETOOMANYREFS and intro(2)

2016-02-01 Thread Jérémie Courrèges-Anglas
Hi, while glancing at the multicast code I noticed the use of ETOOMANYREFS: if (imo->imo_num_memberships == imo->imo_max_memberships) { struct in_multi **nmships, **omships; size_t newmax; /*

ansify libarch/i386

2016-02-01 Thread Jérémie Courrèges-Anglas
ok? Index: lib/libarch/i386/i386_get_ioperm.c === RCS file: /cvs/src/lib/libarch/i386/i386_get_ioperm.c,v retrieving revision 1.7 diff -u -p -r1.7 i386_get_ioperm.c --- lib/libarch/i386/i386_get_ioperm.c 15 Nov 2014 02:23:28 -

Re: ldapd: add -r option to specify datadir path

2016-02-01 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > Sebastien Marie <sema...@openbsd.org> writes: > >> On Sun, Jan 31, 2016 at 09:39:52AM +0100, Landry Breuil wrote: >>> Hi, >>> >>> i'm tinkering with ldapd and writing regress tests for it, a

Re: ldapd: add -r option to specify datadir path

2016-02-01 Thread Jérémie Courrèges-Anglas
Sebastien Marie writes: > On Sun, Jan 31, 2016 at 09:39:52AM +0100, Landry Breuil wrote: >> Hi, >> >> i'm tinkering with ldapd and writing regress tests for it, and to >> allow running independent instances (with separate port/control >> socket/etc) i needed to add the

Re: I have a program I wish to submit for the base

2016-01-29 Thread Jérémie Courrèges-Anglas
Luke Small writes: > I wanted to use kqueue. Name another script or programming language that > offers it from the base install. NONE! If you want to discover how to use kqueue, fine, but that's not how design decisions are done in OpenBSD land. > Why should I write it in

Re: Add readonly flag to tftpd

2016-01-26 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2016/01/26 02:06, Matthew Martin wrote: >> I'd bet the most common use case for tftpd is to serve PXE files or >> similar where the files being served should not be modified. I'm failing >> to find a use case where files need to be overwritten,

libgen.h: unreachable decls

2016-01-24 Thread Jérémie Courrèges-Anglas
I noticed those a while ago, the #if 0 is there since the beginning. Can't see the point in keeping this as is. ok? Index: libgen.h === RCS file: /cvs/src/include/libgen.h,v retrieving revision 1.7 diff -u -p -p -u -r1.7 libgen.h

Re: no more yp support in resolv.conf -> faq 10

2016-01-18 Thread Jérémie Courrèges-Anglas
Matthieu Herrb writes: > Support for 'yp' in resolv.conf was removed last november. > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/asr/asr.c?rev=1.49=text/x-cvsweb-markup > > So don't mention it in the FAQ... > > ok ? Please don't remove the , else ok jca@ > Index:

Re: ferror in ntpd (Re: bugs in printf(3))

2015-12-29 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > On Tue, 29 Dec 2015 13:25:16 +0100, > =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- > Anglas?= wrote: > >> I think it makes sense to try to recover, so calling clearerr() is >> needed. But as said by millert you can't rely on fprintf to set

Re: ferror in ntpd (Re: bugs in printf(3))

2015-12-29 Thread Jérémie Courrèges-Anglas
Sebastian Benoit writes: > Todd C. Miller(todd.mil...@courtesan.com) on 2015.12.28 10:46:08 -0700: >> On Fri, 25 Dec 2015 00:30:29 +0100, Ingo Schwarze wrote: >> >> > Besides, i don't see the point in messing with FILE flags at all >> > in case of encoding errors. As opposed

Re: ARP input path without KERNEL_LOCK

2015-12-29 Thread Jérémie Courrèges-Anglas
Martin Pieuchot writes: > On 22/12/15(Tue) 13:48, Martin Pieuchot wrote: >> On 04/12/15(Fri) 11:54, Martin Pieuchot wrote: >> > Now that in_arpinput() only uses the routing table, if_get()/if_put() >> > and carp_iamatch being already mpsafe we can kill the ARP input queue. >> >

Re: bug in fputwc(3) error reporting

2015-12-26 Thread Jérémie Courrèges-Anglas
Ingo Schwarze writes: [...] > When fputwc(3) encounters an encoding error, it neglects to set the > error indicator, just like fgetwc(3) did before i fixed it today. > Setting the error indicator is required by the manual and by the > standard. Hmm, the C standard and POSIX

Re: bugs in printf(3)

2015-12-26 Thread Jérémie Courrèges-Anglas
Ingo Schwarze writes: > Fourth file, fourth broken file. > This is the worst bug found so far. > All i'm doing is grepping libc/stdio for "EILSEQ". > So far, every single instance i looked at was buggy. > > I think we should cvs rm libc. > The code quality just isn't up to

Re: bug in fputwc(3) error reporting

2015-12-26 Thread Jérémie Courrèges-Anglas
"Anthony J. Bentley" <anth...@anjbe.name> writes: > Hi Jérémie, Hi, > Jérémie Courrèges-Anglas writes: >> Hmm, the C standard and POSIX have slightly different texts regarding >> this. >> >> Quoting POSIX-2013: >> -->8-- >> RETUR

Re: fgetwc(3) error reporting bug

2015-12-24 Thread Jérémie Courrèges-Anglas
Ingo Schwarze writes: > Hi, > > i just noticed a bug in fgetwc(3) in our libc, the function used to > implement getwc(3), getwchar(3), getws(3), getwln(3) and the wscanf(3) > family of functions. In case of an encoding error, it does not set > the error indicator, such that a

Re: Add --brief and --dereference to file(1)

2015-12-23 Thread Jérémie Courrèges-Anglas
Ralf Horstmann writes: > Hi, Hi, > xdg-open uses "xdg-mime query filetype" to find out the mime type of a given > file. Depending on the desktop environment, xdg-mime uses different backends. > In my case (i3 wm) it falls back to the generic code path, which uses > > file

Re: [patch] Convert modulus to arc4random_uniform

2015-12-08 Thread Jérémie Courrèges-Anglas
Matthew Martin writes: > On Mon, Dec 07, 2015 at 09:33:47AM +0100, Theo Buehler wrote: >> I think some of these are ok, but I'm unsure about some of the others. >> Here are some of my concerns: >> >> - since arc4random_uniform can potentially loop indefinitely, it >> might

Re: Move ancient ksh bug from README to man page

2015-12-06 Thread Jérémie Courrèges-Anglas
Michael McConville writes: > Jeremie Courreges-Anglas wrote: >> Jason McIntyre writes: >> >> > On Sun, Dec 06, 2015 at 04:03:16AM -0500, Ted Unangst wrote: >> >> Jason McIntyre wrote: >> >> > the trouble is i think there are some known bugs with ksh. i >>

rtadvd: replace hand-rolled filter with ROUTE_MSGFILTER

2015-11-30 Thread Jérémie Courrèges-Anglas
rtadvd(8) reimplements in userland what setsockopt(ROUTE_MSGFILTER) does, with the additional drawback that it is uselessly woken up for routing messages it doesn't care about. The unreachable RTM_GET case in get_next_msg() can also go away. ok? Index: if.c

rtadvd: remove router renumbering support

2015-11-30 Thread Jérémie Courrèges-Anglas
ie. https://tools.ietf.org/html/rfc2894 This code has been rotting since a long time, only activated during two months after the initial import from KAME. Since rtadvd.c rev.1.3, the -R command-line switch has no effect. This protocol is unsafe and assumes that communication between renumbered

rtadvd: useless argument/checks in if.c:get_next_msg()

2015-11-30 Thread Jérémie Courrèges-Anglas
Hi, get_next_msg() takes an "ifindex" argument, and contains code to check whether the interface affected by a routing message is "the correct one". Those tests have always been meaningless since import, 'cause the "ifindex" argument passed to this function has always been 0 and the checks are

Re: ntpd pledge, needs "unix" to talk to ntpctl

2015-11-20 Thread Jérémie Courrèges-Anglas
Reyk Floeter writes: > On Fri, Nov 20, 2015 at 02:07:46PM +0100, J??r??mie Courr??ges-Anglas wrote: >> Andreas Kusalananda K??h??ri writes: >> >> > Hi, >> > >> > I noticed that ntpd would die if I tried to use ntpctl to check on it: >> > >> > [...]

Re: Use symbolic name instead of hardcoded value on telnet(1)

2015-11-20 Thread Jérémie Courrèges-Anglas
Ricardo Mestre writes: > Use symbolic name instead of hardcoded value on telnet(1): Committed, thanks. > Index: commands.c > === > RCS file: /cvs/src/usr.bin/telnet/commands.c,v > retrieving revision 1.79

Re: does openssl get to use dns?

2015-11-20 Thread Jérémie Courrèges-Anglas
"Todd T. Fries" writes: > To demonstrate: > > openssl s_client -connect www.google.com:443 Heh. > A fix, probably not the full or correct one: ok jca@ do_accept(), in s_socket.c calls gethostbyaddr, then gethostbyname if the former fails... > Index: openssl.c >

Re: Use symbolic name instead of hardcoded value on telnet(1)

2015-11-20 Thread Jérémie Courrèges-Anglas
Ricardo Mestre writes: > That was fast, thank you! In the meantime I found a few more offenders, > patch below. It is unclear to me whether the cvs patch should be committed. Most of those calls *may* go away soon, along with the surrounding code. > PS: I previously

Re: move cron socket to /var/run/cron.sock (pledge)

2015-11-12 Thread Jérémie Courrèges-Anglas
Theo de Raadt writes: >> Grmbl. I've hard a hard time trying to understand *why* this would be >> needed. The answer is pledge(2), who makes chmod(2) fail with EPERM >> instead of killing the process. >> >> I find this confusing. IMO pledge(2) should let the kernel

Re: move cron socket to /var/run/cron.sock (pledge)

2015-11-11 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > On Wed, 11 Nov 2015 23:30:48 +0100, > =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- > Anglas?= wrote: > >> "Todd C. Miller" writes: >> >> > On Wed, 11 Nov 2015 14:43:47 -0700, "Todd C. Miller" wrote: >> > >> >>

Re: warn/err for crontab(1)

2015-11-11 Thread Jérémie Courrèges-Anglas
ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: at(1): stop locking the spool dir

2015-11-11 Thread Jérémie Courrèges-Anglas
ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: at(1): stop locking the spool dir

2015-11-11 Thread Jérémie Courrèges-Anglas
ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: move cron socket to /var/run/cron.sock

2015-11-11 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > On Wed, 11 Nov 2015 14:43:47 -0700, "Todd C. Miller" wrote: > >> There's limited backward compatibility so you can run a new crontab >> with an older cron daemon. > > Revised diff, I neglected to send out the cron.c changes in the > first

Re: [patch] tcpdump gre sre segfault

2015-11-05 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2015/11/03 20:04, Kevin Reay wrote: >> Fix a segfault in the GRE printer when a GRE packet SRE length >> extends past the actual captured length (but not the packet's >> original length). > > That's OK with me.. Committed, thanks Kevin. >>

Re: [patch] tcpdump print-tcp printf format tweaks

2015-11-05 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: >> > Attempted to match printf formating of unsigned 32bits to rest of >> > file. >> >> I don't think this is the good direction. "seq" and "length" are 32bits >> integers. Why cast them to long, and then print them as unsigned long? >> Let's

Re: [patch] tcpdump print-null AF_LINK segfault

2015-11-05 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: > Fixes a segfault (in tcpdump.c:default_print) when a printing a raw > packet of family AF_LINK with an unknown ether_type with > MALLOC_OPTIONS=S. The original version would print 4-bytes of d0 and > occasionally segfault. > > With this change,

Re: tcpdump: stop building SLIP support

2015-11-04 Thread Jérémie Courrèges-Anglas
Theo de Raadt writes: > Why? > > We don't have decnet code either, yet it is nice to sniff it if you > see it. My understanding was that since sl(4) is gone, there's no way to have an interface configured with SLIP on OpenBSD, thus no way to see that protocol and no way

Re: [patch] tcpdump print-tcp printf format tweaks

2015-11-04 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: > Change printf format to print unsigned values. Minor spacing change of > casts to match file/style(9). > > Attempted to match printf formating of unsigned 32bits to rest of > file. I don't think this is the good direction. "seq" and "length"

Re: ftp(1): pledge smaller subset in SMALL version

2015-11-04 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > Frederic Nowak <f...@mailbox.org> writes: > >> Hi there, > > Hi, > >> at the moment ftp pledges "proc exec" in its SMALL version, but not >> otherwise. This seems wrong, because the SMALL ve

tcpdump: stop building SLIP support

2015-11-04 Thread Jérémie Courrèges-Anglas
Some time ago mpi removed the sl(4) driver, IIUC this makes a bunch of code useless in tcpdump. The diff below only removes the define. If people prefer, I could also kill some noise by removing the useless code in print-sl.c, leaving only the stub functions. Comments / ok? Index: Makefile

RFC2292 remnants in ip6(4)

2015-11-02 Thread Jérémie Courrèges-Anglas
Hi, Ted recently removed the backwards compat for RFC2292 options, here's a small nit about documentation: IPV6_PKTOPTIONS is deprecated by RFC3542, and it doesn't appear anymore in /usr/src, except in this manpage. ok? Index: share/man/man4/ip6.4

Re: crontab: use setegid() instead of swap functions

2015-11-02 Thread Jérémie Courrèges-Anglas
"Todd C. Miller" writes: > Using setegid() directly makes the code easier to read. > Some of these calls will be removed in a later diff. looks fine, ok jca@ [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: whois(1) -I (whois.iana.org)

2015-11-02 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > This seems quite a useful database now that there are 500+ TLDs, > OK to add a flag to use it more easily from whois(1)? That's indeed nicer. :) ok jca@ [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: Unsigned char cast for ctype func in uniq(1)

2015-11-02 Thread Jérémie Courrèges-Anglas
Michael McConville writes: > ok? Sure. > > Index: usr.bin/uniq/uniq.c > === > RCS file: /cvs/src/usr.bin/uniq/uniq.c,v > retrieving revision 1.22 > diff -u -p -r1.22 uniq.c > --- usr.bin/uniq/uniq.c 9 Oct

Re: ftp(1): pledge smaller subset in SMALL version

2015-11-02 Thread Jérémie Courrèges-Anglas
Frederic Nowak writes: > Hi there, Hi, > at the moment ftp pledges "proc exec" in its SMALL version, but not > otherwise. This seems wrong, because the SMALL version does not support > interactive mode (which needs "proc exec" for e.g. the page command), > while the !SMALL

Re: [PATCH] pledging dhclient

2015-11-02 Thread Jérémie Courrèges-Anglas
Loganaden Velvindron writes: > Hi guys, Hi, > I've been playing with pledge in base. Here's a small patch for dhclient. > It's still a WiP. > > I can kill -HUP dhclient, and so far no issues. > > I would like it to pledge before however, so that write operations (write_*) >

Re: (patch) tcpdump cleanup stats format

2015-10-28 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: > Correct printf format for received/dropped packet counts in cleanup(). Committed, thanks. > ps_recv and ps_drop (struct pcap_stat) are both type u_int. > Index: tcpdump.c > === >

Re: sed: better error handling

2015-10-26 Thread Jérémie Courrèges-Anglas
Thanks to Michael sed has moved from an error-prone custom err() function to error(). Here's a cleanup for the arguments you can pass to error(). - some calls to err(1, ...) - as in err(3) - had crept in. But misc.c:err() did exit right away if you passed it 1 - despite the misleading

route6d: another pidfile() removal

2015-10-25 Thread Jérémie Courrèges-Anglas
Following the recent discussions, here's another pidfile(3) removal. route6d(8) doesn't document it. ok? Index: Makefile === RCS file: /cvs/src/usr.sbin/route6d/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile ---

Re: sed: better error message

2015-10-25 Thread Jérémie Courrèges-Anglas
Michael McConville <mm...@mykolab.com> writes: > Jérémie Courrèges-Anglas wrote: >> Tobias Stoeckmann <tob...@stoeckmann.org> writes: >> >> > $ sed s/a/b/ /nofile >> > sed: 0: /nofile: /nofile >> > >> > That message doesn't tell me

Re: ftpd banner

2015-10-25 Thread Jérémie Courrèges-Anglas
"Ted Unangst" writes: > unifdef some foolishness. note that BSD is not currently defined when this > file is built. ok jca@ [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

telnet: low-delay traffic class for IPv6 connections

2015-10-25 Thread Jérémie Courrèges-Anglas
While here, there is no option to pass a different tos, and no other use of the "tos" variable out of tn(), so move the "tos" variable in tn() and assign it the right value from the start. ok? Index: commands.c === RCS file:

rtadvd: pledge() and pidfile() are in a boat

2015-10-25 Thread Jérémie Courrèges-Anglas
So I took look at which pledge requests rtadvd could use. Turns out it can't call pledge early, because it attempts to retrieve IPV6CTL_FORWARDING and pledge currently denies it. rtadvd is the only user of IPV6CTL_FORWARDING in base, so IMO it doesn't call for a change in kern_pledge.c. There

telnet: kill dead IP source route

2015-10-24 Thread Jérémie Courrèges-Anglas
Hi, until today I did not know that some of our code did check for IP SSRR and LSRR IP options in incoming packets. That made me look for software that tried to use these options in outgoing packets. That code, in telnet(1), has been broken since 1998, says cvs log. I doubt that anyone will

Re: Pledge "id" for identd

2015-10-22 Thread Jérémie Courrèges-Anglas
Gregor Best writes: > Hi people, Hi, > identd's parent process needs to pledge "id" so it can call setgroups > and friends later. Likely a victim of the "proc" -> "id" switch. The following diff survived a few tests. Index: identd.c

Re: size: cannot read a.out: No such file or directory

2015-08-24 Thread Jérémie Courrèges-Anglas
Alexey Suslikov alexey.susli...@gmail.com writes: Hi tech@. size(1) DESCRIPTION says: ... If no file is specified size attempts to report on the file a.out. And, indeed, it warns: $ size size: cannot read a.out: No such file or directory Above message looks misleading in a.out-less

Re: document clear(1) a bit more prominently

2015-08-24 Thread Jérémie Courrèges-Anglas
Theo Buehler t...@math.ethz.ch writes: The clear(1) manpage is linked to the tput(1) manpage, but the clear utility is only mentioned in the history section. I suggest to make its appearance in the manual page a little more prominent. Committed, with the following difference, suggested by

Re: Possible fix for i217 problem

2015-08-05 Thread Jérémie Courrèges-Anglas
Jonathan Gray j...@jsg.id.au writes: On Tue, Aug 04, 2015 at 10:47:27PM +0100, Stuart Henderson wrote: On 2015/08/04 22:40, Stefan Fritsch wrote: someone mentioned to me the i217-LM problems that were reported on misc end of May. It is possible that the patch below helps. This fixes my

Re: ikectl: quote passwords passed to the shell

2015-07-23 Thread Jérémie Courrèges-Anglas
Stuart Henderson st...@openbsd.org writes: This avoids breaking with shell special characters. OK for the simple fix? Or is there a safer way to feed in the password? OK. I only took a quick look at it, but -key seems the only way to pass the password, and switching this to execv(e) seems

Re: sed -i

2015-07-17 Thread Jérémie Courrèges-Anglas
Jasper Lievisse Adriaanse jas...@openbsd.org writes: Hi, Here's a diff to add the '-i' flag to sed to do inplace edits. It's mostly from FreeBSD with some adjustments to prevent a race with unlink() and fopen() during the tempfile creation. It's been tested in a full ports bulk (thanks

Re: passwd(1): describe behavior when user not specified

2015-07-15 Thread Jérémie Courrèges-Anglas
Todd C. Miller todd.mil...@courtesan.com writes: This comes up periodically with users being confused when running passwd after su changes the passwd of the user they came from. Indeed. ok jca@ Index: usr.bin/passwd/passwd.1

Re: lorder(1) - don't rely on sort(1) and join(1) historical behavior

2015-07-02 Thread Jérémie Courrèges-Anglas
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: When I looked at the lorder script, I had trouble understanding the sort and join calls, since the syntax used is historical. I'm using this diff since a couple of months. Could someone double check that I got the conversion right

lorder(1) - don't rely on sort(1) and join(1) historical behavior

2015-06-19 Thread Jérémie Courrèges-Anglas
When I looked at the lorder script, I had trouble understanding the sort and join calls, since the syntax used is historical. I'm using this diff since a couple of months. Could someone double check that I got the conversion right? Index: lorder.sh

Re: samba4 slow startup, shared libs?

2015-06-18 Thread Jérémie Courrèges-Anglas
Ian Mcwilliam i.mcwill...@uws.edu.au writes: Curiously from --- samba-4.0.3/wscript Tue Dec 4 21:07:44 2012 +++ samba-4.0.26/wscript Mon Dec 8 18:46:38 2014 -if sys.platform != openbsd4: +if not sys.platform.startswith(openbsd): conf.env.asneeded_ldflags =

Re: How to tie up p_tid with pthread_self's thread ID

2015-05-05 Thread Jérémie Courrèges-Anglas
Stuart Henderson st...@openbsd.org writes: I am trying to track down some threads which are seeing high cpu use in top(1), but can't work out how to track back from any information available from struct kinfo_proc back to a thread ID as returned by pthread_self(). The threaded program can

const char *swapfile in kvm_open(3)

2015-04-04 Thread Jérémie Courrèges-Anglas
Here's some nitpicking. Index: kvm_open.3 === RCS file: /cvs/src/lib/libkvm/kvm_open.3,v retrieving revision 1.17 diff -u -p -r1.17 kvm_open.3 --- kvm_open.3 21 Jan 2014 03:15:45 - 1.17 +++ kvm_open.3 4 Apr 2015 18:29:25

Re: sys/stat.h: visibility of fchmod and lstat

2015-04-04 Thread Jérémie Courrèges-Anglas
Hi, just to make things clear, I have no strong opinion towards Philip's proposal. I merely had kept __BSD_VISIBLE mostly because those functions had appeared in BSD before they were standardized. Updated diff, reversing the order of the tests, but not (yet?) suppressing the __BSD_VISIBLE

sys/stat.h: visibility of fchmod and lstat

2015-04-03 Thread Jérémie Courrèges-Anglas
A few months ago, I spotted warnings in a port, related to the decl of one of those functions not being reachable. This went in a bulk (still a few months ago, thanks to landry@) with no fallout. Does this look fine? Index: stat.h

Re: ksh version lies

2015-02-17 Thread Jérémie Courrèges-Anglas
Ted Unangst t...@tedunangst.com writes: Jérémie Courrèges-Anglas wrote: Tristan Le Guern tlegu...@bouledef.eu writes: On 02/16/2015 05:22 PM, Todd C. Miller wrote: There are scripts that use KSH_VERSION to determine whether they are being run under ksh or a Bourne shell. That seems

Re: ksh version lies

2015-02-17 Thread Jérémie Courrèges-Anglas
Ted Unangst t...@tedunangst.com writes: [...] So let's return to the top. What does PD KSH in KSH_VERSION mean? What does one do differently if that string is present or missing? sigh pdksh is not the same thing as ksh88 or ksh93. And not the same thing as mksh, which has grew

Re: ksh version lies

2015-02-17 Thread Jérémie Courrèges-Anglas
Tristan Le Guern tlegu...@bouledef.eu writes: On 02/16/2015 05:22 PM, Todd C. Miller wrote: There are scripts that use KSH_VERSION to determine whether they are being run under ksh or a Bourne shell. That seems like a reasonable thing to do. I don't really care what the version number is

Re: stop deleting /usr/include/openssl

2015-02-16 Thread Jérémie Courrèges-Anglas
Stuart Henderson st...@openbsd.org writes: On 2015/02/16 13:53, Jérémie Courrèges-Anglas wrote: Ted Unangst t...@tedunangst.com writes: [...] - @ln -sf openssl ${DESTDIR}/usr/include/ssl Not ok for this part... ack, this is highly likely to break ports. and base. (I'm cooking

Re: stop deleting /usr/include/openssl

2015-02-16 Thread Jérémie Courrèges-Anglas
Ted Unangst t...@tedunangst.com writes: Index: Makefile === RCS file: /cvs/src/include/Makefile,v retrieving revision 1.198 diff -u -p -r1.198 Makefile --- Makefile 17 Jan 2015 20:37:04 - 1.198 +++ Makefile 16 Feb

Unbreak nc -T + IPv6

2015-02-14 Thread Jérémie Courrèges-Anglas
Currently: $ nc -T lowdelay ::1 22 nc: set IP ToS: Invalid argument With the diff below: $ ./obj/nc -T lowdelay ::1 22 SSH-2.0-OpenSSH_6.7 ok? Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.126

Re: 5.6 nslookup - uses port 48830

2015-02-14 Thread Jérémie Courrèges-Anglas
(stripping bind-users@ from the CC list since current bind versions aren't affected) Pawel S. Veselov pawel.vese...@gmail.com writes: On Sun, 1 Feb 2015 15:06:17 -0800 Pawel S. Veselov pawel.vese...@gmail.com wrote: Running latest amd64 5.6 (p16, just upgraded to it), for some reason my

Re: PATCH: ntpctl.8, ntpd.c

2015-02-14 Thread Jérémie Courrèges-Anglas
Jason McIntyre j...@kerhand.co.uk writes: On Fri, Feb 13, 2015 at 09:49:58PM -0600, Adam Thompson wrote: Fix a minor typo in the ntpctl help output, and same semantic mistake in the manpage. Currently says (to be pedantic) that '-s' only works with 'all', which is not the case: '-s' is

Re: libpcap monitor_mode() handle s/EINVAL/ENOTTY/ for unknown ioctls

2015-02-14 Thread Jérémie Courrèges-Anglas
Makes sense, ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: [patch] xdm doesn't clear wtmp/utmp entry after log out

2015-01-26 Thread Jérémie Courrèges-Anglas
Matthieu Herrb matth...@herrb.eu writes: On Tue, Jan 13, 2015 at 01:38:36PM -0800, patrick keshishian wrote: [...] Makes sense. ok matthieu@ Committed, thanks. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: ftp proxy host header

2015-01-12 Thread Jérémie Courrèges-Anglas
Stuart Henderson st...@openbsd.org writes: On 2015/01/12 12:35, Alexander Bluhm wrote: Hi, Fetching port distfiles with ftp from githup does not work when using a https proxy. The problem is that the http Host header is not not set and githup.com needs that. So remember the host form

Re: env fix

2015-01-11 Thread Jérémie Courrèges-Anglas
Philip Guenther guent...@gmail.com writes: On Sun, 11 Jan 2015, Ted Unangst wrote: Even more awesome. How about enforcing the full rule? IIUC the first diff removed '/' from the characters allowed in an environment variable, so that one can run env(1) and a program whose name contains '='...

chpass(1) change/expire time, and long long time_t

2015-01-04 Thread Jérémie Courrèges-Anglas
This should make things better on 32 bits archs in a few years. Tested on amd64 by changing the format to %d. ok? Index: edit.c === RCS file: /cvs/src/usr.bin/chpass/edit.c,v retrieving revision 1.34 diff -u -p -p -u -r1.34 edit.c

Re: chpass(1) change/expire time, and long long time_t

2015-01-04 Thread Jérémie Courrèges-Anglas
Theo de Raadt dera...@cvs.openbsd.org writes: This should make things better on 32 bits archs in a few years. Tested on amd64 by changing the format to %d. ok? Index: edit.c === RCS file: /cvs/src/usr.bin/chpass/edit.c,v retrieving

Re: uuidgen port from FreeBSD for inclusion in OpenBSD base

2014-10-18 Thread Jérémie Courrèges-Anglas
Why do you post publicly a private mail without asking first? Looks like my first impression about you was right. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

  1   2   3   >