Re: ftpd(8): constify internal functions

2021-05-13 Thread Jan Klemkow
ping? On Tue, May 04, 2021 at 10:50:50AM +0200, Jan Klemkow wrote: > Hi, > > The following diff adds some missing consts for char * to the internal > program functions. > > OK? > > bye, > Jan > > Index: extern.h > ==

Re: ftpd(8): remove useless islower(3) in upper()

2021-05-13 Thread Jan Klemkow
ping? On Sat, May 01, 2021 at 11:19:56AM +0200, Jan Klemkow wrote: > Hi, > > This cleanup diff, removes a useless if islower(3) from the loop. It is > guarantee by toupper(3) that no character will be changed if its not a > lower one. > > man toupper(3): > The

Re: ftpd(8): remove double fflush(3) calls

2021-05-13 Thread Jan Klemkow
ping? On Wed, May 05, 2021 at 04:42:49PM +0200, Jan Klemkow wrote: > Hi, > > The function lreply() already calls fflush(3) on stdout. So, this calls > are useless. > > OK? > > bye, > Jan > > Index: ftpd.c >

ftpd(8): add pledge(2)

2021-05-13 Thread Jan Klemkow
Hi, This is the first attempt to bring pledge into ftpd. The Main ftpd process can't use pledge for now because of possible chroot(2) calls. But, the two forks after user login are pledged with this diff. I tested it manually and with the ftpd's regression tests. OK? bye, Jan Index:

Re: services(5): add default ftps ports

2021-05-07 Thread Jan Klemkow
On Thu, May 06, 2021 at 11:09:03AM -0600, Theo de Raadt wrote: > Jan Klemkow wrote: > > > > > > I'm working on a diff to bring ftps with libtls into our ftpd(8). > > > > > There > > > > > is a "getaddrinfo(NULL, "ftps", ,

Re: services(5): add default ftps ports

2021-05-06 Thread Jan Klemkow
On Thu, May 06, 2021 at 06:36:52PM +0200, Mark Kettenis wrote: > > From: "Theo de Raadt" > > Date: Thu, 06 May 2021 10:26:31 -0600 > > > > Jan Klemkow wrote: > > > > > On Wed, May 05, 2021 at 12:18:43PM -0600, Theo de Raadt wrote: > >

Re: services(5): add default ftps ports

2021-05-06 Thread Jan Klemkow
tcp, 32 of the 512 are locked out. > For udp, 19. > > What software is actually using these ports? > > Is that software irrelevant these days? I'm working on a diff to bring ftps with libtls into our ftpd(8). There is a "getaddrinfo(NULL, "ftps", , )" call, which uses

ftpd(8): remove double fflush(3) calls

2021-05-05 Thread Jan Klemkow
Hi, The function lreply() already calls fflush(3) on stdout. So, this calls are useless. OK? bye, Jan Index: ftpd.c === RCS file: /cvs/src/libexec/ftpd/ftpd.c,v retrieving revision 1.229 diff -u -p -r1.229 ftpd.c --- ftpd.c

Re: services(5): add default ftps ports

2021-05-05 Thread Jan Klemkow
On Wed, May 05, 2021 at 11:09:12AM +0100, Stuart Henderson wrote: > On 2021/05/04 12:07, Jan Klemkow wrote: > > Add missing ftps defaults ports to servies(5). > > > > Index: services > > === > >

services(5): add default ftps ports

2021-05-04 Thread Jan Klemkow
Hi, Add missing ftps defaults ports to servies(5). OK? bye, Jan Index: services === RCS file: /cvs/src/etc/services,v retrieving revision 1.99 diff -u -p -r1.99 services --- services18 Feb 2021 02:30:29 - 1.99 +++

ftpd(8): constify internal functions

2021-05-04 Thread Jan Klemkow
Hi, The following diff adds some missing consts for char * to the internal program functions. OK? bye, Jan Index: extern.h === RCS file: /cvs/src/libexec/ftpd/extern.h,v retrieving revision 1.21 diff -u -p -r1.21 extern.h ---

ftpd(8): remove useless islower(3) in upper()

2021-05-01 Thread Jan Klemkow
Hi, This cleanup diff, removes a useless if islower(3) from the loop. It is guarantee by toupper(3) that no character will be changed if its not a lower one. man toupper(3): The toupper() and toupper_l() functions convert a lower-case letter to the corresponding upper-case letter.

fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread Jan Klemkow
Hi, If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader will hang while loading the kernel. Because, the UEFI loads the bootloader on the same place in memory, where the bootloader will copy the kernel. We are unable to load the kernel on arbitrary memory. Thus, the

Re: vmm crash on 6.9-beta

2021-03-19 Thread Jan Klemkow
Hi, I had the same issue a few days ago a server hardware of mine. I just ran 'cvs up'. So, it looks like a generic bug in FFS and not related to vmm. OpenBSD 6.9-beta (GENERIC.MP) #396: Thu Mar 11 19:15:56 MST 2021 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP

Re: LibreSSL: extend the max. no. of SANs for avoid OOM error

2021-03-17 Thread Jan Klemkow
ping On Tue, Mar 09, 2021 at 03:49:32PM +0100, Jan Klemkow wrote: > Hi, > > The verification of the https://ugos.ugm.ac.id certificate contains 2032 > subject alt names which leads to the following error in LibreSSL. > > # openssl s_client -connect ugos.ugm.ac.id:443 > ...

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Jan Klemkow
On Mon, Mar 15, 2021 at 01:35:28AM -0600, Theo de Raadt wrote: > My comments are about the "text name", which goes into every kernel > anyone compiles. > > It should be as short as possible. Sorry, I missed that point. > But the reason why 10G is incorrect is because surely the port can >

Re: ixl(4): add ID for X710 10G SFP+

2021-03-15 Thread Jan Klemkow
On Sun, Mar 14, 2021 at 12:39:42PM -0600, Theo de Raadt wrote: > > +product INTEL X710_10G_SFP_2 0x104e X710 10G SFP+ > > You only need: > > X710 SFP+ > > Adding 10G is incorrect. OK? Thanks, Jan Index: if_ixl.c === RCS file:

ixl(4): add ID for X710 10G SFP+

2021-03-14 Thread Jan Klemkow
Hi, This diff attaches the Intel x710 10G SFP+ NIC in ixl(4). ixl2 at pci11 dev 0 function 2 "Intel X710 10G SFP+" rev 0x02: port 1, FW 8.1.63299 API 1.12, msix, 8 queues, address 3c:ec:ef:1f:c3:bc ixl3 at pci11 dev 0 function 3 "Intel X710 10G SFP+" rev 0x02: port 3, FW 8.1.63299 API 1.12,

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jan Klemkow
On Fri, Mar 12, 2021 at 11:56:00AM +0100, Mark Kettenis wrote: > I believe this is what ark.intel.com calls a "Intel SSD DC P4510 > Series" part. Is that correct? Yes, that is correct. On Fri, Mar 12, 2021 at 10:00:54PM +1100, Jonathan Gray wrote: > On Fri, Mar 12, 2021 at 11

add missing PCI ID for Intel NVMe

2021-03-12 Thread Jan Klemkow
Hi, This diff add a missing PCI ID of an Intel NVMe disk. The disk works after my last fix [1]. OK? bye, Jan [1]: https://marc.info/?l=openbsd-tech=161418460303831 Index: pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v

LibreSSL: extend the max. no. of SANs for avoid OOM error

2021-03-09 Thread Jan Klemkow
Hi, The verification of the https://ugos.ugm.ac.id certificate contains 2032 subject alt names which leads to the following error in LibreSSL. # openssl s_client -connect ugos.ugm.ac.id:443 ... verify error:num=17:out of memory ... The following diff sets the maximum number of SANs to the next

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
On Fri, Mar 05, 2021 at 09:22:28AM -0700, Theo de Raadt wrote: > Fix dump() to convert subclass == NULL into something else, or maybe the > fix should be in pci_subclass() itself. My initial mistake was to use zero in an empty list. This leads to one element in the list, which causes wrong list

Re: pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
On Fri, Mar 05, 2021 at 04:13:53PM +0100, Mark Kettenis wrote: > > Date: Fri, 5 Mar 2021 12:05:38 +0100 > > From: Jan Klemkow > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > > > Hi, > > > > this diff adds the mis

pcidump(8): add missing PCI classes

2021-03-05 Thread Jan Klemkow
Hi, this diff adds the missing PCI classes Accelerator and Instrumentation. Thus, we can replace a few unknown in its output: - 0x0008: Class: 13 (unknown), Subclass: 00 (unknown), + 0x0008: Class: 13 Instrumentation, Subclass: 00 (null), Both Classes have vendor specific APIs. So,

ixl(4): add missing pci dev id for X710 10GBase-T

2021-02-26 Thread Jan Klemkow
Hi, The diff below adds a missing PCI device ID for an X710 10GBase NIC into the ixl(4) driver. The interfaces attach and run properly with this diff. ixl0 at pci11 dev 0 function 0 "Intel X710 10GBaseT" rev 0x02: port 0, FW 8.1.63299 API 1.12, msix, 8 queues, address 3c:ec:ef:1f:c3:ba ixl1 at

Re: LibreSSL legacy verifier regression

2021-02-25 Thread Jan Klemkow
On Wed, Feb 24, 2021 at 09:21:56PM +0100, Theo Buehler wrote: > On Wed, Feb 24, 2021 at 09:00:05PM +0100, Theo Buehler wrote: > > On Wed, Feb 24, 2021 at 06:47:00AM +0100, Jan Klemkow wrote: > > > another co-worker of mine has found an other regress in the LibreSSL > > &g

fix nvme(4): NULL deref. and empty device attachments

2021-02-24 Thread Jan Klemkow
Hi, While attaching the following disks, the nvme driver runs into a NULL dereference in nvme_scsi_capacity16() and nvme_scsi_capacity(). nvme0 at pci1 dev 0 function 0 vendor "Intel", unknown product 0x0a54 rev 0x00: msix, NVMe 1.2 nvme0: INTEL SSDPE2KX040T8, firmware VDV10170, serial

LibreSSL legacy verifier regression

2021-02-24 Thread Jan Klemkow
lib/libcrypto/expcert/expcrt.c --- /dev/null 1 Jan 1970 00:00:00 - +++ lib/libcrypto/expcert/expcrt.c 24 Feb 2021 05:27:46 - @@ -0,0 +1,218 @@ +/* $OpenBSD$ */ +/* + * Copyright (c) 2021 Jan Klemkow + * Copyright (c) 2021 Anton Borowka + * + * Permission to use, copy, modify, and di

Re: LibreSSL regressions

2021-02-16 Thread Jan Klemkow
On Tue, Feb 16, 2021 at 04:36:59AM +1100, Joel Sing wrote: > On 21-02-15 14:49:46, Jan Klemkow wrote: > > On Sat, Feb 13, 2021 at 03:53:48PM +0100, Theo Buehler wrote: > > > On Sat, Feb 13, 2021 at 11:58:04AM +0100, Jan Klemkow wrote: > > > > A coworker of mine h

Re: LibreSSL regressions

2021-02-15 Thread Jan Klemkow
On Tue, Feb 16, 2021 at 04:36:59AM +1100, Joel Sing wrote: > On 21-02-15 14:49:46, Jan Klemkow wrote: > > +create-libressl-test-certs: create-libressl-test-certs.pl > > + ${PERL} ${.CURDIR}/$@.pl > > We can see how this goes, however we may end up wanting to genera

Re: LibreSSL regressions

2021-02-15 Thread Jan Klemkow
On Sat, Feb 13, 2021 at 03:53:48PM +0100, Theo Buehler wrote: > On Sat, Feb 13, 2021 at 11:58:04AM +0100, Jan Klemkow wrote: > > A coworker of mine has made tests with LibreSSL [1] and found some > > regressions. I took his test descriptions and created the following > > auto

LibreSSL regressions

2021-02-13 Thread Jan Klemkow
Hi, A coworker of mine has made tests with LibreSSL [1] and found some regressions. I took his test descriptions and created the following automated regression test. In the repository he described his findings in detail. I kept the numbers of the files and subtests in the target names for now.

Re: diff: tcp ack improvement

2021-02-08 Thread Jan Klemkow
On Mon, Feb 08, 2021 at 03:42:54PM +0100, Alexander Bluhm wrote: > On Wed, Feb 03, 2021 at 11:20:04AM +0100, Claudio Jeker wrote: > > Just commit it. OK claudio@ > > If people see problems we can back it out again. > > This has huge impact on TCP performance. > >

Re: diff: tcp ack improvement

2021-02-03 Thread Jan Klemkow
On Tue, Jan 05, 2021 at 10:30:33AM +0100, Claudio Jeker wrote: > On Tue, Jan 05, 2021 at 10:16:04AM +0100, Jan Klemkow wrote: > > On Wed, Dec 23, 2020 at 11:59:13AM +, Stuart Henderson wrote: > > > On 2020/12/17 20:50, Jan Klemkow wrote: > > > > ping > > >

Re: diff: tcp ack improvement

2021-01-05 Thread Jan Klemkow
On Wed, Dec 23, 2020 at 11:59:13AM +, Stuart Henderson wrote: > On 2020/12/17 20:50, Jan Klemkow wrote: > > ping > > > > On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > > > bluhm and I make some network performance measurements and kernel > >

Re: remove double call of ttyopen()

2020-12-28 Thread Jan Klemkow
On Mon, Dec 28, 2020 at 07:59:23PM +0100, Klemens Nanni wrote: > On Mon, Dec 28, 2020 at 03:49:35PM +0100, Jan Klemkow wrote: > > The following diff removes useless double calls of ttyopen. l_open is > > a pointer to ttyopen(). All other serial drivers also

remove double call of ttyopen()

2020-12-28 Thread Jan Klemkow
Hi, The following diff removes useless double calls of ttyopen. l_open is a pointer to ttyopen(). All other serial drivers also just use l_open, as it is the general API for this. OK? Bye, Jan Index: arch/luna88k/dev/siotty.c

Re: diff: tcp ack improvement

2020-12-17 Thread Jan Klemkow
ping On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > Hi, > > bluhm and I make some network performance measurements and kernel > profiling. > > Setup:Linux (iperf) -10gbit-> OpenBSD (relayd) -10gbit-> Linux (iperf) > > We figured out, that

Re: rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
On Tue, Dec 15, 2020 at 10:59:50PM +, Stuart Henderson wrote: > On 2020/12/15 23:07, Jan Klemkow wrote: > > for frequent performance test it would be nice to just start tcpbench > > as a regular service. tcpbench gets an extra user and group with this > > diff and is alre

Re: rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
On Tue, Dec 15, 2020 at 03:43:38PM -0700, Theo de Raadt wrote: > Jan Klemkow wrote: > > > for frequent performance test it would be nice to just start tcpbench > > as a regular service. tcpbench gets an extra user and group with this > > diff and is already p

rc.d(8) for tcpbench

2020-12-15 Thread Jan Klemkow
Hi, for frequent performance test it would be nice to just start tcpbench as a regular service. tcpbench gets an extra user and group with this diff and is already pledged to "stdio". Thus, there should be no security risk to do this even in hostile environments. OK? bye, Jan Index:

diff: mbuf-chains for tcp/ip/ether_ouput

2020-12-15 Thread Jan Klemkow
Hi, I took on old idea and diff [1] from bluhm and finished it for the IPv4 case. This change uses mbuf chains in tcp/ip/ether_output instead of single mbufs. This approach takes lesser processing power per packets, which we want to send out. In several code path it optimises the processing

diff: cleanup type handling

2020-12-12 Thread Jan Klemkow
Hi, The type of the local variable hash in pf_map_addr() has right length but the wrong type. This diff uses the correct type and removes the useless casts. Both functions uses hash as pf_addr, so no cast is needed. OK? bye, Jan Index: net/pf_lb.c

diff: replace useless use of MCLGETL with MCLGET

2020-12-12 Thread Jan Klemkow
Hi, The use of MCLGETL with the default length MCLBYTES is useless. Thus, this diff removes '(void)' from the MCLGET macro as it is in the MCLGETL and replaces all uses of MCLGETL with MCLBYTES by MCLGET. OK? bye, Jan Index: arch/octeon/dev/if_ogx.c

Re: FT232H variant in uftdi(4)

2020-12-09 Thread Jan Klemkow
On Wed, Dec 09, 2020 at 09:11:35AM +0100, Jan Klemkow wrote: > On Tue, Dec 08, 2020 at 09:03:53PM -0300, Daniel Bolgheroni wrote: > > I have a FT232H variant (marked FT232HQ, 0403:6014) which works with > > uftdi(4). > > > > Still related to uftdi(4), sys/dev/usb/

Re: FT232H variant in uftdi(4)

2020-12-09 Thread Jan Klemkow
On Tue, Dec 08, 2020 at 09:03:53PM -0300, Daniel Bolgheroni wrote: > I have a FT232H variant (marked FT232HQ, 0403:6014) which works with uftdi(4). > > Still related to uftdi(4), sys/dev/usb/ftdi.c has a comment saying uftdi(4) > does not support multiple serial ports because ucom(4), but I'm

Re: diff: tcp ack improvement

2020-11-06 Thread Jan Klemkow
On Fri, Nov 06, 2020 at 08:03:36AM +0100, Otto Moerbeek wrote: > On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > > bluhm and I make some network performance measurements and kernel > > profiling. > > > > Setup: Linux (iperf) -10gbit-> OpenBSD (

diff: tcp ack improvement

2020-11-05 Thread Jan Klemkow
Hi, bluhm and I make some network performance measurements and kernel profiling. Setup: Linux (iperf) -10gbit-> OpenBSD (relayd) -10gbit-> Linux (iperf) We figured out, that the kernel uses a huge amount of processing time for sending ACKs to the sender on the receiving interface. After

diff: refactor MCLGETI() macro

2020-10-07 Thread Jan Klemkow
Hi, The name of the macro MCLGETI obsolete. It was made to use a network interface pointer inside. But, now it is just used to define a special length and the interface pointer is discarded. Thus, the following diff renames the macro to MCLGETL and removes the dead parameter ifp. OK? Bye,

diff: remove dead code in a{rm,md}64/a{rm,md}/conf.c

2020-10-07 Thread Jan Klemkow
Hi, the cdev_joy_init makro is just used in i386. OK? Bye, Jan Index: amd64/amd64/conf.c === RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v retrieving revision 1.71 diff -u -p -r1.71 conf.c --- amd64/amd64/conf.c 6 Jul 2020

new: rp(4): RocketPort multi serial port pci card driver

2020-10-03 Thread Jan Klemkow
1 Jan 1970 00:00:00 - +++ share/man/man4/rp.4 2 Oct 2020 17:50:01 - @@ -0,0 +1,54 @@ +.\" $OpenBSD$ +.\" +.\" Copyright (c) 2020 Jan Klemkow +.\" +.\" Permission to use, copy, modify, and distribute this software for any +.\" purpose with or without f

fix: ospf6d(8): wrong intra area announcement

2020-10-01 Thread Jan Klemkow
Hi, The new intra area db entry has to be saved into the tree before orig_intra_area_prefix_lsas() is called. If not, the ospf6d will not announce the new intra area db for a newly learned link from another ospf router of the broadcast domain. This bug is triggered, if you add new addresses an

Re: snmpd(8) Remove struct listen_sock

2020-08-22 Thread Jan Klemkow
On Sun, Aug 09, 2020 at 04:10:13PM +0200, Martijn van Duren wrote: > I still want to move udp/tcp handling out of snmpe, so that there's > better layering, but my previous diff never got any response and might > do with some more polishing. > > For now, lets remove listen_sock from snmpd,

diff: simplify ospf6d code

2020-08-21 Thread Jan Klemkow
Hi, The following diff simplifies a switch case statement with no functional change. In case of IMSG_CTL_SHOW_DATABASE duplicated code is removed. This part of the code is now the same as in ospfd. In case of IMSG_CTL_SHOW_DB_INTRA the code was also duplicated and due to a missing continue the

diff: uvm: fix unitialized var and simplify code in km_alloc()

2020-05-20 Thread Jan Klemkow
Hi, The function km_alloc() returns the uninitialized local variable sva if pgl is empty. It seems to be not possible in the current condition of the code, but I'm not sure if this is guaranteed. Thus, I would prefer to initialize sva with zero. It also seems to be unnecessary to loop over the

Re: diff: em(4) deadlock fix

2020-05-09 Thread Jan Klemkow
On Fri, May 08, 2020 at 04:36:28PM +0200, Mark Kettenis wrote: > > Date: Fri, 8 May 2020 15:39:26 +0200 > > From: Jan Klemkow > > On Mon, Apr 27, 2020 at 10:42:52AM +0200, Martin Pieuchot wrote: > > > So the current logic assumes that as long as the ring contains de

Re: diff: em(4) deadlock fix

2020-05-08 Thread Jan Klemkow
On Mon, Apr 27, 2020 at 10:42:52AM +0200, Martin Pieuchot wrote: > On 21/04/20(Tue) 15:54, Jan Klemkow wrote: > > The following diff fixes a deadlock in em(4) when system runs out of > > mbuf(9)s. > > > > Tested with current on amd64 with: > > em0 at pci0 dev

Re: patch: Enable dock audio on Thinkpad dock (Thinkpad L460)

2020-04-27 Thread Jan Klemkow
On Thu, Apr 16, 2020 at 05:59:44PM -0500, Abel Abraham Camarillo Ojeda wrote: > On Tuesday, February 11, 2020, Abel Abraham Camarillo Ojeda > wrote: > > On Wednesday, January 8, 2020, Abel Abraham Camarillo Ojeda > > wrote: > >> On Mon, Dec 30, 2019 at 1:24 PM Abel Abraham Camarillo Ojeda >

diff: em(4) deadlock fix

2020-04-21 Thread Jan Klemkow
Hi, The following diff fixes a deadlock in em(4) when system runs out of mbuf(9)s. Tested with current on amd64 with: em0 at pci0 dev 25 function 0 "Intel I217-LM" rev 0x05: msi, mac 0x1e phy 0xb, address d0:50:99:c1:67:94 When the system runs out of mbufs, the receive ring of the em-NIC also

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
the additional varbinds to > the trap handle "command". > > Now actually asking for OKs. :-) OK jan@ > On 3/10/20 1:43 PM, Jan Klemkow wrote: > > On Tue, Mar 10, 2020 at 01:13:46PM +0100, Martijn van Duren wrote: > >> On 3/10/20 10:21 AM, Jan Klemkow wrote: >

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
On Tue, Mar 10, 2020 at 01:13:46PM +0100, Martijn van Duren wrote: > On 3/10/20 10:21 AM, Jan Klemkow wrote: > > On Tue, Mar 10, 2020 at 12:27:20AM +0100, Martijn van Duren wrote: > >> Looking at RFC1157 section 4.1.6, an snmpv1 trap should also contain a > >> varbindlis

Re: snmpd(8): fix use of uninitialized pointer

2020-03-10 Thread Jan Klemkow
NULL anyway? bye, Jan > On 3/9/20 11:38 PM, Jan Klemkow wrote: > > Hi, > > > > The following diff fixes the use of the uninitialized pointer iter > > in trapcmd_exec(). > > > > iter is just initialized in traphandler_parse() if vers is SNMP_V2. In &

snmpd(8): fix use of uninitialized pointer

2020-03-09 Thread Jan Klemkow
Hi, The following diff fixes the use of the uninitialized pointer iter in trapcmd_exec(). iter is just initialized in traphandler_parse() if vers is SNMP_V2. In all other cases iter stays uninitialized and may dereferenced in trapcmd_exec(). OK? bye, Jan Index: traphandler.c

Re: diff: simplify globbing in ftpd(8)

2020-01-14 Thread Jan Klemkow
On Mon, Jan 13, 2020 at 10:30:11AM -0700, Todd C. Miller wrote: > On Mon, 13 Jan 2020 13:45:55 +0100, Jan Klemkow wrote: > > > This diff simplifies globbing for the ftpd(8) ls and stat command. And > > it avoids to glob for the parameters "-lgA". > > >

Re: [PATCH] src/libexec/ftpd: fix nlist with -option does not work

2020-01-14 Thread Jan Klemkow
On Mon, Nov 18, 2019 at 02:56:46PM +0900, SASANO Takayoshi wrote: > At least OpenBSD-6.5 and 6.6's ftpd does not work NLIST command with > any -option like this. > > > ftp> nlist > 150 Opening ASCII mode data connection for 'file list'. > uaa > _sysupgrade > 226 Transfer complete. > ftp>

Re: diff: simplify globbing in ftpd(8)

2020-01-13 Thread Jan Klemkow
On Mon, Jan 13, 2020 at 10:30:11AM -0700, Todd C. Miller wrote: > On Mon, 13 Jan 2020 13:45:55 +0100, Jan Klemkow wrote: > > This diff simplifies globbing for the ftpd(8) ls and stat command. And > > it avoids to glob for the parameters "-lgA". > > > &

diff: simplify globbing in ftpd(8)

2020-01-13 Thread Jan Klemkow
Hi, This diff simplifies globbing for the ftpd(8) ls and stat command. And it avoids to glob for the parameters "-lgA". Due, we just pass a single string to the ftpd_ls() function, we don't need to provide infrastructure for a dynamic list of arguments. Tested it manually and by regression

Re: Add sizes for free() in clct(4)

2019-12-20 Thread Jan Klemkow
On Fri, Dec 20, 2019 at 05:26:56PM +0100, Frederic Cambus wrote: > Here is a diff to add sizes for free() in clct(4). > > Similar diff to the ones previously sent for other audio drivers. > > Comments? OK? OK jan@ > Index: sys/dev/pci/cs4281.c >

Re: ublink(4), led(4) and ledctl(1)

2019-12-14 Thread Jan Klemkow
+main(int argc, char **argv) > +{ > ... > + exit(0); > +} I think its better to return 0 in main() instead of calling the libc function exit(3). > ... and also there are no manpages yet. Below is an example for ledctl.8. Thanks, Jan .\" $OpenBSD$ .\" .\" Copyr

Re: diff: simplify MGETHDR error handling in tcp_output

2019-11-06 Thread Jan Klemkow
Hi Lucas, On Wed, Nov 06, 2019 at 08:28:43PM +, Lucas wrote: > Jan Klemkow wrote: > > the following diff simplifies the error handling of MGETHDR() in > > tcp_output(). Jumps earlier to out, prevents a double check of NULL and > > makes the code more readable. >

Re: [patch] ftp: improve SMALL and NOSSL #ifdefs

2019-11-06 Thread Jan Klemkow
Hi Hiltjo, On Wed, Nov 06, 2019 at 07:53:02PM +0100, Hiltjo Posthuma wrote: > The below patch fixes the #ifndef's for usr.bin/ftp so any combination of > SMALL > and NOSSL will compile again. Diff looks good for me and works in all ifdef combinations without any warning or error. OK jan@

diff: simplify MGETHDR error handling in tcp_output

2019-11-06 Thread Jan Klemkow
Hi, the following diff simplifies the error handling of MGETHDR() in tcp_output(). Jumps earlier to out, prevents a double check of NULL and makes the code more readable. OK? Bye, Jan Index: netinet/tcp_output.c === RCS file:

Re: iwm: support dynamic queue allocation (DQA)

2019-10-16 Thread Jan Klemkow
On Mon, Oct 14, 2019 at 01:51:02PM +0200, Stefan Sperling wrote: > I have successfully tested this diff on 8265 with our current firmware > image (22.361476.0) as well as a newer -22 firmware image (22.391740.0, > which is *not* in fw_update yet). I have also tested 7265 successfully. Also works

Re: net80211: increase background scan backoff timer

2019-10-16 Thread Jan Klemkow
On Mon, Oct 14, 2019 at 02:22:24PM +0200, Stefan Sperling wrote: > Is anyone running this already? OK? I run the diff without any noticeable problems. Run this with iwm and wpa-enterprise. iwm0 at pci1 dev 0 function 0 "Intel Dual Band Wireless-AC 8265" rev 0x78, msi Seems to work for me. bye,

fix: build of aac(4)

2019-10-05 Thread Jan Klemkow
Hi, aac(4) doesn't build in the current status. The following diff fixes compile errors. Also, with the AAC_DEBUG option. I removed the prototypes of the inline functions in aacvar.h because of a K style compile error and that the prototypes are directly followed by their implementation. ok?

Re: system boot hang due to inteldrm(4)

2019-10-02 Thread Jan Klemkow
On Tue, Oct 01, 2019 at 11:34:09AM +1000, Jonathan Gray wrote: > On Tue, Oct 01, 2019 at 12:27:48AM +0200, Jan Klemkow wrote: > > After updating my router to current, the systems hangs during the boot. > > Maybe its caused by the "invalid EDID"?! The System boots up nor

system boot hang due to inteldrm(4)

2019-09-30 Thread Jan Klemkow
Hi, After updating my router to current, the systems hangs during the boot. Maybe its caused by the "invalid EDID"?! The System boots up normaly and doesn't hang, if I disable inteldrm(4) in UKC. Is this issue known? Or, witch additional debug information should I provide to help fixing this

Re: ix(4): enable checksum offload

2019-07-27 Thread Jan Klemkow
On 9.9.2013. 22:07, Mike Belopuhov wrote: > On 9 September 2013 21:48, Brad Smith wrote: > > Here is a diff to enable the checksum offload support for ix(4). > > > > Looking for any testing. > > > > last time i checked this broke ospf traffic. please make sure at least > ip/tcp, ip/udp,

Re: fix: NULL dereference in bios(4)

2019-07-23 Thread Jan Klemkow
On Tue, Jul 23, 2019 at 10:05:58PM +1000, Jonathan Gray wrote: > On Mon, Jul 22, 2019 at 10:03:38AM +0200, Jan Klemkow wrote: > > On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > > > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > > >

Re: fix: NULL dereference in bios(4)

2019-07-22 Thread Jan Klemkow
On Sat, Jul 20, 2019 at 07:16:05PM +1000, Jonathan Gray wrote: > On Fri, Jul 19, 2019 at 02:15:03PM +0200, Jan Klemkow wrote: > > On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > > > On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > > > &g

Re: fix: NULL dereference in bios(4)

2019-07-19 Thread Jan Klemkow
On Fri, Jul 19, 2019 at 09:13:38PM +1000, Jonathan Gray wrote: > On Fri, Jul 19, 2019 at 01:07:34PM +0200, Jan Klemkow wrote: > > Hi, > > > > fixstring() can return NULL and it does on one of my machines. > > Here is s fix that checks for NULL and return a

fix: NULL dereference in bios(4)

2019-07-19 Thread Jan Klemkow
Hi, fixstring() can return NULL and it does on one of my machines. Here is s fix that checks for NULL and return an empty string. ok? bye, Jan Index: arch/amd64/amd64/bios.c === RCS file: /cvs/src/sys/arch/amd64/amd64/bios.c,v

Re: wsfont & free(9) sizes

2019-07-10 Thread Jan Klemkow
On Wed, Jul 10, 2019 at 12:59:41PM -0300, Martin Pieuchot wrote: > Some free(9) sizes & fix to make wsfont_remove() compile. This function > is #ifndef for the moment. That's mainly for coherency and to reduce > grep noise. > > ok? ok jan > Index: dev/wsfont/wsfont.c >

Re: uvideo(4): *ALL*

2019-07-08 Thread Jan Klemkow
Hi Patrick, I tested all you patches with my integrated uvideo(4) device. ... uvideo0 at uhub0 port 8 configuration 1 interface 0 "SunplusIT Inc Integrated Camera" rev 2.01/54.20 addr 9 video0 at uvideo0 ... addr 09: 5986:2115 SunplusIT Inc, Integrated Camera high speed, power 500 mA,

Re: sparc64 ldomctl(8) fix

2019-07-06 Thread Jan Klemkow
On Sat, Jul 06, 2019 at 12:59:55AM +0200, Mark Kettenis wrote: > The diff below fixes interction between ldomctl(8) and the firmware on > a SPARC T4 system that I have access to. To make sure that this > doesn't break other machines it would be good if people could test > this on a few more

Re: free() sizes for ahc(4)

2019-05-14 Thread Jan Klemkow
On Tue, May 14, 2019 at 10:35:22AM +, Miod Vallat wrote: > Note ahc_set_name() gets invoked with the dv_xname field of a struct > device, so it's not a good idea to free anything, should it be invoked > more than once. > > Tested on: > ahc0 at pci0 dev 1 function 0 "Adaptec AIC-7880" rev

Re: softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
On Mon, May 13, 2019 at 07:25:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > The diff mainly add sizes to free(9) calls. But, while here fix a > > malloc(9) call with the wrong size in sr_ioctl_installboot(). > > omi->omi_som is allocated with size of struct

softraid(4): fix wrong malloc size and zero sized free calls

2019-05-13 Thread Jan Klemkow
Hi, The diff mainly add sizes to free(9) calls. But, while here fix a malloc(9) call with the wrong size in sr_ioctl_installboot(). omi->omi_som is allocated with size of struct sr_meta_crypto, but used as struct sr_meta_boot later. One free(9) with size zero left over in sr_discipline_free().

enable cy(4) by default on amd64

2019-05-12 Thread Jan Klemkow
Hi, I use tree cy(4) cards on amd64 for several releases. Its totally stable and works fine beside known bugs already mentioned in the manpage. Thus, I would prefer to enabled it by default in amd64 as it is in i386. Bye, Jan Index: arch/amd64/conf/GENERIC

sv(4): fix free with zero size

2019-05-12 Thread Jan Klemkow
Hi, The following diff fixes "free with zero size" in sv(4). Builds and stats the kernel with sv at pci and audio at sv enabled. bye, Jan Index: dev/pci/sv.c === RCS file: /cvs/src/sys/dev/pci/sv.c,v retrieving revision 1.34 diff

Re: ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
On Wed, May 08, 2019 at 07:10:37PM -0400, Ted Unangst wrote: > Jan Klemkow wrote: > > - * Special version of popen which avoids call to shell. This ensures noone > > + * Special version of popen which avoids call to shell. This ensures none > > If we don't like noone,

ftpd(8): rm dead code and simplifies popen clone

2019-05-08 Thread Jan Klemkow
Hi, This diff removes dead code from ftpd(8). In the past ftpd executes ls(1) for directory listings. But, quite a while now It justs calls the main function of the linked in ls(1) directly. The code path to the main function of ls(1) as well as the read-only mode are hard coded in the current

diff: reboot(8): document the -l option

2019-03-25 Thread Jan Klemkow
Hi, The following diff adds missing documentation for the -l option of reboot(8) as its done in NetBSD. Bye, Jan Index: reboot.8 === RCS file: /cvs/src/sbin/reboot/reboot.8,v retrieving revision 1.50 diff -u -p -r1.50 reboot.8 ---

diff: add support for ANT-USBStick2 to uscom(4)

2019-02-22 Thread Jan Klemkow
Hi, The diff below adds support for the Dynastream "ANT USBStick2" to uscom(4). The device attached with the following message: uscom0 at uhub0 port 2 configuration 1 interface 0 "Dynastream Innovations ANT USBStick2" rev 2.00/1.00 addr 2 ucom0 at uscom0 portno 0 Additionally, I tested the

diff: add missing bit description for pkthdr_pf.flags

2019-02-08 Thread Jan Klemkow
Hi, The following diff adds the description of the second bit of the struct pkthdr_pf field flags. bye, Jan Index: sys/sys/mbuf.h === RCS file: /cvs/src/sys/sys/mbuf.h,v retrieving revision 1.241 diff -u -p -r1.241 mbuf.h ---

snmpd: dup open ttys to /dev/null in demons mode

2019-01-07 Thread Jan Klemkow
Hi, This diff is similar to bluhm@'s fix for httpd and relayd, but for snmpd. > During the fork+exec implementation, daemon(3) was moved after > proc_init(). As a consequence httpd(8) and relayd(8) child processes > do not detach from the terminal anymore. Dup /dev/null to the stdio > file

diff: new PCI Vendor and Product ID for RocketPort serial card

2019-01-07 Thread Jan Klemkow
Hi, the following diff adds the PCI vendor and product ID for a PCI multiport serial card. dmesg shows the device as: "Comtrol Corporation RocketPort PCI 16-port Serial" rev 0x01 at pci1 dev 1 function 0 not configured bye, Jan Index: pci/pcidevs

diff: fix missing include guard in dev/biovar.h

2018-12-19 Thread Jan Klemkow
Hi, I run into double definition problems because of a missing include guard in dev/biovar.h. The diff below should fix that issue. Bye, Jan Index: sys/dev/biovar.h === RCS file: /cvs/src/sys/dev/biovar.h,v retrieving revision

Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-12-06 Thread Jan Klemkow
On Tue, Nov 27, 2018 at 09:03:15AM +0100, Theo Buehler wrote: > On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > > using the right types for 'i' and 'len'. One warning is left, but I > >

diff: ftpd(8): fix for sign-compare compiler warnings

2018-11-24 Thread Jan Klemkow
Hi, This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by using the right types for 'i' and 'len'. One warning is left, but I don't see that it's fixable without suppressing the warning by a cast of len to size_t. And casting might be controversial in this case?!

  1   2   >